Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Philippe Gerum
On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
 Hello,
 
 the attached patch changes:
 
2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]
 
   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
 

Merged, thanks.

 Wolfgang.
 
 
 ___
 Xenomai-core mailing list
 Xenomai-core@gna.org
 https://mail.gna.org/listinfo/xenomai-core
-- 
Philippe.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Jan Kiszka
Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
 Hello,

 the attached patch changes:

2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]

   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.

 
 Merged, thanks.

You are too fast for me - I was still test-building my approach!

Looks rather like I picked the wrong expression for marking
rtdm_task_sleep_until deprecated. I would prefer to go for this variant
and back Wolfgang's patch out again:

--- include/rtdm/rtdm_driver.h  (Revision 2758)
+++ include/rtdm/rtdm_driver.h  (Arbeitskopie)
@@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
 }

 /* rtdm_task_sleep_abs shall be used instead */
-static inline int __deprecated
+static inline int __deprecated_call__
 rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
 {
 return __rtdm_task_sleep(wakeup_time, XN_REALTIME);


But note that I'm still test-building...

Jan



signature.asc
Description: OpenPGP digital signature
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Philippe Gerum
On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
 Philippe Gerum wrote:
  On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
  Hello,
 
  the attached patch changes:
 
 2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]
 
* include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
 
  
  Merged, thanks.
 
 You are too fast for me - I was still test-building my approach!
 
 Looks rather like I picked the wrong expression for marking
 rtdm_task_sleep_until deprecated. I would prefer to go for this variant
 and back Wolfgang's patch out again:

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
is not only a RTDM issue.

 
 --- include/rtdm/rtdm_driver.h  (Revision 2758)
 +++ include/rtdm/rtdm_driver.h  (Arbeitskopie)
 @@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
  }
 
  /* rtdm_task_sleep_abs shall be used instead */
 -static inline int __deprecated
 +static inline int __deprecated_call__
  rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
  {
  return __rtdm_task_sleep(wakeup_time, XN_REALTIME);
 
 
 But note that I'm still test-building...
 
 Jan
 
-- 
Philippe.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Wolfgang Grandegger
Jan Kiszka wrote:
 Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
 Hello,

 the attached patch changes:

2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]

   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.

 Merged, thanks.
 
 You are too fast for me - I was still test-building my approach!

Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

 Looks rather like I picked the wrong expression for marking
 rtdm_task_sleep_until deprecated. I would prefer to go for this variant
 and back Wolfgang's patch out again:
 
 --- include/rtdm/rtdm_driver.h  (Revision 2758)
 +++ include/rtdm/rtdm_driver.h  (Arbeitskopie)
 @@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
  }
 
  /* rtdm_task_sleep_abs shall be used instead */
 -static inline int __deprecated
 +static inline int __deprecated_call__
  rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
  {
  return __rtdm_task_sleep(wakeup_time, XN_REALTIME);
 
 
 But note that I'm still test-building...

OK, __deprecated_call__ does not make trouble with 2.4.

Wolfgang.


___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Jan Kiszka
Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
 Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
 Hello,

 the attached patch changes:

2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]

   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.

 Merged, thanks.
 You are too fast for me - I was still test-building my approach!

 Looks rather like I picked the wrong expression for marking
 rtdm_task_sleep_until deprecated. I would prefer to go for this variant
 and back Wolfgang's patch out again:
 
 __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
 is not only a RTDM issue.

No problem, as you like it.

Jan



signature.asc
Description: OpenPGP digital signature
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Philippe Gerum
On Mon, 2007-07-09 at 17:02 +0200, Jan Kiszka wrote:
 Philippe Gerum wrote:
  On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
  Philippe Gerum wrote:
  On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
  Hello,
 
  the attached patch changes:
 
 2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]
 
* include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
 
  Merged, thanks.
  You are too fast for me - I was still test-building my approach!
 
  Looks rather like I picked the wrong expression for marking
  rtdm_task_sleep_until deprecated. I would prefer to go for this variant
  and back Wolfgang's patch out again:
  
  __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
  is not only a RTDM issue.
 
 No problem, as you like it.

Actually, I don't like wrappers that much, but, well...

-- 
Philippe.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Jan Kiszka
Wolfgang Grandegger wrote:
 Jan Kiszka wrote:
 Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
 Hello,

 the attached patch changes:

2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]

   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.

 Merged, thanks.

 You are too fast for me - I was still test-building my approach!
 
 Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty,
definitely not touched for several months.

Hell, the amount of regressions one (specifically I) can produce due to
all this config variants is amazing. What would be really nice is a
playground for patches, some build system you could post a patch series
and a set of .configs to and that will then simply try to generate
various kernels and the xenomai userland for various archs
automatically, reporting back any errors or warnings. Without going
through SVN with the changes every time. Just a dream.

Jan



signature.asc
Description: OpenPGP digital signature
___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Wolfgang Grandegger
Philippe Gerum wrote:
 On Mon, 2007-07-09 at 17:02 +0200, Jan Kiszka wrote:
 Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
 Philippe Gerum wrote:
 On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
 Hello,

 the attached patch changes:

2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]

   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.

 Merged, thanks.
 You are too fast for me - I was still test-building my approach!

 Looks rather like I picked the wrong expression for marking
 rtdm_task_sleep_until deprecated. I would prefer to go for this variant
 and back Wolfgang's patch out again:
 __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
 is not only a RTDM issue.
 No problem, as you like it.
 
 Actually, I don't like wrappers that much, but, well...

I just realized, that __deprecated_call__ is _not_ defined in 2.4 but 
already in include/nucleus/compiler.h!

Wolfgang.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Philippe Gerum
On Mon, 2007-07-09 at 17:14 +0200, Jan Kiszka wrote:
 Wolfgang Grandegger wrote:
  Jan Kiszka wrote:
  Philippe Gerum wrote:
  On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
  Hello,
 
  the attached patch changes:
 
 2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]
 
* include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
 
  Merged, thanks.
 
  You are too fast for me - I was still test-building my approach!
  
  Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).
 
 Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty,
 definitely not touched for several months.
 
 Hell, the amount of regressions one (specifically I) can produce due to
 all this config variants is amazing.

We all have a very well defined job in this project, and particularly:
- I do produce the original silly bugs.
- You are in charge of adding regressions to your past fixes of my bugs
- Dmitry is in charge of finding why our common code breaks.
- Wolfgang is in charge of making all the involved fixes compile
properly.
- Gilles is in charge of making the result run on bugous and/or sluggish
hardware.

Ok, all in all, my situation is the best one. Good.

  What would be really nice is a
 playground for patches, some build system you could post a patch series
 and a set of .configs to and that will then simply try to generate
 various kernels and the xenomai userland for various archs
 automatically, reporting back any errors or warnings. Without going
 through SVN with the changes every time. Just a dream.

Niklaus already built most of this infrastructure for us, only the
automated patching part seems to be missing so far: 
http://ngiger.dyndns.org/buildbot/

We would also have to alleviate the burden of his server by providing
some dedicated hardware to do that, though.

 
 Jan
 
-- 
Philippe.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core


Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

2007-07-09 Thread Philippe Gerum
On Mon, 2007-07-09 at 17:32 +0200, Wolfgang Grandegger wrote:
 Philippe Gerum wrote:
  On Mon, 2007-07-09 at 17:02 +0200, Jan Kiszka wrote:
  Philippe Gerum wrote:
  On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
  Philippe Gerum wrote:
  On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
  Hello,
 
  the attached patch changes:
 
 2007-07-09  Wolfgang Grandegger  [EMAIL PROTECTED]
 
* include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
 
  Merged, thanks.
  You are too fast for me - I was still test-building my approach!
 
  Looks rather like I picked the wrong expression for marking
  rtdm_task_sleep_until deprecated. I would prefer to go for this variant
  and back Wolfgang's patch out again:
  __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
  is not only a RTDM issue.
  No problem, as you like it.
  
  Actually, I don't like wrappers that much, but, well...
 
 I just realized, that __deprecated_call__ is _not_ defined in 2.4 but 
 already in include/nucleus/compiler.h!
 

Indeed. __deprecated should go there too btw. Will fix.

 Wolfgang.
 
 
-- 
Philippe.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core