Re: [PATCH 2/2] atom: make FreeAtom static

2015-06-05 Thread Chris Wilson
On Tue, Jun 02, 2015 at 02:08:39PM -0400, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 1/2] atom: Bump initial table size

2015-06-02 Thread Chris Wilson
the number of Atoms created during initialisation. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH 1/8] dix: Unexport various implementation details

2015-06-02 Thread Chris Wilson
On Tue, Jun 02, 2015 at 02:14:59PM -0400, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com For this series, Acked-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 04:59:14PM +0900, Michel Dänzer wrote: On 27.05.2015 15:51, Chris Wilson wrote: On Tue, May 26, 2015 at 02:30:32PM -0700, Keith Packard wrote: Michel Dänzer mic...@daenzer.net writes: The old code also called present_get_crtc() unless pixmap == NULL, so

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 05:56:15PM +0900, Michel Dänzer wrote: On 28.05.2015 17:38, Chris Wilson wrote: On Thu, May 28, 2015 at 04:59:14PM +0900, Michel Dänzer wrote: The patch below is an alternative fix for the problem I'm seeing, while preserving the window CRTC for MSC waits when

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 06:27:34PM +0900, Michel Dänzer wrote: On 28.05.2015 18:07, Chris Wilson wrote: On Thu, May 28, 2015 at 05:56:15PM +0900, Michel Dänzer wrote: On 28.05.2015 17:38, Chris Wilson wrote: On Thu, May 28, 2015 at 04:59:14PM +0900, Michel Dänzer wrote: The patch below

Re: [PATCH 5/5] render: Eliminate temporary mask when drawing glyphs

2015-05-27 Thread Chris Wilson
succinctly. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] renderproto: Fix compositeglyph dst position. eliminate use of mask-format

2015-05-27 Thread Chris Wilson
of the glyph path when specifying a mask - plus the effect the mask has for allowing combining a mixture of glyph formats without unwanted fringing. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 2/3] present: Query the Window's CRTC every time

2015-05-27 Thread Chris Wilson
. It looks like this will only solve the problem of how to deal with new PresentNotifyMSC requests; any PresentPixmap or PresentNotifyMSC requests which are pending when the CRTC is disabled may end up getting wedged too? Queued events are flushed when the CRTC is disabled. -Chris -- Chris

[PATCH] glamor/glyphs: Fix rendering regressions

2015-05-18 Thread Chris Wilson
(for example to correctly render overlapping glyphs and to apply quantisation effects, e.g. mixing different filters) along with incorrectly computing the glyph source coordinates. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Keith Packard kei...@keithp.com --- glamor/glamor_composite_glyphs.c

Re: [PATCH] composite: Install SourceValidation hooks only when required

2015-05-18 Thread Chris Wilson
On Mon, May 18, 2015 at 03:26:29PM +0100, Chris Wilson wrote: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Eek, used send-email from the wrong branch. This is fun but incomplete... -Chris -- Chris Wilson, Intel Open Source Technology Centre

[PATCH] composite: Install SourceValidation hooks only when required

2015-05-18 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- composite/compalloc.c | 3 +++ composite/compinit.c | 49 +++-- composite/compint.h| 4 composite/compwindow.c | 8 4 files changed, 46 insertions(+), 18 deletions(-) diff

Re: combining Render's Composite + SHM's PutImage

2015-04-09 Thread Chris Wilson
of how to mix SHM and Render, or http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/tools/virtual.c#n1819 The synopsis is that you want to insert your own SHMCompletionEvents which are then guarranteed to be sent after the rendering by X's very strict protocol ordering. -Chris -- Chris

Re: [PATCH] modesetting: add tile property support (v2.1)

2015-04-06 Thread Chris Wilson
tile property (Chris) Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

[PATCH 2/2] prime: Don't lose SourceValidate on PixmapSyncDirtyHelper no-ops

2015-04-05 Thread Chris Wilson
the SourceValidate callback back in place even for an early exit. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- dix/pixmap.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dix/pixmap.c b/dix/pixmap.c index 00e298f

[PATCH 1/2] Xv: Only stop the adaptors when the Pixmap is finally destroyed

2015-04-05 Thread Chris Wilson
Pixmaps are reference counted and DestroyPixmap is called for the removal of every reference. However, we only want to stop the adaptors writing into the Pixmap just before the Pixmap is finally destroyed, similar to how Windows are handled. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc

Re: [PATCH 3/3] modesetting: add tile property support (v2)

2015-03-31 Thread Chris Wilson
-length, tile_info); xf86OutputSetTile(output, tile_info); -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 3/3] modesetting: add tile property support (v2)

2015-03-31 Thread Chris Wilson
On Tue, Mar 31, 2015 at 10:07:53AM +0100, Chris Wilson wrote: On Tue, Mar 31, 2015 at 01:47:26PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This adds tiling support to the server modesetting driver, it retrieves the tile info from the kernel and translates

Re: cannot find -lX11

2015-03-16 Thread Chris Sorenson
-L/home/roy/marinas-ide/qt/lib -L/usr/lib There's the bad right there, libX11 must be somewhere other than /usr/lib. Find out where it is and change that entry in the Makefile. (If you really have no idea where it is, do this: find / -name libX11\* could take a while as that will search the

Re: Mint14 Nadia - with interface graphic MATE - After login, video is black

2015-03-08 Thread Chris Sorenson
Message Date: Sun, 8 Mar 2015 15:44:35 +0100 From: Antonio Vescovi To: xorg@lists.x.org Subject: Mint14 Nadia with interface graphic MATE After login, video is black Hi, my name is Antonio and I write in this list, because I have a problemwith server X. I use Mint 14

Re: Mint14 Nadia - with interface graphic MATE - After login , video is black

2015-03-08 Thread Chris Fisichella
/viewtopic.php?f=90t=110111 I normally need to enter the root password to get to a prompt. When you get to a prompt, look at the file Thomas pointed you toward: /var/log/Xorg.0.log. It will normally give you some lines that have (EE) near to the beginning that are useful for debugging. -Chris

Re: Dual head, display driven by mga driver has X cursor and is unusable

2015-03-06 Thread Chris Fisichella
Quoting Chris Fisichella ch...@communityrenewables.com: Hi, Does anyone have any experience with removing the X cursor from a second monitor to make it workable? Thanks, Chris I have been trying to add a second monitor to my machine. I can' quite get it. I am running Debian 7.6.0 and can

Re: Dual head, display driven by mga driver has X cursor and is unusable

2015-03-06 Thread Chris Fisichella
Quoting Felix Miata mrma...@earthlink.net: Chris Fisichella composed on 2015-03-06 14:45 (UTC): ... I read both your posts. It's not clear to me what video ports you are trying to use. I've never encountered any motherboard with onboard video that permits the onboard video to be in use

Bug#529178:

2015-03-04 Thread Chris Bainbridge
the problem with a BIOS update but for other manufacturers it was always an issue. Using an active DisplayPort adaptor was the recommended workaround in the end. Final comment from Dell: Posted by DELL-Chris I never could find a solid fix, several workarounds for PC, none for Macs. The issue does

Re: [PATCH] glx/dri2: Disable AIGLX if indirect GLX is disabled

2015-03-04 Thread Chris Wilson
On Thu, Mar 05, 2015 at 01:18:51PM +0900, Michel Dänzer wrote: On 04.03.2015 21:16, Chris Wilson wrote: There is no point in setting up the acceleration for indirect GLX if indirect GLX is itself disabled. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 3

[PATCH] glx/dri2: Disable AIGLX if indirect GLX is disabled

2015-03-04 Thread Chris Wilson
There is no point in setting up the acceleration for indirect GLX if indirect GLX is itself disabled. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index ec86a73..7cb0f28 100644

RE: DPMS switches to suspend too early

2015-02-26 Thread Chris Sorenson
Something is wrong with your xset, what does `X -version` tell you? --8---cut here---start-8 X.Org X Server 1.16.1 Release Date: 2014-09-21 X Protocol Version 11, Revision 0 Build Operating System: openSUSE SUSE LINUX Current Operating System:

Generated Code : swapcheck_shape.h

2015-02-26 Thread chris
/* * This file generated automatically from shape.xml by gen_swap_check.py. * Edit at your peril. */ /** * @defgroup XCB_Shape_API XCB Shape API * @brief Shape XCB Protocol Implementation. * @{ **/ #ifndef __SHAPE_H #define __SHAPE_H #include swapcheck_xproto.h #ifdef __cplusplus extern

Generated Code: swapcheck_xproto.h

2015-02-26 Thread chris
/* * This file generated automatically from xproto.xml by gen_swap_check.py. * Edit at your peril. */ /** * @defgroup XCB__API XCB API * @brief XCB Protocol Implementation. * @{ **/ #ifndef __XPROTO_H #define __XPROTO_H #include xorg/misc.h #include X11/X.h #include X11/Xproto.h

Generated Code: swapcheck_shape.c

2015-02-26 Thread chris
/* * This file generated automatically from shape.xml by gen_swap_check.py. * Edit at your peril. */ #include swapcheck_xproto.h #include swapcheck_shape.h #include stdlib.h #include assert.h #include stddef.h /* for offsetof() */ #include errno.h #define ALIGNOF(type) offsetof(struct { char

Re: [PATCH] damage: Only track extents where possible

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 02:58:45PM -0500, Adam Jackson wrote: On Wed, 2015-02-25 at 18:01 +, Chris Wilson wrote: For external Damage, we need only track sufficient information to satisfy the DamageReportLevel. That is if the Client only wishes to hear that the Damage is now non-empty

[PATCH] damage: Only track extents where possible

2015-02-25 Thread Chris Wilson
the full region intact for them. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Adam Jackson a...@redhat.com --- miext/damage/damage.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/miext/damage/damage.c b/miext/damage/damage.c index b99cfb0..450a517

Re: Limit DRI2Drawable reference leak

2015-02-22 Thread Chris Wilson
On Sun, Feb 22, 2015 at 02:09:36AM +0200, Ville Syrjälä wrote: On Sat, Feb 21, 2015 at 10:52:49PM +, Chris Wilson wrote: On Sun, Feb 22, 2015 at 12:13:38AM +0200, Ville Syrjälä wrote: On Sat, Feb 21, 2015 at 09:31:07PM +, Chris Wilson wrote: With the current protocol

[PATCH 3/3] dri2: Only create one unnamed reference per Drawable per Client

2015-02-22 Thread Chris Wilson
: http://lists.x.org/archives/xorg-devel/2010-November/014782.html Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Ville Syrjälä syrj...@sci.fi --- hw/xfree86/dri2/dri2.c| 57 +++ hw/xfree86/dri2/dri2ext.c | 4 ++-- 2 files changed, 55 insertions

[PATCH 1/3] dri2: Only invalidate the immediate Window upon SetWindowPixmap

2015-02-22 Thread Chris Wilson
All callers of SetWindowPixmap will themselves be traversing the Window heirachy updating the backing Pixmap of each child and so we can forgo doing the identical traversal inside the DRI2SetWindowPixmap handler. Reported-by: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86

[PATCH 2/3] dri2: Split resource tracking for DRI2Drawable and references to them

2015-02-22 Thread Chris Wilson
to DRI2Drawables. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 10 ++-- hw/xfree86/dri2/dri2.c| 136 ++ hw/xfree86/dri2/dri2.h| 11 ++-- hw/xfree86/dri2/dri2ext.c | 6 +- 4 files changed, 66 insertions

Re: Limit DRI2Drawable reference leak

2015-02-22 Thread Chris Wilson
On Sun, Feb 22, 2015 at 09:02:41AM +, Chris Wilson wrote: Yes, that is what I think the mesa patch is about. I think the solution would have been that the DRI2Drawable take a refcnt on its parent and then DRI2DestroyDrawable could be made to work. However, if we did that today we would end

Re: Limit DRI2Drawable reference leak

2015-02-21 Thread Chris Wilson
On Sun, Feb 22, 2015 at 12:13:38AM +0200, Ville Syrjälä wrote: On Sat, Feb 21, 2015 at 09:31:07PM +, Chris Wilson wrote: With the current protocol and implementations, we have to often call DRI2CreateDrawable but can never call DRI2DestroyDrawable. This ends up with us leaking

Re: [PATCH] dri2: work around broken DRI2CreateDrawable callers

2015-02-21 Thread Chris Wilson
you find an alternative solution for mali? If not, I think I can generalise this into only allocating a single reference per DRI2 Client per Drawable. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development

[PATCH 3/3] dri2: Support named DRI2Drawable references

2015-02-21 Thread Chris Wilson
still causes an invalidate event to be sent, the overhead of sending those unnecessary events quickly mounts. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2ext.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/xfree86/dri2

[PATCH 1/3] dri2: Split resource tracking for DRI2Drawable and references to them

2015-02-21 Thread Chris Wilson
to DRI2Drawables. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- glx/glxdri2.c | 8 +-- hw/xfree86/dri2/dri2.c| 136 ++ hw/xfree86/dri2/dri2.h| 11 ++-- hw/xfree86/dri2/dri2ext.c | 6 +- 4 files changed, 65 insertions

[PATCH 2/3] dri2: Only create one unnamed reference per Drawable per Client

2015-02-21 Thread Chris Wilson
dispatcher and thus we don't need to check that the invalidate handler is the same. Cc: Daniel Drake dr...@endlessm.com Link: https://freedesktop.org/patch/19695/ Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2.c| 22 -- hw/xfree86/dri2/dri2ext.c | 2

Limit DRI2Drawable reference leak

2015-02-21 Thread Chris Wilson
. The first two patches implement the capping of the unnamed internal reference used by DRI2CreateDrawable to just one per Client. The third patch uses a pair of new DRI2 requests to allow the Client to explicitly manage the lifetime via use of a named reference to the DRI2Drawable. -Chris

Re: [OPW] Generated swapping and size-checking code integration

2015-02-17 Thread chris
for each approach. It's basically reduce code-duplication vs avoid API-compatibility issues of public APIs ( we'd need to introduce a public api of that common code. ) We cannot have both. Then we can fix these issues. Cheers, Chris ___ xorg-devel

Re: DRI2InvalidateWalk high in perf top profile

2015-02-16 Thread Chris Wilson
); +DRI2InvalidateDrawable(pWin-drawable); } would suffice -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

Re: [OPW] Generated swapping and size-checking code integration

2015-02-16 Thread chris
, there should be a default: label in the switch statements. For default:, return a BadRequest error code. Best regards, Chris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

[PATCH] present: Fix missed notify MSC computation

2015-02-16 Thread Chris Wilson
Only treat divisor==0 as async to immediately report the actual vblank. If the user species a non-zero divisor, we should compute the missed vblank properly or else we report too early. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 2 +- 1 file changed, 1 insertion

[PATCH] present: Cancel the copy on unflip when aborting a pending flip

2015-02-16 Thread Chris Wilson
-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/present/present.c b/present/present.c index 9a283d4..e9ccfb8 100644 --- a/present/present.c +++ b/present/present.c @@ -401,10 +401,12 @@ present_set_abort_flip

[PATCH 2/2] shm: Expose SHM segments to backends

2015-02-14 Thread Chris Wilson
, GetImage interfaces and hooks provided for the driver. The driver may not implement any of these, in which case we fallback to the current implementation that wraps the normal PutImage and GetImage interface. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- Xext/shm.c | 224

[PATCH 1/2] shm: Fix use-after-free in ShmDestroyPixmap

2015-02-14 Thread Chris Wilson
We pass the pPixmap-drawable.id to the ShmDetachSegment function after the pPixmap is freed. Fortunately, we don't use the value inside ShmDetachSegment and can simply pass zero instead. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- Xext/shm.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 2/2] present: Fix presentation of flips out of order

2015-02-14 Thread Chris Wilson
to the flip_queue in the order that they become ready, we also resolve one issue causing Present to display frames out of order. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/present/present.c b/present

[PATCH 1/2] present: Improve scaling of vblank handler

2015-02-14 Thread Chris Wilson
stop iterating when past the target event_id. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/present/present.c b/present/present.c index ba88f79..b132f4d 100644 --- a/present

Re: [PATCH 1/2] shm: Fix use-after-free in ShmDestroyPixmap

2015-02-14 Thread Chris Wilson
On Sat, Feb 14, 2015 at 08:33:18PM +0900, Michel Dänzer wrote: On 14.02.2015 19:36, Chris Wilson wrote: /*ARGSUSED*/ static int ShmDetachSegment(void *value, /* must conform to DeleteType */ - XID shmseg) + XID unused) { ShmDescPtr shmdesc

Re: [PATCH 3/3] present: Check for an invalid target CRTC before flipping

2015-02-09 Thread Chris Wilson
On Sun, Feb 08, 2015 at 04:28:31PM -0800, Kenneth Graunke wrote: On Sunday, February 08, 2015 12:00:37 PM Chris Wilson wrote: On Sun, Feb 08, 2015 at 02:10:07AM -0800, Kenneth Graunke wrote: On Friday, February 06, 2015 08:25:44 AM Chris Wilson wrote: Once we have chosen the target CRTC

[PATCH 3/3] present: Do not replace Pixmaps on redirected Window on unflip

2015-02-08 Thread Chris Wilson
to flip causing popping between e.g. the compositor and the game. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/present/present.c b/present/present.c index a53dc11..ba88f79

[PATCH 1/3] present: Requery pending flips with the right sync_flip mode

2015-02-08 Thread Chris Wilson
When verifying whether a pending flip is still valid, we need to pass down the orignal sync_flip mode (e.g. if the driver only supports sync flips, verifying a async flip will falsely fail). Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 5 +++-- present

[PATCH 2/3] present: When cancelling a pending synchronous flip, requeue it

2015-02-08 Thread Chris Wilson
at the requested time. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 16 +++- present/present_priv.h | 1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/present/present.c b/present/present.c index ce978f4..a53dc11 100644 --- a/present

Re: [PATCH 3/3] present: Check for an invalid target CRTC before flipping

2015-02-08 Thread Chris Wilson
On Sun, Feb 08, 2015 at 02:10:07AM -0800, Kenneth Graunke wrote: On Friday, February 06, 2015 08:25:44 AM Chris Wilson wrote: Once we have chosen the target CRTC, check for an error when querying the current MSC so we can report the error before attempting to record the uninitialised MSC

[PATCH 3/3] present: Check for an invalid target CRTC before flipping

2015-02-06 Thread Chris Wilson
Once we have chosen the target CRTC, check for an error when querying the current MSC so we can report the error before attempting to record the uninitialised MSC/UST, and subsequently feeding garbage values to drmWaitVBlank. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present

[PATCH 2/3] present: Query the Window's CRTC every time

2015-02-06 Thread Chris Wilson
As the Window may flip between CRTC's between frames, we need to recheck which CRTC to use every frame or else attempt to flip on an invalid CRTC. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

[PATCH 1/3] present: Copy unflip contents back to the Screen Pixmap

2015-02-06 Thread Chris Wilson
the Pixmap, thus we need to copy the last frame contents to the Screen Pixmap when the flip chain is complete. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- present/present.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/present/present.c b/present/present.c index

Re: [PATCH xf86-video-dummy 6/6] Support RandR 1.2

2015-01-25 Thread Chris Wilson
() use pScrn-videoRam to check that the mode scanline fits within RAM matter here? Or is there no validate step in the dummy RandR driver at all? -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development

Re: [xorg 3/3] dri2: Reuse unused flags in GetBuffers protocol to pass last SBC

2015-01-19 Thread Chris Wilson
On Mon, Jan 19, 2015 at 11:00:40AM +, Chris Wilson wrote: @@ -1104,6 +1107,8 @@ DRI2SwapBuffers(ClientPtr client, DrawablePtr pDraw, CARD64 target_msc, * it as early as possible, just to be sure. */ *swap_target = pPriv-swap_count + pPriv-swapsPending + 1; +if (ds

[PATCH v2] dri2: Reuse unused flags in GetBuffers protocol to pass last SBC

2015-01-19 Thread Chris Wilson
Allow mesa/dri2 to implement GLX_EXT_buffer_age by reporting the sbc of when the current back buffer was defined. As this may require ddx support, only set the value if enabled by the ddx and report the new semantics via a DRI2GetParam request. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

[xorg 3/3] dri2: Reuse unused flags in GetBuffers protocol to pass last SBC

2015-01-19 Thread Chris Wilson
Allow mesa/dri2 to implement GLX_EXT_buffer_age by reporting the sbc of when the current back buffer was defined. As this may require ddx support, only set the value if enabled by the ddx and report the new semantics via a DRI2GetParam request. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

Implement GLX_EXT_buffer_age for DRI2

2015-01-19 Thread Chris Wilson
In order to suport GLX_EXT_buffer_age in DRI2, we need to pass back the last swap buffer count that the back buffer was defined for. For simplicity, we can reuse an existing field in the DRI2GetBuffers reply that is not used by current drivers, the flags. Since we change the interpretation of this

[xorg 1/3] dri2: Allow GetBuffers to match any format

2015-01-19 Thread Chris Wilson
or caching of buffers (e.g. for triple buffering) void. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 43a1899..f9f594d 100644 --- a/hw

[xf86-video-nouveau] dri2: Enable BufferAge support

2015-01-19 Thread Chris Wilson
about setting the copying the flags field when injecting the third buffer. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Maarten Lankhorst maarten.lankho...@ubuntu.com Cc: Mario Kleiner mario.kleiner...@gmail.com --- src/nouveau_dri2.c | 7 +++ 1 file changed, 7 insertions(+) diff

[dri2proto] Declare DRI2ParamXHasBufferAge

2015-01-19 Thread Chris Wilson
In order for X/DDX to reuse a driver specific field of the DRI2GetBuffers reply, we need to declare the change in semantics. To indicate that the flags field now continues the last swap buffers count instead, we introduce the has-buffer-age parameter. Signed-off-by: Chris Wilson ch...@chris

[mesa 9/9] glx/dri2: Implement getBufferAge

2015-01-19 Thread Chris Wilson
the query and the rendering where the buffer may be invalidated by the server. However, for the primary usecase (that of a compositing manager), the DRI2Drawable is only accessible to a single client mitigating the impact of the issue. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

[xorg 2/3] dri2: Pass swap-interval=0 ScheduleSwap requests to the ddx

2015-01-19 Thread Chris Wilson
/xorg-devel/2011-June/023102.html References: http://lists.x.org/archives/xorg-devel/2012-February/029336.html Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2.c | 14 ++ hw/xfree86/dri2/dri2.h | 5 - 2 files changed, 14 insertions(+), 5 deletions

[mesa 7/9] glx/dri2: Add DRI2GetParam()

2015-01-19 Thread Chris Wilson
Available since the inclusion of dri2proto 1.4 is a DRI2 request to query and set certain parameters about the X/DDX configuration. This implements the getter request. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- src/glx/dri2.c | 29 + src/glx/dri2.h | 4

[mesa 8/9] glx/dri2: Move the wait after SwapBuffers into the next GetBuffers

2015-01-19 Thread Chris Wilson
before querying properties. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- src/glx/dri2_glx.c | 73 -- 1 file changed, 38 insertions(+), 35 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 462d560..0577804 100644

[xf86-video-ati] dri2: Enable BufferAge support

2015-01-19 Thread Chris Wilson
perserving the flags when injecting the third buffer. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com Cc: Jerome Glisse jgli...@redhat.com Cc: Alex Deucher alexander.deuc...@amd.com Cc: Michel Dänzer michel.daen...@amd.com --- src/radeon_dri2.c | 10 ++ 1

[PATCH] dri2: SourceOffloads may be for DRI3 only

2015-01-17 Thread Chris Wilson
://bugs.freedesktop.org/show_bug.cgi?id=88514 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Ilia Mirkin imir...@alum.mit.edu Cc: Dave Airlie airl...@redhat.com --- hw/xfree86/dri2/dri2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index

Re: [PATCH] randr/prime: Don't stop on the first pipe when disabling ReplaceScanoutPixmap

2015-01-16 Thread Chris Wilson
On Tue, Oct 07, 2014 at 07:22:27AM +0100, Chris Wilson wrote: On Mon, Oct 06, 2014 at 10:02:22AM +0100, Chris Wilson wrote: As we define sizeFits based on whether a CRTC is active, and skip trying to redirect the scanout on a disable pipe, we then attempt to undo it later and fail because

Re: how can I identify which video card on a mutli-card linux box a display belongs to

2014-11-10 Thread Chris Wilson
nothing to do with the information in /sys/class/drm. If your devices support DRI2/DRI3, you can send a DRI request to query the device node for a screen. Might be a nice extension to xrandr --verbose, or perhaps a new dri[23]info. -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] dri2: Only invalidate our tree upon Pixmap changes

2014-10-27 Thread Chris Wilson
On Sun, Oct 26, 2014 at 05:23:42PM -0700, Keith Packard wrote: Chris Wilson ch...@chris-wilson.co.uk writes: x11perf -ucreate highlights an instance where compCreateWindow reassigns the same Pixmap to the Window. Currently this triggers an expensive invalidation of the entire window

[PATCH] dri2: Only invalidate our tree upon Pixmap changes

2014-10-20 Thread Chris Wilson
for the Window is actually unchanged, there is no need to invalidate at all. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- hw/xfree86/dri2/dri2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 140c833..028cfae 100644

[PATCH] Xext/shm: Detach SHM segment after Pixmap is released

2014-10-16 Thread Chris Wilson
://bugs.freedesktop.org/show_bug.cgi?id=85058 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- Xext/shm.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Xext/shm.c b/Xext/shm.c index 4dad8b6..b787918 100644 --- a/Xext/shm.c +++ b/Xext/shm.c @@ -248,21 +248,20

Re: [PATCH] Xext/shm: Detach SHM segment after Pixmap is released

2014-10-16 Thread Chris Wilson
On Thu, Oct 16, 2014 at 02:09:08PM +0100, Chris Wilson wrote: The GPU may still have a reference to the SHM segment which would only be finally released when the Pixmap is destroy. So we can only detach the SHM segment (and thereby making the memory unaccessible) after the backend has had

Re: [PATCH] randr/prime: Don't stop on the first pipe when disabling ReplaceScanoutPixmap

2014-10-07 Thread Chris Wilson
On Mon, Oct 06, 2014 at 10:02:22AM +0100, Chris Wilson wrote: As we define sizeFits based on whether a CRTC is active, and skip trying to redirect the scanout on a disable pipe, we then attempt to undo it later and fail because crtc-scanout_pixmap != DRI2_Pixmap and !sizeFits. Paper over

Re: [PATCH] Fallback to std DRI2CopyRegion when DRI2UpdatePrime fails

2014-10-06 Thread Chris Wilson
On Mon, Oct 06, 2014 at 11:04:51AM +0900, Michel Dänzer wrote: On 05.10.2014 16:06, Chris Wilson wrote: I was looking at a bug report today of intel/ati prime and noticed a number of sna_share_pixmap_backing() failures (called from DRI2UpdatePrime). These were failing as the request

[PATCH] randr/prime: Don't stop on the first pipe when disabling ReplaceScanoutPixmap

2014-10-06 Thread Chris Wilson
: https://bugs.freedesktop.org/show_bug.cgi?id=84653 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- randr/rrcrtc.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c

[PATCH] randr/prime: Don't stop on the first pipe when disabling ReplaceScanoutPixmap

2014-10-06 Thread Chris Wilson
upon failure Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84653 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- randr/rrcrtc.c | 67 +++--- 1 file changed, 45 insertions(+), 22 deletions

[PATCH] Fallback to std DRI2CopyRegion when DRI2UpdatePrime fails

2014-10-05 Thread Chris Wilson
I was looking at a bug report today of intel/ati prime and noticed a number of sna_share_pixmap_backing() failures (called from DRI2UpdatePrime). These were failing as the request was for the scanout buffer (which is tiled and so we refuse to share it, and since it is already on the scanout we

Re: [PATCH 3/4] Add none acceleration option

2014-09-27 Thread Chris Wilson
allocation. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 3/4] Add none acceleration option

2014-09-27 Thread Chris Wilson
On Sat, Sep 27, 2014 at 05:35:15PM +0200, Michal Suchanek wrote: On 27 September 2014 10:09, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, Sep 26, 2014 at 08:35:34PM -0700, Keith Packard wrote: This uses fb directly, and supports DRI2 and DRI3. The fundamental principle of UXA

Re: [PATCH 3/4] Add none acceleration option

2014-09-27 Thread Chris Wilson
.) -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 3/4] Add none acceleration option

2014-09-27 Thread Chris Wilson
On Sat, Sep 27, 2014 at 07:58:31PM +0100, Chris Wilson wrote: On Sat, Sep 27, 2014 at 07:17:26PM +0200, Michal Suchanek wrote: And the difference between UXA/none and AccelMethod none and fbdev is supposed to be what? s/fbdev/modesetting/ Not much. UXA/none adds in hw DRI support

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-26 Thread Chris Wilson
On Fri, Sep 26, 2014 at 06:05:07PM +0200, Egbert Eich wrote: Hi Chris, Chris Wilson writes: Also realised that even this should be fixed up as a last resort by falling back to the shadow CRTC allocation. That band-aid should be working again. Hopefully commit

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-26 Thread Chris Wilson
...@freedesktop.org Pushed a slight variation, commit f785035d5bd42a778d4be0bf3ff8678bd7a7e503 Author: Chris Wilson ch...@chris-wilson.co.uk Date: Fri Sep 26 21:01:43 2014 +0100 sna: Allow move-to-gpu to fail during ScreenCreateResources Before we attach the Screen Pixmap to the scanout, we

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-25 Thread Chris Wilson
On Thu, Sep 25, 2014 at 03:16:23PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: For panning one needs to be able to draw

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-25 Thread Chris Wilson
On Thu, Sep 25, 2014 at 04:10:26PM +0100, Chris Wilson wrote: On Thu, Sep 25, 2014 at 03:16:23PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
, but that it can fit individual CRTC into the GTT. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH] uxa/video: only call intel_xvmc_adaptor_init when xvmc is enabled

2014-09-24 Thread Chris Wilson
On Tue, Sep 23, 2014 at 08:13:11PM +0200, tobias.jako...@uni-bielefeld.de wrote: Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de Thank you, I had stumbled across it but had forgotten to send the fix. Pushed, -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH driver/intel] In sna_pixmap_alloc_gpu() process user selected tiling thru kgem_choose_tiling()

2014-09-24 Thread Chris Wilson
a surface size for the tiling value. Fixes regression from commit a10781b70f222f3997928fa979f6292617f79316 [2.99.913] Author: Chris Wilson ch...@chris-wilson.co.uk Date: Tue Jul 1 15:11:07 2014 +0100 sna: Enforce LinearFramebuffer option Signed-off

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
into by the clients. What should happen with the panning is that the CRTC is updated through set_mode_major which invalidates the new CRTC location in the big screen Pixmap and the contents copied during the next shadow update. That's the theory at least... -Chris -- Chris Wilson, Intel Open Source

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: For panning one needs to be able to draw into the screen pixmap outside of the area exposed by the crtc. Note that the screen

Re: [PATCH driver/intel] Allow copy_front() to fail and clean up gracefully if it does

2014-09-24 Thread Chris Wilson
On Wed, Sep 24, 2014 at 01:23:26PM +0200, Egbert Eich wrote: Chris Wilson writes: On Wed, Sep 24, 2014 at 12:34:29PM +0200, Egbert Eich wrote: For panning one needs to be able to draw into the screen pixmap outside of the area exposed by the crtc. Note that the screen

<    1   2   3   4   5   6   7   >