Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-04-02 Thread Daniel Stone
Hi, On 1 April 2012 16:31, Ran Benita ran...@gmail.com wrote: On Tue, Mar 27, 2012 at 02:59:13PM +0100, Daniel Stone wrote:      Have a sane fallback strcasecmp Eh, if your system doesn't have strcasecmp, then I'm pretty sure it's not my problem.  I've removed the fallback entirely

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-04-02 Thread Daniel Stone
Hi, On 2 April 2012 11:30, Michal Suchanek hramr...@gmail.com wrote: I guess the expectations of different people will differ. However, CapsLock and NumLock are shared in all systems I tried connecting multiple keyboards to so I don't see why Shift should be different. Note that there are

Re: [Xcb] 7.7 katamari Release Notes draft RC1 content list

2012-04-02 Thread Daniel Stone
Hi, On 2 April 2012 11:51, Michal Suchanek hramr...@gmail.com wrote: It did not? It does work for me. If it does not work for you then you could at least mention that you tested it and it failed. Sorry, I hadn't seen your revised patch go past, only the original one which was broken.

Re: [BUG] xkbcommon: segfault in xkb_compile_keymap_from_rules()

2012-03-29 Thread Daniel Stone
Hi, On 29 March 2012 17:02, David Herrmann dh.herrm...@googlemail.com wrote: xkb_compile_keymap_from_rules() fails on my machine if the variant is not found. I used: [...] Then a call to xkb_compile_keymap_from_rules(rmlvo) produces a segfault. I have no debug symbols (so the backtrace is

Re: xserver-wrapper licensing

2012-03-28 Thread Daniel Stone
Hi Mark, On 28 March 2012 00:24, Mark Eichin eic...@thok.org wrote: Stephen, Mark, Branden - would you be amenable to relicensing this under the standard X.Org MIT/X11 copyright, as quoted below, for possible inclusion in X.Org upstream? Feel free as far as my patches to it are concerned.

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-03-28 Thread Daniel Stone
Hi, On 27 March 2012 14:59, Daniel Stone dan...@fooishbar.org wrote: In terms of what I have coming up, aside from the context API and vmod merging, I've got a branch that actually adds multiple-keysym support that I just need to fix up and put in.  After that, my rough TODO list is (rough

Re: [PATCH libxkbcommon] Add xkb_key_get_action API

2012-03-27 Thread Daniel Stone
Hi Ran, On 24 March 2012 15:03, Ran Benita ran...@gmail.com wrote: I like the API, it's clear and extensible, and the filter-pipeline implementation is also nice (I'd never think of something like that..). Ha, in fairness, it's not actually original, mostly just ripped from the server code. ;)

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

2012-03-27 Thread Daniel Stone
Hi Ran, On 24 March 2012 15:24, Ran Benita ran...@gmail.com wrote: There's some unrelated groups of commits here. I've tried to arrange them such that they can be picked selectively if needed. Great stuff, thanks. I've pulled most of it, aside from:      Remove remaining uses of X11/X.h

Re: [PATCH libxkbcommon 2/2] Make parser and scanner reentrant

2012-03-27 Thread Daniel Stone
Hi, On 24 February 2012 00:58, Ran Benita ran...@gmail.com wrote: All global state is removed from the parser and scanner. This makes use of the standard facilities in Bison and Flex for reentrant/pure scanner/lexer and location tracking. I've merged this now as it's more important to me that

xserver-wrapper licensing (was: Re: [PULL to discuss] Remove kdrive, Xnest, and Xvfb)

2012-03-27 Thread Daniel Stone
Hi, Sorry for the excess quoting, I've left it in for context for those Cc'ed ... 2012/3/27 Jeremy Huddleston jerem...@apple.com: On Mar 27, 2012, at 12:08 AM, Michel Dänzer mic...@daenzer.net wrote: On Mon, 2012-03-26 at 22:06 -0700, Alan Coopersmith wrote: On 03/26/12 09:07 PM, Jamey Sharp

Re: indent quirks

2012-03-23 Thread Daniel Stone
Hi, On 23 March 2012 15:13, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 02:44:41 23.03.2012 UTC-07 when jerem...@apple.com did gyre and gimble:  JH Is there a way we can tweak indent to not mess up blocks like this: I had to resort to post-processing script recently,

Re: X server source code re-indented

2012-03-22 Thread Daniel Stone
Hi, On 22 March 2012 00:26, Chase Douglas chase.doug...@canonical.com wrote: On 03/21/2012 05:21 PM, Peter Hutterer wrote: http://www.x.org/wiki/CodingStyle The brace handling is different between here and what Daniel described. Here's from the wiki page: Opening curly brace on the same

Re: [PATCH] dix: set raw event values before adding up relative values (#46976)

2012-03-21 Thread Daniel Stone
peter.hutte...@who-t.net Sounds good to me. Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: X server source code re-indented

2012-03-21 Thread Daniel Stone
Hi, On 21 March 2012 22:27, Chase Douglas chase.doug...@canonical.com wrote: On 03/21/2012 02:25 PM, Keith Packard wrote: I'll also happily take whitespace cleanup patches that recover from mistakes made by indent. I haven't made any attempt to learn the new style yet. Is there a guide

Re: libX11: Changes to 'master'

2012-03-20 Thread Daniel Stone
Hi, On 20 March 2012 17:55, Pander pan...@users.sourceforge.net wrote: On 2012-03-20 16:41, Julien Cristau wrote: Then let's make it consistent by only having one of the orders for new sequences.  Over time people will get the order that actually works in muscle memory, we won't have so many

Re: [PATCH libxkbcommon] Add xkb_key_get_action API

2012-03-19 Thread Daniel Stone
Hi Ran, On 16 March 2012 17:04, Ran Benita ran...@gmail.com wrote: By which one can tell when to switch groups, etc. Signed-off-by: Ran Benita ran...@gmail.com --- This would allow me to delete some duplicate code in the application and would make me a happy camper for a while. It makes

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread Daniel Stone
Hi, On 16 March 2012 16:54, Ran Benita ran...@gmail.com wrote: On Sat, Mar 10, 2012 at 02:00:46PM +, Daniel Stone wrote: Great stuff - thanks again! I've pushed this, along with a bunch of other changes I've made, now. Great, thanks! And the changed you made are much better; especially

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread Daniel Stone
Hi, On 17 March 2012 15:21, wettstein...@solnet.ch wrote: And the changed you made are much better; especially removing geometry (by far the ugliest part) and overlays and radio groups (what the hell are those again?). Also removing atoms from the public API. Overlays are a very useful

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread Daniel Stone
Hi, On 17 March 2012 16:24, wettstein...@solnet.ch wrote: At the moment it just means they won't work in Wayland, but support might (might) be removed from the X server at some stage too.  Is there any reason you can't just use a locked group or level rather than an overlay? I currently

Re: server-1.12-branch

2012-03-15 Thread Daniel Stone
Hi, On 14 March 2012 04:09, Keith Packard kei...@keithp.com wrote: #part sign=pgpmime On Wed, 14 Mar 2012 01:45:47 +, Daniel Stone dan...@fooishbar.org wrote: I can definitely see the argument here.  Keith, do you want me to send you an automated whole-tree changeset, followed

Re: server-1.12-branch

2012-03-13 Thread Daniel Stone
Hi, On 9 March 2012 22:47, Keith Packard kei...@keithp.com wrote: On Fri, 09 Mar 2012 12:56:52 -0800, Alan Coopersmith alan.coopersm...@oracle.com wrote: Are you going to pull in Daniel's code style change now?   Of all the -next candidates from the last few months, that was the biggest I

Re: server-1.12-branch

2012-03-13 Thread Daniel Stone
Hi, On 14 March 2012 01:30, Jeremy Huddleston jerem...@apple.com wrote: id rather have a single 100% automated commit followed by 1 or more cleanups.  Could we do this simultaneously on all the stable branches that people care about (1.10+ I think), so cherry-picks are less painful? I can

Re: [libxkbcommon] Pull request - many changes

2012-03-10 Thread Daniel Stone
Hi Ran, On 3 March 2012 22:40, Ran Benita ran...@gmail.com wrote: [I know the normal procedure is to send the patches for review in reasonable chunks to the list, however I won't have time the following weeks, and I don't want them to get lost. So I'll try my luck now.] I set up a github

Re: [PATCH 01/10] dri2: Fix can_exchange() to allow page-flipping on more mesa versions.

2012-03-01 Thread Daniel Stone
Hi, On 1 March 2012 18:11, Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: can_exchange() returns false and thereby prevents page flipping on some drawables where page flipping would work fine. This due to non-matching drawable depths values between front buffer pixmap and back buffer

Re: [PATCH xorg-gtest] Relicense under the X.org preferred license

2012-03-01 Thread Daniel Stone
the only person outside of Canonical who has contributed to xorg-gtest so far. Thanks! Thanks a lot - very very much appreciated! Acked-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH libxkbcommon 08/11] Fix all constness warnings

2012-02-28 Thread Daniel Stone
Hi, On 28 February 2012 18:27, Ran Benita ran...@gmail.com wrote: Running the following semantic patch: @@ expression E; @@ - if (E != NULL) -     free(E); + free(E); Gives this: [...] And probably doesn't catch all of them. So maybe I can send this as a separate patch later? Yes,

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

2012-02-26 Thread Daniel Stone
Hi, On 24 February 2012 21:20, Miles Bader mi...@gnu.org wrote: Some xorg contributors have expressed what are essentially irrational objections to even _using_ GPLv3 tools. The one I encountered previously was from Apple, and apparently Apple itself is pushing this crap (whether due to

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

2012-02-25 Thread Daniel Stone
Hi Ran, On 25 February 2012 09:09, Ran Benita ran...@gmail.com wrote: OK, I guess these patches are dropped than; I'll rebase my other patches. I must say that ATT lex and yacc is rather limiting this day and age, for a library at least. It means that the parser cannot be made to work

Re: [PATCH libxkbcommon 08/11] Fix all constness warnings

2012-02-25 Thread Daniel Stone
Hi, On 25 February 2012 17:32, Alan Coopersmith alan.coopersm...@oracle.com wrote: Mostly trivial/obvious - some change the API by changing return types of extern functions from char * to const char *. If this was an API that had been established for years that would be a problem, but since

Re: [PATCH libxkbcommon 03/11] Remove ancient compatibility check

2012-02-25 Thread Daniel Stone
BTW, that was purged from the libX11 copy in March 2009, so it may be worth checking just how far out of sync libxkbcommon has gotten with the code it was copied from and which everyone has been using in the meantime. Indeed, basically copying the libX11 version in wholesale would be an

Re: [PATCH] Include strings.h on Solaris for bzero definition

2012-02-25 Thread Daniel Stone
in the past, but Solaris is the only one of those libxkbcommon is being ported to. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Acked-by: Daniel Stone dan...@fooishbar.org I'll push this on Monday too. Cheers, Daniel ___ xorg-devel

Re: [PATCH xinput] Handle XA_CARDINAL as property type

2012-02-21 Thread Daniel Stone
Hi, On 21 February 2012 11:29, Chase Douglas chase.doug...@canonical.com wrote: I don't really know what XA_CARDINAL means. Where is it defined. It's defined in Xatom.h (using cscope might be handy here - vim -t XA_CARDINAL from any of my X source trees takes me to the definition), and means

Re: [PATCH synaptics] Revert Don't store fake events in the motion history

2012-02-20 Thread Daniel Stone
/show_bug.cgi?id=45278#c11 X.Org Bug 45278 http://bugs.freedesktop.org/show_bug.cgi?id=45278 This reverts commit c8b098214b44cf0585d78c460401ea7d143769f3. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Daniel Stone dan...@fooishbar.org Yes, this was both designed for and only works

Re: [PATCH xf86-input-synaptics 00/12] Clickpad support

2012-02-11 Thread Daniel Stone
Hi, On 11 February 2012 01:25, Chase Douglas chase.doug...@canonical.com wrote: On 02/11/2012 02:09 AM, Bryce Harrington wrote: With the Clickpad property turned on with one of these dell netbooks, when you touch the button surface with the second finger without pushing the button it

Re: [PATCH xf86-input-synaptics 00/12] Clickpad support

2012-02-11 Thread Daniel Stone
Hi, On 11 February 2012 15:42, Chase Douglas chase.doug...@canonical.com wrote: On 02/11/2012 11:51 AM, Daniel Stone wrote: On 11 February 2012 01:25, Chase Douglas chase.doug...@canonical.com wrote: This means we also can't emit touch events while moving the cursor. I added a patch

Re: [PATCH synaptics 2/5] Ensure delta computation does not go crazy

2012-02-02 Thread Daniel Stone
the issue for now. Signed-off-by: Chase Douglas chase.doug...@canonical.com Acked-by: Daniel Stone dan...@fooishbar.org I've seen this a few times now, it's pretty dramatic. (And for bonus points, if you rmmod/modprobe bcm5974, gnome-shell crashes.) I was planning to take a look at this over

Re: xserver: Branch 'master' - 3 commits

2012-01-31 Thread Daniel Stone
Hi, On 31 January 2012 04:56, Keith Packard kei...@kemper.freedesktop.org wrote: +        if (pDev-key) { +            for (i = 0; i NUM_KEYCODES; i++) { +                if (BitIsOn(pDev-key-down, i + MIN_KEYCODE)) { +                    QueueKeyboardEvents(pDev, KeyRelease, i +

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Daniel Stone
it later. Signed-off-by: Dave Airlie airl...@redhat.com Can you not drop the ScreenPtr argument and just say that the function relies on ScrnInfoPtr::pScreen being valid? With that: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Daniel Stone
Hi, On 27 January 2012 09:28, Aaron Plattner aplatt...@nvidia.com wrote: On 01/26/2012 01:46 PM, Daniel Stone wrote: Can you not drop the ScreenPtr argument and just say that the function relies on ScrnInfoPtr::pScreen being valid? It would presumably be typically called from ScreenInit

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Daniel Stone
Hi, On 27 January 2012 10:22, Colin Harrison colin.harri...@virgin.net wrote: If I revert those traps and then call the function... void winEnqueueMotion(int x, int y) {  int valuators[2];  ValuatorMask mask;  double dx = (double)x;  double dy = (double)y;  

Re: [PATCH] Remove XAA

2012-01-22 Thread Daniel Stone
Hi, On 22 January 2012 14:33, Mark Kettenis mark.kette...@xs4all.nl wrote: No way!  XAA works for accelerated scrolling and makes a significant difference on slow CPUs.  It often works better for EXA.  If there is something that should be removed it's that since very few drivers actually have

Re: [PATCH] Remove XAA

2012-01-19 Thread Daniel Stone
Hi, On 19 January 2012 07:14, Roman Mamedov r...@romanrm.ru wrote: I love this. It invalidates some of my outstanding patches in the best possible way. But... could you explain (preferably in the commit message) what evidence you have that it hasn't worked? I thought people were still using

Re: [PATCH SECURITY] XKB: Workaround for CVE-2012-0064: Stop calling UngrabAllDevices().

2012-01-19 Thread Daniel Stone
could alter the keymap and thus leave your screensaver vulnerable in the future, but a malicious client could also just kill the screensaver, or impersonate it, or, or, or ... Cheers, Daniel From 9966d0a83ad7cf5ea76a04f31912e92908f3da63 Mon Sep 17 00:00:00 2001 From: Daniel Stone dan

[PATCH] UngrabAllDevices: Don't kill clients if not told to

2012-01-19 Thread Daniel Stone
The kill_client argument to UngrabAllClients specifies if we want to kill the client holding the grab or just deactivate the grab. Signed-off-by: Daniel Stone dan...@fooishbar.org Reported-by: Julien Cristau jcris...@debian.org --- dix/grabs.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [PATCH] Remove XAA

2012-01-18 Thread Daniel Stone
XAA. Ah, fair point. I guess it wasn't _completely_ non-functional as such, but almost entirely so; the only time it'd be useful is if you were playing xtank in a non-composited environment. Here's the updated commit message: commit eb422cd841f188a42520492dea01fef960372ed5 Author: Daniel Stone

Re: [PATCH 1.12] A coding style for the server

2012-01-18 Thread Daniel Stone
Hi, On 19 January 2012 01:11, Trevor Woerner twoer...@gmail.com wrote: On Tue, Jan 17, 2012 at 10:02 PM, Daniel Stone dan...@fooishbar.org wrote: indent -linux -bad -bap -blf -bli0 -br -brs -cbi0 -cdw -nce -cs -i4 -hnl -l80 -lc80 -lp -nbbo -nbc -nbfda -nprs -npcs -npsl -saf -sai -saw -nut

Re: [PATCH 1.12] A coding style for the server

2012-01-18 Thread Daniel Stone
Hi, On 19 January 2012 06:42, Chase Douglas chase.doug...@canonical.com wrote: Part of the problem of a coding style is the ongoing maintenance. The kernel handles this through the check_patch script. This gives rise to the following questions: 1. Should we just go with linux style, so we

Re: [PATCH 1.12] A coding style for the server

2012-01-18 Thread Daniel Stone
Hi, On 19 January 2012 10:25, Guillem Jover guil...@hadrons.org wrote: On Wed, 2012-01-18 at 14:02:01 +1100, Daniel Stone wrote: So, the commit in my coding-style xserver branch is simply the result of running this: indent -linux -bad -bap -blf -bli0 -br -brs -cbi0 -cdw -nce -cs -i4 -hnl

[PATCH 1.12] A coding style for the server

2012-01-17 Thread Daniel Stone
Hi all, So since the list has been fairly quiet and uncontroversial since the Ctrl-Alt-Backspace argument, I thought I might throw two comedy patches out there and see if they stuck. No but seriously though, it's both a) utterly ridiculous and b) faintly stupid, that we still don't actually have

[PATCH] Remove XAA

2012-01-17 Thread Daniel Stone
, however. Given that the drivers right now are broken, I'm proposing to leave this patch until 1.13, so we at least have some time to fix the drivers and get them deployed. commit 3811d1b85b71c1f8bd0b3c8269e0f7d388a51c2b Author: Daniel Stone dan...@fooishbar.org Date: Wed Jan 18 15:01:09 2012

Re: [Intel-gfx] [PATCH] Android port of intel-gpu-tools

2012-01-16 Thread Daniel Stone
Hi, On 16 January 2012 18:53, Chad Versace chad.vers...@linux.intel.com wrote: On 01/16/2012 10:36 AM, Daniel Vetter wrote: I've just read about androgenizer: http://cgit.collabora.com/git/user/derek/androgenizer.git/ Would that be a useful to at least generate the Android.mk in a sensible

Re: [PATCH evdev 1/2] Force x/y axes to exist on devices with any other axes (#44655)

2012-01-13 Thread Daniel Stone
(pInfo, X_PROBED, Found relative axes\n); Pretty sure this should be in the !ignore_rel branch? That aside: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: synaptics: Motion history change in b26125e412a130b7a8f8b6adf9ffc8e9cc8df42c

2012-01-11 Thread Daniel Stone
Hi, On 11 January 2012 16:43, Chase Douglas chase.doug...@canonical.com wrote: In Ubuntu, we have been shipping xf86-input-synaptics 1.4.1. Now we are upgrading to the latest code (which I hope to add multitouch support to soon). We noticed that the pointer speed is much faster now, across

Re: [PULL] 1.12 fix queue

2012-01-11 Thread Daniel Stone
Hi, On 11 January 2012 22:54, Keith Packard kei...@keithp.com wrote: I can easily do that. Now, the only question is one of names. I'm not sure I like changing where the release is done; keeping it on master makes things straightforward (at least for me, and perhaps for others?). The pending

Re: [Resend] Patch: fix regression introduced in intel driver version 2.16.0

2012-01-08 Thread Daniel Stone
Hi, On 6 January 2012 14:53, Chris Clayton chris2...@googlemail.com wrote: I sent this message on 29 December, but I guess all the intel driver developers were busy with (well-earned) Yuletide relaxing. Here it is again with the graphics-related output from lspci added... The Intel guys

Re: linux intel and xorg status on i915GM hardware

2012-01-06 Thread Daniel Stone
Hi, On 6 January 2012 07:45, Knut Petersen knut_peter...@t-online.de wrote: Some comments related to linux and xorg git master on an AOpen i915GMm-hfs: 1: Xorg.0.log is full of (besides timestamp) identical EDID entries: == [...] The

Re: [PATCH 1/2] dix: Return BadWindow rather than BadMatch from dixLookupWindow

2012-01-05 Thread Daniel Stone
return BadMatch is: ListProperties, SetSelectionOwner, {Destroy,Map,Unmap}{,Sub}Window. This also fixes QueryTree. Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH 00/31] _X_UNEXPORT

2012-01-05 Thread Daniel Stone
Hi, On Fri, Dec 02, 2011 at 01:05:43PM -0800, Aaron Plattner wrote: Of the symbols removed here, we use the following: [...] Thanks for this list -- it's great, exactly what I was hoping for. I've re-exported all these symbols in my current tree, so hopefully it should be fine. Using nobody

[PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/properties.c |2 +- src/synapticsstr.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/properties.c b

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Hi, On 4 January 2012 17:30, Cyril Brulebois k...@debian.org wrote: Daniel Stone dan...@fooishbar.org (04/01/2012): Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. Signed-off-by: Daniel Stone dan...@fooishbar.org Reminds me

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Hi, For the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel On 3 January 2012 00:44, Peter Hutterer peter.hutte...@who-t.net wrote: synaptics.c: In function 'SynapticsPreInit': synaptics.c:731:18: warning: assignment discards 'const' qualifier from pointer target type

Re: [PATCH 20/42] Move DGA from extmod to built-in

2012-01-04 Thread Daniel Stone
Hi, On Fri, Dec 02, 2011 at 07:17:24PM -0200, Paulo Zanoni wrote: 2011/12/2 Daniel Stone dan...@fooishbar.org: @@ -90,6 +104,9 @@ load_extension_config(void)         }  #endif     } + +    for (i = 0; i ARRAY_SIZE(extensionModules); i++) +       LoadExtension(extensionModules[i

Re: [PATCH 25/42] Move DRI1 from external module to built-in

2012-01-04 Thread Daniel Stone
Hi, On Wed, Dec 07, 2011 at 09:51:38AM +1000, Peter Hutterer wrote: whitespace, plus I don't actually see the change here anyway. erroneous hunk? Yeah, just detritus from removing and re-adding it later. Removed, thanks. Cheers, Daniel ___

Re: [PATCH 11/31] mi: _X_UNEXPORT

2012-01-04 Thread Daniel Stone
Hi, On Wed, Dec 14, 2011 at 08:37:47AM +0100, Adam Tkac wrote: On Wed, Dec 07, 2011 at 08:40:41AM +1000, Peter Hutterer wrote: I also suspect that VNC may use some of these. Hello Peter, Daniel, thanks for CCing me. In VNC we use following: - mieqProcessInputEvents You can just call

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-04 Thread Daniel Stone
Hi, On 4 January 2012 18:45, Ian Romanick i...@freedesktop.org wrote: Okay, I looked back at your build output, and I think I see the problem:  * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub  * econf: updating Mesa-/bin/config.guess with

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Daniel Stone
Hi, On 4 January 2012 18:55, Mark Kettenis mark.kette...@xs4all.nl wrote: X-Original-To: xorg-devel@lists.x.org From: Daniel Stone dan...@fooishbar.org Date: Wed,  4 Jan 2012 17:02:30 + Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code

Re: [PATCH inputproto] specs: Clarify rejection for touch events on current owner

2012-01-04 Thread Daniel Stone
On Fri, Dec 23, 2011 at 06:07:50PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 08/31] os: _X_UNEXPORT

2012-01-04 Thread Daniel Stone
On Fri, Dec 02, 2011 at 12:33:46PM -0800, Alan Coopersmith wrote: On 12/02/11 03:31, Daniel Stone wrote: diff --git a/include/dixstruct.h b/include/dixstruct.h index 0a85f40..1a4aece 100644 --- a/include/dixstruct.h +++ b/include/dixstruct.h @@ -38,7 +38,7 @@ SOFTWARE. * translation

Re: [PATCH 11/31] mi: _X_UNEXPORT

2012-01-04 Thread Daniel Stone
Hi, On Wed, Dec 07, 2011 at 08:40:41AM +1000, Peter Hutterer wrote: On Fri, Dec 02, 2011 at 11:31:17AM +, Daniel Stone wrote: Remove unnecessary _X_EXPORT tags from mi headers. Signed-off-by: Daniel Stone dan...@fooishbar.org some of these are still used by input drivers, most

Re: [PATCH 21/31] XFree86: _X_UNEXPORT

2012-01-04 Thread Daniel Stone
On Wed, Dec 07, 2011 at 08:50:03AM +1000, Peter Hutterer wrote: On Fri, Dec 02, 2011 at 11:31:27AM +, Daniel Stone wrote: Unexport all the remaining _X_EXPORTed XFree86 symbols not used by any drivers. Signed-off-by: Daniel Stone dan...@fooishbar.org Needed externally

Re: [PATCH 22/31] DIX: _X_UNEXPORT

2012-01-04 Thread Daniel Stone
Hi, On Fri, Dec 02, 2011 at 11:32:31AM -0800, Alan Coopersmith wrote: On 12/02/11 03:31, Daniel Stone wrote: --- a/dix/dispatch.c +++ b/dix/dispatch.c @@ -167,7 +167,7 @@ static int nextFreeClientID; /* always MIN free client ID */ static int nClients; /* number of authorized

Re: PING: [PATCH xserver] xkb: Message actions suppress other key presses #28575

2012-01-03 Thread Daniel Stone
were not registered. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch Seems sensible and doesn't contradict the spec, so: Reviewed-by: Daniel Stone dan...@fooishbar.org Looks fine for both master and 1.11. Cheers, Daniel ___ xorg-devel

Re: [PATCH xdm] Support reloading xdm through systemd.

2011-12-30 Thread Daniel Stone
Hi, On 30 December 2011 18:54, Gaetan Nadon mems...@videotron.ca wrote: /bin/kill works on all platforms? There are 50,000 hits on google about /usr/bin/kill. One of them for Oracle: No matter, systemd is (very) Linux-only. Cheers, Daniel ___

Re: [PATCH s3virge] Add missing VERBLEV argument to xf86DrvMsgVerb()

2011-12-29 Thread Daniel Stone
Pushed, thanks. On 26 December 2011 16:37, Tormod Volden lists.tor...@gmail.com wrote: From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Fixes build failure here at least.  src/s3v_driver.c |    2 +-  1 files changed, 1 insertions(+), 1

Re: [ANNOUNCE] xorg-server 1.11.3 [fix kdrive build]

2011-12-18 Thread Daniel Stone
Hi, On Sat, Dec 17, 2011 at 11:06:38AM -0800, Jeremy Huddleston wrote: On Dec 17, 2011, at 2:35 AM, Julien Cristau wrote: Can we move all the -Werror flags to a devel option instead (ie the strict-compilation flag), and have release builds not use any of them? Pretty please? The ones

Re: [PATCH 11/42] Hook up the ownership events

2011-12-18 Thread Daniel Stone
Hi, On Thu, Dec 15, 2011 at 01:01:48PM +1000, Peter Hutterer wrote: +static void STouchOwnershipEvent(xXITouchOwnershipEvent *from, + xXITouchOwnershipEvent *to) +{ +*to = *from; +swaps(to-sequenceNumber); +swapl(to-length); +

Re: [PATCH inputproto multitouch] Touch IDs must be at least unique per master device

2011-12-11 Thread Daniel Stone
Hi, On 9 December 2011 21:43, Chase Douglas chase.doug...@canonical.com wrote: XIAllowEvents with a master device and a touch ID must uniquely identify a touch sequence. If touch IDs were unique per slave device, multiple slave devices could have valid sequences with the same touch ID, and the

Re: [PATCH xkbcomp] include resets group compatibility modifiers #43091

2011-12-06 Thread Daniel Stone
Hi, On Fri, Dec 02, 2011 at 09:10:06PM +0100, Andreas Wettstein wrote: This change makes sure that include does not overwrite previous compatibility modifier settings when the included files does not explicitly specify them. Looks good to me -- I've applied and pushed it now. Thanks a lot!

Re: [PATCH 0/2 RFC] Fixes version 6

2011-12-02 Thread Daniel Stone
Hi, On 1 December 2011 20:53, Adam Jackson a...@redhat.com wrote: Two minor additions.  The atomic query requests I think I've proposed before but got distracted by the XI2 interaction.  The latter moves PropertyNotify filtering into the server, to avoid waking up every client uselessly just

[PATCH v2 00/42] Death to extmod

2011-12-02 Thread Daniel Stone
Hi, A little while later (cough), I've finally finished cleaning up and rebasing my extmod changes, based on the review comments I got the first time around. I'm running this now, and it seems fine -- including having the Composite visual created in GLX too. Anything with 'v2' in the subject is

[PATCH v2 01/42] Xorg: Link XKB DDX library after core server libs

2011-12-02 Thread Daniel Stone
-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) v2: New. diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am index 4f08772..38ac73c 100644 --- a/hw/xfree86/Makefile.am +++ b/hw/xfree86/Makefile.am @@ -56,8

[PATCH 02/42] Add a common ARRAY_SIZE macro to dix.h

2011-12-02 Thread Daniel Stone
Does what it says on the box, replacing those from Xi/ and glx/. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte

[PATCH 04/42] Xinerama: Fix ExtensionInit prototype

2011-12-02 Thread Daniel Stone
Huh, so I guess INITARGS used to be int argc, char *argv then. Either way, it's now void, so fix that ... Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH 03/42] Make extension.h self-contained, remove C++ externs

2011-12-02 Thread Daniel Stone
externsion.h required bits from Xfuncproto.h and dixstruct.h, but included neither; fix that. It also had _XFUNCPROTOBEGIN and _XFUNCPROTOEND wrappers, which is a bit pointless for a server-only library, as it's only needed for C++. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed

[PATCH 09/42] Loader: Drop EXTERN_MODULE flag

2011-12-02 Thread Daniel Stone
EXTERN_MODULE was used to specify that we shouldn't worry about modules lacking a ModuleData object. It was also completely unused. *shrug* Signed-off-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Module.h |3 --- hw

[PATCH 07/42] Reorder extension initialisation for non-Xorg

2011-12-02 Thread Daniel Stone
Reorder static extension initialisation in miinitext for non-Xorg servers to match Xorg's order. Tested with Xephyr; checked that the extension list was identical before and after. Signed-off-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- mi

[PATCH 11/42] Move DBE from an external module to built-in

2011-12-02 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com If DBE support is compiled in the server, just man up and build it into the server, rather than having it as an external module. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja

[PATCH v2 10/42] Add xf86ExtensionInit for DDX extension configuration

2011-12-02 Thread Daniel Stone
xf86ExtensionInit is called after configuration file parsing, so it can perform the two parts of extension initialisation currently done by extmod: enabling and disabling of extensions through an 'omit' option, and SELinux configuration. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed

[PATCH 13/42] Move MIT-SCREEN-SAVER from extmod to built-in

2011-12-02 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com If we've built MIT-SCREEN-SAVER support, then just build it into the main binary, rather than leaving it in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net

[PATCH v2 17/42] XFree86: sdksyms: Remove unused -DXorgLoader

2011-12-02 Thread Daniel Stone
, so we can remove the define. Signed-off-by: Daniel Stone dan...@fooishbar.org --- v2: Split out from Xv patch. hw/xfree86/sdksyms.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/sdksyms.sh b/hw/xfree86/sdksyms.sh index b8563ee..38115ba 100755 --- a/hw

[PATCH 24/42] Xext: Only build one library

2011-12-02 Thread Daniel Stone
Now that libXextmodule.la is both empty and unused, we can just build the one libXext.la for everyone, rather than having Xorg be special and unique. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

[PATCH 26/42] XFree86: DRI: Don't use per-target CFLAGS

2011-12-02 Thread Daniel Stone
AM_CFLAGS will suffice, given we only have one target in this directory. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Cyril Brulebois k...@debian.org --- hw/xfree86/dri/Makefile.am | 25 - 1 files changed, 12 insertions(+), 13 deletions(-) diff --git

[PATCH 23/42] Remove the last remnants of extmod

2011-12-02 Thread Daniel Stone
extmod was originally a big pointless module. Now it's an empty, pointless module. This commit makes it unexist. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/Makefile.am

[PATCH v2 34/42] Quartz: Move PseudoramiX initialisation to DDX

2011-12-02 Thread Daniel Stone
As PseudoramiX is a DDX-specific extension, move its loading and initialisation to hw/xquartz. This creates a QuartzExtensionInit() similar in spirit to xf86ExtensionInit. Signed-off-by: Daniel Stone dan...@fooishbar.org --- v2: New. hw/xquartz/quartz.c | 19 +++ 1 files

[PATCH 18/42] Xv: Remove excessive module-induced indirection

2011-12-02 Thread Daniel Stone
...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org Acked-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/xvdix.h |7 --- Xext/xvmain.c| 15 --- hw/kdrive/src/kxv.c

[PATCH 25/42] Move DRI1 from external module to built-in

2011-12-02 Thread Daniel Stone
Rather than building the tiny amount of code required for XFree86-DRI as an external module, build it in if it's enabled at configure time. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |6 +- hw/xfree86/Makefile.am |7 ++- hw/xfree86

[PATCH 40/42] Ignore local-only requests from remote clients

2011-12-02 Thread Daniel Stone
Even though we hide local-only extensions from remote clients in the extension list, make doubly sure they can't make a local-only request. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/dispatch.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git

[PATCH 41/42] Remove LocalClient checks from local-only extensions

2011-12-02 Thread Daniel Stone
We already hide the extension from clients and deny their requests, so I doubt we'll be needing the LocalClient() check anymore. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/kdrive/ephyr/ephyrdriext.c | 62 +- hw/xfree86/common/xf86DGA.c |5 +- hw/xfree86/dri

[PATCH 39/42] Hide local-only extensions from remote clients

2011-12-02 Thread Daniel Stone
If an extension is declared as being for local use only, don't show it to remote clients in the extension list. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Jamey Sharp ja...@minilop.net --- dix/extension.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 36/42] Unify miinitext.c

2011-12-02 Thread Daniel Stone
Rather than having a non-Xorg and an Xorg-specific path which basically just duplicated each other for no reason, we could ... just have one. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/dixmods/Makefile.am |2 +- mi/miinitext.c | 91

<    1   2   3   4   5   6   7   8   9   10   >