Re: [PATCH RFC inputproto] Add WrapAround axis flag

2011-08-17 Thread Daniel Stone
Hi, On Wed, Aug 17, 2011 at 08:19:50AM +1000, Peter Hutterer wrote: On Tue, Aug 16, 2011 at 01:04:06PM +0100, Daniel Stone wrote: Ugh. I suppose it's too late now, but I don't suppose it makes any more sense to export them as relative rather than abs? If not: Reviewed-by: Daniel Stone dan

Re: [PATCH RFC inputproto] Remove requirement for 1.0 == 1 unit of scrolling

2011-08-17 Thread Daniel Stone
Hi, On Wed, Aug 17, 2011 at 08:41:22AM +1000, Peter Hutterer wrote: On Tue, Aug 16, 2011 at 12:58:49PM +0100, Daniel Stone wrote: Err, but then it makes smooth scrolling useless to clients. Does -1.0 mean to scroll up one unit, or one third of a unit? Or one tenth of a unit? Or one pixel

Re: [PATCH inputproto] specs: ValuatorClass includes a mode

2011-08-17 Thread Daniel Stone
On Wed, Aug 17, 2011 at 04:11:28PM +1000, Peter Hutterer wrote: Documented in the description, but missing in the definition. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel

Re: [PATCH RFC inputproto] Remove requirement for 1.0 == 1 unit of scrolling

2011-08-17 Thread Daniel Stone
On Wed, Aug 17, 2011 at 11:33:51AM +0100, Daniel Stone wrote: then it'd need to be a part of the ValuatorInfo rather than ValuatorClassInfo ... Ignore this, I'm an idiot. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH RFC inputproto] Remove requirement for 1.0 == 1 unit of scrolling

2011-08-16 Thread Daniel Stone
Hi, On Tue, Aug 16, 2011 at 04:08:24PM +1000, Peter Hutterer wrote: This isn't true in most cases, especially where physical scroll axes are involved. Wacom Intuos4 scroll rings have a unit size of 3.0 and the driver historically sent one scroll event per 3.0 increment or decrement. Mapping

Re: [PATCH RFC inputproto] Use flags for smooth scrolling, not axis labels.

2011-08-16 Thread Daniel Stone
On Mon, Aug 15, 2011 at 09:40:55PM +1000, Peter Hutterer wrote: On 15/08/11 21:09 , Daniel Stone wrote: On Mon, Aug 15, 2011 at 03:28:03PM +1000, Peter Hutterer wrote: +The behavior of the server if there is more than one VertScroll or more than +one HorizScroll axes on the same device

Re: [PATCH RFC inputproto v2] Use flags for smooth scrolling, not axis labels.

2011-08-16 Thread Daniel Stone
Hi, On Tue, Aug 16, 2011 at 10:00:41AM +1000, Peter Hutterer wrote: diff --git a/XI2proto.h b/XI2proto.h index 8977e87..03ead01 100644 --- a/XI2proto.h +++ b/XI2proto.h @@ -186,9 +186,11 @@ typedef struct { uint8_t mode; /** ModeRelative or ModeAbsolute */ uint8_t

Re: [PATCH RFC inputproto] Add WrapAround axis flag

2011-08-16 Thread Daniel Stone
it's too late now, but I don't suppose it makes any more sense to export them as relative rather than abs? If not: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH RFC inputproto] Use flags for smooth scrolling, not axis labels.

2011-08-15 Thread Daniel Stone
Hi, Looks good to me generally, but: On Mon, Aug 15, 2011 at 03:28:03PM +1000, Peter Hutterer wrote: +Newer X servers may provide scrolling information through specific +valuators to provide scroll events with more precision than the button +events. Valuators for axes sending scrolling

Re: [PATCH] randr: stop clients from deleting immutable output properties

2011-08-10 Thread Daniel Stone
On Wed, Aug 10, 2011 at 01:06:33PM +0200, Luc Verhaegen wrote: Immutable in randr means that clients are not able to alter the property itself, they are only allowed to alter the property value. This logically means that the property then should not be deleted by the client either. Instead of

Re: [PATCH] clarify RRDeleteOutputProperty for immutable properties

2011-08-10 Thread Daniel Stone
+ If the specified property does not exist, a Match error is returned. If + the property is marked 'immutable', an Access error is returned. s/Match/Atom/ With that fixed: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel

Re: [PATCH] randr: stop clients from deleting immutable output properties

2011-08-10 Thread Daniel Stone
On Wed, Aug 10, 2011 at 03:53:03PM +0200, Luc Verhaegen wrote: On Wed, Aug 10, 2011 at 03:48:30PM +0200, Luc Verhaegen wrote: This was not done for a few reasons: 1) it clearly splits between clientside and server internal usage. The comment that i added to RRDeleteOutputProperty in the

Re: [PATCH] Xephyr/dri: register screen and window privates on init

2011-08-09 Thread Daniel Stone
Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/ephyrdriext.c |4 1 files changed, 4 insertions(+), 0 deletions(-) Ping. Anyone? Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel

Re: [PATCH] Recognise ISO_Level5-keysyms as modifiers in xcb_is_modifier_key #39177

2011-08-08 Thread Daniel Stone
...@solnet.ch Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Recognise ISO_Level5-keysyms as modifiers in IsModifierKey #21910.

2011-08-08 Thread Daniel Stone
...@solnet.ch Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 03/17] config: use add_option for source and path too.

2011-08-08 Thread Daniel Stone
like there are two different commits here. :) With the split: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH 04/17] dix: avoid using the VCP as modifier device

2011-08-08 Thread Daniel Stone
...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 07/17] dix: don't XWarpPointer through the last slave anymore (#38313)

2011-08-08 Thread Daniel Stone
On Mon, Aug 08, 2011 at 04:21:03PM +1000, Peter Hutterer wrote: This line was introduced pre-1.6 to fix Bug 19297. The effect of warping through the VCP then was that if a device had custom valuator ranges, the warp position would be wrong. This has since been fixed otherwise and devices scale

Re: [PATCH 08/17] dix: rename mieqSwitchScreen argument fromDix → set_dequeue_screen, document

2011-08-08 Thread Daniel Stone
On Mon, Aug 08, 2011 at 04:21:04PM +1000, Peter Hutterer wrote: fromDIX is neither exactly true nor particularly helpful in understanding what this parameter triggers. Rename to set_dequeue_screen, because that's exactly what happens. With s/differeent/different/: Reviewed-by: Daniel Stone dan

Re: [PATCH 09/17] mi: fix comment typo, whitespace in miPointerSetPosition

2011-08-08 Thread Daniel Stone
On Mon, Aug 08, 2011 at 04:21:05PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH 10/17] test: add a test for GetMaster() behaviour

2011-08-08 Thread Daniel Stone
On Mon, Aug 08, 2011 at 04:21:06PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH 11/17] dix: don't use the pointer as modifier device in UngrabKey.

2011-08-08 Thread Daniel Stone
On Mon, Aug 08, 2011 at 04:21:07PM +1000, Peter Hutterer wrote: Modifier device is always the keyboard. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 12/17] dix: add KEYBOARD_OR_FLOAT and POINTER_OR_FLOAT to GetMaster()

2011-08-08 Thread Daniel Stone
. _OR_FLOAT confusion): Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 16/17] Xi: silence compiler warnings (set but not used)

2011-08-08 Thread Daniel Stone
pretty trivially get rid of 'b' too, it's only used in a couple of places where you wouldn't introduce wrapping by expanding b. Either way though: Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 15/17] mi: fix compiler warnings (foo set but not used)

2011-08-08 Thread Daniel Stone
] mivaltree.c: In function 'miComputeClips': mivaltree.c:226:10: warning: variable 'resized' set but not used [-Wunused-but-set-variable] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel

Re: [PATCH 14/17] dix: fix compiler warnings (foo set but not used)

2011-08-08 Thread Daniel Stone
-variable] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

Re: [PATCH 01/17] Revert Attempt to add the 'mouse' driver in more situations.

2011-08-08 Thread Daniel Stone
a xorg.conf that only references one device. This is possible, but not a use-case we should worry about too much now. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 02/17] config: fix a log message

2011-08-08 Thread Daniel Stone
On Mon, Aug 08, 2011 at 04:20:58PM +1000, Peter Hutterer wrote: PRODUCT was taken from the parent, hence ppath. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 05/17] dix: ignore devices when adding passive core grabs to list (#39545)

2011-08-08 Thread Daniel Stone
when trying to set the same grab combo twice on a window. I don't see how this could make the described case worse, so: Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH 13/17] input: replace remaining GetPairedDevice() with GetMaster()

2011-08-08 Thread Daniel Stone
be POINTER_OR_FLOAT, as the aim is to get something with dev-valuator if you've just triggered a pointer event from an XKB action. With those fixed: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread Daniel Stone
Hi, On Fri, Aug 05, 2011 at 04:07:13PM +0200, walter harms wrote: I am not sure if i understand the purpose of swap() really. To account for different byte ordering (rather than bit ordering) on machines of different endianness. The bit ordering is already taken care of for us by everyone

Re: [PATCH inputproto] Add sourceid to RawEvents (#34420)

2011-07-29 Thread Daniel Stone
On Fri, Jul 29, 2011 at 11:05:26AM +1000, Peter Hutterer wrote: +sourceid +The source device that originally generated the event. The sourceid +is undefined for clients supporting XI 2.0. 'for clients not supporting XI 2.1'. Otherwise: Reviewed-by: Daniel Stone dan

Re: [PATCH xinput] Print the sourceid for RawEvents. (#34240)

2011-07-29 Thread Daniel Stone
On Fri, Jul 29, 2011 at 11:05:28AM +1000, Peter Hutterer wrote: For XI 2.0 servers, this will always be 0. X.Org Bug 34240 http://bugs.freedesktop.org/show_bug.cgi?id=34240 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH libXi] Set the raw event's sourceid in XI 2.1 (#34240)

2011-07-29 Thread Daniel Stone
Hi, On Fri, Jul 29, 2011 at 10:54:34AM +0100, Daniel Stone wrote: On Fri, Jul 29, 2011 at 11:05:29AM +1000, Peter Hutterer wrote: +#if (defined XI_2_Major) (defined XI_2_1_Minor) +out-sourceid = in-sourceid; +#else +out-sourceid = 0; +#endif out-flags

Re: [PATCH xserver] randr: Compare all the bytes in RRPostPendingProperties

2011-07-29 Thread Daniel Stone
On Fri, Jul 29, 2011 at 04:42:43PM -0700, Keith Packard wrote: On Fri, 29 Jul 2011 16:12:06 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Fix this by computing the total number of bytes to compare in the memcmp. Nice catch. Merged (and reviewed). b8f61c1..08dfff9 master -

Re: [PATCH] Initialize the fd to -1 for xorg.conf input devices.

2011-07-25 Thread Daniel Stone
early. Reproducible: add a wacom driver InputDevice section with no Option Device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 10/10] xfree86: factor out adding/removing a device from the input device array

2011-07-25 Thread Daniel Stone
your new InputInfoRec duplication here? +return list; +} With that, for the series: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: [PATCH RFC] Terminate the log with one last message.

2011-07-25 Thread Daniel Stone
) why the server terminated (to some degree, given that most real-world errors will be caused by AbortServer()). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel

[PATCH RESEND 1/2] Fix non-Composite builds in PrintWindowTree

2011-07-13 Thread Daniel Stone
The previous patch accidentally introduced a hard dependency on Composite. Sorry, OS X. Signed-off-by: Daniel Stone dan...@fooishbar.org Reported-by: Jeremy Huddleston jerem...@apple.com --- dix/window.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/dix

[PATCH RESEND 2/2] XKB: Work around broken interps from old xkbcomp

2011-07-13 Thread Daniel Stone
in particular. See xkbcomp commits 2a473b906943ffd807ad81960c47530ee7ae9a60 and 3caab5aa37decb7b5dc1642a0452efc3e1f5100e for more details. Signed-off-by: Daniel Stone dan...@fooishbar.org --- xkb/xkb.c | 19 ++- xkb/xkmread.c | 31 --- 2 files changed, 46

Re: X server not responding when querying X pointer position

2011-07-08 Thread Daniel Stone
Hi, On Fri, Jul 08, 2011 at 12:51:19PM +0200, Thierry Reding wrote: * Thierry Reding wrote: * Daniel Stone wrote: Heh, threads are always problematic. Are you calling XInitThreads() before your first call to XOpenDisplay()? Actually I was just using Gtk+, without any explicit calls

Re: X server not responding when querying X pointer position

2011-07-07 Thread Daniel Stone
Hi, On Thu, Jul 07, 2011 at 11:17:57AM +0200, Thierry Reding wrote: I see strange behaviour with a program I'm developing. Basically the program embeds WebKit to display a graphical user-interface. Sometimes during testing (which is just playing around with some buttons on the screen) it

Re: X server not responding when querying X pointer position

2011-07-07 Thread Daniel Stone
On Thu, Jul 07, 2011 at 11:46:43AM +0200, Thierry Reding wrote: * Daniel Stone wrote: The two most pertinent questions I can think of are: * are you using threads at all? I try to keep the number of threads used to a minimum, but since WebKit is involved and the program also uses

Re: [PATCH 2/2] XKB: Work around broken interps from old xkbcomp

2011-07-05 Thread Daniel Stone
Hi, I thought you were just going to pick up on the workaround only being commented in xkmread.c and not xkb.c ... On Tue, Jul 05, 2011 at 08:20:50AM +1000, Peter Hutterer wrote: On Mon, Jul 04, 2011 at 04:41:05PM +0100, Daniel Stone wrote: See xkbcomp commits

Re: [PATCH xkbcomp] Add .pc file for version export

2011-07-05 Thread Daniel Stone
format, so. Anyway, seems harmless enough, so: Reviewed-by: Daniel Stone dan...@fooishbar.org Something like this should do to get us around the bugs. I don't believe so, no. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http

[PATCH 1/2] Fix non-Composite builds in PrintWindowTree

2011-07-04 Thread Daniel Stone
The previous patch accidentally introduced a hard dependency on Composite. Sorry, OS X. Signed-off-by: Daniel Stone dan...@fooishbar.org Reported-by: Jeremy Huddleston jerem...@apple.com --- dix/window.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/dix

[PATCH 2/2] XKB: Work around broken interps from old xkbcomp

2011-07-04 Thread Daniel Stone
in particular. See xkbcomp commits 2a473b906943ffd807ad81960c47530ee7ae9a60 and 3caab5aa37decb7b5dc1642a0452efc3e1f5100e for more details. Signed-off-by: Daniel Stone dan...@fooishbar.org --- xkb/xkb.c | 19 ++- xkb/xkmread.c | 31 --- 2 files changed, 46

Re: [PATCH 21/37] Move DRI1 from external module to built-in

2011-07-01 Thread Daniel Stone
Hi, On Thu, Jun 30, 2011 at 02:04:43PM -0700, Ian Romanick wrote: On 06/28/2011 12:27 PM, Daniel Stone wrote: Rather than building the tiny amount of code required for XFree86-DRI as an external module, build it in if it's enabled at configure time. Signed-off-by: Daniel Stone dan

Re: [PULL] valuator double work

2011-06-30 Thread Daniel Stone
Hi, On Wed, Jun 29, 2011 at 08:00:50PM -0700, Keith Packard wrote: On Wed, 29 Jun 2011 15:37:43 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: This is admittedly a larger-than-usual pull request but I'd like this to be in 1.11. The main chunk of this work is the switch to use double

Re: [PULL] valuator double work

2011-06-30 Thread Daniel Stone
On Thu, Jun 30, 2011 at 08:41:12AM -0700, Keith Packard wrote: On Thu, 30 Jun 2011 10:17:11 +0100, Daniel Stone dan...@fooishbar.org wrote: Looks like 1.12 is going to be fun for input. :) Yup. Nice to see stuff ready *before* the merge window opens for another release though. Don't worry

Re: [PATCH 37/37] Remove separate ExtensionToggle list from miinitext [WIP]

2011-06-30 Thread Daniel Stone
On Thu, Jun 30, 2011 at 12:43:14PM -0700, Jamey Sharp wrote: I think the winwindowswm hunks belong in the previous patch, right? Eep yes, good catch. Thanks. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 1/1] Add some keysyms to support Breton’s n-graphs.

2011-06-29 Thread Daniel Stone
Thanks for this. I guess we'll also need default Compose mappings along the lines of: ch ch: # BRETON ch ? Regardless, for this patch: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [PULL] Kill libxorg

2011-06-28 Thread Daniel Stone
Hi, On Thu, Jun 23, 2011 at 05:52:47AM -0700, Dan Nicholson wrote: Having now played around with trying to kill libxservertest, I realized that this patchset isn't quite as robust as I thought. It turns out that getting all the Xorg convenience libraries to link without putting them into a

Re: [PATCH RESEND synaptics 1/2] Revert build: collapse all Makefile.am files into a single non-recursive one.

2011-06-28 Thread Daniel Stone
= @inputdir@ to input_LTLIBRARIES = @DRIVER_NAME@_drv.la noinst_PROGRAMS to check_PROGRAMS Signed-off-by: Gaetan Nadon mems...@videotron.ca For both patches: Acked-by: Daniel Stone dan...@fooishbar.org The changes seem to have broken ChangeLog generation too, such that: make -C build

[PATCH 01/37] Add a common ARRAY_SIZE macro to dix.h

2011-06-28 Thread Daniel Stone
Does what it says on the box, replacing those from Xi/ and glx/. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xi/extinit.c |2 -- glx/glxdricommon.c |2 -- include/dix.h |2 ++ 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Xi/extinit.c b/Xi

[PATCH 0/37] Extension handling cleanup, death to extmod

2011-06-28 Thread Daniel Stone
Hi, The following patch series cleans up extension handling pretty substantially: it kills extmod, removes about half of miinitext.c to give us one unified set of extension definitions, and removes all other Xorg extension modules except for GLX, which is huge. This also adds a localOnly argument

[PATCH 02/37] Make extension.h self-contained, remove C++ externs

2011-06-28 Thread Daniel Stone
externsion.h required bits from Xfuncproto.h and dixstruct.h, but included neither; fix that. It also had _XFUNCPROTOBEGIN and _XFUNCPROTOEND wrappers, which is a bit pointless for a server-only library, as it's only needed for C++. Signed-off-by: Daniel Stone dan...@fooishbar.org --- include

[PATCH 03/37] Xinerama: Fix ExtensionInit prototype

2011-06-28 Thread Daniel Stone
Huh, so I guess INITARGS used to be int argc, char *argv then. Either way, it's now void, so fix that ... Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/panoramiX.c|2 +- hw/xfree86/dixmods/extmod/modinit.h |2 +- 2 files changed, 2 insertions(+), 2

[PATCH 11/37] Move DPMS from extmod to built-in

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build DPMS support into the core server, rather than letting it languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am|2 +- Xext/dpms.c

[PATCH 08/37] Move DBE from an external module to built-in

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com If DBE support is compiled in the server, just man up and build it into the server, rather than having it as an external module. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- configure.ac

[PATCH 06/37] Loader: Drop EXTERN_MODULE flag

2011-06-28 Thread Daniel Stone
EXTERN_MODULE was used to specify that we shouldn't worry about modules lacking a ModuleData object. It was also completely unused. *shrug* Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/xf86Module.h |3 --- hw/xfree86/doc/ddxDesign.xml |9 - hw

[PATCH 13/37] Move Xv and XvMC from extmod to built-in

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build these extensions into the core server, rather than letting them languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am |2 +- Xext

[PATCH 20/37] Xext: Only build one library

2011-06-28 Thread Daniel Stone
Now that libXextmodule.la is both empty and unused, we can just build the one libXext.la for everyone, rather than having Xorg be special and unique. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am | 28 ++-- configure.ac |3 +-- 2 files

[PATCH 07/37] Add xf86ExtensionInit for DDX extension configuration

2011-06-28 Thread Daniel Stone
xf86ExtensionInit is called after configuration file parsing, so it can perform the two parts of extension initialisation currently done by extmod: enabling and disabling of extensions through an 'omit' option, and SELinux configuration. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw

[PATCH 04/37] Replace INITARGS with void

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com It was defined to void anyway. Everyone but panoramix used INITARGS, but PanoramiXExtensionInit() had hardcoded argc/argv. Replace that with void as well. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org

[PATCH 12/37] Move XRes from extmod to built-in

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Always build XRes support into the core server, rather than letting it languish in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am|2 +- Xext/xres.c

[PATCH 29/37] Remove Xorg-specific extensions from non-Xorg miinitext

2011-06-28 Thread Daniel Stone
miinitext.c had a completely separate codepath for non-Xorg servers, which included tests for Xorg-specific extensions such as XFree86-VidMode, which were external even to the Xorg DDX. So we can just remove them, and the associated #undefs. Signed-off-by: Daniel Stone dan...@fooishbar.org

[PATCH 19/37] Remove the last remnants of extmod

2011-06-28 Thread Daniel Stone
extmod was originally a big pointless module. Now it's an empty, pointless module. This commit makes it unexist. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/bigreq.c |1 - Xext/dpms.c |1 - Xext/panoramiX.c

[PATCH 21/37] Move DRI1 from external module to built-in

2011-06-28 Thread Daniel Stone
Rather than building the tiny amount of code required for XFree86-DRI as an external module, build it in if it's enabled at configure time. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |2 +- hw/xfree86/Makefile.am |2 + hw/xfree86

[PATCH 22/37] XFree86: DRI: Don't use per-target CFLAGS

2011-06-28 Thread Daniel Stone
AM_CFLAGS will suffice, given we only have one target in this directory. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/dri/Makefile.am | 25 - 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/hw/xfree86/dri/Makefile.am b/hw/xfree86/dri

[PATCH 27/37] Loader: Move ExtensionModule types to DIX

2011-06-28 Thread Daniel Stone
In preparation for gutting loadext.c, move the ExtensionModule struct to the DIX, and unexport ExtensionModuleList (why, why, why, why was this ever exported in the first place, tbqh). Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/xf86Module.h | 13

[PATCH 28/37] Move the remnants of loadext.c to miinitext.c

2011-06-28 Thread Daniel Stone
There was nothing XFree86-specific or loader-specific about this, aside from using xf86MsgVerb instead of ErrorF. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/xf86Module.h |1 - hw/xfree86/loader/Makefile.am |1 - hw/xfree86/loader/loadext.c| 94

[PATCH 14/37] Xv: Remove excessive module-induced indirection

2011-06-28 Thread Daniel Stone
...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- Xext/xvdix.h|7 --- Xext/xvmain.c | 15 --- hw/kdrive/src/kxv.c |8 hw/xfree86/common/xf86xv.c |9 - hw/xfree86

[PATCH 35/37] Ignore local-only requests from remote clients

2011-06-28 Thread Daniel Stone
Even though we hide local-only extensions from remote clients in the extension list, make doubly sure they can't make a local-only request. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/dispatch.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/dix

[PATCH 26/37] Loader: Remove extension initialisation sorting

2011-06-28 Thread Daniel Stone
be sorted by GLX, so we no longer have any users for it. Signed-off-by: Daniel Stone dan...@fooishbar.org --- COPYING |2 +- hw/xfree86/loader/loaderProcs.h |1 - hw/xfree86/loader/loadext.c | 346 --- mi/miinitext.c

[PATCH 31/37] Remove initDependencies from ExtensionModule

2011-06-28 Thread Daniel Stone
This is now just an unused field, so remove it. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/xf86Extensions.c |4 hw/xfree86/dixmods/glxmodule.c |1 - include/extension.h|1 - mi/miinitext.c | 33

[PATCH 23/37] DRI2: Remove prototype for DRI2DestroyDrawable

2011-06-28 Thread Daniel Stone
DRI2DestroyDrawable() was still being _X_EXPORTed, but hasn't existed since 1da1f33f last year. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/dri2/dri2.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/dri2/dri2.h b/hw/xfree86/dri2/dri2.h

[PATCH 34/37] Hide local-only extensions from remote clients

2011-06-28 Thread Daniel Stone
If an extension is declared as being for local use only, don't show it to remote clients in the extension list. Signed-off-by: Daniel Stone dan...@fooishbar.org --- dix/extension.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dix/extension.c b/dix/extension.c

[PATCH 15/37] Move SELinux from extmod to built-in

2011-06-28 Thread Daniel Stone
Instead of letting it languish in extmod just because we want to configure bits of it from xf86, move XSELinux to the builtin part of Xext, and do its configuration from xf86ExtensionInit. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am|8

[PATCH 36/37] Remove LocalClient checks from local-only extensions

2011-06-28 Thread Daniel Stone
We already hide the extension from clients and deny their requests, so I doubt we'll be needing the LocalClient() check anymore. Signed-off-by: Daniel Stone dan...@fooishbar.org --- hw/kdrive/ephyr/ephyrdriext.c |9 + hw/xfree86/common/xf86DGA.c |3 --- hw/xfree86/dri/xf86dri.c

[PATCH 10/37] Move MIT-SCREEN-SAVER from extmod to built-in

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com If we've built MIT-SCREEN-SAVER support, then just build it into the main binary, rather than leaving it in extmod. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- Xext/Makefile.am

[PATCH 33/37] Add localOnly argument to AddExtension

2011-06-28 Thread Daniel Stone
Does what it says on the box (or will, next commit): specifies if the extension should be enabled for local clients only. Marked SHM, DRI and DRI2 as the only extensions requiring local clients. Signed-off-by: Daniel Stone dan...@fooishbar.org --- Xext/bigreq.c |2 +- Xext

[PATCH 09/37] Move RECORD from external module to built-in

2011-06-28 Thread Daniel Stone
From: Tomas Carnecky t...@dbservice.com Rather than languishing in its own special module, move RECORD into the core server. Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- configure.ac |2 +- hw/xfree86/common

[PATCH 05/37] Reorder extension initialisation for non-Xorg

2011-06-28 Thread Daniel Stone
Reorder static extension initialisation in miinitext for non-Xorg servers to match Xorg's order. Tested with Xephyr; checked that the extension list was identical before and after. Signed-off-by: Daniel Stone dan...@fooishbar.org --- mi/miinitext.c | 84

[PATCH 17/37] DGA: Remove excessive module-induced indirection

2011-06-28 Thread Daniel Stone
...@dbservice.com Reviewed-by: Daniel Stone dan...@fooishbar.org --- hw/xfree86/common/dgaproc.h|1 - hw/xfree86/common/xf86DGA.c| 20 ++-- hw/xfree86/common/xf86Extensions.c |2 +- 3 files changed, 7 insertions(+), 16 deletions(-) diff --git a/hw/xfree86/common

Re: [PATCH 16/37] Move DGA from extmod to built-in

2011-06-28 Thread Daniel Stone
On Tue, Jun 28, 2011 at 08:55:40PM +0100, Alan Hourihane wrote: Just remembered, if --disable-dga when configuring still works, then I'm fine :-) Indeed it does; I had to double back and install dgaproto to actually test this. I'm all in favour of ditching DGA if we can, but I think SDL still

Re: [PATCH 0/37] Extension handling cleanup, death to extmod

2011-06-28 Thread Daniel Stone
Hi, On Tue, Jun 28, 2011 at 08:27:16PM +0100, Daniel Stone wrote: The following patch series cleans up extension handling pretty substantially: it kills extmod, removes about half of miinitext.c to give us one unified set of extension definitions, and removes all other Xorg extension modules

Re: [PATCH 30/37] Unify miinitext.c

2011-06-28 Thread Daniel Stone
Hi, On Tue, Jun 28, 2011 at 03:57:35PM -0700, Jeremy Huddleston wrote: This patch removes this XQuartz extension which needs to be initialized in the new common path. #ifdef INXQUARTZ if(!noPseudoramiXExtension) PseudoramiXExtensionInit(); #endif Damnit, sorry about that. The real

Re: [PATCH] input: add POINTER_NORAW to avoid generation of raw events (#30068)

2011-06-24 Thread Daniel Stone
peter.hutte...@who-t.net Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH v2 03/28] Input: Add flags to RawDeviceEvent

2011-06-24 Thread Daniel Stone
Hi, On Fri, Jun 24, 2011 at 09:51:38AM +1000, Peter Hutterer wrote: On Thu, Jun 23, 2011 at 10:53:34AM +0100, Daniel Stone wrote: Hmm, it's hard to say. Certainly on the face of it it seems cleaner to leave it as driver-native data, but I'm kind of worried that clients may have come

Re: [PATCH v2 28/28] Input: Add smooth-scrolling support to GetPointerEvents

2011-06-24 Thread Daniel Stone
Hi, On Fri, Jun 24, 2011 at 09:18:55AM +1000, Peter Hutterer wrote: On Thu, Jun 23, 2011 at 10:52:16AM +0100, Daniel Stone wrote: On Thu, Jun 23, 2011 at 01:35:59PM +1000, Peter Hutterer wrote: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for the lot though (well, the unreviewed

Re: [PATCH synaptics v2 09/21] Add last_scroll_millis to track scroll event timing

2011-06-23 Thread Daniel Stone
Hi, On Wed, Jun 15, 2011 at 02:55:13PM +0800, Daniel Kurtz wrote: On Wed, Jun 15, 2011 at 1:05 AM, Daniel Stone dan...@fooishbar.org wrote: @@ -1754,7 +1754,7 @@ get_delta_for_trackstick(SynapticsPrivate *priv, const struct SynapticsHwState *                          double *dx, double

Re: [PATCH v2 28/28] Input: Add smooth-scrolling support to GetPointerEvents

2011-06-23 Thread Daniel Stone
On Thu, Jun 23, 2011 at 01:35:59PM +1000, Peter Hutterer wrote: every time I see 95 lines being added to one function something in me diese a little. you don't seem to be accessing anything but v_scroll_axis and h_scroll_axis from the local stack anyway, why not make the while loop a: int

Re: [PATCH synaptics 17/21] Revise palm check logic

2011-06-23 Thread Daniel Stone
Hi, On Wed, Jun 15, 2011 at 12:40:07PM +0800, Daniel Kurtz wrote: On Wed, Jun 15, 2011 at 1:06 AM, Daniel Stone dan...@fooishbar.org wrote: @@ -1390,17 +1394,16 @@ SynapticsDetectFinger(SynapticsPrivate *priv, struct SynapticsHwState *hw)        return finger;     /* palm detection

Re: [PATCH inputproto 2/2] Document smooth-scrolling support

2011-06-23 Thread Daniel Stone
Hi, On Thu, Jun 23, 2011 at 10:44:44AM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 06:26:01PM +0100, Daniel Stone wrote: Two new axes are added to support smooth scrolling: Rel Vert Scroll and Rel Horiz Scroll. Cumulative values of 1.0 with either magnitude on these axes

Re: [PATCH synaptics v2 10/21] Use hardware time where possible

2011-06-23 Thread Daniel Stone
Hi, On Wed, Jun 15, 2011 at 01:42:13PM +0800, Daniel Kurtz wrote: On Wed, Jun 15, 2011 at 1:05 AM, Daniel Stone dan...@fooishbar.org wrote: @@ -2460,7 +2457,7 @@ repeat_scrollbuttons(const InputInfoPtr pInfo,  * occurs.  */  static int -HandleState(InputInfoPtr pInfo, struct

Re: [PATCH v2 03/28] Input: Add flags to RawDeviceEvent

2011-06-23 Thread Daniel Stone
Hi, On Thu, Jun 23, 2011 at 01:41:58PM +1000, Peter Hutterer wrote: On Thu, Jun 09, 2011 at 06:17:11PM +0100, Daniel Stone wrote: Add a flags member which will be copied wholesale into the resultant xXIRawEvent. sorry to flip-flop on this, but seing this patch and reading the XI2 proto

Re: [PATCH xserver] Remove unused check for PERL program

2011-06-23 Thread Daniel Stone
On Thu, Jun 23, 2011 at 09:29:16AM -0400, Gaetan Nadon wrote: Unable to find any use of the PERL Automake variable. It was used in hw/xfree86/scanpci around 2005. Should it ever be needed, use XORG_WITH_PERL macro. Signed-off-by: Gaetan Nadon mems...@videotron.ca Reviewed-by: Daniel Stone

Re: [PATCH synaptics 15/21] More accurate extrapolated fake motion events

2011-06-23 Thread Daniel Stone
Hi, On Wed, Jun 15, 2011 at 12:41:54PM +0800, Daniel Kurtz wrote: On Wed, Jun 15, 2011 at 1:06 AM, Daniel Stone dan...@fooishbar.org wrote: -    *dx = -xb1 * (HIST(0).millis - hw-millis); -    *dy = -yb1 * (HIST(0).millis - hw-millis); +    *dx = -xb1 * (start_time - hw-millis); +    *dy

[PATCH 02/23] Shuffle include order around

2011-06-23 Thread Daniel Stone
Group X protocol/server includes together, and synaptics-internal includes together. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/synaptics.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 8f4bca1..40eca99

<    3   4   5   6   7   8   9   10   11   12   >