Re: Dynamically adding / removing outputs to / from an existing kms device?

Hi, On 30-06-16 13:53, Hans de Goede wrote: Hi All, While going through patchwork I stumbled over these: https://patchwork.freedesktop.org/patch/38368/ https://patchwork.freedesktop.org/patch/38367/ https://patchwork.freedesktop.org/patch/38369/ Which made me wonder if the number of outputs

Dynamically adding / removing outputs to / from an existing kms device?

Hi All, While going through patchwork I stumbled over these: https://patchwork.freedesktop.org/patch/38368/ https://patchwork.freedesktop.org/patch/38367/ https://patchwork.freedesktop.org/patch/38369/ Which made me wonder if the number of outputs a card has changing is a thing and if we

Re: [xf86-video-nouveau] Properly cleanup fb for reverse-prime-offload

Hi Ilia, Ben, et al. Can I please get a review of this patch, and assuming the review is favorable, can someone please push this ? Regards, Hans p.s. Is it ok if I request push rights to the nouveau repos / group at freedesktop.org ? On 03-06-16 14:46, Hans De Goede wrote

Re: [PATCH xserver 1/2] modesetting: Fix swapping of provider sink / source capabilities

Hi, On 22-06-16 21:19, Emil Velikov wrote: Hi Hans, On 16 June 2016 at 14:37, Hans de Goede <hdego...@redhat.com> wrote: When a card has import capability it can be an offload _sink_, not a source and vice versa for export capability. This commit fixes the modesetting driver to proper

Re: [PATCH xserver] modesetting: Properly cleanup fb for reverse-prime-offload

Hi, On 22-06-16 09:09, Michel Dänzer wrote: On 22.06.2016 12:47, Michel Dänzer wrote: On 02.06.2016 04:04, Hans de Goede wrote: drmmode_set_scanout_pixmap_gpu(pix) adds drmmod->fb_id through a call to drmmode_xf86crtc_resize(), but on a subsequent drmmode_set_scanout_pixmap_gpu(NULL) it wo

Re: [PATCH xserver 1/2] modesetting: Fix swapping of provider sink / source capabilities

Hi, On 22-06-16 10:48, Eric Engestrom wrote: On Thu, Jun 16, 2016 at 03:37:51PM +0200, Hans de Goede wrote: When a card has import capability it can be an offload _sink_, not a source and vice versa for export capability. This commit fixes the modesetting driver to properly set

[xserver PULL 1.18 v2] Present, randr and modesetting fixes

ate to NULL after closing fd. xf86Crtc: don't set the root window property on slave GPUs. modesetting: set capabilities up after glamor and enable offload caps. Hans de Goede (1): modesetting: Properly cleanup fb for reverse-prime-offload Lyude Paul (1): modesetting: Cl

Re: [xserver PULL 1.18] Present, randr and modesetting fixes

Hi, On 20-06-16 17:45, Adam Jackson wrote: On Fri, 2016-06-17 at 15:36 +0200, Hans de Goede wrote: Hi Adam, Keith, Here is a pull req for server-1.18-branch, this more or less matches the pull-req for master, but with some patches which are more cleanups then actual bug-fixes dropped

Re: [PATCH xserver] randr: Do not check the screen size bound for gpu screens

Hi, On 20-06-16 18:32, Nikhil Mahale wrote: Sorry for late reply, Hans. See inline - On 06/13/2016 10:36 PM, Hans de Goede wrote: Hi, On 20-05-16 07:00, Nikhil Mahale wrote: For gpu screen, CrtcSet set/adjust the master screen size along mode in following callstack - ProcRRSetCrtcConfig

Cleaning up Xorg patchwork a bit

Hi, So as the 2 pull-reqs I send out earlier today show, we unfortunately have patches falling through the cracks every now and then. On one hand this is unavoidable and it is up to the submitter to ping us if this happens, OTOH we could / should do better IMHO. I believe that having an actual

[xserver PULL 1.18] Present, randr and modesetting fixes

ULL after closing fd. xf86Crtc: don't set the root window property on slave GPUs. modesetting: set capabilities up after glamor and enable offload caps. Hans de Goede (1): modesetting: Properly cleanup fb for reverse-prime-offload Lyude Paul (1): modesetting: Clear drmmode->

[xserver PULL master] Present, randr and modesetting fixes

blank handler present: Fix presentation of flips out of order Hans de Goede (5): xrandrprovider: Do not use separate lists for unbound / source / offload slaves modesetting: Properly cleanup fb for reverse-prime-offload modesetting: Set ppix->fb_id to 0 after

Re: [xserver] modesetting: Clear drmmode->fb_id before unflipping

nected at the same resolution - Rotate one monitor from normal straight to inverted - Watch as the monitor you didn't rotate either freezes or shows intense flickering Signed-off-by: Lyude <cp...@redhat.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com&g

Re: [PATCH v7 09/11] modesetting: Blacklist USB transport devices from PRIME sync

to accomodate earlier changes v6: Rebase onto ToT v7: Expand to blacklist all USB transport devices, not just UDL Signed-off-by: Alex Goins <ago...@nvidia.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/drivers/modesett

[PATCH xserver 2/2] modesetting: Load on GPU-s with 0 outputs

In newer laptops with switchable graphics, the GPU may have 0 outputs, in this case the modesetting driver should still load if the GPU is SourceOffload capable, so that it can be used as an offload source provider. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/d

[PATCH xserver 1/2] modesetting: Fix swapping of provider sink / source capabilities

de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c index 1604044..d786b3e 100644 --- a/hw/xfree86/drivers/modes

[PATCH xserver v2] randr: Adjust master's last set time with slaves

d confuse xrandr client. Reviewed-by: Hans de Goede <hdego...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2 (hdegoede): -Rebase on top of "xrandrprovider: Do not use separate lists for unbound / source / offload slaves" -Add my Reviewed-by an

Re: [PATCH v6 09/11] modesetting: Blacklist UDL from PRIME sync

Hi, On 14-06-16 03:02, Alex Goins wrote: Hi Hans! Replying inline. On 11-06-16 02:21, Alex Goins wrote: UDL (USB 2.0 DisplayLink DRM driver) has strange semantics when it comes to vblank events and damage tracking when page flipping. When doing a page flip, it will instantly raise a vblank

[PATCH xserver v2] modesetting: Remove unnecessary fb addition from drmmode_xf86crtc_resize

drmmode_set_mode_major() is the only user of drmmode->fb_id and will create it if necessary. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Remove no longer used "Bool ret;" declaration (fix compiler warning) --- hw/xfree86/drivers/modesetting/drm

Re: [PATCH xserver 2/2] modesetting: Only add main fb if necessary

6 at 05:04, Hans de Goede <hdego...@redhat.com> wrote: If we're doing reverse-prime; or doing rotation the main fb is not used, and there is no reason to add it in this case. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 34

Re: [PATCH xserver] randr: Do not check the screen size bound for gpu screens

Hi, On 20-05-16 07:00, Nikhil Mahale wrote: For gpu screen, CrtcSet set/adjust the master screen size along mode in following callstack - ProcRRSetCrtcConfig() | -> RRCrtcSet() | -> rrCheckPixmapBounding() | -> pScrPriv->rrScreenSetSize()

Re: [PATCH v6 09/11] modesetting: Blacklist UDL from PRIME sync

Hi, On 11-06-16 02:21, Alex Goins wrote: UDL (USB 2.0 DisplayLink DRM driver) has strange semantics when it comes to vblank events and damage tracking when page flipping. When doing a page flip, it will instantly raise a vblank event without waiting for vblank. However, it has no support for

Re: [PATCH xf86-input-libinput] Init touch x/y axis labels as MT axis labels

Hi, On 12-06-16 23:56, Peter Hutterer wrote: https://bugs.freedesktop.org/show_bug.cgi?id=96481 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/xf86libinput.c | 4 ++-- 1 fil

xserver patch which needs to be pushed

Hi, This patch has 2 Reviewed-by-s and 1 Tested-by and fixes a resource leak I'm hitting with udl testing, can someone please push this ? : https://patchwork.freedesktop.org/patch/85749/ Thanks & Regards, Hans ___ xorg-devel@lists.x.org: X.Org

xserver patches in need of review

Hi All, I've recently been working on testing / fixing switchable graphics support, and specifically the case of an external output which is only connected to the dgpu while the igpu is the master. This has resulted in the following patches which need someone to review them:

[PATCH xf86-video-nouveau] Properly cleanup fb for reverse-prime-offload

hed to the dgpu has been used once. Which causes burning through an additional 10W of power and the laptop to run quite hot. This commit adds the missing remove fb call, allowing the dgpu to runtime suspend after an external monitor has been plugged into the laptop. Signed-off-by: Hans de Go

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hi, On 26-05-16 12:04, Michel Dänzer wrote: From: Michel Dänzer Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy conditions from exaComposite which ensure that the composite operation doesn't access outside of the

[PATCH xserver 1/2] modesetting: Remove unnecessary fb addition from drmmode_xf86crtc_resize

drmmode_set_mode_major() is the only user of drmmode->fb_id and will create it if necessary. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/xfree8

[PATCH xserver 2/2] modesetting: Only add main fb if necessary

If we're doing reverse-prime; or doing rotation the main fb is not used, and there is no reason to add it in this case. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 34 1 file changed, 17 insertions(

[PATCH xserver] modesetting: Properly cleanup fb for reverse-prime-offload

kes drmmode_set_scanout_pixmap_gpu(NULL) match the behavior of drmmode_set_scanout_pixmap_cpu(NULL) which was already removing the fb. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hi, On 28-05-16 04:49, Michel Dänzer wrote: On 26.05.2016 21:55, Hans de Goede wrote: On 26-05-16 12:04, Michel Dänzer wrote: From: Michel Dänzer <michel.daen...@amd.com> Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy

[PATCH xserver v2] xrandrprovider: Do not use separate lists for unbound / source / offload slaves

suffice. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Change sin v2: -Do not call AttachUnboundGPU on SetOffloadSink/SetOutputSource(NULL) -Fix "associated providers" count when source_provider and sink_provider are the same -Fix assert(new->isGPU) triggering on

Re: [PATCH xserver] randr: Adjust master's last set time with slaves

ase and confuse xrandr client. Thanks, looks good to me now: Acked-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- randr/randr.c | 9 + 1 file changed, 9 insertions(+) diff --git a/randr/randr.c b/randr/randr.c index 3aabb19..549f26c 100644 --- a/randr/randr.c +++ b/rand

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hi, On 26-05-16 12:04, Michel Dänzer wrote: From: Michel Dänzer Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy conditions from exaComposite which ensure that the composite operation doesn't access outside of the

Re: [PATCH xserver] randr: Adjust master's last set time with slaves

Hi, On 20-05-16 07:01, Nikhil Mahale wrote: In prime configurations master's last set time may not be latest and greatest, adjust it with slaves last set time, pick up greatest one. Otherwise xserver may end with events which has lastSetTime < lastConfigTime even if that's not the case and

Re: [PATCH synaptics] conf: rename to 70-synaptics.conf

Hi, On 19-05-16 17:35, Stefan Dirsch wrote: Bump up synaptics driver to 70, so it get's perferred over libipnut, which was dropped down to 60. Reason is, that synaptics driver is more of an additional driver, which then should be installed if installed. Similar to what was done for wacom

Re: [PATCH xserver 1/3] glamor: Disable logic ops when doing compositing [v3]

in glamor_composite_set_shader_blend Signed-off-by: Keith Packard <kei...@keithp.com> I've given this series a quick test run on skylake integrated graphics with the modesetting driver. I've not noticed any regressions: Tested-by: Hans de Goede <hdego...@redhat.com> Note I've not actually tested if these

[PATCH xserver] xrandrprovider: Do not use separate lists for unbound / source / offload slaves

suffice. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- dix/dispatch.c | 30 +++ hw/xfree86/dri2/dri2.c | 7 +-- hw/xfree86/modes/xf86RandR12.c | 7 ++- include/scrnintstr.h | 15 +++--- present/pre

Re: [PATCH xserver v2] xwayland: Pretend we support viewport in vidmode

com> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- v2: Support only the default zoom and viewport. hw/xwayland/xwayland-vidmode.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/hw/xwayland/xwayland

Re: [PATCH xserver] xwayland: Pretend we support viewport in vidmode

Hi, On 18-03-16 11:53, Olivier Fourdan wrote: Some games (namely openttd) will raise an XError and fail with a BadValue if their request to XF86VidModeSetViewPort fails. Lie to them and pretend it works, so they live happily ever after. There are probably setting the viewport to 0x0, I

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 08-03-16 10:15, Pekka Paalanen wrote: On Mon, 7 Mar 2016 19:25:54 +0100 Hans de Goede <hdego...@redhat.com> wrote: Hi, On 07-03-16 19:23, Hans de Goede wrote: Hi, On 07-03-16 18:44, Olivier Fourdan wrote: Key repeat is handled by the X server, but for Wayland, the key press/r

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 07-03-16 19:23, Hans de Goede wrote: Hi, On 07-03-16 18:44, Olivier Fourdan wrote: Key repeat is handled by the X server, but for Wayland, the key press/release events need to be processed and forwarded by the Wayland compositor first. If the Wayland compositor get stuck for whatever

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 07-03-16 18:44, Olivier Fourdan wrote: Key repeat is handled by the X server, but for Wayland, the key press/release events need to be processed and forwarded by the Wayland compositor first. If the Wayland compositor get stuck for whatever reason and does not process the key release

[PATCH] glamor: Fix XvPutImage when src_y != 0

We already take src_y into account when uploading the src data by starting at the top line of the src data when uploading. Adjust src_y accordingly when rendering. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- glamor/glamor_xv.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Glamor bug in XVideo / XvPutImage when src_y != 0

Hi Eric, While working on getting tvtime to work on cards using the modesetting driver + glamor, I have hit what I believe is a bug in glamor's XVideo implementation. I've tried with the current xserver master and it seems the bug is still present there. The problem is that src_y seems to get

Re: [PATCH xf86-input-libinput] Add property/option for enabling/disabling tap-n-drag

Hi, On 27-01-16 02:20, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Patch looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- include/libinput-properties.h | 6 +++ man/libinput.man |

Re: [PATCH xfree86 v2] systemd-logind.c: don't parse VT settings for non-seat0 X servers

viewed-by: Hans de Goede <hdego...@redhat.com> Ajax, can you pick this new version up please? This time I've compile tested it on top of master. Thanks & Regards, Hans --- hw/xfree86/os-support/linux/systemd-logind.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH xfree86] systemd-logind.c: don't parse VT settings for non-seat0 X servers

Hi, On 02-12-15 16:53, Adam Jackson wrote: On Wed, 2015-12-02 at 12:33 +0100, Hans de Goede wrote: Hi, On 02-12-15 11:16, Laércio de Sousa wrote: Since non-seat0 X servers no longer touch VTs since release 1.16, I believe these settings are unnecessary. Signed-off-by: Laércio de Sousa

Re: [PATCH/WIP xf86-input-libinput 0/3] Add tablet support

Hi, On 02-12-15 03:29, Peter Hutterer wrote: This patchset adds tablet support to the xorg libinput driver. Note: this patchset requires the tablet-support branch of libinput, the current tree for this patchset is avaiable here:

Re: [PATCH xfree86] systemd-logind.c: don't parse VT settings for non-seat0 X servers

Hi, On 02-12-15 11:16, Laércio de Sousa wrote: Since non-seat0 X servers no longer touch VTs since release 1.16, I believe these settings are unnecessary. Signed-off-by: Laércio de Sousa <laercioso...@sme-mogidascruzes.sp.gov.br> You're right: Reviewed-by: Hans de Goede <hdego...@r

Re: [PATCH xserver] xfree86: fix minor memory leak

Hi, On 22-11-15 23:00, Peter Hutterer wrote: xf86*StrOption returns a strdup Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me, thanks for fixing the leak I think I introduced :) Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans ---

Re: [PATCH xf86-input-libinput] Replace the "fd" option when enabling dependent devices

. Not happy with this approach, but short of a big rewrite of the server's input APIs there isn't that much we can do. And no-one is keen to do that atm :) FWIW I cannot think of a better fix either. It took me a while to wrap my head around this patch, but after that I cannot find anythin

Re: [PATCH v2 xf86-input-libinput] Split mixed pointer/keyboard devices into two separate X devices

deletions(-) This version looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans diff --git a/src/xf86libinput.c b/src/xf86libinput.c index bc6e677..430fc9a 100644 --- a/src/xf86libinput.c +++ b/src/xf86libinput.c @@ -77,9 +77,17 @@ struct xf86libinput_driver {

Re: [PATCH xf86-input-libinput] Unref the libinput context on pre_init failure

ver cleaned up after ourselves. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/xf86libinput.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xf86libinput.c b/src/xf86l

Re: [PATCH v2 xf86-input-libinput 4/4] Split mixed pointer/keyboard devices into two separate X devices

Hi, Patches 1-3 look good to me and are: Reviewed-by: Hans de Goede <hdego...@redhat.com> I've a couple of comments on this one inline. On 17-11-15 09:36, Peter Hutterer wrote: The server struggles with devices that are both, the protocol (especially XI2) requires a fairly strict sepa

[PATCH v2 0/1] Xorg.wrap: activate libdrm based detection for KMS drivers

Hi Adam, Here is a cleaned up version of Arkadiusz' patch to fix the kms detection in the Xorg-wrapper which was causing the Xserver to always run as root as it was not detecting kms. Can you please merge this to both master and the 1.18 branch ? Thanks & Regards, Hans

[PATCH v2] Xorg.wrap: activate libdrm based detection for KMS drivers

ed-off-by: Arkadiusz Miśkiewicz <ar...@maven.pl> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Fix bugzilla reference in commit message -Add Michel Dänzer's Reviewed-by --- hw/xfree86/xorg-wrapper.c | 1 + 1 f

Re: [PATCH:xbacklight] Use current output configuration

Hi, On 04-11-15 18:03, Nils Schneider wrote: Do not trigger re-enumerating output devices when changing or querying the backlight. Re-enumerating output devices may stall Xorg at least on Intel GPUs when EDID is unresponsive or contains bogus data (due to retries). When working with the

Re: [PATCH xkbcomp] symbols: increase the warning level for shortening a key type

gt; Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- symbols.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/symbols.c b/symbols.c index d43ba9f..b5738c9 100644 --- a/symbols.c +++ b/symbols.c @@ -2030,7 +2030,7 @@ Copy

Re: [PATCH:xbacklight] Use double instead of int for value

Hi, On 28-09-15 15:20, Nils Schneider wrote: Modern displays allow for fine grained brightness settings. For example, my laptop allows for 852 brightness steps. In some situations I find it useful to set the brightness below 1 percent (the minimum possible when using integers). This patch

[PATCH v2] linux: Do not call FatalError from xf86CloseConsole

all logs warnings and continues. Add checking of the return value in xf86OpenConsole and call FatalError there when switch_to fails, to preserve the error-handling behavior of xf86OpenConsole. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1269210 Signed-off-by: Hans de Goede <hd

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 14:00, Samuel Thibault wrote: Mark Kettenis, le Mon 19 Oct 2015 12:26:27 +0200, a écrit : If you're doing this with certain platforms in mind, maybe we need to only not check for libdrm on those platforms ? Does it make sense at all to use the wrapper on platforms without

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

Hi, On 19-10-15 12:57, Julien Cristau wrote: On Mon, Oct 19, 2015 at 10:43:45 +0200, Hans de Goede wrote: Hi, On 18-10-15 19:26, Julien Cristau wrote: When the server is privileged, we shouldn't be passing the user's environment directly. Signed-off-by: Julien Cristau <jcris...@debian.

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 10:53, Samuel Thibault wrote: Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : @@ -237,6 +242,7 @@ int main(int argc, char *argv[]) close(fd); } } +#endif This turns needs_root_rights=auto into needs_root_rights=yes do we really want

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

Hi, On 18-10-15 19:26, Julien Cristau wrote: When the server is privileged, we shouldn't be passing the user's environment directly. Signed-off-by: Julien Cristau I've no real objections against this, and I can see this being a good thing from a security pov, but I'm

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 18-10-15 18:48, Samuel Thibault wrote: Signed-off-by: Samuel Thibault --- configure.ac | 2 -- hw/xfree86/xorg-wrapper.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 11:03, Samuel Thibault wrote: Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : In which case would you want to build without libdrm anyways ? Can you explain the use-case for this patch ? Systems with no drm support, simply :) Actually I do not think

Re: [PATCH xserver v2] xorg-wrapper: when starting the server as root, reset its environment

://bugs.freedesktop.org/show_bug.cgi?id=83849 Signed-off-by: Julien Cristau <jcris...@debian.org> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Adam, can you pick this one up please ? Regards, Hans v2: rename envp to empty_envp (Jeremy) --- hw/xfree86/xorg-wrapper.c | 6 +++

Re: [PATCH 1/2] hurd: disable detecting drm

Hi, On 19-10-15 14:47, Samuel Thibault wrote: Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> OK, re-checking the LIBDRM deps this should work, so this series is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Adam, can you pick these 2 up ? Re

Re: [PATCH] linux: Do not call FatalError from xf86CloseConsole

Hi, On 16-10-15 06:41, Peter Hutterer wrote: On Wed, Oct 14, 2015 at 04:03:54PM +0200, Hans de Goede wrote: FatalError ends up calling xf86CloseConsole itself, so calling FatalError from within xf86CloseConsole is not a good idea. All the other error checking done in xf86CloseConsole uses

[PATCH] linux: Do not call FatalError from xf86CloseConsole

xf86Msg rather then FatalError when called from xf86CloseConsole. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1269210 Signed-off-by: Hans de Goede <hdego...@redhat.com> --- hw/xfree86/os-support/linux/lnx_init.c | 24 1 file changed, 16 insertions(+), 8 del

Re: [PATCH] xf86: don't add gpus from udev if autoAddGPU is set

seems the right place to it: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- hw/xfree86/common/xf86platformBus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/common/xf86platformBus.c b/hw/xfree86/common/xf86platformBus.c index f1e9423..96895a6 100

Re: [PATCH xf86-input-libinput] Add property support for the accel profiles

Hi, On 10-09-15 19:28, Peter Hutterer wrote: Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- include/libinput-properties.h | 12 man/libinput.man | 9 +++ src/xf

Re: [PATCH] [RFC] xf86: add glamor preferred probing

Hi Dave, On 02-09-15 06:57, Dave Airlie wrote: From: Dave Airlie This patch adds an interface to query and ask DDX if they would prefer to use modesetting/glamor for a particular hw configuration, and if so to fail probing on that hw, so that modesetting gets picked up.

Re: [PATCH] [RFC] xf86: add glamor preferred probing

Hi, On 02-09-15 11:13, Dave Airlie wrote: On 2 September 2015 at 18:37, Hans de Goede <hdego...@redhat.com> wrote: Hi Dave, On 02-09-15 06:57, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> This patch adds an interface to query and ask DDX if they would prefer to use

Re: [PATCH xf86-input-libinput 1/2] Revamp server fd opening

we'll can use for xf86OpenSerial(). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Good idea, and this results in a nice cleanup, series is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/xf86libinput.c | 127

Re: [PATCH xf86-input-libinput 1/2] Add drag lock support

good and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- Makefile.am | 2 +- configure.ac | 1 + include/libinput-properties.h | 6 + man/libinput.man | 46 +++- src/Makefile.am | 4 +- src

Re: [PATCH xf86-input-libinput 2/2] Add an option to disable horizontal scrolling

...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- include/libinput-properties.h | 4 +++ man/libinput.man | 10 src/xf86libinput.c| 60 ++- 3 files changed, 73 insertions(+), 1

Re: Xorg hangs use 99% of CPU on systemd reboot

Hi, On Thu, Jul 02, 2015 at 04:26:19PM +0100, Barry Scott wrote: The attached patch works around an issue we hit after we ported from Fedora 20 to Fedora 21. When systemd reboot starts something happens to dbus that causes Xorg to loop hard using 99% CPU in WaitForSomething. The reason for

Re: [PATCH xf86-input-libinput] Add a property for tap drag lock

Hi, On 08-07-15 03:04, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- configure.ac | 2 +- include/libinput-properties.h | 6 +++ man/libinput.man

Re: Using prime with udl leaks a ref, making it impossible to unload the udl kmod

Hi, On 03-07-15 20:56, Hans de Goede wrote: Hi Dave, I've been working on a kms driver for a mini projector which uses usb for its video transport. During the development of this I've hit this problem where once used from within Xorg to extend my regular gnome-desktop, the module keeps

[PATCH] glamor_egl: Properly free resources on init-error and exit

, call eglTerminate() from the new glamor_egl_cleanup() to fix this. Signed-off-by: Hans de Goede hdego...@redhat.com --- glamor/glamor_egl.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c

Using prime with udl leaks a ref, making it impossible to unload the udl kmod

Hi Dave, I've been working on a kms driver for a mini projector which uses usb for its video transport. During the development of this I've hit this problem where once used from within Xorg to extend my regular gnome-desktop, the module keeps a refcount of 1 after unplugging the projector, so I

[git pull] Fix systemd integration when starting X on a new VT + 2 more fixes

) David Herrmann (1): systemd-logind: do not rely on directed signals Hans de Goede (4): linux: Add linux_parse_vt_settings and linux_get_keeptty helpers linux: Add a may_fail paramter to linux_parse_vt_settings systemd-logind: Only use

[PATCH] Xorg.wrap.man: Fix spelling mistake in Xorg.wrap.1

This commit fixes a small mistake in Xorg.wrap.1 . Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/man/Xorg.wrap.man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/man/Xorg.wrap.man b/hw/xfree86/man/Xorg.wrap.man index 11090f1..f3f30a6 100644

Re: [git pull] Fix systemd integration when starting X on a new VT

Hi Keith, What is the status of this? I thought that after my answers to your questions this set is good to go, but I do not see it upstream yet... ? Regards, Hans ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] systemd-logind: do not rely on directed signals

. Therefore, dbus-daemon bypasses the broadcast matches. However, this is not ABI and Xorg should not rely on this. systemd-logind is free to send those signals as broadcasts, in which case Xorg will freeze the VT. Fix this by always installing those matches. Cc: Hans de Goede hdego...@redhat.com Cc

Re: [PATCH synaptics] Drop touch events from the driver

the touchpad speed whenever a monitor is added/removed in. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/synaptics.c | 113 +--- 1 file changed

Re: [git pull]

Hi, I should have put something more helpful in the subject, sorry about that. Regards, Hams On 03-06-15 11:45, Hans de Goede wrote: Hi Keith, Please pull from my git tree for a bugfix patch-set fixing some issues with the systemd integration when starting X on a new VT The following

[git pull]

) Hans de Goede (3): linux: Add linux_parse_vt_settings and linux_get_keeptty helpers linux: Add a may_fail paramter to linux_parse_vt_settings systemd-logind: Only use systemd-logind integration together with keeptty hw

Re: [git pull] Fix systemd integration when starting X on a new VT

Hi, On 03-06-15 16:02, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: linux: Add linux_parse_vt_settings and linux_get_keeptty helpers linux: Add a may_fail paramter to linux_parse_vt_settings systemd-logind: Only use systemd-logind integration together

Re: [PATCH xf86-input-libinput] Only init abs axes if we don't have acceleration

/show_bug.cgi?id=90322 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Not optimal, but I think this should work fine: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- Long term we need to look at splitting a second xorg device out if we get events from an interface that we

[PATCH v3 3/3] systemd-logind: Only use systemd-logind integration together with keeptty

, requiring ssh access to the system to kill X. The fix for this is easy, we must not use systemd-logind integration when not using KeepTty, or iow we may only use systemd-logind integration together with KeepTty. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte

[PATCH v3 2/3] linux: Add a may_fail paramter to linux_parse_vt_settings

working when e.g. no /dev/tty0 is present in such a setup. This commit adds a may_fail parameter to linux_parse_vt_settings() which can be used to make linux_parse_vt_settings() fail silenty with an error return in this case, rather then calling FatalError(). Signed-off-by: Hans de Goede hdego

[PATCH v3 1/3] linux: Add linux_parse_vt_settings and linux_get_keeptty helpers

no side effects other than setting xf86Info.vtno and keepTty. Note this basically only moves a large chunk of xf86OpenConsole() into linux_parse_vt_settings() without changing a single line of it, this is hard to see in the diff because the identation level has changed. Signed-off-by: Hans de Goede

Re: [PATCH libX11] Fix three use of uninitialized variable coverity warnings

Hi, On 19-05-15 04:42, Peter Hutterer wrote: False positive, if rlen/nbytes are unset we quit early before using it. Still, initialize it so we don't have to deal with these warnings again. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego

Re: [PATCH libX11 1/2] Fix potential memory leak

de Goede hdego...@redhat.com Regards, Hans --- modules/im/ximcp/imLcPrs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/im/ximcp/imLcPrs.c b/modules/im/ximcp/imLcPrs.c index 9bb45ff..4979975 100644 --- a/modules/im/ximcp/imLcPrs.c +++ b/modules/im/ximcp

Re: [PATCH v2 2/2] systemd-logind: Only use systemd-logind integration together with keeptty

Hi, On 15-05-15 22:21, Aaron Plattner wrote: On 04/30/2015 05:24 AM, Hans de Goede wrote: systemd-logind integration does not work when starting X on a new tty, as that detaches X from the current session and after hat systemd-logind revokes all rights any already open fds and refuses to open

Re: [PATCH xauth] usage(): Print summary for the -n option

Hi, On 14-05-15 03:14, Alan Coopersmith wrote: Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Thanks, pushed. Regards, Hans ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH v2 1/3] dix: Add unaccelerated valuators to the ValuatorMask

just drop the bits we know we don't want. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire set LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- Changes to v1: - fix typo - add valuator_mask_drop_unaccelerated() as a shortcut for the server. we re

<    1   2   3   4   5   6   7   8   9   >