Re: [PATCH libXxf86misc] Add missing UnlockDisplay() and SyncHandle() to some error paths.

2011-09-07 Thread Matt Turner
, but it was missing from others. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:libXaw3d 2/2] Update README.XAW3D for X.Org release

2011-09-07 Thread Matt Turner
-by: Alan Coopersmith alan.coopersm...@oracle.com Both patches are Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH:libXaw3d 1/2] Add LayYY.h header for common definitions of lex/yacc created functions

2011-09-07 Thread Matt Turner
declaration: LayYYlex laygram.c, line 1777: warning: implicit function declaration: LayYYerror Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Both patches are Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 1/2 xf86-video-impact] Cacheflush-enhancement,...

2011-09-06 Thread Matt Turner
On Tue, Sep 6, 2011 at 4:45 PM, peter fuerst p...@pfrst.de wrote: This patch provides some enhancements for XImpact: Wow, I had no idea that you (or anyone at all) was working on -impact. If you don't have commit access, I'll commit the patches if no one complains. You mention a kernel driver,

Re: [PATCH libXaw3d] Template.c: use #include X11/Xaw3d/TemplateP.h

2011-09-02 Thread Matt Turner
XtResource resources[] = {  #define offset(field) XtOffsetOf(TemplateRec, template.field) -- 1.7.4.1 Acked-by: Matt Turner matts...@gmail.com Looks like the last of these. git grep 'P.h' ___ xorg-devel@lists.x.org: X.Org development Archives: http

[PULL] bswap cleanup and misc patches

2011-09-02 Thread Matt Turner
commit 0caeef6146bee5fb1827ab25db191685dde9d4b4: Version bumped to 1.11 (2011-08-26 16:46:13 -0700) are available in the git repository at: git://people.freedesktop.org/~mattst88/xserver for-keith Matt Turner (12): Use abs() on integers, not fabs() Remove unnecessary #undefs of [f

Re: [PATCH libXaw3d 0/5] Fix old-style function definitions, round three

2011-09-01 Thread Matt Turner
++  7 files changed, 194 insertions(+), 303 deletions(-) -- 1.7.5.1 Acked-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PULL libXaw3d] Various patches

2011-08-25 Thread Matt Turner
On Thu, Aug 25, 2011 at 1:18 AM, Yaakov (Cygwin/X) yselkow...@users.sourceforge.net wrote: From: Yaakov Selkowitz yselkow...@users.sourceforge.net Great! Thank you! I pulled this and pushed it to ~mattst88/libXaw3d. Hopefully someone will notice that bug report soon so other people can have

Re: [PULL libXaw3d] Various patches

2011-08-25 Thread Matt Turner
On Thu, Aug 25, 2011 at 4:48 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 08/25/11 10:11, Yaakov (Cygwin/X) wrote: I understand, but libXaw3d (not libXaw) is being hosted by Matt Turner until xorg/lib/libXaw3d is created (fd.o bug 40112).  Matt invited others to push

Re: [PATCH 2/8] Use correct swap{l,s} (or none at all for CARD8)

2011-08-17 Thread Matt Turner
On Wed, Aug 17, 2011 at 10:25 AM, Peter Harris phar...@opentext.com wrote: On 2011-08-16 22:58, Matt Turner wrote: Swapping the wrong size was never caught because swap{l,s} are macros. --- a/xkb/xkb.c +++ b/xkb/xkb.c @@ -6190,7 +6190,6 @@ char *                  str;       swaps

[PATCH 3/8] Cast char* buffers to swap functions

2011-08-16 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- dix/swaprep.c |4 ++-- render/render.c |6 +++--- xkb/xkb.c | 12 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/dix/swaprep.c b/dix/swaprep.c index a02333d..28c354c 100644 --- a/dix/swaprep.c +++ b

[PATCH 4/8] Introduce swap_uint{16,32} functions, used in swap{l,s}

2011-08-16 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/include/misc.h b/include/misc.h index d991c0a..6034c72 100644 --- a/include/misc.h +++ b/include/misc.h @@ -259,20 +259,30

[PATCH 2/8] Use correct swap{l,s} (or none at all for CARD8)

2011-08-16 Thread Matt Turner
Swapping the wrong size was never caught because swap{l,s} are macros. It's clear in the case of Xext/xres.c, that the author believed client_major/minor to be CARD16 from looking at the code in the first hunk. Signed-off-by: Matt Turner matts...@gmail.com --- Xext/saver.c

[PATCH 5/8] Add type checking to swap macros

2011-08-16 Thread Matt Turner
The original macros are retained (instead of replacing them with inline functions) because of implicit type promotion. That is, an int16 passed to an inline function taking int32 would be implicitly promoted to int32 without a warning. Signed-off-by: Matt Turner matts...@gmail.com --- include

[PATCH 6/8] Make lswap{l,s} inline functions

2011-08-16 Thread Matt Turner
text databss dec hex filename before: 1875668 52136 78040 2005844 1e9b54 hw/xfree86/Xorg after: 1875588 52136 78040 2005764 1e9b04 hw/xfree86/Xorg Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h | 20 +--- 1 files changed

[PATCH 7/8] Use lswap{l,s} in cpswap{l,s}

2011-08-16 Thread Matt Turner
instructions: 811 - 943 (used in lswaps) Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/misc.h b/include/misc.h index 46b83ef..cfe734f 100644 --- a/include/misc.h +++ b/include/misc.h

[PATCH 8/8] Use __builtin_constant_p to determine if we can use lswapl

2011-08-16 Thread Matt Turner
1994572 1e6f4c hw/xfree86/Xorg bswap instructions: 131 - 308 (used in lswapl) rol instructions: 943 - 1174 (used in lswaps) Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/misc.h b

bswap-cleanup v2

2011-08-16 Thread Matt Turner
Hi Preceding this is version 2 of my bswap clean-up patches. They're split into the very small, easily reviewable (and bisectable) patches. As before, they're available in my git repo: http://cgit.freedesktop.org/~mattst88/xserver/log/?h=bswap-cleanup2 The first patch wasn't sent to the list

Re: [PATCH 1/5] Use internal temp variable for swap macros

2011-08-15 Thread Matt Turner
On Thu, Aug 4, 2011 at 6:11 PM, Matt Turner matts...@gmail.com wrote: This patch was way too big to make it to the mailing list, so you can see it here http://cgit.freedesktop.org/~mattst88/xserver/commit/?h=bswap-cleanupid=039d90b2a6a68496ef63f4b7e557c41b3bc82379 I used Coccinelle

Re: libXaw3d hosting on freedesktop

2011-08-15 Thread Matt Turner
On Mon, Aug 1, 2011 at 2:13 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 07/30/11 18:00, Matt Turner wrote: Xaw3d apparently has no upstream, anywhere. It's unfortunately still used by a couple of applications. I guess it'd be nice to get it moved to xorg/lib/libXaw3d at some

Re: [PATCH glint v2] Make pm2's xv driver collect options like all other drivers.

2011-08-13 Thread Matt Turner
On Mon, Feb 28, 2011 at 7:08 PM, Matt Turner matts...@gmail.com wrote: On Sat, Dec 11, 2010 at 4:38 AM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports had

Re: [PATCH] [glint] Fix uploading YV12 data to texture buffer on BE machines

2011-08-13 Thread Matt Turner
On Fri, Mar 11, 2011 at 10:51 PM, Matt Turner matts...@gmail.com wrote: On Mon, Feb 28, 2011 at 11:32 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: On BE machines various hardware byteswapping options are used for the framebuffer aperture.  Which option gets used depends on the depth

Re: [PATCH 1/2] Properly register session with utmp

2011-08-10 Thread Matt Turner
On Tue, Aug 9, 2011 at 1:34 PM, Matěj Cepl mc...@redhat.com wrote: Fixing https://bugzilla.redhat.com/177890 Patch by Wilfried Teiken (wteikens at @teiken dot org) Why isn't this sent with the author set as Wilfried Teiken (wteikens at @teiken dot org)?

Re: [PATCH 1/2] Properly register session with utmp

2011-08-10 Thread Matt Turner
On Wed, Aug 10, 2011 at 2:16 PM, Matěj Cepl mc...@redhat.com wrote: On 10.8.2011 16:14, Matt Turner wrote: On Tue, Aug 9, 2011 at 1:34 PM, Matěj Ceplmc...@redhat.com  wrote: Fixing https://bugzilla.redhat.com/177890 Patch by Wilfried Teiken (wteikens at @teiken dot org) Why isn't this sent

Re: [PATCH libXaw3d] Add .gitignore to filter out all the compile artifacts

2011-08-05 Thread Matt Turner
+*.tar.bz2 +*.tar.gz +# +#              Add Override patterns for libXaw +# +#              Edit the following section as needed +# For example, !report.pc overrides *.pc. See 'man gitignore' +# -- 1.7.4.1 Ah, didn't see this before. Acked-by: Matt Turner matts...@gmail.com Please commit

[PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-04 Thread Matt Turner
Swapping the wrong size was never caught because swap{l,s} are macros. It's clear in the case of Xext/xres.c, that the author believed client_major/minor to be CARD16 from looking at the code in the first hunk. Signed-off-by: Matt Turner matts...@gmail.com --- Xext/saver.c

[PATCH 3/5] Add type checking to swap macros

2011-08-04 Thread Matt Turner
In a few cases, char* are passed to the swap macros, so cast them. Signed-off-by: Matt Turner matts...@gmail.com --- dix/swaprep.c |4 ++-- include/misc.h | 14 +++--- render/render.c |6 +++--- xkb/xkb.c | 12 ++-- 4 files changed, 22 insertions(+), 14

[PATCH 4/5] Use lswapl() in cpswapl macro

2011-08-04 Thread Matt Turner
it actually increases the code size. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/include/misc.h b/include/misc.h index ebfbc1a..d2b5e11 100644 --- a/include/misc.h +++ b/include

[PATCH 5/5] Make swapl and swaps macros readable

2011-08-04 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h | 38 +- 1 files changed, 21 insertions(+), 17 deletions(-) diff --git a/include/misc.h b/include/misc.h index d2b5e11..6eeacda 100644 --- a/include/misc.h +++ b/include/misc.h @@ -261,25

Re: [PATCH 1/5] Use internal temp variable for swap macros

2011-08-04 Thread Matt Turner
This patch was way too big to make it to the mailing list, so you can see it here http://cgit.freedesktop.org/~mattst88/xserver/commit/?h=bswap-cleanupid=039d90b2a6a68496ef63f4b7e557c41b3bc82379 I used Coccinelle and a simple semantic patch to remove the second argument from swap[ls]: --- @@

Re: libXaw3d hosting on freedesktop

2011-08-03 Thread Matt Turner
On Tue, Aug 2, 2011 at 5:42 PM, Gaetan Nadon mems...@videotron.ca wrote: On Tue, 2011-08-02 at 01:01 -0400, Matt Turner wrote: Rebased everything on 1.5E and rewrote the autotools files to more closely match libXaw. I've never done this before so I'm sure there are errors, but the autotools

Re: libXaw3d hosting on freedesktop

2011-08-01 Thread Matt Turner
On Mon, Aug 1, 2011 at 2:13 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 07/30/11 18:00, Matt Turner wrote: Xaw3d apparently has no upstream, anywhere. It's unfortunately still used by a couple of applications. I guess it'd be nice to get it moved to xorg/lib/libXaw3d at some

Re: libXaw3d hosting on freedesktop

2011-08-01 Thread Matt Turner
On Mon, Aug 1, 2011 at 2:43 PM, Matt Turner matts...@gmail.com wrote: On Mon, Aug 1, 2011 at 2:13 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 07/30/11 18:00, Matt Turner wrote: Xaw3d apparently has no upstream, anywhere. It's unfortunately still used by a couple of applications

libXaw3d hosting on freedesktop

2011-07-30 Thread Matt Turner
Xaw3d apparently has no upstream, anywhere. It's unfortunately still used by a couple of applications. I've created a git repo at http://cgit.freedesktop.org/~mattst88/libXaw3d/ It contains a basic autotools system provided by participants of https://bugs.gentoo.org/show_bug.cgi?id=290410

Re: xf86XVCopyPacked() and friends : why so slow ?

2011-07-21 Thread Matt Turner
On Thu, Feb 4, 2010 at 7:45 PM, ri...@happyleptic.org wrote: When playing some video with mplayer I noticed with oprofile that half the time is spent in xf86XVCopyPacked() or xf86XVCopyYUV12ToPacked(). Looking at the former, I wonder why a mere memcpy was not used instead of manually copying

Re: [PATCH mach64] mach64: add a DRI option

2011-07-15 Thread Matt Turner
On Fri, Jul 15, 2011 at 7:52 AM, Mika Blanc mika.bl...@gmail.com wrote: This patch adds a boolean DRI option to the mach64 driver. Direct rendering can be either enabled (default) or disabled with this option. Signed-off-by: Mika Blanc mika.bl...@gmail.com ---  src/aticonfig.c |   10

Re: [PATCH 4/6] drm/radeon: Add a rmb() in IH processing

2011-07-14 Thread Matt Turner
On Wed, Jul 13, 2011 at 6:28 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: We should have a read memory barrier between reading the WPTR from memory and reading ring entries based on that value (ie, we need to ensure both loads are done in order by the CPU). It could be argued

Re: Qery on Xlib project idea on summer of code page

2011-06-14 Thread Matt Turner
On Tue, Jun 14, 2011 at 2:17 PM, Daniel Stone dan...@fooishbar.org wrote: Hi, On Tue, Jun 14, 2011 at 10:22:43PM +0530, nijil yes wrote: I am interested in working on the idea mentioned on summer of code page on replacing CMS code inside libX11 with libXcm.I would be glad to get a few more

Re: [PATCH 2/4] x86emu: Silence compiler warnings.

2011-06-05 Thread Matt Turner
On Sun, Jun 5, 2011 at 1:58 PM, Cyril Brulebois k...@debian.org wrote: Both if/else match, so usage of ip32 or ip16 will only happen after the proper one has been initialized. As a consequence, let's silence those warnings by initializing both variables to 0: |   CC     ops.lo | ops.c: In

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-06-03 Thread Matt Turner
On Fri, Jun 3, 2011 at 11:10 AM, Cyril Brulebois k...@debian.org wrote: Julien Cristau jcris...@debian.org (28/02/2011): On Mon, Feb 28, 2011 at 02:15:39 +, Matt Turner wrote: Since newport doesn't even compile anymore (since the RAC removal), this probably isn't helpful at all

Re: [PATCH 02/27] Input: Add round_towards_zero helper

2011-06-03 Thread Matt Turner
On Fri, Jun 3, 2011 at 10:59 AM, Daniel Stone dan...@fooishbar.org wrote: lrint() exists to round _away_ from zero, but there's no equivalent for rounding towards zero, aside from tediously calling fesetenv(), which isn't hugely portable anyway, then lround().  Great. Signed-off-by: Daniel

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-05-13 Thread Matt Turner
On Fri, May 13, 2011 at 4:43 PM, Keith Packard kei...@keithp.com wrote: On Fri, 29 Apr 2011 14:46:23 +0300, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: And of course, if none of the swapl/swaps/cpswapl/cpswaps are supposed to deal with unaligned pointers, then this is not an issue

Re: [PATCH 3/6] Use abs() on integers, not fabs()

2011-04-28 Thread Matt Turner
2011/4/28 Michel Dänzer mic...@daenzer.net: On Mit, 2011-04-27 at 19:33 -0400, Matt Turner wrote: Signed-off-by: Matt Turner matts...@gmail.com ---  hw/xfree86/modes/xf86Crtc.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-28 Thread Matt Turner
On Thu, Apr 28, 2011 at 4:36 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Thu, Apr 28, 2011 at 2:33 AM, Matt Turner matts...@gmail.com wrote: diff --git a/include/misc.h b/include/misc.h index 803f5ba..b7a3fd2 100644 --- a/include/misc.h +++ b/include/misc.h @@ -240,32 +240,17

[PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Matt Turner
Either way, it doesn't matter much. Signed-off-by: Matt Turner matts...@gmail.com --- The follow-up patch to this which removes the temporary variables used by the swap macros is too big for the mailing list, so please review it here: http://cgit.freedesktop.org/~mattst88/xserver/commit/?id

[PATCH 3/6] Use abs() on integers, not fabs()

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/modes/xf86Crtc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index c2814d4..92c75b1 100644 --- a/hw/xfree86/modes/xf86Crtc.c +++ b/hw/xfree86

[PATCH 4/6] Remove unnecessary #undefs of [f]abs and old comments

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- glx/glxserver.h |6 -- hw/dmx/glxProxy/glxserver.h |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/glx/glxserver.h b/glx/glxserver.h index 891315b..6bcf7d3 100644 --- a/glx/glxserver.h +++ b/glx

[PATCH 5/6] Replace Fabs() macro with fabs() function

2011-04-27 Thread Matt Turner
gcc generates better code with fabs() anyway. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h |3 --- mi/miarc.c |2 +- mi/mifpoly.h|6 +++--- mi/miwideline.c |2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/include/misc.h b/include

[PATCH 6/6] Silence printf format warnings in helper_exec.c

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/int10/helper_exec.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exec.c index ec84200..8cca28a 100644 --- a/hw/xfree86

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Matt Turner
On Thu, Apr 28, 2011 at 12:44 AM, Keith Packard kei...@keithp.com wrote: On Wed, 27 Apr 2011 19:33:01 -0400, Matt Turner matts...@gmail.com wrote: The follow-up patch to this which removes the temporary variables used by the swap macros is too big for the mailing list, so please review it here

Re: [PATCH] Fix __STDC_VERSION__ tests.

2011-04-20 Thread Matt Turner
On Wed, Apr 20, 2011 at 5:02 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Sun, Mar 13, 2011 at 10:11 PM, Christian Weisgerber na...@mips.inka.de wrote: GTK+3 blows up on LP64 archs with strict alignment.  This comes down to an unaligned access error in libXi, specifically in the XIButtonClass case in copy_classes() in XExtInt.c.    cls_lib-num_buttons =

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-25 Thread Matt Turner
On Thu, Mar 24, 2011 at 10:44 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 2:17 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:19 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 1:13 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Wed, Mar 23, 2011 at 8:29 PM, Matt Turner matts...@gmail.com wrote: Fixes: http://bugs.gentoo.org/show_bug.cgi?id=360227 Problem is easily seen during compile:        -DDFLT_XKB_CONFIG_ROOT='/usr/share/X11/xkb

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 1:20 PM, Gaetan Nadon mems...@videotron.ca wrote: This is what I get on Ubuntu before the patch:     -DDFLT_XKB_CONFIG_ROOT=\/home/nadon/xorg/src/share/X11/xkb\ Is this a platform difference? I kind of think so. With the patch I get:

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 10:14 AM, Daniel Stone dan...@fooishbar.org wrote: On Thu, Mar 24, 2011 at 09:20:39AM -0400, Gaetan Nadon wrote: On Wed, 2011-03-23 at 23:29 -0400, Matt Turner wrote: Fixes: http

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 7:19 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 10:14 AM, Daniel Stone dan...@fooishbar.org wrote: On Thu, Mar 24, 2011 at 09:20:39AM -0400, Gaetan Nadon wrote: On Wed, 2011

Re: [PATCH] dix: Small refactor to resource deletion

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 8:52 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com --- Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

[PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-23 Thread Matt Turner
Fixes: http://bugs.gentoo.org/show_bug.cgi?id=360227 Problem is easily seen during compile: -DDFLT_XKB_CONFIG_ROOT='/usr/share/X11/xkb' --- src/xkbcomp/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xkbcomp/Makefile.am b/src/xkbcomp/Makefile.am

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-23 Thread Matt Turner
On Thu, Mar 24, 2011 at 3:29 AM, Matt Turner matts...@gmail.com wrote: This is for libxkbcommon, meant to modify the subject line. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH] [glint] Fix uploading YV12 data to texture buffer on BE machines

2011-03-11 Thread Matt Turner
On Mon, Feb 28, 2011 at 11:32 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: On BE machines various hardware byteswapping options are used for the framebuffer aperture.  Which option gets used depends on the depth of the framebuffer.  Uploading YV12 data to the texture buffer is done through

Re: [PATCH:libXt 1/2] Incorrect cast in XtCvtIntToPixmap could cause bus error on 64-bit machines

2011-03-04 Thread Matt Turner
no extra arguments,                    (String *) NULL, (Cardinal *)NULL); -    done(Pixmap, *(Pixmap*)fromVal-addr); +    done(Pixmap, *(int*)fromVal-addr);  }  #ifdef MOTIFBC -- 1.7.3.2 Makes sense to me, and will be good for alpha too. Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH:xman] Remove xmu dependency by inlining AssignMax macro

2011-03-04 Thread Matt Turner
a good idea? Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2011-02-28 Thread Matt Turner
On Sat, Dec 11, 2010 at 10:24 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Sat, 11 Dec 2010 22:52:25 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl From: Alan Hourihane al...@fairlite.co.uk Date: Thu, 09 Dec 2010 13:00:54 + On Thu, 2010-12-09 at 13:41 +0100, Mark

Re: [PATCH glint v2] Make pm2's xv driver collect options like all other drivers.

2011-02-28 Thread Matt Turner
On Sat, Dec 11, 2010 at 4:38 AM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports had to be named 'Input' for input options, and 'Output' for output options. This

Re: [PATCH 01/32] [libx11] Using freed pointer e

2011-02-12 Thread Matt Turner
On Sat, Feb 12, 2011 at 11:00 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= erkki.sepp...@vincit.fi Date: Thu, 27 Jan 2011 09:53:44 +0200 Reordered code to first to do the comparison and then to release data Your static analysis tool isn't all

Re: [PATCH 05/32] [libx11] Pointer pBuf returned from fgets(buf, 256, stream) is never used

2011-01-27 Thread Matt Turner
2011/1/27 Erkki Seppälä erkki.sepp...@vincit.fi: Removed unused assignment Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi ---  src/xcms/cmsColNm.c |    2 +-  1 files changed, 1 insertions(+), 1

Re: [PATCH 0/8] More warning fixes and build cleanups

2011-01-23 Thread Matt Turner
On Mon, Jan 24, 2011 at 4:18 AM, Adam Jackson a...@redhat.com wrote: What it says on the box. - ajax For the series: Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: where is KMS API docs?

2010-12-14 Thread Matt Turner
On Tue, Dec 14, 2010 at 2:59 PM, Jeremy C. Reed r...@reedmedia.net wrote: Where is the documentation for the KMS API? Any man pages? If not written, please point me to any specifications or source used for learning the API. Thanks My summer of code project's purpose was to create

Re: [PULL] Warning fixes, *LookupID* riddance, logic fix.

2010-12-10 Thread Matt Turner
On Tue, Dec 7, 2010 at 6:13 PM, Cyril Brulebois k...@debian.org wrote: The following changes since commit 780754050bc9cb1489f92a2a890ab5665e3e6358:  Fix GLX_LIBS vs. DMX_LIBS order. (2010-12-07 09:24:16 -0800) are available in the git repository at:  

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-07 Thread Matt Turner
On Tue, Dec 7, 2010 at 8:07 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: No need for byteswapping in YV12 decoding on BE machines The hardware seems to do the proper thing already, so always use the same code on both little-endian and big-endian machines.  Fixes xv YV12 on a TechSource

Re: [PATCH:xorg-macros] Use AC_LANG_PROGRAM in XORG_CHECK_MALLOC_ZERO to clear autoconf-2.68 warnings

2010-12-05 Thread Matt Turner
) was leaking, but now I see that it is realloc()'d to 0. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-04 Thread Matt Turner
On Sat, Dec 4, 2010 at 2:18 AM, Jesse Adkins jesserayadk...@gmail.com wrote: I should have been more clear. I really was wondering why there's a vbeInit right before a vbeFree. It seems like that would end up being a rather long no-op. It looks like the vbe pointer is never used by the

Re: [PATCH] Make pm2's xv driver collect options like all other drivers.

2010-12-04 Thread Matt Turner
On Fri, Nov 12, 2010 at 3:48 AM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports had to be named 'Input' for input options, and 'Output' for output options. This

Re: [PATCH 4/7] Convert hw/xfree86/parser code to use asprintf() calls

2010-12-04 Thread Matt Turner
:                                s = strdup(x); -- 1.7.3.2 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xrdb] predefined cpp macros can produce unexpected results (bug 3413)

2010-12-03 Thread Matt Turner
From: Matthieu Herrb matthieu.he...@laas.fr GNU cpp is predefining a number of symbols, depending on the host and target architecture. This can produce some unexpected results: for example, the expansion of CLIENTHOST if the host name is i386.my.domain. The attached patch creates a new -undef

[PATCH gccmakedep] Fix gccmakedep from mutilates arguments containing ' or *

2010-12-03 Thread Matt Turner
From: Peter Breitenlohner p...@mppmu.mpg.de Fixes https://bugs.freedesktop.org/show_bug.cgi?id=7414 --- gccmdep.cpp | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gccmdep.cpp b/gccmdep.cpp index ff4b12a..6c7c05f 100644 --- a/gccmdep.cpp +++ b/gccmdep.cpp @@

[PATCH iceauth] Make iceauth manpage describe commands. (fd.o bug#2354)

2010-12-03 Thread Matt Turner
From: David Nusinow dnusi...@debian.org --- iceauth.man | 84 +++ 1 files changed, 84 insertions(+), 0 deletions(-) diff --git a/iceauth.man b/iceauth.man index 72b2ab0..a3eed7e 100644 --- a/iceauth.man +++ b/iceauth.man @@ -36,5 +36,89

[PATCH trident] trident cyberblade FIFO status check (bug 3304)

2010-12-03 Thread Matt Turner
From: Laurence Darby lda...@tuffmail.com --- I verified that it compiled, but I don't have hardware to test. src/blade_accel.c | 27 ++- 1 files changed, 26 insertions(+), 1 deletions(-) diff --git a/src/blade_accel.c b/src/blade_accel.c index 31d97df..6a624b9 100644

[PATCH libX11] Fix XQueryColors() doesn't return if ncolors is 65536.

2010-12-03 Thread Matt Turner
From: Kusanagi Kouichi sl...@ma.neweb.ne.jp Fixes bugs: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=278984 https://bugs.freedesktop.org/show_bug.cgi?id=9160 --- The patch looks like it only makes the whitespace mess worse, so if this gets committed, we should fix the

[PATCH libXaw] fix potential infinte loop in XawBoxQueryGeometry() (bug 11569)

2010-12-03 Thread Matt Turner
From: Glenn Burkhardt gbburkha...@verizon.net Originally sent to xorg@ back in July 2007. http://lists.x.org/archives/xorg/2007-July/025997.html --- Please don't ignore it this time. src/Box.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Box.c b/src/Box.c

[PATCH libXfont] Fix Font lookup by fontfile is slow on certain patterns.

2010-12-03 Thread Matt Turner
From: Takano Akio al...@hyper.cx https://bugs.freedesktop.org/show_bug.cgi?id=7832 --- src/fontfile/fontdir.c | 67 +--- 1 files changed, 18 insertions(+), 49 deletions(-) diff --git a/src/fontfile/fontdir.c b/src/fontfile/fontdir.c index

[PATCH] Add component= to bugzilla link for DDXs' README

2010-12-03 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- After triaging bugs for a few days, the main thing I've learned is that people cannot figure out where to file a bug if their lives depended on it. Not that anyone actually reads the README, but does anyone have any objections to adding component

Re: [PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-03 Thread Matt Turner
On Sat, Dec 4, 2010 at 6:53 AM, Jesse Adkins jesserayadk...@gmail.com wrote: Perhaps a dumb question, but why is there a vbeFree after a vbeInit? To free memory allocated by vbeInit. If your question is why is vbeInit called if it doesn't then call vbeDoEDID()... well, that I don't know. Matt

[PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-02 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- Why are we doing VBEInit if we're not subsequently calling vbeDoEDID? src/s3.h|1 - src/s3_driver.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/s3.h b/src/s3.h index 49b8a54..0875fc9 100644

[PATCH] Add missing call to vbeFree (bug 4417)

2010-12-02 Thread Matt Turner
Also kill unneeded vbe.h include from radeon_bios.c. Signed-off-by: Matt Turner matts...@gmail.com --- src/radeon_bios.c |1 - src/radeon_driver.c |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/radeon_bios.c b/src/radeon_bios.c index 5810bdb..b53a0ed 100644

Re: [PATCH] Fix detection of multi-function cards

2010-12-01 Thread Matt Turner
On Thu, Dec 2, 2010 at 2:42 AM, Bryce Harrington br...@canonical.com wrote: Bit 7 of the pci device header type is an indicator of multi-function devices, so needs to be masked when examining the bridge type. Thanks go to Chih-Pin Wu for finding the bug and its fix. Signed-off-by: Bryce

Re: [PATCH 08/11] Convert hw/xfree86/parser code to use Xasprintf() calls

2010-11-30 Thread Matt Turner
); +                               if (Xasprintf(s, %ul %ul, val1, val.num) == -1) +                                   s = NULL;                                break;                        case XAXIS:                                s = strdup(x); -- Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH 04/11] FindModuleInSubdir: Stop allocating one more byte than needed

2010-11-30 Thread Matt Turner
(dirpath) + 1);             sprintf(ret, %s%s, dirpath, tmpBuf);             break;         } -- Good catch. Did you just happen to notice this, or find it in some more automated way? Reviewed-by: Matt Turner matts...@gmail.com Is there any reason we shouldn't use Xasprintf here instead

Re: [PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-11-30 Thread Matt Turner
On Tue, Nov 30, 2010 at 6:06 PM, Ferry Huberts maili...@hupie.com wrote: Signed-off-by: Ferry Huberts ferry.hube...@pelagic.nl Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH 2/3] Move xchomp inside #ifdef __linux__

2010-11-29 Thread Matt Turner
On Tue, Nov 30, 2010 at 4:22 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] xf86OutputRename: Replace another strlen/malloc/strcpy set with strdup

2010-11-26 Thread Matt Turner
On Fri, Nov 26, 2010 at 8:32 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Probably missed by coccinelle patches since this only became a malloc() after a recent xalloc-malloc conversion. Reviewed-by: Matt Turner matts

Re: Respository vandalism by r...@...fd.o

2010-11-24 Thread Matt Turner
On Wed, Nov 24, 2010 at 6:58 AM, Luc Verhaegen l...@skynet.be wrote: On Wed, Nov 24, 2010 at 08:27:12PM +1000, Peter Hutterer wrote: On 24/11/10 19:38 , Luc Verhaegen wrote: Conspiracy theories? I did not imply that you were the one starting with the conspiracy theories, and I think

Re: [PATCH 02/13] render: repack PictureRec

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 04/13] dix: Remove the backing store leftovers

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com - * Copyright (c) 1987 by the Regents of the University of California Should we be sad or happy to see this go? Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH 06/13] dix: Remove unused ChangeSaveUnder hooks

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com git grep tells me these are not used anywhere else. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 07/13] dix: reshuffle WindowOptRec to fill a hole on LP64

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com ---  include/windowstr.h |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/windowstr.h b/include/windowstr.h index 29b95fc..0b66ebb 100644 ---

Re: [PATCH 08/13] render: Reshuffle and cull dead field from GlyphSetRec

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 12/13] mi: Remove unused miAllocateGCPrivateIndex

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Appears unused in the xserver and the DDXs. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development

<    1   2   3   4   5   6   7   >