Re: [PATCH 13/13] xfree86: Remove unused xf86PixmapKeyRec

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 07/13] dix: reshuffle WindowOptRec to fill a hole on LP64

2010-11-23 Thread Matt Turner
On Wed, Nov 24, 2010 at 1:37 AM, Peter Harris phar...@opentext.com wrote: On 2010-11-23 20:10, Matt Turner wrote: Probably just me not spotting the obvious, but I see xserver $ git grep 'VisualID' | grep typedef hw/dmx/dmxclient.h:typedef unsigned long VisualID64; hw/xnest/Xnest.h:typedef

Re: Patches to stop libtool droppings (#4898)

2010-11-19 Thread Matt Turner
On Fri, Nov 19, 2010 at 10:01 PM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-11-19 at 14:58 -0800, Jesse Adkins wrote: Following this is a whopping 66 patches. These patches cover every driver listed under cgit.freedesktop.org/xorg/driver/ (So wacom and some other got skipped). I

Re: Fix serious X server crash (xinerama + any QT app)

2010-11-13 Thread Matt Turner
That looks like a pretty obvious typo, so Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Make pm2's xv driver collect options like all other drivers.

2010-11-11 Thread Matt Turner
Wow. A real patch for pm2? Are you compile testing or do you have real hardware? On Thu, Nov 11, 2010 at 10:48 PM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports

Re: [PATCH] Remove superfluous if(p!=NULL) checks around free(p); p=NULL;

2010-11-10 Thread Matt Turner
On Wed, Nov 10, 2010 at 10:06 AM, Cyril Brulebois k...@debian.org wrote: This patch has been generated by the following Coccinelle semantic patch: @@ expression E; @@ -  if (E != NULL) { -   free(E); ( -   E = NULL; | -   E = 0; ) -  } + free(E); + E = NULL; Signed-off-by: Cyril

Re: [PATCH] Remove more superfluous if(p!=NULL) checks around free(p); p=NULL; p_foo=0;

2010-11-10 Thread Matt Turner
); +       map-acts= NULL; +       map-num_acts= map-size_acts= 0;     }     if ((whatXkbKeyBehaviorsMask)(map-behaviors!=NULL)) {        free(map-behaviors); -- 1.7.2.3 I think this should be OK. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel

Re: [PATCH] Remove more superfluous if(p!=NULL) checks around free(p).

2010-11-10 Thread Matt Turner
-base.GLXextensions = xnfalloc(buffer_size);             __glXGetExtensionString(screen-glx_enable_bits, screen-base.GLXextensions); -- 1.7.2.3 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] try the newport driver on mips

2010-11-08 Thread Matt Turner
On Mon, Nov 8, 2010 at 6:13 AM, Julien Cristau jcris...@debian.org wrote: On Mon, Nov  8, 2010 at 08:30:37 +0100, Mark Kettenis wrote: Actually, I don't think this is a good idea.  Unless I'm mistaken, the newport driver only supports one particular range of SGI graphics hardware.  There are

Re: [PATCH 1/2] Remove more superfluous if(p) checks around free(p).

2010-11-08 Thread Matt Turner
-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] Remove more superfluous if(p!=NULL) checks around free(p).

2010-11-08 Thread Matt Turner
)        nameRtrn[0]= '\0'; -    if (buf != NULL) -        free(buf); +    free(buf);     return FALSE;  } -- 1.7.2.3 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH] shadow: Optimize shadowUpdatePacked(). (#26973)

2010-11-07 Thread Matt Turner
On Sat, Sep 11, 2010 at 5:55 PM, Matt Turner matts...@gmail.com wrote: From: Adam Jackson a...@redhat.com Signed-off-by: Matt Turner matts...@gmail.com --- I was bug triaging and came across 26973 and remembered seeing it on the ml at some point recently. Here's a patch, as suggested by ajax

Re: [PATCH] try the newport driver on mips

2010-11-07 Thread Matt Turner
On Sat, Mar 6, 2010 at 1:03 PM, Matt Turner matts...@gmail.com wrote: On Sat, Mar 6, 2010 at 3:23 AM, Brice Goglin brice.gog...@gmail.com wrote: *From:* Bernhard R. Link brl...@debian.org http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=566545 Attached patch should tell the autodection code

Re: [PATCH] xfree86: fix two compiler warnings - unused variable ati, atimisc

2010-11-04 Thread Matt Turner
; -    char **ati, **atimisc;     int i;     /* walk to the end of the list */ -- 1.7.3.2 Reviewed-by: Matt Turner matts...@gmail.com ati and atimisc are still listed, along with lots of other dead and outdated modules, in hw/xfree86/doc/devel/Registry. Maybe cleaning hw/xfree86/doc/devel

Re: [PATCH] xfree86: fix compiler warnings - unused variable i

2010-11-04 Thread Matt Turner
-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] shadow: Optimize shadowUpdatePacked(). (#26973)

2010-10-28 Thread Matt Turner
On Tue, Sep 21, 2010 at 10:29 AM, Matt Turner matts...@gmail.com wrote: On Sat, Sep 11, 2010 at 5:55 PM, Matt Turner matts...@gmail.com wrote: From: Adam Jackson a...@redhat.com Signed-off-by: Matt Turner matts...@gmail.com --- I was bug triaging and came across 26973 and remembered seeing

Re: [PATCH]libXt-1.0.8/src/Keyboard.c fix NULL-pointer check

2010-10-24 Thread Matt Turner
On Sun, Oct 24, 2010 at 8:42 AM, walter harms wha...@bfs.de wrote: Alan Coopersmith schrieb: While we're accommodating with one-off patches in weird formats, if you're going to be sending series, or plan on continuing to send patches, you need to start using git to create them, working of

Re: [PATCH] xserver: Enable visible cursor on start without -retro #26798

2010-10-20 Thread Matt Turner
Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH RESEND 1/4] xkb: init mapWidth and symsPerKey arrays to 0.

2010-10-15 Thread Matt Turner
On Fri, Oct 15, 2010 at 2:02 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 12:02:56 15.10.2010 UTC+10 when peter.hutte...@who-t.net did gyre and gimble:  PH -    CARD16              symsPerKey[XkbMaxLegalKeyCode + 1];  PH +    CARD8              

Re: [PATCH 1/3] xfree86: drop linux libc5 support from the SIGIO code

2010-10-14 Thread Matt Turner
number of input devices usable  * at the same time plus one entry for DRM support. -- 1.7.2.3 Ha. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH 1/5] config: Don't look for .o drivers anymore

2010-10-14 Thread Matt Turner
char *patlist[] = {(.*)_drv\\.so, (.*)_drv\\.o, NULL}; +    static const char *patlist[] = {(.*)_drv\\.so, NULL};     ret = LoaderListDirs(subdirs, patlist);     /* fix up the probe order for video drivers */ -- 1.7.2.3 For the series: Reviewed-by: Matt Turner matts...@gmail.com

Re: [Xorg-driver-geode] xf86-video-geode: Changes to 'master'

2010-10-11 Thread Matt Turner
On Mon, Oct 11, 2010 at 9:38 PM, Huang, FrankR frankr.hu...@amd.com wrote: [snip] OK, let me see if I can explain: The purpose of the *_mode_valid function in each device-dependent X (xf86-video-ati, xf86-video-intel) is to allow the driver to decide whether a particular mode (mode is a

Re: [PATCH xorg-docs] Remove Linuxdoc Japanese XFree86 PC98 Dependent Information

2010-09-28 Thread Matt Turner
. They have never been built or installed. Signed-off-by: Gaetan Nadon mems...@videotron.ca Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH xserver] config: remove --with-dri-driver-path option, use dri.pc #29740

2010-09-26 Thread Matt Turner
On Sun, Sep 26, 2010 at 5:30 PM, Rémi Cardona r...@gentoo.org wrote: Well that's what bit us: you need a DRI-enabled mesa even if you're only building swrast. So we've had to turn on DRI (even though it doesn't have any DRM drivers) just to get swrast, whereas older versions of

Re: [PATCH xserver] config: remove --with-dri-driver-path option, use dri.pc #29740

2010-09-24 Thread Matt Turner
On Fri, Sep 24, 2010 at 6:19 PM, Rémi Cardona r...@gentoo.org wrote: I'll pipe in to add that this bit us (Gentoo) in the past as well. For some unknown reason, DRI support was disabled in our packages for HPPA and alpha. When swrast's build was moved from the server back into mesa, the

Re: dead code in build.sh?

2010-09-22 Thread Matt Turner
On Wed, Sep 22, 2010 at 4:34 PM, Mikhail Gusarov dotted...@dottedmag.net wrote:  MD The Kconfig item is for easily seeing dependencies. It seems to  MD work well for the linux kernel. Makes sense if someone uses it for (well-working) x-jhbuild/jhbuild/build.sh replacement. Kconfig is _not_

Re: [PATCH] shadow: Optimize shadowUpdatePacked(). (#26973)

2010-09-21 Thread Matt Turner
On Sat, Sep 11, 2010 at 5:55 PM, Matt Turner matts...@gmail.com wrote: From: Adam Jackson a...@redhat.com Signed-off-by: Matt Turner matts...@gmail.com --- I was bug triaging and came across 26973 and remembered seeing it on the ml at some point recently. Here's a patch, as suggested by ajax

Re: Obfuscated code in xserver/os/io.c ?

2010-09-21 Thread Matt Turner
On Tue, Sep 21, 2010 at 3:09 PM, Jesse Adkins jesserayadk...@gmail.com wrote: Syntax-wise, they're the same thing. There's nothing technically wrong with it, since it goes if - if - statement. The first if sees everything in the second if as a single statement, so no braces are required. To

Re: [RFC PATCH 0/9] Bus layer cleanups

2010-09-21 Thread Matt Turner
/ I'm not completely familiar with all the code, so take it with a grain of salt, Reviewed-by: Matt Turner matts...@gmail.com I tried to kill xf86SlowBcopy one time and it got reverted. (aa07957373fd7cbe67458a001e4afd6a7f1ea37f). xf86-video-vesa uses xf86SlowBcopy, so we can't get rid

Re: [PATCH glint] Fix timing errors, as per documentation

2010-09-16 Thread Matt Turner
On Thu, Sep 16, 2010 at 3:02 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Matt Turner matts...@gmail.com Date: Wed, 15 Sep 2010 23:37:55 -0400 pm2_dac.c: -     VsEnd and VsStart should have 1 subtracted, say the docs. This also       matches with the PM3 and PM4 docs, and is what

[PATCH glint] Fix timing errors, as per documentation

2010-09-15 Thread Matt Turner
the Shiftbpp, as the docs say. This error has existed since xf86-video-glint was imported into git and has been propagated to the pm3fb Linux kernel driver. Signed-off-by: Matt Turner matts...@gmail.com --- I know there isn't much interest in this hardware, but I'd really

Re: Is XAA still supported in recent and future xserver?

2010-09-13 Thread Matt Turner
On Mon, Sep 13, 2010 at 4:06 AM, Marc Scherer marc.sche...@mp-ndt.de wrote: We are using the siliconmotion video driver and the performance on a xserver dated June 2009 was better with XAA than with EXA. Since I am just starting again to work on the driver: will XAA be available and supported

Re: Is XAA still supported in recent and future xserver?

2010-09-13 Thread Matt Turner
On Mon, Sep 13, 2010 at 11:18 AM, Matt Dew m...@osource.org wrote: Is that something that should go on a TODO (wish)list?  Move remaining DDXs from XXA to EXA? Maybe improve those drivers' performance on EXA first? Matt I'd think that at this point, EXA isn't good enough to bother rewriting

Re: Is XAA still supported in recent and future xserver?

2010-09-13 Thread Matt Turner
On Mon, Sep 13, 2010 at 3:09 PM, Tiago Vignatti tiago.vigna...@nokia.com wrote: On Mon, Sep 13, 2010 at 05:26:34PM +0200, ext Alex Deucher wrote: On Mon, Sep 13, 2010 at 11:18 AM, Matt Dew m...@osource.org wrote: Is that something that should go on a TODO (wish)list?  Move remaining DDXs

[PATCH] shadow: Optimize shadowUpdatePacked(). (#26973)

2010-09-11 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Matt Turner matts...@gmail.com --- I was bug triaging and came across 26973 and remembered seeing it on the ml at some point recently. Here's a patch, as suggested by ajax [1]. Corbin: are there any patches from your bug triage branch that need

[PATCH] Remove dolt

2010-09-11 Thread Matt Turner
From: Adrian Bunk b...@stusta.de With libtool 2.2.6b the difference in build time is so small ( 5% with -j8 builds) that it isn't worth having this hack. --- I don't have any idea if this is something we want. I'm just sending it to xorg-devel so it doesn't rot in bugzilla for all eternity. Bug

Bug 15882: Patches from OpenEmbedded.org

2010-09-11 Thread Matt Turner
Bug 15882 (https://bugs.freedesktop.org/show_bug.cgi?id=15882) has links to potentially interesting patches from OpenEmbedded.org. See http://cgit.openembedded.net/cgit.cgi/openembedded/tree/recipes/xorg-xserver/xserver-xorg-1.9.0 Does anyone see anything here that's useful, or can we close

Re: for GSoC: looking for a PCI Permedia 3 (VX1, GVX1)

2010-09-10 Thread Matt Turner
On Tue, May 4, 2010 at 10:20 AM, Matt Turner matts...@gmail.com wrote: Hi, I've been accepted to the GSoC this year. My proposal is here [1]. I've collected quite a bit of Permedia hardware:  - 2 GVX420s, dual R4 rasterizers, G2 geometry engine  - a GVX1 Pro, R4 rasterizer, G2 geometry

Re: for GSoC: looking for a PCI Permedia 3 (VX1, GVX1)

2010-09-10 Thread Matt Turner
. ~ C. On Sep 10, 2010 10:21 AM, Matt Turner matts...@gmail.com wrote: On Tue, May 4, 2010 at 10:20 AM, Matt Turner matts...@gmail.com wrote: Hi, I've been accepted to the GSoC this year. My proposal is here [1]. I've collected quite a bit of Permedia hardware:  - 2 GVX420s, dual R4

Re: [PATCH 3/4] xfree86: fbdevhw: remove superfluous pci pointer from probe function

2010-09-09 Thread Matt Turner
On Thu, Sep 9, 2010 at 3:57 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Thu, 9 Sep 2010 11:01:59 +0300 From: Vignatti Tiago (Nokia-MS/Helsinki) tiago.vigna...@nokia.com Mark, On Tue, Sep 07, 2010 at 11:25:26PM +0200, ext Mark Kettenis wrote: From: Tiago Vignatti

Re: for GSoC: looking for a PCI Permedia 3 (VX1, GVX1)

2010-09-05 Thread Matt Turner
On Thu, Sep 2, 2010 at 6:06 AM, Mark Marshall mark.marsh...@csr.com wrote: On 04/05/2010 15:20, Matt Turner wrote: Hi, I've been accepted to the GSoC this year. My proposal is here [1]. Hi. I've been following your progress on this, and am interested to know how you got on.  I've managed

[PULL] xserver clean ups

2010-08-27 Thread Matt Turner
xfree86: Purge parsePrologueVoid. Matt Turner (1): Replace malloc/strlen/strcpy with strdup. Xi/extinit.c |3 +-- dix/extension.c |6 ++ hw/kdrive/src/kxv.c |9 +++-- hw/xfree86/common/xf86Helper.c

Re: xorg-server 1.7.8?

2010-08-26 Thread Matt Turner
On Thu, Aug 26, 2010 at 2:42 AM, Rémi Cardona r...@gentoo.org wrote: Le 25/08/2010 20:05, Alan Coopersmith a écrit : Would a 1.7.8 be useful to anyone else besides our two distros?   Are there any fixes suitable for 1.7.8 that are not yet cherry-picked to server-1.7-branch that would be

Re: Old O'Reilly X books

2010-08-26 Thread Matt Turner
On Thu, Aug 26, 2010 at 11:11 AM, Aaron Plattner aplatt...@nvidia.com wrote: On Thu, Aug 26, 2010 at 05:43:53AM -0700, Pat Kane wrote: BTW, while trying to grep my dead trees I noticed that the current X server contains some HAKMEM code, in ./mi/micmap.c I see this hack:     ...     count =

[PATCH] Replace malloc/strlen/strcpy with strdup.

2010-08-26 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- Xi/extinit.c |3 +-- dix/extension.c |6 ++ hw/kdrive/src/kxv.c |9 +++-- hw/xfree86/common/xf86Init.c |6 ++ hw/xfree86/common/xf86xv.c

Re: what is the effect of RADEON_ALIGN (macros) in ATI-driver?

2010-08-11 Thread Matt Turner
On Wed, Aug 11, 2010 at 10:55 PM, Cui, Hunk hunk@amd.com wrote:        I want to know why the variable should add X (in '(variable + X)'), what is the mainly intention? What are the different with HW operation? Good question. If I understand it correctly, I think I can help. Given some

Re: protocol driver releases needed for Xorg 1.9

2010-08-10 Thread Matt Turner
xf86-video-glide:        24 commits since 1.2.24, including:   Matt Turner:      Use libc instead of deprecated libc wrappers for malloc/calloc/free. I think this is supposed to be xf86-video-glint, instead of glide. (And 1.2.4 instead of 1.2.24) Given a bit of guidance on how to sign

Re: configure error at line 11573

2010-08-10 Thread Matt Turner
On Mon, Aug 9, 2010 at 11:31 AM, mas christ mas_chr...@hotmail.com wrote: ./configure: line 11573: syntax error near unexpected token `RANDR,' ./configure: line 11573: `XORG_DRIVER_CHECK_EXT(RANDR, randrproto)' The git master is at revision r6xx/r7xx: default to micro (1D) tiling for now.

Re: [PATCH] xfree86: parser: Fix using heap memory for driver names. (Fixes #17438)

2010-08-05 Thread Matt Turner
On Thu, Aug 5, 2010 at 2:55 AM, Jesse Adkins jesserayadk...@gmail.com wrote: I also put this patch in bugzilla, in case it might help somebody in the future. While I'm at it, can I get some thoughts about logging this as a warning or informational. What about deprecating this feature? Can we

Re: [PATCH 2/6] xfree86: Remove prototypes for non-existant functions.

2010-08-03 Thread Matt Turner
://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com Unless someone else has a -next tree set up, I'll create one and vacuum up these patches. Matt ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] xfree86: Loader: Don't print loader 'magic'.

2010-08-02 Thread Matt Turner
On Mon, Aug 2, 2010 at 11:57 AM, Adam Jackson a...@nwnk.net wrote: On Sun, 2010-08-01 at 16:01 -0700, Jesse Adkins wrote: xorg_symbols has nothing to do with module loading. Signed-off-by: Jesse Adkins jesserayadk...@gmail.com Be very very careful in doing this.  I'm inclined to nak this on

Re: [PATCH] replace malloc+strlen+strcpy with strdup

2010-08-01 Thread Matt Turner
On Sat, Jun 19, 2010 at 1:59 PM, matts...@gmail.com wrote: From: Matt Turner matts...@gmail.com Signed-off-by: Matt Turner matts...@gmail.com ---  dix/extension.c              |    3 +--  hw/xfree86/common/xf86Init.c |    6 ++  hw/xfree86/parser/scan.c     |    6 ++  3 files

Re: [PATCH] ddc: Fix memory leak in GetEDID_DDC1

2010-08-01 Thread Matt Turner
On Tue, Jul 27, 2010 at 11:32 PM, Matt Turner matts...@gmail.com wrote: Mark argument to DDC_checksum as const too. Signed-off-by: Matt Turner matts...@gmail.com ---  hw/xfree86/ddc/ddc.c |    7 +--  1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/ddc/ddc.c b

Re: [PATCH] Freeing EDID_block attached to nowhere

2010-08-01 Thread Matt Turner
://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Looks good. Reviewed-by: Matt Turner matts...@gmail.com I think after reviewing your patch, I found another leak. Patch in progress. ___ xorg-devel@lists.x.org

Re: [PATCH] replace malloc+strlen+strcpy with strdup

2010-08-01 Thread Matt Turner
On Sun, Aug 1, 2010 at 8:13 PM, Matt Turner matts...@gmail.com wrote: On Sat, Jun 19, 2010 at 1:59 PM,  matts...@gmail.com wrote: From: Matt Turner matts...@gmail.com Signed-off-by: Matt Turner matts...@gmail.com ---  dix/extension.c              |    3 +--  hw/xfree86/common/xf86Init.c

Re: [PATCH 1/2] xfree86: Revert 'Remove constants supposedly for isc cc.', add note.

2010-08-01 Thread Matt Turner
On Sun, Aug 1, 2010 at 10:05 PM, Jesse Adkins jesserayadk...@gmail.com wrote: Turns out the keyboard driver relies on these. Added a note about who uses the macros, so this doesn't happen again. Signed-off-by: Jesse Adkins jesserayadk...@gmail.com ---  hw/xfree86/common/xf86Privstr.h |   11

Re: [PATCH] replace malloc+strlen+strcpy with strdup

2010-08-01 Thread Matt Turner
On Sun, Aug 1, 2010 at 10:46 PM, Keith Packard kei...@keithp.com wrote: On Sun, 1 Aug 2010 20:13:03 -0400, Matt Turner matts...@gmail.com wrote: On Sat, Jun 19, 2010 at 1:59 PM,  matts...@gmail.com wrote: From: Matt Turner matts...@gmail.com Signed-off-by: Matt Turner matts...@gmail.com

Re: [PATCH] Freeing EDID_block attached to nowhere

2010-07-27 Thread Matt Turner
/listinfo/xorg-devel Looks good. Reviewed-by: Matt Turner matts...@gmail.com I think after reviewing your patch, I found another leak. Patch in progress. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

[PATCH] ddc: Fix memory leak in GetEDID_DDC1

2010-07-27 Thread Matt Turner
Mark argument to DDC_checksum as const too. Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/ddc/ddc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/ddc/ddc.c b/hw/xfree86/ddc/ddc.c index 7379e95..2d9d4dc 100644 --- a/hw/xfree86/ddc/ddc.c

Re: Rotate left and Rotate right at higher resolutions - result in distorted graphics

2010-07-19 Thread Matt Turner
On Mon, Jul 19, 2010 at 11:39 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon, Jul 19, 2010 at 2:45 AM, DarkKnight BrightWarrior bindasbe...@gmail.com wrote: Hai! I am using centos 5.3. I upgraded it with Xorg7.3. My graphics card is ati radeon x1200. Xserver version is 1.4.2 and

Re: [PATCH] include: Update stale comment after bzero removal

2010-06-20 Thread Matt Turner
On Sun, Jun 20, 2010 at 8:39 PM, Matt Turner matts...@gmail.com wrote: On Sun, Jun 20, 2010 at 8:16 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, Jun 20, 2010 at 04:37:26AM +0700, Mikhail Gusarov wrote: Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net ---  include/misc.h

Re: [PATCH] parser/scan.c: use strdup

2010-06-19 Thread Matt Turner
On Wed, Jun 16, 2010 at 4:33 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Matt Turner wrote: Found using --- @@ expression E; identifier i; identifier address; @@ - i = malloc(strlen(E) + 1); - strcpy(address, E); + i = strdup(E); --- Would it be possible to similarly

Re: Post-RC1 merging criteria (was Re: [PULL] cleanups)

2010-06-19 Thread Matt Turner
On Fri, Jun 18, 2010 at 5:32 PM, Keith Packard kei...@keithp.com wrote: On Mon, 14 Jun 2010 10:44:38 -0700, Jamey Sharp ja...@minilop.net wrote: These cleanups and warning fixes have been reviewed and don't, as far as I can tell, affect API or ABI. Can they be merged to master? I don't know.

[PATCH] Define/use X_ALIGN2() instead of open coding it

2010-06-19 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- Notes: Page size is always a power of two, so those conversions are safe. This patch requires [PATCH] Guard x* macros with _HAVE_XALLOC_DECLS as well to avoid clashes with Xlib because it includes misc.h in XF86dri.c, causing a clash between

Re: [PATCH] Define/use X_ALIGN2() instead of open coding it

2010-06-19 Thread Matt Turner
jcristau tells me that I shouldn't include misc.h in kdrive/ephyr/XF86dri.c, so just throw out that hunk. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Replace xalloc with malloc

2010-06-16 Thread Matt Turner
() is NULL, since free(NULL) is allowed. Signed-off-by: Tomas Carnecky t...@dbservice.com 'Also' in commit messages is usually a sign that the commit needs to be split into multiple patches. Whatever the case, Reviewed-by: Matt Turner matts...@gmail.com

[PATCH] parser/scan.c: use strdup

2010-06-16 Thread Matt Turner
Found using --- @@ expression E; identifier i; identifier address; @@ - i = malloc(strlen(E) + 1); - strcpy(address, E); + i = strdup(E); --- Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/parser/scan.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw

[PATCH] Remove more superfluous if(p) checks around free(p)

2010-06-09 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- exa/exa_glyphs.c | 12 ++--- hw/kdrive/ephyr/ephyrhostvideo.c |6 +-- hw/kdrive/ephyr/hostx.c | 25 +++-- hw/xfree86/modes/xf86Cursors.c |7 +-- hw/xfree86/os-support/bus/Sbus.c |6 +-- hw/xwin

Re: [PATCH] Remove more superfluous if(p) checks around free(p)

2010-06-09 Thread Matt Turner
On Wed, Jun 9, 2010 at 12:46 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Matt Turner wrote: --- a/xkb/ddxList.c +++ b/xkb/ddxList.c @@ -208,10 +208,8 @@ char     tmpname[PATH_MAX];       return BadImplementation;      }      list-nFound[what]= 0; -    if (buf) { -        free

Re: [PATCH] Remove more superfluous if(p) checks around free(p)

2010-06-09 Thread Matt Turner
On Wed, Jun 9, 2010 at 1:04 PM, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 12:51:39 09.06.2010 UTC-04 when matts...@gmail.com did gyre and gimble:  MT Good catch. I'll resent to Keith with the Reviewed-by tags and this  MT change. Keith said merge window is closed. Do

Re: [PATCH] Remove more superfluous if(p) checks around free(p)

2010-06-06 Thread Matt Turner
On Sun, Jun 6, 2010 at 9:14 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 10:03:16 06.06.2010 UTC-03 when fcarr...@yahoo.com.br did gyre and gimble:  FC By the way, the hunk below sounds rather fishy, right?   @@ -109,14 +107,10 @@ RRCreateOutputProperty (Atom property)

Re: [PATCH 1/2] xrandr: Inline RRInitOutputPropertyValue called from single place

2010-06-06 Thread Matt Turner
; -- 1.7.1 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg

Re: [PATCH 1/4] xkb: Remove superfluous if(p) checks around free(p)

2010-06-04 Thread Matt Turner
On Fri, Jun 4, 2010 at 4:52 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net ---  xkb/xkbUtils.c |  144 +++-  1 files changed, 48 insertions(+), 96 deletions(-) diff --git

Re: [PATCH 2/4] xkb: Remove superfluous if(x) x = realloc(x, sz); else x = malloc(sz); logic

2010-06-04 Thread Matt Turner
@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com Why did anyone write the code like that to begin with? Did the behavior or realloc not allow this at some point

Re: [PATCH 4/4] Misc coding style cleanup

2010-06-04 Thread Matt Turner
___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel

[PATCH] record: move free() to after last use of pContext

2010-06-04 Thread Matt Turner
No functional change, since free doesn't change the value of the pointer passed to it, but it makes this code less confusing. Signed-off-by: Matt Turner matts...@gmail.com --- Alan, I saw this when looking through your parfait results. It looks like RecordFindContextOnAllContexts's argument

Re: running build.sh under gentoo

2010-06-03 Thread Matt Turner
On Thu, Jun 3, 2010 at 9:23 PM, Matt Dew m...@osource.org wrote: Has anyone had luck getting build.sh to run on gentoo? It's something with gentoo's python I think.   I searched around but no luck. It dies in libxcb. ... ... /usr/bin/python ./c_client.py -p

Re: [PATCH synaptics] Don't use libcwrappers for calloc and free.

2010-05-24 Thread Matt Turner
___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] xfree86: fix typo in optionTypeToSting.

2010-05-17 Thread Matt Turner
) + 1; -- 1.7.0.1 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH 5/5] Add abort(3) to the end of FatalError in case one of DDX functions fails to abort

2010-05-12 Thread Matt Turner
On Wed, May 12, 2010 at 4:33 PM, Mikhail Gusarov dotted...@dottedmag.net wrote: Also it makes gcc happier. Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net ---  os/log.c |    4  1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/os/log.c b/os/log.c index

Re: [PATCH 5/5] Add abort(3) to the end of FatalError in case one of DDX functions fails to abort

2010-05-12 Thread Matt Turner
On Wed, May 12, 2010 at 4:40 PM, Matt Turner matts...@gmail.com wrote: On Wed, May 12, 2010 at 4:33 PM, Mikhail Gusarov dotted...@dottedmag.net wrote: Also it makes gcc happier. Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net ---  os/log.c |    4  1 files changed, 4 insertions

Re: [PATCH] Fix mod() definition.

2010-05-07 Thread Matt Turner
: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-05 Thread Matt Turner
On Wed, May 5, 2010 at 3:27 PM, Mikhail Gusarov dotted...@dottedmag.net wrote: Hi, There is RFC patchset which gets rid of Xalloc/Xfree/... wrappers in X server while retaining the API and ABI. URL: git://anongit.freedesktop.org/~dottedmag/xserver no-xalloc The changes are as the

Re: [PATCH: libXdmcp 2/4] XdmcpARRAY8Equal: Use memcmp instead of rolling our own

2010-05-05 Thread Matt Turner
development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH: libXdmcp 1/4] Constify function prototypes

2010-05-05 Thread Matt Turner
);  extern int XdmcpAllocARRAY32 (ARRAY32Ptr array, int length); -- 1.5.6.5 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner

Re: [PATCH: libXdmcp 3/4] unifdef Lynx

2010-05-05 Thread Matt Turner
-#endif /* !Lynx */  #endif  #endif -- 1.5.6.5 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH: libXdmcp 4/4] Deal with lint warnings about implicit narrowing conversions

2010-05-05 Thread Matt Turner
: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

for GSoC: looking for a PCI Permedia 3 (VX1, GVX1)

2010-05-04 Thread Matt Turner
, no geometry engine - an old Permedia 2 But all but the Permedia 2 are AGP. Has anyone got a PCI VX1 or GVX1 they'd like to donate to the project? Thanks, Matt Turner [1] http://mattst88.com/blog/?dd=11mm=04=2010 ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] Boolean-or short-circuits, so (a || (!a ...)) is redundant. Simplify.

2010-04-26 Thread Matt Turner
://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Kill unused/useless macros in panoramiX.h: BREAK_IF, IF_RETURN, FORCE_ROOT

2010-04-26 Thread Matt Turner
Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH v3 3/4] xfree86/dri2: wrap drm bits with macros and change drm_magic type

2010-04-21 Thread Matt Turner
On Wed, Apr 21, 2010 at 9:00 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Wed, 21 Apr 2010 15:34:48 +0300 From: Tiago Vignatti tiago.vigna...@nokia.com On Wed, Apr 21, 2010 at 11:53:04AM +0200, ext Mark Kettenis wrote: I'll reiterate an opinion stated here before.  We should

Re: [PATCH v3 3/4] xfree86/dri2: wrap drm bits with macros and change drm_magic type

2010-04-21 Thread Matt Turner
On Wed, Apr 21, 2010 at 4:40 AM, Pauli Nieminen ext-pauli.niemi...@nokia.com wrote: From: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com The whole series looks like it's got the

[PATCH] Define/use ALIGN() instead of open coding it

2010-04-08 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- Xext/xf86bigfont.c|2 +- hw/dmx/dmxpict.c |2 +- hw/kdrive/ephyr/XF86dri.c |6 +++--- hw/xfree86/dixmods/extmod/xf86vmode.c |6 +++--- hw/xfree86/int10/generic.c

Re: [PATCH] Mark highly predictable branches as likely/unlikely

2010-04-07 Thread Matt Turner
On Wed, Apr 7, 2010 at 7:15 PM, Dave Airlie airl...@redhat.com wrote: On Wed, 2010-04-07 at 18:49 -0400, Matt Turner wrote: Highly predicatble branches include  - unlikely: error conditions, such as those leading to       - RADEON_FALLBACK       - goto fail       - return FALSE (as an error

Re: [PATCH] Initialize __expected to 0 in RING_LOCALS.

2010-04-06 Thread Matt Turner
On Mon, Apr 5, 2010 at 2:11 PM, Cyril Brulebois k...@debian.org wrote: This avoids some noise during building:    CC     radeon_accel.lo  radeon_accel.c: In function ‘RADEONHostDataBlit’:  radeon_accel.c:855: warning: ‘__expected’ may be used uninitialized in this function Signed-off-by:

Re: [PATCH] Fix x86emu builds when using non-gnu compilers

2010-03-30 Thread Matt Turner
-  #endif /* __X86EMU_TYPES_H */ -- 1.5.6.5 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Acked-by: Matt Turner matts...@gmail.com

[PATCH] Define/use pad_to_pow_two() instead of open coding it

2010-03-24 Thread Matt Turner
à la the Linux Kernel's ALIGN macro. Signed-off-by: Matt Turner matts...@gmail.com --- hw/dmx/dmxpict.c |2 +- hw/kdrive/ephyr/XF86dri.c |6 +++--- hw/xfree86/dixmods/extmod/xf86vmode.c |6 +++--- hw/xfree86/int10/generic.c| 13

Re: [PATCH] Define/use pad_to_pow_two() instead of open coding it

2010-03-24 Thread Matt Turner
On Wed, Mar 24, 2010 at 2:56 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Matt Turner matts...@gmail.com Date: Wed, 24 Mar 2010 13:57:15 -0400 diff --git a/hw/dmx/dmxpict.c b/hw/dmx/dmxpict.c index 072e3a6..51616bb 100644 --- a/hw/dmx/dmxpict.c +++ b/hw/dmx/dmxpict.c @@ -674,7

Re: [PATCH] Define/use pad_to_pow_two() instead of open coding it

2010-03-24 Thread Matt Turner
On Wed, Mar 24, 2010 at 4:29 PM, Eric Anholt e...@anholt.net wrote: On Wed, 24 Mar 2010 14:59:04 -0400, Matt Turner matts...@gmail.com wrote: On Wed, Mar 24, 2010 at 2:56 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Matt Turner matts...@gmail.com Date: Wed, 24 Mar 2010 13:57:15

Re: ATI 6.12.4 on ultraSparc runs slow

2010-03-23 Thread Matt Turner
On Tue, Mar 23, 2010 at 6:31 PM, jean-francois simon jfsimonc...@gmail.com wrote: Hi, thanks to the people who provided support for big endian architectures, we are able to run the 6.12.4 ATI driver on a openSolaris sparc platform (T2000 niagara). the graphic is a PCIe card using a e4690. i

<    1   2   3   4   5   6   7   >