Hi,
On 06-05-15 05:20, Peter Hutterer wrote:
This code was largely lifted from the X server in
bb25b2ad297891430606c367bfabc but didn't take the copyright messages that
applied to that code.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
LGTM: Reviewed-by: Hans de Goede hdego
From: Søren Sandmann Pedersen s...@redhat.com
This option is mentioned in the man page, but not in the help text
Signed-off-by: Hans de Goede hdego...@redhat.com
---
xauth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xauth.c b/xauth.c
index 85fcaf4..d9efda0 100644
--- a/xauth.c
+++ b
requires either a valuator_mask_zero()
call or unsetting all valuators one-by-one.
Trying to mix the two will produce a warning.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
The entire set looks good to me, and seems to be a clean solution to the
problem:
Reviewed-by: Hans de Goede
-off-by: Peter Hutterer peter.hutte...@who-t.net
The set LGTM:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
10-evdev.conf | 40
Makefile.am | 1 +
configure.ac | 7 +++
3 files changed, 48 insertions(+)
create mode
Hi,
On 23-01-15 05:20, Peter Hutterer wrote:
On Wed, Jan 21, 2015 at 10:36:16AM +0100, Hans de Goede wrote:
systemd-logind integration does not work when starting X on a new tty, as
that detaches X from the current session and after hat systemd-logind revokes
all rights any already open fds
Hi,
So after letting these sit it is time to dust them of, fix the review
comments and get them upstream.
On 23-01-15 05:20, Peter Hutterer wrote:
On Wed, Jan 21, 2015 at 10:36:15AM +0100, Hans de Goede wrote:
systemd-logind integration does not work when starting X on a new tty
,
requiring ssh access to the system to kill X.
The fix for this is easy, we must not use systemd-logind integration when
not using KeepTty, or iow we may only use systemd-logind integration together
with KeepTty.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Changes in v2:
-Document that -keeptty
no side effects other than setting xf86Info.vtno and keepTty.
Note this basically only moves a large chunk of xf86OpenConsole() into
linux_get_vtno() without changing a single line of it, this is hard to see
in the diff because the identation level has changed.
Signed-off-by: Hans de Goede hdego
Hi,
On 29-04-15 01:51, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Other then the bugzilla link in 4/4 not making any sense (as already pointed
out)
this patch set looks good and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
.
This commit changes the message_filter function to filter out all
non-signal messages, including spurious message replies.
Downstream-bug: https://bugzilla.redhat.com/show_bug.cgi?id=1209347
Signed-off-by: Ray Strode rstr...@redhat.com
Thanks both patches look good and are:
Reviewed-by: Hans de Goede
Hi,
On 17-04-15 15:07, Ray Strode wrote:
Hi,
Ray, you may want to reduce the number of context lines a bit next time
you post patches.
Nope, definitely don't. my default config produces patches with a lot
of context intentionally. I want driveby readers who aren't motivated
enough to go to
Non serverfd input devices will never get a systemd-logind dbus resume signal,
causing them to never get re-enabled.
This commit changes xf86VTEnter() to enable them immediately, fixing this.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=89756
Signed-off-by: Hans de Goede hdego
Hi,
When building current master on Fedora 22 I end up with the following in
sdksyms.c:
/*
* These symbols are referenced to ensure they
* will be available in the X Server binary.
*/
/* topdir=../.. */
_X_HIDDEN void *xorg_symbols[] = {
(void *) ,
Hi,
On 08-04-15 13:54, Hans de Goede wrote:
Hi,
When building current master on Fedora 22 I end up with the following in
sdksyms.c:
/*
* These symbols are referenced to ensure they
* will be available in the X Server binary.
*/
/* topdir=../.. */
_X_HIDDEN void *xorg_symbols
Hi,
On 25-03-15 22:45, Julien Cristau wrote:
On Wed, Mar 25, 2015 at 09:15:12 -0400, Ray Strode wrote:
Hi,
Now, I've tried to avoid anything xauth-related, but from the little I know:
to support displayfd in startx you'd have to communicate back to startx
about the $DISPLAY and do the xauth
Hi,
On 25-03-15 02:50, Peter Hutterer wrote:
This is misleading - it is always overwritten after looping through the lock
files.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good to me:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
startx.cpp | 2
Hi,
On 25-03-15 02:53, Peter Hutterer wrote:
On Mon, Mar 23, 2015 at 02:16:13PM +, Jon TURNEY wrote:
On 20/03/2015 17:16, Ray Strode wrote:
On Fri, Mar 20, 2015 at 10:02 AM, Hans de Goede hdego...@redhat.com wrote:
If a separate /tmp per user is used the existing auto display select
Hi,
On 25-03-15 05:21, Peter Hutterer wrote:
Required to make the driver receive keyboard events from the console.
X.Org Bug http://bugs.freedesktop.org/show_bug.cgi?id=89653
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Hi,
On 25-03-15 01:54, Peter Hutterer wrote:
On Fri, Mar 20, 2015 at 03:02:35PM +0100, Hans de Goede wrote:
Currently startx relies on /tmp/.X?-lock being present for automatically
picking a free display number. This does not work if -nolock is used when
starting the server, or if the server
Hi,
On 25-03-15 14:20, Ray Strode wrote:
Hi,
You're right I had forgotten that the xauth file needs to contain the
displaynr, so there is no easy fix here I'm afraid.
That's not true actually. The xauth file can have a display wildcard, but
the xauth command doesn't support generating xauth
Hi,
On 24-03-15 06:45, Peter Hutterer wrote:
An MT device without X/Y is not a touchpad. And neither are fake MT devices.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/eventcomm.c | 9
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/eventcomm.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/eventcomm.c b/src/eventcomm.c
index 53a0ca4..cddf7fc 100644
--- a/src/eventcomm.c
+++ b/src/eventcomm.c
@@ -436,6 +436,11
If a separate /tmp per user is used the existing auto display select code
does not work, add an extra check for the unix socket for the display number
existing in /proc/net/unix (linux only).
Signed-off-by: Hans de Goede hdego...@redhat.com
---
startx.cpp | 6 +-
1 file changed, 5 insertions
is getting used by
display-managers (e.g. gdm), this fixes this by also checking for
/tmp/.X11-unix/X?
Signed-off-by: Hans de Goede hdego...@redhat.com
---
startx.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/startx.cpp b/startx.cpp
index 8520399..fe49996 100644
--- a/startx.cpp
are encouraged to leave the
0644453 commit in and undo this revert.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Hans de Goede hdego...@redhat.com
---
Just sending this out for the changed commit message. Some of the patches
are en-route to the stable kernel, the full
Hi,
On 18-03-15 03:43, Ingo Brückl wrote:
I've got it!
It has nothing to do with xf86-input-keyboard or xorg-server, but with
startx. It nowadays starts X on the current tty due to an issue in
systemd-logind (according to bugzilla.redhat.com/show_bug.cgi?id=806491).
This causes xorg-server to
Hi,
On 16-03-15 23:22, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Both patches look good to me and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/libinput.c | 212 ++---
1
in Dmitry's for-linus branch.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good to me:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
conf/50-synaptics.conf | 7 ---
conf/71-synaptics.rules | 20
conf/Makefile.am| 7
Hi Peter,
On 15-03-15 23:47, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
All 3 patches look good to me and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
xorg.modules | 1 +
1 file changed, 1 insertion(+)
diff --git
Hi,
All patches in this series look good and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
On 11-03-15 06:53, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
configure.ac | 12 ++--
src/evdev.c | 93
Hi,
On 04-03-15 22:46, Peter Hutterer wrote:
On Wed, Mar 04, 2015 at 01:15:31PM +0100, Hans de Goede wrote:
Hi,
On 04-03-15 06:00, Peter Hutterer wrote:
For source FINGER and CONTINUOUS, the axis value is the same as relative
motion - but scrolling in X usually doesn't have the same speed
Hi,
On 04-03-15 06:00, Peter Hutterer wrote:
For source FINGER and CONTINUOUS, the axis value is the same as relative
motion - but scrolling in X usually doesn't have the same speed as finger
movement, it's a lot coarser.
We don't know ahead of time where we'll get the scroll events from. Set
...@who-t.net
Both patches look good and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/libinput.c | 403 +
1 file changed, 234 insertions(+), 169 deletions(-)
diff --git a/src/libinput.c b/src/libinput.c
Hi,
On 11-02-15 17:04, Alan Coopersmith wrote:
Fixes build errors when using Solaris Studio 12.4 from getting the wrong
strings (such as __attribute__) put into the sdksyms function list.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Hmm, have you seen my patch to sdksyms.sh to
gcc5's cpp inserts patterns like this:
extern
__attribute__((visibility(default)))
int WaitForSomething(int *
);
This patch make sdksyms.sh work with this. Note my awk skills are weak, so
there likely is a better way to deal with this.
Signed-off-by: Hans de Goede
Hi,
In case someone wants to do a better fix, I've put a
file already mangled by gcc5 cpp here:
https://fedorapeople.org/~jwrdegoede/sdksyms.pre
Regards,
Hans
On 11-02-15 16:39, Hans de Goede wrote:
gcc5's cpp inserts patterns like this:
extern
__attribute__((visibility(default
Hi,
On 10-02-15 08:39, Jeremy Huddleston Sequoia wrote:
It seems that using cpp for startx and xinitrc in the xinit port is coming back
to bite us now as different C preprocessors don't exactly process non-C files
in ways that we might want.
https://trac.macports.org/ticket/46811#comment:4
Hi,
On 30-01-15 06:31, Peter Hutterer wrote:
Needs a temporary libinput context to get all capability events without
events from other devices interfering.
This doesn't yet handle true capability changes, only the initial burst of
events after the DEVICE_ADDED event.
Signed-off-by: Peter
Hi,
On 02/03/2015 12:13 PM, Peter Hutterer wrote:
On 3/02/2015 18:29 , Hans de Goede wrote:
Hi,
On 30-01-15 06:31, Peter Hutterer wrote:
Needs a temporary libinput context to get all capability events without
events from other devices interfering.
This doesn't yet handle true capability
Hi All,
A Fedora user has reported problems with MIT-SHM when the xserver
is not running as root. Normal use works fine, but when doing a
su - and then starting X apps as root MIT-SHM fails, see this
screenshot:
https://bugzilla.redhat.com/attachment.cgi?id=977933
The culprit is this error:
Hi,
On 29-01-15 10:33, Martin Gräßlin wrote:
On Thursday 29 January 2015 10:20:41 Hans de Goede wrote:
Hi All,
A Fedora user has reported problems with MIT-SHM when the xserver
is not running as root. Normal use works fine, but when doing a
su - and then starting X apps as root MIT-SHM fails
) associated with the
trackpoint device we also don't need to worry about having finger motion event
correctly synced up with the button presses - it's acceptable to send the
presses before the motion events.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good.
Reviewed-by: Hans de
.
Signed-off-by: Mark Kettenis kette...@openbsd.org
Looks good, and I've checked that this still does what we want it to do under
Linux / bash:
Acked-by: Hans de Goede hdego...@redhat.com
---
startx.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/startx.cpp b
code we check at hotplug time.
This patch indeed looks nicer then Jonathan's original patch:
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info
with
this patch?
I was waiting for Dave to chime in, but I guess he is busy,
v3 looks good to me and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Keith, this seems to count as a bugfix to me, can you pick this
up and add it to master ?
Regards,
Hans
Hi,
On 23-01-15 17:05, Ray Strode wrote:
Hi,
The fix for this is easy, we must not use systemd-logind integration when
not using KeepTty, or iow we may only use systemd-logind integration together
with KeepTty.
I think this behaviour should be documented in the man page. And maybe even
Hi,
On 21-01-15 18:21, Jonathan Dieter wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=1183654
Signed-off-by: Jonathan Dieter jdie...@lesbg.com
Thanks looks good now:
Reviewed-by: Hans de Goede hdego...@redhat.com
Keith can you pick this up, or do you want me to prepare a tree
Hi,
On 19-01-15 16:02, Jonathan Dieter wrote:
Currently xorg ignores the seat assignments for drm devices because the devices
are initialized earlier in the code. Depending on race conditions, the first X
server will get more than one of the drm devices, which breaks multiseat
systems.
Hi,
The entire set looks good to me and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
On 19-01-15 19:41, Alan Coopersmith wrote:
Help catch errors like missing prototypes in makestrs sooner.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
configure.ac
no side effects other then setting xf86Info.vtno and keepTty.
Note this basically only moves a large chunk of xf86OpenConsole() into
linux_get_vtno() without changing a single line of it, this is hard to see
in the diff because the identation level has changed.
Signed-off-by: Hans de Goede hdego
,
requiring ssh access to the system to kill X.
The fix for this is easy, we must not use systemd-logind integration when
not using KeepTty, or iow we may only use systemd-logind integration together
with KeepTty.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/xfree86/os-support/linux/systemd
explicitly tell
the xserver to not detach when we're telling it to run on the current tty.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1177513
Signed-off-by: Hans de Goede hdego...@redhat.com
---
startx.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/startx.cpp b/startx.cpp
allocated at line 154.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
transSet.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/transSet.c b/transSet.c
index 9938e79..04c40e4
at line 731.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
xcmsdb.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/xcmsdb.c b/xcmsdb.c
index
de Goede hdego...@redhat.com
Regards,
Hans
---
xsetroot.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/xsetroot.c b/xsetroot.c
index 56ce741..5f142e1 100644
--- a/xsetroot.c
+++ b/xsetroot.c
@@ -331,10 +331,13 @@ FixupState(void)
return
journalctl _COMM=Xorg
works universally, regardless of whether the wrapper is used or not.
CC: Hans de Goede hdego...@redhat.com
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Keith Packard kei...@keithp.com
Looks good:
Acked-by: Hans de Goede hdego...@redhat.com
Regards
Hi,
On 29-12-14 00:57, Peter Hutterer wrote:
On Thu, Dec 25, 2014 at 02:21:04PM -0800, Keith Packard wrote:
Peter Hutterer peter.hutte...@who-t.net writes:
true, both changed locally
Did I miss a patch/pull request with this change included?
Haven't sent one yet, I wanted to wait for
Hi,
On 07-12-14 23:42, Peter Hutterer wrote:
On Fri, Dec 05, 2014 at 02:21:15PM +0100, Hans de Goede wrote:
Hi Peter,
Thanks for working on this!
On 12/02/2014 06:01 AM, Peter Hutterer wrote:
libinput's device handling and server-side fd handling are a bit of a
mismatch, so this is hackier
do have one small nitpick, as it currently stands this patch
adds an unchecked calloc as well as an unchecked strdup (both in fd_push),
please
fix that. I'm fine with just using the xnf variants (assuming those are exported
to drivers). With that fixed this is:
Reviewed-by: Hans de Goede hdego
Hi,
Series looks good and is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
On 11/06/2014 03:05 AM, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/OS.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi,
On 11/06/2014 03:26 AM, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/AsciiSrc.c | 15 ---
src/MultiSrc.c | 16
2 files changed
bitmask to EVTYPEMASK.
Reported-by: Gabriel Laskar gabr...@lse.epita.fr
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
specs/XI2proto.txt | 12 ++--
1 file changed, 6 insertions(+), 6 deletions
Hi,
On 08/26/2014 03:21 AM, Alan Coopersmith wrote:
Missed when the code was updated in commit eb9a8904fbef61a57ff0.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Looks good, series is:
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
doc/xtrans.xml |2
on #xorg-devel irc
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Looks good:
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
COPYING |2 +-
map-JISX0201.1976-0 | 42 ++
2 files changed, 27 insertions(+), 17
-mogidascruzes.sp.gov.br
Code looks good to me and is:
Acked-by: Hans de Goede hdego...@redhat.com
I think this should get a second look by someone more familiar with the Xau code
though, so I'll leave merging this up to someone else.
Regards,
Hans
---
AuGetAddr.c
(most of) an encoding before adding a line for that
encoding to fonts.scale, and the hole not properly being undefined causes
this check to fail for atleast the Sazanami fonts.
Cc: Akira TAGOH ta...@redhat.com
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1009350
Signed-off-by: Hans de Goede
kernel device name, fix comment.
Signed-off-by: Thomas Hellstrom thellst...@vmware.com
Reviewed-by: Brian Paul bri...@vmware.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
configure.ac | 14 +++
tools/Makefile.am | 7 +++-
tools
Hi Éric
On 09/29/2014 10:57 PM, Éric Brunet wrote:
Hi!
ok, this patch looked good at first, so I applied it locally.
Unfortunately, it breaks a couple of tests in XIT, specifically
EvdevMixedDeviceTest.AbsXYAndRelScroll/*.
[...]
Ouch... I am summarizing, to be sure I understood:
snip
Hi,
On 09/26/2014 09:06 AM, Thomas Hellstrom wrote:
Hi!
On 09/26/2014 03:36 AM, Peter Hutterer wrote:
On Wed, Sep 24, 2014 at 11:12:50AM +0200, Thomas Hellstrom wrote:
While looking at a vmmouse kernel driver, I wonder how the Xorg evdev
driver can be configured to receive both absolute
Hi,
On 09/24/2014 09:23 PM, Felix Miata wrote:
Laércio de Sousa wrote on 2014-09-23 08:05 (GMT-0300):
2014-09-23 3:37 GMT-03:00 Jasper St. Pierre composed:
Felix Miata wrote:
xorg-x11-drv-sis seems to have disappeared. Did that happen on purpose? It
still exists as a selelection in
that limit, reset
it to 0/0.
On devices without resolution, use 0.25 the touchpad's diagonal instead.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good to me:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
See the git repo below for a simple script
-off-by: Keith Packard kei...@keithp.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
configure.ac| 20
include/dix-config.h.in | 9 +
man/Xserver.man | 7 +++
os/utils.c | 29
globals
Pass files to cpp via CLI arg instead of stdin to workaround gcc 4.8
change
configure: Drop AM_MAINTAINER_MODE
autogen.sh: Honor NOCONFIGURE=1
Brad Smith (1):
Remove hardcoded path to OpenSSL for OpenBSD
Hans de Goede (7):
Remove unixware / sco support
Hi,
On 09/12/2014 08:40 PM, Keith Packard wrote:
Hans de Goede hdego...@redhat.com writes:
This patch fixes this, I realize that this is a behavior change, and as such
may be a bit controversial, but I really believe that in this day and age
-nolisten tcp by default is the right thing to do
option to re-enable them later on.
Signed-off-by: Keith Packard kei...@keithp.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
Xtrans.c | 25 +
Xtrans.h | 4
2 files changed, 29 insertions(+)
diff --git a/Xtrans.c b/Xtrans.c
.
Signed-off-by: Keith Packard kei...@keithp.com
We should probably put a #ifdef __linux__ around the
unix in the defaultNoListenList, other then that this
looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
os/utils.c | 21 +
1 file changed
Hi,
On 09/13/2014 08:00 PM, Keith Packard wrote:
Hans de Goede hdego...@redhat.com writes:
Signed-off-by: Keith Packard kei...@keithp.com
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
I've pushed this to master. We'll need a release before we can use it in
the X server
Hi All,
After doing the 1.3.4 release yesterday, I've started working on updating the
Fedora packages to 1.3.4. While looking at our open bug list against xinit,
I found one bug which is not yet resolved in 1.3.4 .
This patch fixes this, I realize that this is a behavior change, and as such
may
Having servers started by startx listen on tcp by default is not a good idea
in this time and age. Pass -nolisten tcp by default, and add a special
-listen server option which can be used to disable this new default behavior.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
man/startx.man
Hi,
On 09/12/2014 11:12 AM, Mark Kettenis wrote:
From: Hans de Goede hdego...@redhat.com
Date: Fri, 12 Sep 2014 09:25:17 +0200
Hi All,
After doing the 1.3.4 release yesterday, I've started working on updating the
Fedora packages to 1.3.4. While looking at our open bug list against xinit
Hi,
On 09/12/2014 02:11 PM, Laurent Bigonville wrote:
Le Fri, 12 Sep 2014 09:25:17 +0200,
Hans de Goede hdego...@redhat.com a écrit :
Hi All,
Hello,
After doing the 1.3.4 release yesterday, I've started working on
updating the Fedora packages to 1.3.4. While looking at our open bug
Hi,
On 09/12/2014 03:46 PM, Mark Kettenis wrote:
Date: Fri, 12 Sep 2014 12:17:24 +0200
From: Hans de Goede hdego...@redhat.com
Hi,
On 09/12/2014 11:12 AM, Mark Kettenis wrote:
From: Hans de Goede hdego...@redhat.com
Date: Fri, 12 Sep 2014 09:25:17 +0200
Hi All,
After doing the 1.3.4
Hi,
On 09/12/2014 04:40 PM, Mateusz Jończyk wrote:
W dniu 12.09.2014 o 09:25, Hans de Goede pisze:
Having servers started by startx listen on tcp by default is not a good idea
in this time and age. Pass -nolisten tcp by default, and add a special
-listen server option which can be used
globals
Pass files to cpp via CLI arg instead of stdin to workaround gcc 4.8
change
configure: Drop AM_MAINTAINER_MODE
autogen.sh: Honor NOCONFIGURE=1
Brad Smith (1):
Remove hardcoded path to OpenSSL for OpenBSD
Hans de Goede (7):
Remove unixware / sco support
Hi,
On 09/09/2014 12:12 AM, Julien Cristau wrote:
On Sat, Sep 6, 2014 at 10:14:29 +0200, Hans de Goede wrote:
Hi All,
When the support for automatically loading drivers for non-PCI devices
landed in 1.16, these 2 patches were missed, and without these 2 patches
the non-PCI device support
Hi poma,
On 09/05/2014 11:19 PM, poma wrote:
...
- xorg-x11-server-Xorg-1.16.99.1-1.fc21.x86_64
commit 3a51418
*auto-detection* PASSED
- xorg-x11-server-Xorg-1.16.99.1-2.fc21.x86_64
commit 3a51418 + xorg-non-pci-v2.patch[1] (rebased xorg-non-pci.patch)
*auto-detection* BROKEN
Clark robdcl...@gmail.com
Tested-by: Rob Clark robdcl...@gmail.com
Signed-off-by: Keith Packard kei...@keithp.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/xfree86/common/xf86Bus.c | 3 +++
hw/xfree86/common/xf86platformBus.c | 17 +
hw/xfree86/common
...@gmail.com
Signed-off-by: Keith Packard kei...@keithp.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/xfree86/common/xf86platformBus.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/xfree86/common/xf86platformBus.c
b/hw/xfree86/common/xf86platformBus.c
index
Hi All,
When the support for automatically loading drivers for non-PCI devices
landed in 1.16, these 2 patches were missed, and without these 2 patches
the non-PCI device support does not work.
This is a straight cherry pick from master, with one compile error due to
1.16 not having syspath
.
The whole issue is further enhanced by us unconditionally setting the timer
func if we get any events, which is a separate issue anyway.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
src/eventcomm.c | 13
Hi All,
I know I send this same a couple of months ago as well, and then did
nothing (as I got burried on other work), but this time I really do
plan to do a new release soon :)
Starting the X-server as non root through startx on Linux requires some
startx changes, which are now all in place. As
https://bugs.freedesktop.org/show_bug.cgi?id=83019
Signed-off-by: Hans de Goede hdego...@redhat.com
---
startx.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/startx.cpp b/startx.cpp
index 5dafce7..1c6fce0 100644
--- a/startx.cpp
+++ b/startx.cpp
@@ -191,7 +191,7
.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Looks good, thanks.
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
conf/50-synaptics.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf/50-synaptics.conf b/conf/50-synaptics.conf
index
n);
^
This is caused by HAVE_STRNDUP not being set (it is set from xorg-server.h),
causing os.h to redefine it.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
configure.ac | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 101ca17
drivers won't get
surprised by the semantic differences between the APIs.
Both patches look good to me and are:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
Hi,
On 07/15/2014 01:19 AM, Keith Packard wrote:
Hans de Goede hdego...@redhat.com writes:
Note the robustness patch needs to be applied after the fix, otherwise
the switch-case in the fix will fail to compile due to a duplicate
label.
This is better than my version as it effectively
Hi,
On 07/14/2014 03:41 PM, Daniel Stone wrote:
Hi,
On 14 July 2014 13:51, Hans de Goede hdego...@redhat.com wrote:
On 07/14/2014 02:43 PM, Julien Cristau wrote:
On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote:
Can I / we please get a reply from you on this ?
As explained
Hi,
On 07/15/2014 10:42 AM, Hans de Goede wrote:
snip
It might not be strictly harmful in some cases, but it's not the sort of
thing I want to encourage. 'Always include xorg-server.h before any X
header ever' is a really simple rule to remember for driver developers;
muddying the water
Hi,
On 07/15/2014 11:33 AM, Keith Packard wrote:
Hans de Goede hdego...@redhat.com writes:
1) I was not around when the OdevAttributes stuff got added, but I
think the idea behind it was to be able to add new atrributes without
breaking ABI (as was done this cycle when adding the driver
Hi Keith,
Here is a v2 of my odev-attrribute fix patch. The actual patch itself is
unchanged. New is the second patch which makes the api robust against storing
an int in a string attribute or vice versa.
Note the robustness patch needs to be applied after the fix, otherwise
the switch-case in
401 - 500 of 802 matches
Mail list logo
