[ANNOUNCE] libdrm 2.4.98

memcpy draw test tests/amdgpu: minor fix for dispatch/draw test Emil Velikov (4): xf86drm: fallback to MODALIAS for OF less platform devices xf85drm: de-duplicate drmParse{Platform.Host1x}{Bus,Device}Info Revert "libdrm: Fix issue about differrent domainID but sam

Re: frustrated by gitlab - where is the release history?

On Thu, 28 Feb 2019 at 08:18, Felix Miata wrote: > > https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/ has what I'm > looking for for the Intel > DDX. I would like to find whatever corresponds to it for the server, which on > opensuse seems to be > called xorg-x11-server. URL in its

[ANNOUNCE] libdrm 2.4.95

Emil Velikov (9): xf86drm: fallback to normal path when realpath fails intel: annotate the intel genx helpers as private automake: set NM before running the tests *-symbols-check: error out when using unset variables gitlab-ci: pass the correct toggles to configure

Re: WebKit failing to find GLXFBConfig, confusion around fbconfigs + swrast

Hi Daniel, On 27 August 2018 at 09:07, Daniel Drake wrote: > Questions: > > 1. What should webkit be doing in event of it not being to find a > GLXFBConfig that corresponds to the X visual of it's window? > > Attempt another config that user(webkit) knows how to work with? > 2. Why is swrast

Re: [PATCH xf86-video-sis] Minor adjustment to the compilation order

Hi Kevin, Jfyi: the original seems to align with $LC_ALL=C ls | sort Must admit that sorting tends to be a bit annoying, so personally I try to stick with the command ;-) HTH Emil ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver] glamor_egl: request GL2.1 when requesting Desktop GL context

On 21 August 2018 at 17:01, Icenowy Zheng wrote: > Some devices cannot support OpenGL 2.1, which is the minimum desktop GL > version required by glamor. However, they may support OpenGL ES 2.0, > which is the GLES version required by glamor. Usually in this situation > the desktop GL version

Re: gitlab group permissions update

Hi Adan, On 20 August 2018 at 20:17, Adam Jackson wrote: > gitlab groups are recursive, which means if you are a member of the > 'xorg' group, your permission level for every project in that group is > at least as high as your permission at the top level. Most of the > existing accounts were set

Re: 4K@60 YCbCr420 missing mode in usermode

On 27 June 2018 at 09:40, Michel Dänzer wrote: > On 2018-06-26 07:11 PM, Emil Velikov wrote: >> On 26 June 2018 at 17:23, Michel Dänzer wrote: >>> On 2018-06-26 05:43 PM, Emil Velikov wrote: >>>> On 25 June 2018 at 22:45, Zuo, Jerry wrote: >>>>> Hell

Re: 4K@60 YCbCr420 missing mode in usermode

On 26 June 2018 at 17:23, Michel Dänzer wrote: > On 2018-06-26 05:43 PM, Emil Velikov wrote: >> Hi Jerry, >> >> On 25 June 2018 at 22:45, Zuo, Jerry wrote: >>> Hello all: >>> >>> >>> >>> We are working on an issue affecting 4K@6

Re: [PATCH] Improve the ButtonInfo description.

On 8 June 2018 at 01:59, Peter Hutterer wrote: > On Thu, Jun 07, 2018 at 03:32:08AM +0200, Roman Kapl wrote: >> It failed to mention it is followed by a bit-mask and then the atoms. >> >> Signed-off-by: Roman Kapl >> --- >> include/X11/extensions/XI2proto.h | 5 +++-- >> 1 file changed, 3

Re: 4K@60 YCbCr420 missing mode in usermode

Hi Jerry, On 25 June 2018 at 22:45, Zuo, Jerry wrote: > Hello all: > > > > We are working on an issue affecting 4K@60 HDMI display not to light up, but > only showing up 4K@30 from: > https://bugs.freedesktop.org/show_bug.cgi?id=106959 and others. > > > > Some displays (e.g., ASUS PA328) HDMI

Re: [PATCH xf86-video-savage] Add check for max[HV]Value to ValidMode hook

f-by: Stefan Dirsch Reviewed-by: Emil Velikov I'll push this shortly. Although if you'd like to address the other drivers, that'll be appreciated. Thanks Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH xf86-video-r128] Include in order to declare uint32_t

On 25 June 2018 at 14:57, Stefan Dirsch wrote: > Apparently this is needed in src/atipcirename.h since xorg-server > 1.20 in order to still build this driver. > > Signed-off-by: Stefan Dirsch Trivial - reviewed and pushed it to master. Thanks Emil ___

Re: [PATCH xserver] : bug 106963 : change the DPMS initialization to be conditional on not set from config

later stage. > Cheers, John > > From: John Lumby > Sent: June 19, 2018 3:29 PM > To: xorg-devel@lists.x.org > Cc: Emil Velikov > Subject: Re: [PATCH xserver] : bug 106963 : change the DPMS initialization > to be conditional on not set from c

Re: [PATCH] release: fix mesa url detection after migration to gitlab

On 19 June 2018 at 16:37, Dylan Baker wrote: > Quoting Dylan Baker (2018-06-15 14:12:55) >> Mesa's migration to gitlab has changed the URL and made things not work. >> --- >> release.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/release.sh b/release.sh >> index

Re: [PATCH xserver] : bug 106963 : change the DPMS initialization to be conditional on not set from config

Hi John, On 19 June 2018 at 16:16, John Lumby wrote: > > --- xorg/xserver/Xext/dpms.c.orig 2018-06-16 18:54:24.520660890 -0400 > +++ xorg/xserver/Xext/dpms.c2018-06-18 11:09:19.021529381 -0400 > @@ -45,9 +45,9 @@ Equipment Corporation. > > CARD16 DPMSPowerLevel = 0; > Bool

Re: [PATCH xorgproto 1/2] Remove the use of no-op B16 & B32 bitfield macros in headers

ibX11 lib/libxkbfile mesa/drm mesa/mesa - dri1, appledri, windowsdri copies xserver - same as mesa >> Signed-off-by: Alan Coopersmith > > Acked-by: Keith Packard > Reviewed-by: Emil Velikov HTH Emil ___ xorg-devel@lists.x.org: X

Re: [PATCH] release: fix mesa url detection after migration to gitlab

On 15 June 2018 at 22:12, Dylan Baker wrote: > Mesa's migration to gitlab has changed the URL and made things not work. Thanks for the fixup Dylan. Reviewed-by: Emil Velikov -Emil ___ xorg-devel@lists.x.org: X.Org development Archives: h

Re: [PATCH xserver 0/2] xwayland: couple of EGL backend API cleanup

? If the former, that should be addressed. You have done some serious work on Xwayland. That said, the series is Reviewed-by: Emil Velikov -Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 10/10] xwayland: EGL_IMG_context_priority required by EGLStream

On 5 June 2018 at 18:38, Olivier Fourdan wrote: > xwl_glamor_eglstream_init_egl() uses "EGL_IMG_context_priority" > extension, make sure it's actually available before using it. > > Suggested-by: Emil Velikov > Signed-off-by: Olivier Fourdan > --- > hw/xwayland/

Re: [PATCH xserver 5/5] xwayland: refactor egl_backends for wayland registry

On 5 June 2018 at 18:28, Olivier Fourdan wrote: > Hi Emil, > > Many thanks for your detailed review! > > On Tue, Jun 5, 2018 at 12:37 PM, Emil Velikov > wrote: >> Hi Olivier, >> >> There's a handful of mostly trivial suggestions below. The idea itself

Re: [PATCH xserver 1/5] xwayland: Allow "-eglstream" option

On 4 June 2018 at 15:37, Olivier Fourdan wrote: > Hi > > On 4 June 2018 at 16:24, Emil Velikov wrote: >> >> On 24 May 2018 at 15:10, Olivier Fourdan wrote: >> > The command line option "-eglstream" used to enable EGLi stream support >> > for

Re: [PATCH xserver 5/5] xwayland: refactor egl_backends for wayland registry

Hi Olivier, There's a handful of mostly trivial suggestions below. The idea itself seems reasonable IMHO. One gripe is that we're 'leaking' twice as much as before. Namely: even if the current backend cleans-up after itself (it some cases it does not), the other backend 'leaks'. Not sure if/how

Re: [PATCH xserver 3/5] xwayland: Add Wayland interfaces check

On 1 June 2018 at 15:31, Olivier Fourdan wrote: > +static Bool > +xwl_glamor_gbm_has_wl_interfaces(struct xwl_screen *xwl_screen) > +{ > +struct xwl_gbm_private *xwl_gbm = xwl_gbm_get(xwl_screen); > + > +if (xwl_gbm->drm == NULL) { > +ErrorF("glamor: 'wl_drm' not supported\n"); >

Re: [PATCH xserver 2/5] xwayland: move egl_backend to its own struct

On 1 June 2018 at 15:31, Olivier Fourdan wrote: > EGL backend availability requires both EGL extensions and Wayland > interfaces to be present, so we will need to consider multiple backends > during initialization. > > As a preliminary work, move the egl_backend to its own struct so that we > can

Re: [PATCH xserver 5/5] xwayland: small xdg_output cleanup

On 24 May 2018 at 15:11, Olivier Fourdan wrote: > Make xwl_output_get_xdg_output() private, it doesn't need to be > available elsewhere. > s/small xdg_output cleanup/make xwl_output_get_xdg_output static/ With this and the nitpicks in 1/5 + 3/5 nitpicks the series is Reviewed-by: Emi

Re: [PATCH xserver 3/5] xwayland: process Wayland events after adding screen

On 24 May 2018 at 15:11, Olivier Fourdan wrote: > When we're done adding a new screen, we need to process pending Wayland > events again so that we don't end up processing xdg_output events when > unexpected if glamor is disabled (either becauase "-shm" was passed or > because "-eglstream"

Re: [PATCH xserver 1/5] xwayland: Allow "-eglstream" option

On 24 May 2018 at 15:10, Olivier Fourdan wrote: > The command line option "-eglstream" used to enable EGLi stream support > for NVidia GPU was made available only when Xwayland was built with EGL > stream support enabled. > > Wayland compositors who spawn Xwayland have no easy way to tell whether

Re: [PATCH xserver] glamor: Work around GEM usage

On 23 May 2018 at 22:23, Mark Kettenis wrote: >> From: Thomas Hellstrom >> Date: Wed, 23 May 2018 22:58:05 +0200 >> >> On 05/23/2018 08:00 PM, Adam Jackson wrote: >> > On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: >> >> KMS drivers are

Re: [PATCH xserver 2/2] glamor: Propagate glamor_fds_from_pixmap error in glamor_fd_from_pixmap

atch, plus is reads easier on my end ;-) -if (ret > 1) { +if (ret != 1 || offsets[0] != 0) { Regardless, the series is on point and is Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil ___ xorg-devel@lists.x.org: X.Org devel

Re: [PATCH xserver 2/4] dri3: Robustly clamp to 1.0 if not all screens support 1.2

On 30 April 2018 at 08:06, Mario Kleiner wrote: > Checking for dri3_screen_info_rec.version >= 2 is insufficient, > as some shipping drivers, e.g., intel-ddx, nouveau-ddx, set the > version to DRI3_SCREEN_INFO_VERSION, ie. to whatever version the > installed servers

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

On 24 April 2018 at 20:14, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > On Tue, Apr 24, 2018 at 7:30 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 13 April 2018 at 11:00, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: >>> This tries to

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

On 13 April 2018 at 11:00, Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > > We also tend to not revoke commit rights for people no

[PATCH xserver] configure.ac: make use of wayland-scanner.pc

From: Emil Velikov <emil.veli...@collabora.com> Replace the current (incorrect) assumption that wayland-scanner is located in the wayland-client prefix. Make use of the wayland_scanner variable in wayland-scanner.pc It was introduced back in 2013 and we already require newer wayland bits

Re: [PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

On 6 April 2018 at 12:26, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 6 April 2018 at 12:18, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 4 April 2018 at 19:51, Adam Jackson <a...@nwnk.net> wrote: >>> This, combined with 10/15,

Re: [PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

On 4 April 2018 at 19:51, Adam Jackson <a...@nwnk.net> wrote: > On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Currently depending on the code path hit, the helper will set some of >> the outpu

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

On 5 April 2018 at 19:06, Mike Lothian wrote: > Nope still not working > > Intel DDX didn't launch, Modesetting did however compositing was disabled > due to the previous failure. Upon reenabling the screen went blank, however > things were still running, when I went to the

Re: [PATCH xserver 0/8] GCC8 warning fixes

rivial suggestions but the most notable one is the foobar snprintf statement in 2/8 With the last one tweaked (regardless of the remaining nitpicks) patches 1-3 and 5-8 are Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Note 4/8 needs some rework. HTH Emil __

Re: [PATCH xserver 6/8] xkb: Silence some compiler warnings

On 5 April 2018 at 18:13, Adam Jackson wrote: > Of the form: > > ../xkb/XKBGAlloc.c: In function ‘SrvXkbAddGeomKeyAlias’: > ../xkb/XKBGAlloc.c:591:13: warning: ‘strncpy’ specified bound 4 equals > destination size [-Wstringop-truncation] > strncpy(alias->real,

Re: [PATCH xserver 5/8] dmx: Silence a string truncation warning.

On 5 April 2018 at 18:13, Adam Jackson wrote: > ../hw/dmx/config/dmxparse.c: In function ‘dmxConfigCreateOption’: > ../hw/dmx/config/dmxparse.c:385:13: warning: ‘strncpy’ output truncated > before terminating nul copying as many bytes from a string as its length >

Re: [PATCH xserver 4/8] dmx: Clean up some argument parsing code

On 5 April 2018 at 18:13, Adam Jackson wrote: > This threw: > > ../hw/dmx/input/dmxarg.c: In function ‘dmxArgParse’: > ../hw/dmx/input/dmxarg.c:128:5: warning: ‘strncpy’ specified bound depends on > the length of the source argument [-Wstringop-overflow=] > strncpy(tmp,

Re: [PATCH xserver 3/8] dmx: Fix a read-from-uninitialized warning

On 5 April 2018 at 18:13, Adam Jackson wrote: > ../hw/dmx/dmxpixmap.c: In function ‘dmxBitmapToRegion’: > ../include/regionstr.h:174:22: warning: ‘Box.x1’ may be used uninitialized in > this function [-Wmaybe-uninitialized] > (_pReg)->extents = *(_pBox); >

Re: [PATCH xserver 2/8] dmx: Fix some snprintf warnings.

On 6 April 2018 at 09:44, Peter Hutterer wrote: > On Thu, Apr 05, 2018 at 01:13:55PM -0400, Adam Jackson wrote: >> snprintf doesn't terminate the string if it truncates, so things like >> this are lurking crashers: > > it doesn't? which platforms is that on? Apparently

Re: [PATCH xserver] xwayland: Silence a build warning if we can

>> hw/xwayland/Makefile.am | 14 +++--- >> hw/xwayland/meson.build | 9 - >> 3 files changed, 19 insertions(+), 8 deletions(-) >> > > Hi, > > I only read through the patch, and it looks quite ok to me, so: > Reviewed-by: Pekka Paalanen <pe

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

:24:21 2018 +0100 > > present: Advertise protocol version 1.2 > > Everything is implemented to support protocol version 1.2. Make it > official. > > Reviewed-by: Daniel Stone <dani...@collabora.com> > Signed-off-by: Thierry Reding <tred...@nvidi

Re: [PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

On 2 April 2018 at 20:34, Adam Jackson <a...@redhat.com> wrote: > On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: > >> Why do we have the explicit _rec and _ptr typecasts to begin with? > > Convention, mostly. The typedef for the struct is because 'struct' is a &g

[PATCH xserver 2/2] docs: remove resource management references

From: Emil Velikov <emil.veli...@collabora.com> The code referenced was removed back in 2009. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- hw/xfree86/doc/ddxDesign.xml | 168 --- 1 file changed, 168 deletions(-) diff --git

[PATCH xserver 1/2] docs: purge some Isa references

From: Emil Velikov <emil.veli...@collabora.com> The respective Isa functions were dropped back in 2008 Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- hw/xfree86/doc/ddxDesign.xml | 89 +--- 1 file changed, 2 insertions(+),

[PATCH xserver 14/15] dri3: s/intersect/window/ to match the names used in caller

From: Emil Velikov <emil.veli...@collabora.com> Cc: Louis-Francis Ratté-Boulianne <l...@collabora.com> Cc: Daniel Stone <dani...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- dri3/dri3_screen.c | 30 +++--- 1 fil

[PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

From: Emil Velikov <emil.veli...@collabora.com> Currently depending on the code path hit, the helper will set some of the output values and not others. It could also leak memory ;-) At the same time the caller was: - working around the broken behaviour - by initialising the var

[PATCH xserver 13/15] dri3: rework format/modifier caching

From: Emil Velikov <emil.veli...@collabora.com> Cut down the unnecessary malloc/memcpy/free by utilising the explicit copy provided by the client. But above all: do so, after ensuring we get valid data from the implementation. Fixes: cef12efc15c ("glamor: Implement GetSupportedMod

[PATCH xserver 07/15] xwayland: zero num_modifiers from the start

From: Emil Velikov <emil.veli...@collabora.com> The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers&

[PATCH xserver 12/15] glamor: zero num_formats from the start

From: Emil Velikov <emil.veli...@collabora.com> The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers&

[PATCH xserver 06/15] dri3: use designated initializers for {s, }proc_dri3_vector

From: Emil Velikov <emil.veli...@collabora.com> Cc: Louis-Francis Ratté-Boulianne <l...@collabora.com> Cc: Daniel Stone <dani...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Seems like the underscore went missing with v1.2? ---

[PATCH xserver 04/15] dri3: simplify dri3_open() implementation

From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- dri3/dri3_screen.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c index f5e87bc9e..628f

[PATCH xserver 05/15] dri3: annotate {s, }proc_dri3_vector as static const

From: Emil Velikov <emil.veli...@collabora.com> Read-only data, used only locally. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- dri3/dri3_request.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dri3/dri3_request.c b/dri3/dri3_req

[PATCH xserver 10/15] dri3: return BadImplementation when missing ::get_{formats, modifiers}

From: Emil Velikov <emil.veli...@collabora.com> If the implementations is missing the required functionality simply return BadImplementation. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc: Louis-Francis Ratté-Boulianne <l...@collabora.com>

[PATCH xserver 03/15] dri3: annotate fds/strides/offsets arrays as const

From: Emil Velikov <emil.veli...@collabora.com> It makes it perfectly clear that we should not be modifying them. Should help highlight issues like the one fixed with previous commit. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc: Louis-Francis Ra

[PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

From: Emil Velikov <emil.veli...@collabora.com> dri3_screen_info is the user provide dispatch. Something that we do not and should not change. When using the _ptr typecast + const the compiler barfs at us (rightfully so), so use the _rec one. Fixes: 56313829886 ("dri3: Add DRI3 ext

[PATCH xserver 02/15] xwayland: don't close() fds we don't own

From: Emil Velikov <emil.veli...@collabora.com> The glamor_pixmap_from_fds error path erroneously closes the fds. We don't own them, plus the caller closes them after the function in called. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc: Louis-Francis Ra

[PATCH xserver 09/15] dri3: check for ::get_drawable_modifiers failure

From: Emil Velikov <emil.veli...@collabora.com> Currently if the function fails, we'll fall into two false assumptions: - the the count is zero - that the storage pointer is safe for free() I've just fixed the former (in glamore + xwayland) and have no plans on adding yet another work

[PATCH xserver 11/15] xwayland: zero num_formats from the start

From: Emil Velikov <emil.veli...@collabora.com> The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers&

[PATCH xserver 08/15] glamor: zero num_modifiers from the start

From: Emil Velikov <emil.veli...@collabora.com> The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers&

Re: [PATCH xserver 2/2] glamor: Hide new DRI for behind Option "Debug" "dmabuf_capable"

On 28 March 2018 at 17:46, Adam Jackson wrote: > ... for xfree86, at least for now. Things appear to work for Xwayland > but not yet for modesetting. Hopefully we can fix that before 1.20 but > in the meantime this makes testing both paths easier than a rebuild. > >

Re: [PATCH xserver 3/3] modesetting/drmmode: Use drmModeGetFB2

pers? > +break; > +case DRM_FORMAT_XRGB: > +depth = 24; > +bpp = 32; > +break; > +case DRM_FORMAT_XRGB2101010: > +depth = 30; > +bpp = 32; > + default: > +break; Err

Re: [PATCH xserver 2/3] modesetting/drmmode: Use glamor_pixmap_from_fds

t;fd, handles[i], O_CLOEXEC, > [i]); > + if (err != 0) > +return 0; Close the existing fds ones on error? With the fd leak plugged (regardless of the nit) Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Aside: there's plenty of duplication in the

Re: [PATCH xserver 1/3] modesetting/drmmode: Remove unused flink call

cs were removed and codepath was enabled with commit caabc4e8554 ("modesetting: add support for background none.") Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists

Re: [PATCH xserver] modesetting: Fix up some XXX from removing GLAMOR_HAS_DRM_*

Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Thanks! Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/5] configure: remove libdrm version check

On 21 March 2018 at 14:12, Adam Jackson <a...@nwnk.net> wrote: > On Tue, 2018-03-20 at 16:41 +0000, Emil Velikov wrote: > >> Humble ping? >> >> Patch 2 might need a respin based on the feedback from Daniel/Louis. >> Although the rest of the series should

Re: [PATCH xserver] present: cap the version returned to the client

On 21 March 2018 at 08:02, Julien Cristau <jcris...@debian.org> wrote: > On Mon, Mar 19, 2018 at 16:04:43 +0000, Emil Velikov wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> As per the protocol, the server should not return version greater tha

Re: [PATCH xserver 1/5] configure: remove libdrm version check

On 7 March 2018 at 18:45, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > We already require said version. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 3 +-- > 1

Re: [PATCH xserver] dri3: cap the version returned to the client

On 19 March 2018 at 19:59, Adam Jackson <a...@nwnk.net> wrote: > On Mon, 2018-03-19 at 12:04 +0000, Emil Velikov wrote: >> On 13 March 2018 at 18:38, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> > From: Emil Velikov <emil.veli...@collabora.com> >> >

Re: [PATCH] present: Advertise protocol version 1.2

gt; Signed-off-by: Thierry Reding <tred...@nvidia.com> Yes, please. Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] present: cap the version returned to the client

From: Emil Velikov <emil.veli...@collabora.com> As per the protocol, the server should not return version greater than the one supported by the client. Add a spec quote and tweak the numbers accordingly. Fixes: 5c5c1b77982 ("present: Add Present extension") Cc: Thie

Re: [PATCH xserver 2/3] modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD

On 19 March 2018 at 15:43, Alan Coopersmith <alan.coopersm...@oracle.com> wrote: > On 03/19/18 06:33 AM, Emil Velikov wrote: >> On 15 March 2018 at 18:33, Adam Jackson <a...@redhat.com> wrote: >>> On Wed, 2018-03-14 at 21:48 +0100, Thomas Klausner wrote: >>&

Re: [PATCH xserver 2/3] modesetting: Remove #ifdefs XF86_PDEV_SERVER_FD

On 15 March 2018 at 18:33, Adam Jackson wrote: > On Wed, 2018-03-14 at 21:48 +0100, Thomas Klausner wrote: >> On Wed, Mar 14, 2018 at 01:33:28PM -0700, Alan Coopersmith wrote: >> > On 03/14/18 01:01 PM, Thomas Klausner wrote: >> > > I see a build failure in

Re: [PATCH xserver] dri3: cap the version returned to the client

On 13 March 2018 at 18:38, Emil Velikov <emil.l.veli...@gmail.com> wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > As per the protocol, the server should not return version greater than > the one supported by the client. > > Add a spec quote and

Re: [PATCH xserver] build: Bump Mesa requirement to 17.1

On 14 March 2018 at 18:43, Adam Jackson wrote: > gbm_bo_get_modifier is new in 17.1, which is 10 months old and two > stable branches ago. > > Signed-off-by: Adam Jackson > --- > configure.ac| 2 +- > glx/meson.build | 4 ++-- > 2 files changed, 3

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

a_priv.h > @@ -244,7 +244,7 @@ extern DevPrivateKeyRec exaScreenPrivateKeyRec; > } > #else > #define swap(priv, real, mem) {\ > -void *tmp = priv->Saved##mem; \ > +const void *tmp = priv->Saved##mem; \ Hmm what compiler are you using - any clang/gcc should hit the

Re: [PATCH xserver v2 1/4] os: move xf86PrivsElevated here

> + Any particular reason why this is exported? Is it simply mimicking the surrounding code, or there's a genuine reason for it? Not an issue either way, the series is Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Somewhat unrelated: Seems like commit 49f77fff1495c0a2050fb18f9b1fc627

Re: [PATCH xserver v2 3/4] xfree86: replace all uses of xf86PrivsElevated with PrivsElevated

On 13 March 2018 at 21:46, Ben Crocker wrote: > -extern _X_EXPORT Bool > -xf86PrivsElevated(void); > FWIW, I cannot spot any external users of the symbol, so removing it should be fine. -Emil ___ xorg-devel@lists.x.org: X.Org

[PATCH xserver] dri3: cap the version returned to the client

From: Emil Velikov <emil.veli...@collabora.com> As per the protocol, the server should not return version greater than the one supported by the client. Add a spec quote and tweak the numbers accordingly. Fixes: 563138298868 ("dri3: Add DRI3 extension") Cc: Daniel Stone <da

Re: [PATCH xserver] meson: Require libdrm for dri1/2/3 when configured 'auto' as well as 'true'

> > Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

On 7 March 2018 at 20:10, Alan Coopersmith <alan.coopersm...@oracle.com> wrote: > On 03/ 7/18 05:36 AM, Emil Velikov wrote: >> Hi Alan, >> >> On 6 March 2018 at 21:47, Alan Coopersmith <alan.coopersm...@oracle.com> >> wrote: >>> Reported by gcc 7.

[PATCH xserver 2/5] Remove always true GLAMOR_HAS_DRM_* guards

From: Emil Velikov <emil.veli...@collabora.com> With earlier commit the required version was bumped to 2.4.89, thus the guards always evaluate to true. Fixes: e4e3447603b ("Add RandR leases with modesetting driver support [v6]") Cc: Keith Packard <kei...@keithp.com>

[PATCH xserver 3/5] modesetting: remove always true defined(DRM_CAP_PRIME) guards

From: Emil Velikov <emil.veli...@collabora.com> The macro was available in libdrm for ages. Furthermore having a guard like this is a very bad idea. Building on an old server will result in a missing run-time functionality. Since it's UABI one can use a local fallback, old kernels will

[PATCH xserver 5/5] modesetting: remove fallback DRM_CAP_* defines

From: Emil Velikov <emil.veli...@collabora.com> All the macros are available in the libdrm that we depend on. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- hw/xfree86/drivers/modesetting/driver.c | 8 hw/xfree86/drivers/modesetting/drmmode_d

[PATCH xserver 4/5] modesetting: remove always true DRM_IOCTL_CRTC_QUEUE_SEQUENCE guard

From: Emil Velikov <emil.veli...@collabora.com> We already require libdrm 2.4.89 which provides the definition plus guarding kernel UABI like that is generally a bad idea. See previous commit for details why :-) Cc: Keith Packard <kei...@keithp.com> Signed-off-by: Emil Veliko

[PATCH xserver 1/5] configure: remove libdrm version check

From: Emil Velikov <emil.veli...@collabora.com> We already require said version. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f82c0a66a..14fe

[PATCH xserver 1/5] configure: remove libdrm version check

From: Emil Velikov <emil.veli...@collabora.com> We already require said version. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f82c0a66a..14fe

Re: [PATCH:libX11] If XGetImage fails to create image, don't dereference it to bounds check

Hi Alan, On 6 March 2018 at 21:47, Alan Coopersmith wrote: > Reported by gcc 7.3: > > GetImage.c:110:25: warning: potential null pointer dereference > [-Wnull-dereference] > if (planes < 1 || image->height < 1 || image->bytes_per_line < 1 || >

Re: [PATCH xserver] Require libdrm 2.4.89 or newer

On 3 March 2018 at 01:05, Keith Packard wrote: > Both autotools and meson build systems had complicated logic around > what version of libdrm to require for various options. Remove that and > just check for a new enough version to support all of the options > which need libdrm.

Re: [PATCH util/modular] xorg.modules: Replace individual proto modules with xorgproto

On 1 March 2018 at 13:35, Jon Turney <jon.tur...@dronecode.org.uk> wrote: > On 28/02/2018 15:17, Emil Velikov wrote: >> >> On 28 February 2018 at 13:04, Jon Turney <jon.tur...@dronecode.org.uk> >> wrote: >>> >>> Signed-off-by: Jon Turney <j

Re: [PATCH util/modular] xorg.modules: Replace individual proto modules with xorgproto

,257 +338,13 @@ > + I'd say keep this as autotools and toggle as 2/2... > + +checkoutdir="xorg/proto/xorgproto"/> > > - > - > - > > - .. hence this hunk will stay as-is and drop util-macros with 2/2? It's fairly fiddly to have th

[PATCH xserver] protocol.txt: add GLX req. 35 - SetClientInfo2ARB

From: Emil Velikov <emil.veli...@collabora.com> Noticed while skimming for the typo'd version ;-) Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- dix/protocol.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/dix/protocol.txt b/dix/protocol.txt index 244556a0

Re: [PATCH util/modular v2] release.sh: Add support for mesa-demos

On 23 February 2018 at 14:13, Andreas Boll wrote: > v2: Rebase on Mesa cleanup. > Move demos into its own elif statement. > > Signed-off-by: Andreas Boll > --- > Rebased on https://patchwork.freedesktop.org/patch/206466/ > > release.sh

[PATCH util-modular] release.sh: remove workaround for early Mesa versions

From: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- release.sh | 14 -- 1 file changed, 14 deletions(-) diff --git a/release.sh b/release.sh index ff89d2e..99bd0c3 100755 --- a/release.sh +++ b/release.sh @@ -58

Re: [PATCH util/modular] release.sh: Add support for mesa-demos

On 23 February 2018 at 09:40, Andreas Boll wrote: > Signed-off-by: Andreas Boll > --- > release.sh | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) > > diff --git a/release.sh b/release.sh >

Re: [PATCH xserver 6/6] mi: Mention extension loading in verbose logs

On 21 February 2018 at 16:42, Adam Jackson <a...@nwnk.net> wrote: > On Mon, 2018-02-19 at 15:18 +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Listing the extensions is useful, despite being annoying for normal >> us

[PATCH xserver] mi: Mention extension loading in verbose logs

From: Emil Velikov <emil.veli...@collabora.com> Listing the extensions is useful, despite being annoying for normal usecases. Print it only when extra (lvl 3) vebose is requested. v2: Move the logging to InitExtensions(), as requested by Adam. Cc: Adam Jackson <a...@nwnk.net>

  1   2   3   4   5   6   >