Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Rémi Cardona
Le 30/11/2010 05:57, Alan Coopersmith a écrit : +#ifdef HAVE_VASPRINTF +# define Xvasprintf vasprintf +#endif No #else? Am I missing something? Other than that, the entire series looks good to me: Reviewed-by: Rémi Cardona r...@gentoo.org Cheers, Rémi

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dirk Wallenstein
On Sun, Nov 28, 2010 at 09:43:31AM -0800, Dan Nicholson wrote: Add a moduleset for the 7.6 katamari based on xorg.modules. This uses the module list from 7.6-rc1 with gzipped tarballs and sha1sums from announce emails (when available). Modules not included in the katamari have been removed.

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dirk Wallenstein
On Mon, Nov 29, 2010 at 09:46:20PM -0800, Alan Coopersmith wrote: Also, as far as dependencies go, if building documentation, then a lot of modules now depend on xorg-sgml-doctools for the xsl stylesheets, but I don't know if you can express conditional dependencies like that for jhbuild. The

Re: [PATCH 3/3] Fix compiler warnings in hw/xfree86/os-support/solaris

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:22:19 -0800, Alan Coopersmith wrote: sun_init.c: In function `xf86OpenConsole': sun_init.c:99: warning: cast does not match function type sun_init.c:74: warning: unused variable `FreeVTslot' sun_init.c: In function `xf86UseMsg': sun_init.c:417: warning: old-style

Re: [PATCH 01/11] xf86ValidateModes: xnfalloc(strlen) + strcpy = xnfstrdup

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:38 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/common/xf86Mode.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 02/11] xf86AutoConfig: make copyScreen memory allocation error handling more sane

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:39 -0800, Alan Coopersmith wrote: No point calling the no-fail-alloc if you check for failure and your only caller checks for failure. No point calling calloc to zero fill memory you're about to memcpy over. In the unlikely event of a loss of memory

Re: [PATCH 03/11] xf86VIDrvMsgVerb: print args, not format string

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:40 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/common/xf86Helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org Cheers, Julien

Re: [PATCH 04/11] FindModuleInSubdir: Stop allocating one more byte than needed

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:41 -0800, Alan Coopersmith wrote: 15ac25627e7239629be59 removed the / from the sprintf strings, but failed to remove the extra byte allocated for the '/'. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/loader/loadmod.c |6

Re: [PATCH 05/11] Simplify Error() - don't allocate temporary copy of error string

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:42 -0800, Alan Coopersmith wrote: Doesn't seem to be any reason to just not pass the error string as another argument directly to LogVWrite() Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- include/os.h |2 +- os/log.c | 19

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:43 -0800, Alan Coopersmith wrote: +/* Old api, now deprecated, may be removed in a future release */ +char * +Xvprintf(const char *format, va_list va) +{ +char *ret; + +Xvasprintf(ret, format, va); + return ret; } @@ -68,7 +191,7 @@ char

Re: [PATCH 08/11] Convert hw/xfree86/parser code to use Xasprintf() calls

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:45 -0800, Alan Coopersmith wrote: Requires linking xprintf.c into libxf86config for those who build it. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/parser/Flags.c | 13 - hw/xfree86/parser/Makefile.am |1 +

Re: [PATCH 09/11] Convert malloc+sprintf pairs into X*asprintf() calls

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:46 -0800, Alan Coopersmith wrote: diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c index 06d082b..751fec6 100644 --- a/hw/xfree86/loader/loadmod.c +++ b/hw/xfree86/loader/loadmod.c @@ -406,22 +406,22 @@ FindModuleInSubdir(const char

Re: [PATCH 10/11] Replace alloc+strcpy+strcat with Xasprintf calls

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:47 -0800, Alan Coopersmith wrote: diff --git a/dix/devices.c b/dix/devices.c index 708860a..db38c1a 100644 --- a/dix/devices.c +++ b/dix/devices.c @@ -2524,9 +2524,10 @@ AllocDevicePair (ClientPtr client, char* name, if (!pointer) return

Re: [PATCH 11/11] Convert cvt code to use Xasprintf() calls

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 20:57:48 -0800, Alan Coopersmith wrote: Requires linking xprintf.c into standalone cvt utility Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/modes/xf86cvt.c | 10 +- hw/xfree86/utils/cvt/Makefile.am |5 -

[PATCH keyboard] Small cleanup.

2010-11-30 Thread Alexandr Shadchin
Removed unnecessary code: case PCCONS: break; Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/bsd_kbd.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c index 35d3649..a3f6321

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dirk Wallenstein
I just needed the following mapping and thought that might be helpful here, too, as the modules-list.txt file uses package names: # A dictionary mapping package name to repo-basename as used on fd.o ModuleIdTranslation = { 'font-adobe-100dpi' : 'adobe-100dpi', 'font-adobe-75dpi' :

Re: Event for override-redirect change

2010-11-30 Thread Devin J. Pohly
On 11/29/2010 02:06 PM, Adam Jackson wrote: On Fri, 2010-11-26 at 23:33 -0500, Devin J. Pohly wrote: The override-redirect flag is important for a window manager to know about, but there's no notification made when a window changes it. It doesn't appear that the protocol specifies an action to

Re: Can we configure Xserver render with the FrameBuffer?

2010-11-30 Thread Leo
I‘ve already try the fbdev instead of the old one, but it does not work. what I want is to get rid of the transition animation, something like fade-in/fade-out, transparency I want to know which component controls this process? we're supposed to think it's related with fbdev driver,but it's not.

Re: [PATCH 00/11] Xasprintf() and other string-handling cleanups

2010-11-30 Thread Mikhail Gusarov
Twas brillig at 20:57:37 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC The meat of this series is sandwiched right in the middle - patch AC #6 replaces the nifty, but unique, Xprintf() API with a local AC implementation of the asprintf() family that's becoming

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Mikhail Gusarov
Twas brillig at 20:57:43 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC +#ifndef XPRINTF_H AC +#define XPRINTF_H AC + AC +#include stdarg.h AC +#include X11/Xfuncproto.h AC + AC +#ifndef _X_RESTRICT_KYWD AC +# if defined(restrict) /* assume autoconf set it

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dan Nicholson
On Tue, Nov 30, 2010 at 1:26 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Nov 28, 2010 at 09:43:31AM -0800, Dan Nicholson wrote: Add a moduleset for the 7.6 katamari based on xorg.modules. This uses the module list from 7.6-rc1 with gzipped tarballs and sha1sums from announce emails

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dan Nicholson
On Mon, Nov 29, 2010 at 9:46 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Dan Nicholson wrote: Add a moduleset for the 7.6 katamari based on xorg.modules. This uses the module list from 7.6-rc1 with gzipped tarballs and sha1sums from announce emails (when available). Modules not

Re: [PATCH v2 modular 2/2] release.sh: Update jhbuild moduleset with --moduleset

2010-11-30 Thread Dan Nicholson
On Mon, Nov 29, 2010 at 9:48 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Dan Nicholson wrote: In order to keep the katamari moduleset up to date with current tarball information, have release.sh update the file when new releases are made. This is enabled by passing a module file

Re: [PATCH 08/11] Convert hw/xfree86/parser code to use Xasprintf() calls

2010-11-30 Thread Matt Turner
On Tue, Nov 30, 2010 at 4:57 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Requires linking xprintf.c into libxf86config for those who build it. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---  hw/xfree86/parser/Flags.c     |   13 -  

Re: [PATCH 04/11] FindModuleInSubdir: Stop allocating one more byte than needed

2010-11-30 Thread Matt Turner
On Tue, Nov 30, 2010 at 4:57 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: 15ac25627e7239629be59 removed the / from the sprintf strings, but failed to remove the extra byte allocated for the '/'. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---  

Re: [PATCH] xfree86: Fix rotation of 2-color non-interleaved cursor images

2010-11-30 Thread Alex Deucher
On Mon, Nov 29, 2010 at 9:03 PM, Aaron Plattner aplatt...@nvidia.com wrote: Does anyone else want to review this, or are Robert's (@nvidia.com) Reviewed-by and Cyril's Tested-by sufficient? Looks good to me. Reviewed-by: Alex Deucher alexdeuc...@gmail.com On Tue, Nov 16, 2010 at 12:17:33PM

[PATCH keyboard] Removing unused code

2010-11-30 Thread Alexandr Shadchin
In OpenBSD removed support PCCONS in 2002 year http://marc.info/?l=openbsd-cvsm=102435816424294w=2 Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/bsd_KbdMap.c | 198 -- 1 files changed, 0 insertions(+), 198 deletions(-)

Re: [PATCH] dri2: Destroy buffer before reseting the private key

2010-11-30 Thread Rami Ylimäki
Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi On 11/26/2010 05:07 PM, Pauli wrote: From: Pauli Nieminenext-pauli.niemi...@nokia.com Destroying buffers after reseting the private key would prevent DDX from calling DRI2 functions that require private. This can be result to [DRI2]

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dirk Wallenstein
On Tue, Nov 30, 2010 at 06:03:22AM -0800, Dan Nicholson wrote: On Mon, Nov 29, 2010 at 9:46 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Dan Nicholson wrote: Add a moduleset for the 7.6 katamari based on xorg.modules. This uses the module list from 7.6-rc1 with gzipped tarballs

Re: [RFC XI 2.1 - inputproto] Various fixes in response to Peter Hutterer's review

2010-11-30 Thread Chase Douglas
On 11/29/2010 11:03 PM, Peter Hutterer wrote: On Mon, Nov 29, 2010 at 04:07:24PM -0500, Chase Douglas wrote: once you have the device in the hierarchy, it'll be hard _not_ to send through the master device. we're sending single-touch events from traditional touchscreens through the master

[PATCH xserver] Removing unused code

2010-11-30 Thread Alexandr Shadchin
In OpenBSD removed support PCCONS in 2002 year http://marc.info/?l=openbsd-cvsm=102435816424294w=2 Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- hw/xfree86/os-support/bsd/bsd_init.c |6 +- hw/xfree86/os-support/xf86_OSlib.h |8 2 files changed, 1

Re: DRI2GetBuffersWithFormat hangs waiting for X.org

2010-11-30 Thread Joris Dobbelsteen
Hi all, I'm looking for some expert opinion to verify a possible cause of our problems. After further investigation of the issue the following is found: We do all our X drawing on a single thread. However, DirectFB (used due to legacy reasons) creates a second thread for reading inputs (events).

[PATCH] DGA: fix screen number check

2010-11-30 Thread Julien Cristau
screenInfo.numScreens is not a valid screen number, they go from 0 to numScreens - 1. Signed-off-by: Julien Cristau jcris...@debian.org --- hw/xfree86/dixmods/extmod/xf86dga2.c | 46 +- 1 files changed, 23 insertions(+), 23 deletions(-) diff --git

Re: [PATCH 04/11] FindModuleInSubdir: Stop allocating one more byte than needed

2010-11-30 Thread Alan Coopersmith
Matt Turner wrote: On Tue, Nov 30, 2010 at 4:57 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: 15ac25627e7239629be59 removed the / from the sprintf strings, but failed to remove the extra byte allocated for the '/'. Good catch. Did you just happen to notice this, or find it in some

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Alan Coopersmith
Dirk Wallenstein wrote: On Tue, Nov 30, 2010 at 06:03:22AM -0800, Dan Nicholson wrote: On Mon, Nov 29, 2010 at 9:46 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: I've never looked at jhbuild modules before, so I can't really review, but it appears reasonable at a brief glance.

Re: Can we configure Xserver render with the FrameBuffer?

2010-11-30 Thread Alan Coopersmith
Leo wrote: what I want is to get rid of the transition animation, something like fade-in/fade-out, transparency I want to know which component controls this process? Your composite manager or window manager - compiz, metacity, enlightenment, etc. -- -Alan Coopersmith-

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Alan Coopersmith
Rémi Cardona wrote: Le 30/11/2010 05:57, Alan Coopersmith a écrit : +#ifdef HAVE_VASPRINTF +# define Xvasprintf vasprintf +#endif No #else? Am I missing something? else use the function we just defined before that. Really it's just a forced inlining of the Xvasprintf - vasprintf wrapper

Re: [PATCH 00/11] Xasprintf() and other string-handling cleanups

2010-11-30 Thread Keith Packard
On Tue, 30 Nov 2010 13:08:36 +0100, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 20:57:37 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC The meat of this series is sandwiched right in the middle - patch AC #6 replaces the nifty, but unique,

Re: [PATCH] DGA: fix screen number check

2010-11-30 Thread Keith Packard
On Tue, 30 Nov 2010 17:23:10 +0100, Julien Cristau jcris...@debian.org wrote: screenInfo.numScreens is not a valid screen number, they go from 0 to numScreens - 1. Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Keith Packard kei...@keithp.com It looks like this same error

Re: [PATCH v2 modular 1/2] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2010-11-30 Thread Dirk Wallenstein
On Tue, Nov 30, 2010 at 09:08:16AM -0800, Alan Coopersmith wrote: Dirk Wallenstein wrote: On Tue, Nov 30, 2010 at 06:03:22AM -0800, Dan Nicholson wrote: On Mon, Nov 29, 2010 at 9:46 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: I've never looked at jhbuild modules before, so I

[PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-11-30 Thread Ferry Huberts
From: Ferry Huberts ferry.hube...@pelagic.nl Performing bit-wise operations on a boolean amounts to mixing types, is confusing and basically incorrect; one should only perform logical operations on booleans. Performing such operations relies on the implementation detail that a boolean is in fact

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread walter harms
Am 30.11.2010 05:57, schrieb Alan Coopersmith: Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we support. If the platform provides vasprintf() we simply wrap it, otherwise we implement it - either way callers can

Re: [PATCH] xfree86: Remove the xf8_16bpp overlay module

2010-11-30 Thread Julien Cristau
On Mon, Nov 29, 2010 at 14:18:41 -0500, Adam Jackson wrote: Only one (marginal) driver was using it, and it's been fixed to just implement it directly. v2: Also fix sdksyms.sh (spotted by Jesse Adkins) Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac

Re: [PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-11-30 Thread Matt Turner
On Tue, Nov 30, 2010 at 6:06 PM, Ferry Huberts maili...@hupie.com wrote: Signed-off-by: Ferry Huberts ferry.hube...@pelagic.nl Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH keyboard] Small cleanup.

2010-11-30 Thread Mikhail Gusarov
Twas brillig at 15:36:36 30.11.2010 UTC+05 when alexandr.shadc...@gmail.com did gyre and gimble: AS Removed unnecessary code: AS case PCCONS: AS break; Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpt3POqPhEKv.pgp

Re: [PATCH] xfree86: Remove the xf8_16bpp overlay module

2010-11-30 Thread Jesse Adkins
Reviewed-by: Jesse Adkins jesserayadk...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xserver xf86PrintModeline(): print DisplayMode type bits.

2010-11-30 Thread Jesse Adkins
This applies cleanly and I should be able to test it pretty soon. Assuming this is the only patch to be applied, I'd like some explanation in the code as to why some of the letters are capitalized. As a suggestion : /* U and P are capitalized because USERPREF and PREFERRED have priority when

[PULL] Accumulated 1.10 work

2010-11-30 Thread Adam Jackson
The following changes since commit 23e3d1f23318ce69623f91908f888a09f8b74ac2: dix: remove now unnecessary !! before BitIsOn() (2010-11-26 11:05:50 +1000) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (15): glx: Remove swap

Re: [PATCH] xfree86: Bump classic driver default to 1024x768

2010-11-30 Thread Keith Packard
On Mon, 15 Nov 2010 11:25:13 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Merged. 903e0f6..5f34853 master - master -- keith.pack...@intel.com

Re: [PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-11-30 Thread Keith Packard
On Tue, 30 Nov 2010 19:06:55 +0100, Ferry Huberts maili...@hupie.com wrote: From: Ferry Huberts ferry.hube...@pelagic.nl Performing bit-wise operations on a boolean amounts to mixing types, is confusing and basically incorrect; one should only perform logical operations on booleans.

Re: [PULL] Accumulated 1.10 work

2010-11-30 Thread Keith Packard
On Tue, 30 Nov 2010 16:22:17 -0500, Adam Jackson a...@redhat.com wrote: Adam Jackson (15): glx: Remove swap barrier and hyperpipe support linux: Remove redundant variable xfree86: Remove os-support/sysv linux: Don't muck about with tty permissions xfree86:

Re: [PATCH:xf86-input-mouse] Add ABI checks around XI86_CONFIGURED uses in OS-specific PreInits

2010-11-30 Thread Peter Hutterer
On Mon, Nov 29, 2010 at 10:39:19PM -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/bsd_mouse.c |4 src/hurd_mouse.c |2 ++ src/sun_mouse.c |2 ++ 3 files changed, 8 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Dan Nicholson
On Tue, Nov 30, 2010 at 10:16 AM, walter harms wha...@bfs.de wrote: Am 30.11.2010 05:57, schrieb Alan Coopersmith: Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we support. If the platform provides vasprintf() we

Re: [PATCH keyboard] Removing unused code

2010-11-30 Thread Peter Hutterer
On Tue, Nov 30, 2010 at 08:12:24PM +0500, Alexandr Shadchin wrote: In OpenBSD removed support PCCONS in 2002 year http://marc.info/?l=openbsd-cvsm=102435816424294w=2 Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- Acked-by: Peter Hutterer peter.hutte...@who-t.net but I'd

Re: [PATCH] xfree86: Bump classic driver default to 1024x768

2010-11-30 Thread Corbin Simpson
I wasn't going to say anything, but I have an XGI Volari hanging on my wall with a Dx9 sticker on it. I've just been too lazy/incompetent/indifferent/much of an AMD whore to get started on KMS for it. My Didj and Ego share a similar fate, along with other various video cards. Modern and rare

Re: [PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-11-30 Thread Peter Hutterer
On Tue, Nov 30, 2010 at 07:06:55PM +0100, Ferry Huberts wrote: From: Ferry Huberts ferry.hube...@pelagic.nl Performing bit-wise operations on a boolean amounts to mixing types, is confusing and basically incorrect; one should only perform logical operations on booleans. Performing such

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Alan Coopersmith
Mikhail Gusarov wrote: Twas brillig at 20:57:43 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC +#ifndef XPRINTF_H AC +#define XPRINTF_H AC + AC +#include stdarg.h AC +#include X11/Xfuncproto.h AC + AC +#ifndef _X_RESTRICT_KYWD AC +# if

Re: [PATCH 10/11] Replace alloc+strcpy+strcat with Xasprintf calls

2010-11-30 Thread Alan Coopersmith
Julien Cristau wrote: On Mon, Nov 29, 2010 at 20:57:47 -0800, Alan Coopersmith wrote: diff --git a/dix/devices.c b/dix/devices.c index 708860a..db38c1a 100644 --- a/dix/devices.c +++ b/dix/devices.c @@ -2524,9 +2524,10 @@ AllocDevicePair (ClientPtr client, char* name, if (!pointer)

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Alan Coopersmith
Julien Cristau wrote: On Mon, Nov 29, 2010 at 20:57:43 -0800, Alan Coopersmith wrote: +/* Old api, now deprecated, may be removed in a future release */ +char * +Xvprintf(const char *format, va_list va) +{ +char *ret; + +Xvasprintf(ret, format, va); + return ret; }

Re: [PATCH 09/11] Convert malloc+sprintf pairs into X*asprintf() calls

2010-11-30 Thread Alan Coopersmith
Julien Cristau wrote: On Mon, Nov 29, 2010 at 20:57:46 -0800, Alan Coopersmith wrote: diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c index 06d082b..751fec6 100644 --- a/hw/xfree86/loader/loadmod.c +++ b/hw/xfree86/loader/loadmod.c @@ -406,22 +406,22 @@

Re: [PATCH 09/11] Convert malloc+sprintf pairs into X*asprintf() calls

2010-11-30 Thread Julien Cristau
On Tue, Nov 30, 2010 at 15:15:22 -0800, Alan Coopersmith wrote: Julien Cristau wrote: Should these use XNFasprintf? Certainly the previous code effectively did that (though by just SEGV on writing to the NULL value returned by malloc, instead of an orderly abort), but since the callers

Re: [PATCH 08/11] Convert hw/xfree86/parser code to use Xasprintf() calls

2010-11-30 Thread Alan Coopersmith
Matt Turner wrote: @@ -426,13 +425,9 @@ char * xf86uLongToString(unsigned long i) { char *s; - int l; - l = ceil(log10((double)i) + 2.5); - s = malloc(l); - if (!s) + if (Xasprintf(s, %lu, i) == -1) return NULL; - sprintf(s,

Re: [PATCH 00/11] Xasprintf() and other string-handling cleanups

2010-11-30 Thread Alan Coopersmith
Keith Packard wrote: On Tue, 30 Nov 2010 13:08:36 +0100, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 20:57:37 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC The meat of this series is sandwiched right in the middle - patch AC #6 replaces

Re: [PATCH 07/11] Convert existing Xprintf style calls to Xasprintf style

2010-11-30 Thread Alan Coopersmith
Julien Cristau wrote: On Mon, Nov 29, 2010 at 20:57:44 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- config/hal.c |4 +++- config/udev.c | 14 -- dix/dixfonts.c

[PATCH] Move inclusion of panoramiX headers to top of render.c

2010-11-30 Thread Alan Coopersmith
Fixes compiler error from Sun compilers due to _X_EXPORT declaration being included after the unlabeled version: ../Xext/panoramiXsrv.h, line 29: redeclaration must have the same or more restrictive linker scoping: XRT_PICTURE Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---

Re: [PATCH] Move inclusion of panoramiX headers to top of render.c

2010-11-30 Thread Peter Hutterer
On Tue, Nov 30, 2010 at 04:37:56PM -0800, Alan Coopersmith wrote: Fixes compiler error from Sun compilers due to _X_EXPORT declaration being included after the unlabeled version: ../Xext/panoramiXsrv.h, line 29: redeclaration must have the same or more restrictive linker scoping:

[PULL] Xserver-spec, Solaris warnings, and first set of memory alloc cleanups

2010-11-30 Thread Alan Coopersmith
The following changes since commit 02449ee24b484c9fea501df5274d95a9f87cab23: Merge remote branch 'ajax/for-keithp' (2010-11-30 13:30:59 -0800) are available in the git repository at: ssh://people.freedesktop.org/~alanc/xserver master This includes the recently reviewed series of doc fixes,

Re: [PATCH] xfree86: Bump classic driver default to 1024x768

2010-11-30 Thread Dave Airlie
On Wed, Dec 1, 2010 at 8:52 AM, Corbin Simpson mostawesomed...@gmail.com wrote: I wasn't going to say anything, but I have an XGI Volari hanging on my wall with a Dx9 sticker on it. I've just been too lazy/incompetent/indifferent/much of an AMD whore to get started on KMS for it. My Didj and

[PATCH 2/6 v2] Convert existing Xprintf style calls to Xasprintf style

2010-11-30 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- config/hal.c |4 ++- config/udev.c | 14 ++- dix/dixfonts.c |4 ++- hw/xfree86/common/xf86AutoConfig.c |4 +- hw/xfree86/common/xf86Config.c |

[PATCH 1/6 v2] Add X*asprintf() routines to mirror common asprintf() routines

2010-11-30 Thread Alan Coopersmith
Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we support. If the platform provides vasprintf() we simply wrap it, otherwise we implement it - either way callers can use it regardless of platform. Since not all platforms

[PATCH 3/6 v2] Convert hw/xfree86/parser code to use Xasprintf() calls

2010-11-30 Thread Alan Coopersmith
Requires linking xprintf.c into libxf86config for those who build it. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Julien Cristau jcris...@debian.org --- hw/xfree86/parser/Flags.c | 13 -

[PATCH 5/6 v2] Replace alloc+strcpy+strcat with Xasprintf calls

2010-11-30 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- dix/devices.c | 17 +++-- hw/xfree86/common/xf86Config.c |4 +--- hw/xfree86/common/xf86Option.c |5 + hw/xfree86/common/xf86ShowOpts.c|7 ++-

Re: [PATCH keyboard] Removing unused code

2010-11-30 Thread Matthieu Herrb
On Tue, Nov 30, 2010 at 08:12:24PM +0500, Alexandr Shadchin wrote: In OpenBSD removed support PCCONS in 2002 year http://marc.info/?l=openbsd-cvsm=102435816424294w=2 Nack. As per http://mail-index.netbsd.org/tech-x11/2010/11/30/msg000927.html NetBSD wants to keep the PCCONS code around. So

Re: [PATCH xserver] Removing unused code

2010-11-30 Thread Matthieu Herrb
On Tue, Nov 30, 2010 at 09:17:19PM +0500, Alexandr Shadchin wrote: In OpenBSD removed support PCCONS in 2002 year http://marc.info/?l=openbsd-cvsm=102435816424294w=2 Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr ---