On Mon, Nov 29, 2010 at 20:57:39 -0800, Alan Coopersmith wrote: > No point calling the no-fail-alloc if you check for failure and your > only caller checks for failure. > > No point calling calloc to zero fill memory you're about to memcpy over. > > In the unlikely event of a loss of memory allocation, drop your previous > allocations before returning to others. > > Signed-off-by: Alan Coopersmith <[email protected]> > --- > hw/xfree86/common/xf86AutoConfig.c | 20 +++++++++++++++----- > 1 files changed, 15 insertions(+), 5 deletions(-) > Reviewed-by: Julien Cristau <[email protected]>
Cheers, Julien _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
