Re: [PATCH 1/3] Have FreePixmap call screen hooks, not the other way around.

2011-10-04 Thread Michel Dänzer
On Mon, 2011-10-03 at 16:16 -0700, Jamey Sharp wrote: On Mon, Oct 03, 2011 at 12:03:33PM +0200, Michel Dänzer wrote: On Sam, 2011-10-01 at 23:08 -0700, Jamey Sharp wrote: In the process, move reference counting into FreePixmap instead of doing it inconsistently in the various screen

[PATCH] mkfontscale: Support FontForge weight designations.

2011-10-04 Thread Maxim Iorsh
Fontforge uses 'ExtraLight' and 'Heavy' weights in Type 1 fonts, which should be understood by mkfontscale. Other FontForge designations are already addressed. Signed-off-by: Maxim Iorsh io...@users.sourceforge.net --- mkfontscale.c |4 1 files changed, 4 insertions(+), 0 deletions(-)

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Jamey Sharp
On Mon, Oct 03, 2011 at 03:13:09PM -0700, Jamey Sharp wrote: On Mon, Oct 03, 2011 at 12:01:23PM -0700, Keith Packard wrote: On Wed, 28 Sep 2011 13:57:27 -0700, Jamey Sharp ja...@minilop.net wrote: Hi Keith! Here's some reviewed code deletion (hooray!) and the fix to make kdrive build

[PATCH] x11proto: add permille, ezh, and EZH to keysymdef.h

2011-10-04 Thread Marko Myllynen
Hi, as requested in https://bugs.freedesktop.org/show_bug.cgi?id=19687 I'm submitting a patch for review to add the following mnemonic symbols: XK_permille for U+2030 PER MILLE SIGN XK_EZH for U+01B7 LATIN CAPITAL LETTER EZH XK_ezh for U+0292 LATIN SMALL LETTER EZH These are

Re: [PATCH] fix doPolyText use-after-free issue

2011-10-04 Thread Alan Hourihane
Attached. Thanks Jeremy. What's happening to the 1.10.x branch now ? Can this be nominated for that too ? Alan. On 09/28/11 07:46, Jeremy Huddleston wrote: I missed this point at first. The context is that in 'bail', c is accessed and expected to be the old value. Candidate for

Re: [PATCH xserver 3/3] record: Preserve client input buffer for RecordEnableContext request.

2011-10-04 Thread Rami Ylimäki
On 10/03/2011 06:03 PM, Keith Packard wrote: On Mon, 3 Oct 2011 15:16:27 +0300, Rami Ylimäkirami.ylim...@vincit.fi wrote: This request installs hooks that keep sending replies even after the request handler has finished. Each reply accesses the input buffer. If we let the buffer to be

Re: [PULL] XI 2.1 - raw events and smooth scrolling

2011-10-04 Thread Daniel Stone
Hi, On 3 October 2011 11:50, Max Schwarz m...@x-quadraht.de wrote:       Input: Add smooth-scrolling support to GetPointerEvents There's a subtle bug on that one: Old-style scroll button presses create inverted emulated presses (and maybe inverted valuator events, but I don't know which

Re: [PATCH 00/12] Multihead screen crossing fixes

2011-10-04 Thread Daniel Stone
Hi, On 4 October 2011 06:23, Peter Hutterer peter.hutte...@who-t.net wrote: This is another attempt at the screen crossing fixes that I sent out last month. The basic goal was to make switching between ScreenRecs work for absolute devices. Which turned out tricky and the best solution I came

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
Hello, is this by any chance related to the swap macro changes? ../../Xext/xselinux_ext.c: In function ‘SELinuxSendItemsToClient’: ../../Xext/xselinux_ext.c:340:16: warning: unused variable ‘n’ [-Wunused-variable] In function ‘SProcSELinuxQueryVersion’, inlined from ‘SProcSELinuxDispatch’ at

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Matt Turner
On Tue, Oct 4, 2011 at 9:24 AM, Michal Suchanek hramr...@centrum.cz wrote: Hello, is this by any chance related to the swap macro changes? ../../Xext/xselinux_ext.c: In function ‘SELinuxSendItemsToClient’: ../../Xext/xselinux_ext.c:340:16: warning: unused variable ‘n’ [-Wunused-variable]

Re: [PATCH 12/12] input: change pointer screen crossing behaviour for multiple ScreenRecs

2011-10-04 Thread Michal Suchanek
Hello, The X server off two-screen-coordinates branch builds and runs in two-csreen configuration with a mouse. However, the XI tests shipped with the X server fail. Worse, they crash. Thanks Michal ___ xorg-devel@lists.x.org: X.Org development

Re: [PULL] prep work for screen crossing fixes

2011-10-04 Thread Michal Suchanek
On 4 October 2011 07:58, Jamey Sharp ja...@minilop.net wrote: On Tue, Oct 04, 2011 at 03:35:41PM +1000, Peter Hutterer wrote: On Mon, Oct 03, 2011 at 10:02:28PM -0700, Jamey Sharp wrote: On Tue, Oct 04, 2011 at 02:15:53PM +1000, Peter Hutterer wrote: On Mon, Oct 03, 2011 at 09:02:19PM

Re: [PATCH 0/3] simplify pixmap create/free hooks

2011-10-04 Thread Jamey Sharp
On Tue, Oct 04, 2011 at 10:41:48AM +0100, Chris Wilson wrote: On Sat, 1 Oct 2011 23:08:45 -0700, Jamey Sharp ja...@minilop.net wrote: Jamey Sharp (3): Have FreePixmap call screen hooks, not the other way around. Introduce CreatePixmap, allocating a header and calling screen

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 16:02, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 9:24 AM, Michal Suchanek hramr...@centrum.cz wrote: Hello, is this by any chance related to the swap macro changes? ../../Xext/xselinux_ext.c: In function ‘SELinuxSendItemsToClient’:

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Matt Turner
On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a warning about stuff variable being unused  - probably defined in one of the macros. It's because the swap macros stopped taking a second argument. Matt ___

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a warning about stuff variable being unused  - probably defined in one of the macros. It's because the swap macros stopped taking a second

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Daniel Stone
Hi, On 4 October 2011 16:00, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011

Re: [PULL] prep work for screen crossing fixes

2011-10-04 Thread Keith Packard
On Tue, 4 Oct 2011 14:15:53 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: is it ever other than 0/0? It's up to the DDX to set these values. The Quarz backend pulls the geometry out of the operating system and assigns the same values to the X screens. kdrive lets the user specify the

[PATCH xserver] Fix FP3232 related issues.

2011-10-04 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Make check has been broken since commit f32c827d513c44f07e1d0fbcc0c96cef18c9a4d9 ('Input: Fix frac calculation on [Raw]DeviceEvent conversion'). * Use floor() instead of trunc() in order to achieve the inverse of FP3232.integral + FP3232.frac /

Re: [PATCH xserver] Fix FP3232 related issues.

2011-10-04 Thread Daniel Stone
Hi, 2011/10/4 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com Make check has been broken since commit f32c827d513c44f07e1d0fbcc0c96cef18c9a4d9 ('Input: Fix frac calculation on [Raw]DeviceEvent conversion'). * Use floor() instead of trunc() in order to achieve

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Keith Packard
On Mon, 3 Oct 2011 23:46:10 -0700, Jamey Sharp ja...@minilop.net wrote: Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs. Good fix Make GC clientClip always be a region. Good fix. Introduce ReleasePixmap to unreference, call screen hooks, and free. This one

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 17:18, Daniel Stone dan...@fooishbar.org wrote: Hi, On 4 October 2011 16:00, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Michal Suchanek
On 4 October 2011 18:07, Keith Packard kei...@keithp.com wrote: On Mon, 3 Oct 2011 23:46:10 -0700, Jamey Sharp ja...@minilop.net wrote:       Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs. Good fix       Make GC clientClip always be a region. Good fix.       Introduce

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Keith Packard
On Tue, 4 Oct 2011 18:19:54 +0200, Michal Suchanek hramr...@centrum.cz wrote: Wasn't it just renamed from DestroyPixmap to ReleasePixmap? The function was renamed, but the screen structure member was not (nor should it have been -- it's now actually called when the pixmap is destroyed, not just

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Aaron Plattner
On 10/04/2011 09:33 AM, Keith Packard wrote: On Tue, 4 Oct 2011 18:19:54 +0200, Michal Suchanekhramr...@centrum.cz wrote: Wasn't it just renamed from DestroyPixmap to ReleasePixmap? The function was renamed, but the screen structure member was not (nor should it have been -- it's now

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Keith Packard
On Tue, 4 Oct 2011 12:37:59 -0700, Aaron Plattner aplatt...@nvidia.com wrote: With the old CreatePixmap API, drivers could override the width and height when calling down to prevent the fb layer from allocating the pixmap memory, and then plug in its own. It looks like a driver could do

[RFC modular] Publish.sh: batch release and autotagging of modules

2011-10-04 Thread Gaetan Nadon
Features: - Navigate the build tree from a given list of modules to release - Accepts a list in the format produced by build.sh -L - Tag and version names picked-up from Makefile - Section name picked-up from module list - It only release tarballs it has created from the module - Timely feedback,

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Aaron Plattner
On 10/04/2011 12:43 PM, Keith Packard wrote: * PGP Signed by an unknown key On Tue, 4 Oct 2011 12:37:59 -0700, Aaron Plattneraplatt...@nvidia.com wrote: With the old CreatePixmap API, drivers could override the width and height when calling down to prevent the fb layer from allocating the

[PATCH evdev, v2] Support smooth scrolling on wheel emulation

2011-10-04 Thread Max Schwarz
This adds support for the new smooth-scrolling valuator system to the wheel emulation code. Caveats: - Enabling wheel emulation at runtime does not work if the device does not provide the necessary axes already. - Horizontal scrolling is always reported on the REL_HWHEEL axis, ignoring a

Re: [PULL] build fix, GC clipping cleanup

2011-10-04 Thread Keith Packard
On Tue, 4 Oct 2011 12:47:22 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Oh, you mean have the driver allocate the storage before calling down? Yeah, that's a good idea. Thinking about how this mixes in with my idea of just using the existing callback infrastructure instead of using

Re: [PULL] prep work for screen crossing fixes

2011-10-04 Thread Peter Harris
On 2011-10-04 01:35, Peter Hutterer wrote: On Mon, Oct 03, 2011 at 10:02:28PM -0700, Jamey Sharp wrote: On Tue, Oct 04, 2011 at 02:15:53PM +1000, Peter Hutterer wrote: On Mon, Oct 03, 2011 at 09:02:19PM -0700, Keith Packard wrote: On Tue, 4 Oct 2011 13:26:35 +1000, Peter Hutterer

[PATCH] dix: fix inverted handling of legacy scroll button events

2011-10-04 Thread Max Schwarz
This bug led to inverted scrolling axes with legacy drivers that do not support smooth scrolling classes. Signed-off-by: Max Schwarz m...@x-quadraht.de --- Applies on Peter's next branch. dix/getevents.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 12/12] input: change pointer screen crossing behaviour for multiple ScreenRecs

2011-10-04 Thread Peter Hutterer
On Tue, Oct 04, 2011 at 04:03:56PM +0200, Michal Suchanek wrote: The X server off two-screen-coordinates branch builds and runs in two-csreen configuration with a mouse. cool, thanks for testing. However, the XI tests shipped with the X server fail. Worse, they crash. yeah, the tests all

Re: [PATCH 1/3] Move miTrapezoids() into fb as fbTrapezoids().

2011-10-04 Thread Aaron Plattner
This caused a performance regression because previously, miTrapezoids would render its mask image into a scratch pixmap and then perform the final composite using a possibly-accelerated RENDER Composite call. Now, fbTrapezoids does the final composite in software, leading to, for example,

[PATCH] dix: add utility functions for double to/fro FP1616/FP3232 conversion

2011-10-04 Thread Peter Hutterer
Co-authored by Jeremy Huddleston jerem...@apple.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Jeremy, these are your functions fixed up to pass the tests (a few bitshifts where wrong). Changes to your version: - use trunc instad of (double)(int)(double_value) - use rint(trunc())

Re: [PATCH evdev, v2] Support smooth scrolling on wheel emulation

2011-10-04 Thread Peter Hutterer
On Tue, Oct 04, 2011 at 09:53:56PM +0200, Max Schwarz wrote: This adds support for the new smooth-scrolling valuator system to the wheel emulation code. Caveats: - Enabling wheel emulation at runtime does not work if the device does not provide the necessary axes already. - Horizontal

Re: [PATCH] dix: fix inverted handling of legacy scroll button events

2011-10-04 Thread Jeremy Huddleston
Can you add a reference to the commit that introduced this regression to the commit message? On Oct 4, 2011, at 2:55 PM, Max Schwarz wrote: This bug led to inverted scrolling axes with legacy drivers that do not support smooth scrolling classes. Signed-off-by: Max Schwarz

Re: [PATCH] dix: add utility functions for double to/fro FP1616/FP3232 conversion

2011-10-04 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com Wow, that's all I missed? Not bad for coding in an email client ;) You might want to replace my crap comment with something more descriptive such as loss of precision, setting to 0 On Oct 4, 2011, at 4:39 PM, Peter Hutterer wrote:

Re: [RFC modular] Publish.sh: batch release and autotagging of modules

2011-10-04 Thread Jeremy Huddleston
I haven't reviewed yet, but this seems like a great idea. On Oct 4, 2011, at 12:46 PM, Gaetan Nadon wrote: Features: - Navigate the build tree from a given list of modules to release - Accepts a list in the format produced by build.sh -L - Tag and version names picked-up from Makefile -

Re: [PATCH] dix: add utility functions for double to/fro FP1616/FP3232 conversion

2011-10-04 Thread Peter Hutterer
On Tue, Oct 04, 2011 at 06:02:21PM -0700, Jeremy Huddleston wrote: Reviewed-by: Jeremy Huddleston jerem...@apple.com Wow, that's all I missed? Not bad for coding in an email client ;) You might want to replace my crap comment with something more descriptive such as loss of precision,

[PATCH] dix: mark motion events as emulated if we're scrolling from button press

2011-10-04 Thread Peter Hutterer
The protocol requires that the emulated event is marked as such. So if a driver with smooth scrolling axis sends legacy button events, the motion event must be marked as emulated. Pass the real type to emulate_scroll_button_events and create the events accordingly. For real button press or relase

Re: [PATCH] dix: fix inverted handling of legacy scroll button events

2011-10-04 Thread Peter Hutterer
On Tue, Oct 04, 2011 at 10:06:08PM +0200, Max Schwarz wrote: This bug led to inverted scrolling axes with legacy drivers that do not support smooth scrolling classes. Signed-off-by: Max Schwarz m...@x-quadraht.de merged, thanks. though I've amended the commit message, this can only be

Re: [PATCH] fix doPolyText use-after-free issue

2011-10-04 Thread Jeremy Huddleston
Thanks, I've pulled this into my tree, and it will be in my next pull request to master. On Oct 4, 2011, at 12:48 AM, Alan Hourihane wrote: Attached. Thanks Jeremy. What's happening to the 1.10.x branch now ? Can this be nominated for that too ? Alan. On 09/28/11 07:46, Jeremy

Re: [PATCH xserver/hw/xfree86/modes/xf86Crtc.c] trivial memory leak

2011-10-04 Thread Jeremy Huddleston
reviewed and pulled into my tree for my next pull request. On Sep 17, 2011, at 9:55 AM, v...@picaros.org wrote: Anyone willing to review this triviality ? The code is included below. This patch fixes a memory leak in xf86CrtcCreate(). It frees the crtc-gamma_red buffer when a quit on

Re: [PATCH] mkfontscale: Support FontForge weight designations.

2011-10-04 Thread Jeremy Huddleston
reviewed and pushed d429321..8ee3b3f master - master On Oct 3, 2011, at 12:52 PM, Maxim Iorsh wrote: Fontforge uses 'ExtraLight' and 'Heavy' weights in Type 1 fonts, which should be understood by mkfontscale. Other FontForge designations are already addressed. Signed-off-by: Maxim

Re: [PATCH evdev, v2] Support smooth scrolling on wheel emulation

2011-10-04 Thread Peter Hutterer
On Tue, Oct 04, 2011 at 09:53:56PM +0200, Max Schwarz wrote: This adds support for the new smooth-scrolling valuator system to the wheel emulation code. Caveats: - Enabling wheel emulation at runtime does not work if the device does not provide the necessary axes already. you could

[PULL] pot pouri

2011-10-04 Thread Jeremy Huddleston
The following changes since commit 6378d0233d21088b6429755627b4253859892c72: Merge remote-tracking branch 'herrb/master' (2011-10-03 13:56:06 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver for-keith Alan Hourihane (1): dixfonts: Don't

Re: [PULL] pot pouri

2011-10-04 Thread Keith Packard
On Tue, 4 Oct 2011 22:13:49 -0700, Jeremy Huddleston jerem...@apple.com wrote: Alan Hourihane (1): dixfonts: Don't overwrite local c variable until new_closure is safely initialized. Jeremy Huddleston (1): XQuartz: pbproxy: Add missing AM_OBJCFLAGS Kirill Elagin (1):

[PATCH:libpciaccess] Solaris: Give better error on realloc failure

2011-10-04 Thread Alan Coopersmith
commit a18460b385ae03 converted from a fixed maximum number of devices to dynamically growing the list via realloc, but didn't update the error message shown on failure. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/solx_devfs.c |5 +++-- 1 files changed, 3