Re: lack of reviewers

2012-05-17 Thread Ernst Sjöstrand
Hi, (sorry for jumping in from the outside and breaking the thread!) I read about this problem and wanted to offer a suggestion! What if you set up a Gerrit server for git.freedesktop.org? That's the tool the Android OpenSource project uses among other things:

Re: lack of reviewers

2012-05-17 Thread Olivier Galibert
On Thu, May 17, 2012 at 10:39:55AM +0200, Ernst Sjöstrand wrote: What if you set up a Gerrit server for git.freedesktop.org? When you have a social problem and try to handle it with technology, you end up with two problems. There has been no specific grumblings against the review methodology.

Re: lack of reviewers

2012-05-17 Thread Michal Suchanek
On 17 May 2012 10:56, Olivier Galibert galib...@pobox.com wrote: On Thu, May 17, 2012 at 10:39:55AM +0200, Ernst Sjöstrand wrote: What if you set up a Gerrit server for git.freedesktop.org? When you have a social problem and try to handle it with technology, you end up with two problems.  

[PATCH] xkb: Allocate size_syms correctly when width of a type increases

2012-05-17 Thread Siddhesh Poyarekar
The current code seems to skip syms with width less than type-num_levels when calculating the total size for the new size_syms. This leads to less space being allocated than necessary during the next phase, which is to copy over the syms to the new location. This results in an overflow leading to

Re: [PATCH synaptics] Don't allow for scroll distances of 0 (#49965)

2012-05-17 Thread Chase Douglas
On 05/16/2012 08:30 PM, Peter Hutterer wrote: It'll either hang the server or blow up with divisions by 0, whichever one comes first. X.Org Bug 49965 http://bugs.freedesktop.org/show_bug.cgi?id=49965 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/properties.c |6

Re: [PATCH synaptics] Reset hw-x/y to INT_MIN and skip HandleState until we have x/y events

2012-05-17 Thread Chase Douglas
On 05/16/2012 06:38 PM, Peter Hutterer wrote: The driver assumes x/y is always valid but after coming from a resume we may get a few events with either ABS_X or ABS_Y (not both). Thus we process with hw-x == 0 and hw-y == somevalue, causing cursor jumps when calculating deltas whenver the real

Re: [PATCH v3 02/02] dri2: Add DRI2GetParam request

2012-05-17 Thread Eric Anholt
On Wed, 16 May 2012 12:44:41 -0700, Chad Versace chad.vers...@linux.intel.com wr diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c index 2579a5c..5487806 100644 --- a/hw/xfree86/dri2/dri2ext.c +++ b/hw/xfree86/dri2/dri2ext.c @@ -535,6 +535,38 @@ ProcDRI2WaitSBC(ClientPtr

Re: [PATCH] int10/vbe: don't use xf86Screens. (ABI) (v2)

2012-05-17 Thread Adam Jackson
On 5/16/12 5:16 AM, Dave Airlie wrote: @@ -340,7 +341,7 @@ vbeDoEDID(vbeInfoPtr pVbe, pointer pDDCModule) if (!DDC_data) return NULL; -pMonitor = xf86InterpretEDID(pVbe-pInt10-scrnIndex, DDC_data); +pMonitor = xf86InterpretEDID(pVbe-pInt10-pScrn-scrnIndex, DDC_data);

Re: randr provider object

2012-05-17 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On 5/15/12 3:04 PM, Dave Airlie wrote: My concern is how you're going to build this programmatically if you keep with a poke-one-thing model, I just envision intermediate states that don't make a ton of sense on their own but that we'd end up needing to

[PATCH synaptics] Remove absolute mode

2012-05-17 Thread Peter Hutterer
Moving a touchpad in absolute mode is unusual - touchpads are disconnected from the output device, so direct interaction is hard. There appears to be little usage of it (I haven't seen bug reports from people claiming to use it). Joe Shaw, author of the code and only known user doesn't have a use

Re: [PATCH synaptics] Remove absolute mode

2012-05-17 Thread Chase Douglas
On 05/17/2012 02:48 PM, Peter Hutterer wrote: Moving a touchpad in absolute mode is unusual - touchpads are disconnected from the output device, so direct interaction is hard. There appears to be little usage of it (I haven't seen bug reports from people claiming to use it). Joe Shaw, author

Re: [PATCH 1/4] xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: + +ScrnInfoPtr +xf86ScreenToScrn(ScreenPtr pScreen) +{ +return xf86Screens[pScreen-myNum]; +} While reviewing, I found a bit of comedy in xf86Helper.c -- it appears the code 'supports' removing a screen from the middle of the xf86Screens list.

Re: [PATCH 2/4] xf86: migrate to using xf86ScreenToScrn wrapper

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: migrate to new helper API. SCREEN_PROLOG(GetImage); -//if (xf86Screens[pScreen-myNum]-vtSema) { +//if (xf86ScreenToScrn(pScreen)-vtSema) { VGAGet(pScreen); //} Maybe just remove the commented out lines? -

Re: [PATCH 3/4] render: add GetGlyphPicture accessor.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This is a new API to stop the drivers directly looking up the glyph pictures in a global array. It provides a define GLYPH_HAS_GET_GLYPH_PICTURE to allow drivers to work in a compat way. Yeah, this also provides an

Re: [PATCH 4/4] render/exa: use glyph picture accessors

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com use the glyph picture accessors in the X server, render and EXA code. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpI9TGlydR02.pgp Description: PGP signature

Re: convert some more users to the screen conversion functions.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: These are just some more simple patches to move to using the Screen-Scrn and Scrn-Screen conversion functions in various parts of the server. I'm wondering if you've tested these to see if the server builds without publishing the two global arrays any

Re: lack of reviewers

2012-05-17 Thread Peter Hutterer
On Thu, May 17, 2012 at 10:39:55AM +0200, Ernst Sjöstrand wrote: Hi, (sorry for jumping in from the outside and breaking the thread!) I read about this problem and wanted to offer a suggestion! What if you set up a Gerrit server for git.freedesktop.org? That's the tool the Android

Re: [PATCH 1/4] xf86/modes: drop two uses of screenInfo

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Just use new macros to access scrn-screen. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpJObmdpv6FZ.pgp Description: PGP signature

Re: lack of reviewers

2012-05-17 Thread Peter Hutterer
On Thu, May 17, 2012 at 01:15:25PM +0200, Michal Suchanek wrote: On 17 May 2012 10:56, Olivier Galibert galib...@pobox.com wrote: On Thu, May 17, 2012 at 10:39:55AM +0200, Ernst Sjöstrand wrote: What if you set up a Gerrit server for git.freedesktop.org? When you have a social problem and

Re: [PATCH 2/4] xaa: convert pScrn-pScreen to use accessor.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: This uses a standard conversion function to do the conversion. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgplwrY6u9tKJ.pgp Description: PGP signature ___ xorg-devel@lists.x.org:

Re: [PATCH 3/4] xf86/modes: drop more pScrn-pScreen usages

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Just simple conversion to use the lookup function. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpw4Jz2mq8p8.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 4/4] xf86: reimplement XF86SCRNINFO macro using new functions.

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: This patch drops all in-server uses, we should drop the macro later, once drivers have been converted to not use it. There aren't many drivers using it at least... Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard

[PULL] XQuartz

2012-05-17 Thread Jeremy Huddleston
The following changes since commit 31174565ec0090b4c03c9334c82878be2455f938: dix: Remove redundant declarations. (2012-05-14 13:31:00 +0100) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master for you to fetch changes up to

Re: [PULL] Implement GLX_ARB_create_context

2012-05-17 Thread Keith Packard
Ian Romanick i...@freedesktop.org writes: glx: Extend __GLXscreen::createContext to take attributes This doesn't even compile - a missing comma: __glXDRIscreenCreateContext(__GLXscreen * baseScreen, __GLXconfig * glxConfig,

Re: [PULL] build fix, bug fix, warning fixes

2012-05-17 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Peter Hutterer (9): test: fix redundant declaration of devices warning test: fix userdata shadows global declaration warnings test: fix redundant declaration of BadDevice test: don't shadow parameter 'len'

Re: [PULL] XQuartz

2012-05-17 Thread Keith Packard
Jeremy Huddleston jerem...@apple.com writes: Jeremy Huddleston (5): XQuartz: Workaround an SDK bug on Leopard/x86_64 XQuartz: Tiger build fix XQuartz: Provide fls implementation for Tiger XQuartz: Declare noPseudoramiXExtension for miinitext.c XQuartz: Avoid a

Re: [pull] fixes and first set of new API changes

2012-05-17 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr I sent some comments about this one today; please take a look and let me know what you think. I'll wait for your reply before merging any of these patches. --

Re: [PATCH 1/4] xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr

2012-05-17 Thread Aaron Plattner
On 05/17/2012 03:58 PM, Keith Packard wrote: Dave Airlieairl...@gmail.com writes: + +ScrnInfoPtr +xf86ScreenToScrn(ScreenPtr pScreen) +{ +return xf86Screens[pScreen-myNum]; +} While reviewing, I found a bit of comedy in xf86Helper.c -- it appears the code 'supports' removing a screen

Re: [PATCH 1/4] xf86: add helper functions to convert to from ScrnInfoPtr/ScreenPtr

2012-05-17 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: Are you talking about xf86DeleteScreen? It does that if PreInit fails, before it has called AddScreen. Yeah, good point. ... not that having your screen renumbered between PreInit and ScreenInit is something people test a lot... Given that

Re: [PULL] Implement GLX_ARB_create_context

2012-05-17 Thread Ian Romanick
On 05/17/2012 04:37 PM, Keith Packard wrote: Ian Romanicki...@freedesktop.org writes: glx: Extend __GLXscreen::createContext to take attributes This doesn't even compile - a missing comma: __glXDRIscreenCreateContext(__GLXscreen * baseScreen, __GLXconfig