Re: [PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

Hi Keith, sorry for delaying this. I was occupied with other things and therefore wanted to wait for a bigger time window. On Fri, Oct 04, 2013 at 04:07:28PM -0700, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: ConfineToShape does not work well: The cursor often times

[PATCH] [DIX/ConfineTo] Don't bother about the bounding box when grabbing a shaped window

Limiting the the cursor coordinates on the bounding box of a shaped window before applying ConfineTo leads to strange cursor placement when the pointer is located outside the vertial and horizontal strip of this bounding box. Ignoring the bounding box when a shape is set leads to the correct

[PATCH app/scripts] Add ssh support to 'xon'

'xon' has been around for ages, it's a small script that can be used to start any xclient remotely. It did so by opening a shell connection using 'rsh' or 'rcmd' to connect to the remote system. Today (hopefully) nobody has rsh installed any more for security reasons. 'ssh' has become the remote

Re: [PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

It would be nice if someone took a look at this issue. So far noone has commented on this patch. Cheers, Egbert. On Wed, Aug 14, 2013 at 06:17:59PM +0200, Egbert Eich wrote: From: Reinhard Max m...@suse.de For IPv6 add a link local addresses to the end of the list passed to the

Re: [PATCH] configure.ac: add missing test

Hi, Thanks, this is my bad. Note I already posted a fix for this myself too. Either way, this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 02/07/2014 02:06 AM, David Heidelberger wrote: --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] libxf86config: libxf86config_internal - libxf86config

Now since the installable libxf86config is gone, rename libxf86config_internal to libxf86config. Signed-off-by: Egbert Eich e...@freedesktop.org --- hw/xfree86/Makefile.am| 2 +- hw/xfree86/parser/Makefile.am | 4 ++-- test/Makefile.am | 2 +- 3 files changed, 4

[PATCH 1/2] libxf86config: Remove

The library used by the Xserver to read and parse the configuration file could be built so that it culd be installed as a separate lib and used by external programs. Apparently there has not been any interest in this for quite a while as this library has been broken for a long time now in the

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

On Thu, 2014-02-06 at 19:17 -0800, Keith Packard wrote: Any time the colormap is changed, the entire screen needs to be repainted to match. Signed-off-by: Keith Packard kei...@keithp.com Which works for kdrive, because kdrive as a base class doesn't support more than one installed colormap.

[PATCH] dri2: work around broken DRI2CreateDrawable callers

The state of the DRI2CreateDrawable request is a little unclear. dri2proto.txt states that it was dropped in version 1.99.2, but actually this must still be called exactly once for each drawable before GetBuffers and friends can be called, because it is the only way that the internal

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

Adam Jackson a...@redhat.com writes: On Thu, 2014-02-06 at 19:17 -0800, Keith Packard wrote: Any time the colormap is changed, the entire screen needs to be repainted to match. Signed-off-by: Keith Packard kei...@keithp.com Which works for kdrive, because kdrive as a base class doesn't

Re: [PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

On Fri, Feb 07, 2014 at 11:38:25AM +0100, Egbert Eich wrote: commit d8a52a3a3b5bc4a1ff0a986e87dd6c36366e531b Author: Keith Packard kei...@keithp.com Date: Fri Oct 4 16:00:49 2013 -0700 Improved ConfineToShape Find the box within the region which is closest to the

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

Keith Packard kei...@keithp.com writes: Any time the colormap is changed, the entire screen needs to be repainted to match. Revviewed-by: Eric Anholt e...@anholt.net pgp4JvCVe4emQ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 04/15] glamor: Drop a bunch of GLES2 ifdefs.

Michel Dänzer mic...@daenzer.net writes: On Mon, 2014-02-03 at 11:03 -0800, Eric Anholt wrote: Now that we're using epoxy, we can write code using both desktop and ES symbols and decide what to use at runtime. Nice. diff --git a/glamor/glamor_copyarea.c b/glamor/glamor_copyarea.c index

Re: [PATCH 6/8] xephyr: Build support for rendering with glamor using a -glamor option.

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net With the caveat that fixing the trouble with 5/8 will require some changes here to fix the CreateScreenResources stuff, Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpJC1CnXf7lq.pgp

Re: [PATCH 7/8] xephyr: Pass incoming XCB events to the Xlib event filter.

Eric Anholt e...@anholt.net writes: This is the same thing that Qt ended up doing to get DRI2's event mangling to happen despite using an XCB event loop. That's disgusting. But, it looks like it will work... Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com

Re: [PATCH 8/8] xephyr: Use GLX swap events to reduce repaints.

Eric Anholt e...@anholt.net writes: If there's a swap already outstanding, don't bother queueing another one until this one has completed. The assumption here is that our screen paints are cheap compared to everything else going on, so we don't need to queue them up way ahead of time. The

Re: [PATCH 01/15] glamor: Drop useless glEnable/glDisable(GL_TEXTURE_2D) calls.

Eric Anholt e...@anholt.net writes: Those calls are only for enabling texture handling in the fixed function pipeline, while everything we do is with shaders. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpcRWfiZ8mex.pgp Description: PGP signature

Re: [PATCH 03/15] glamor: yInverted is a boolean value, so use the Bool type.

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpVOeRRHYzIo.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 02/15] glamor: Drop fixed function transformation matrix setup.

Eric Anholt e...@anholt.net writes: gl_ModelViewProjection and friends aren't used in our shaders, so this setup didn't do anything. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpn7r1B2VPNq.pgp Description: PGP signature

Re: [PATCH 04/15] glamor: Drop a bunch of GLES2 ifdefs.

Eric Anholt e...@anholt.net writes: Now that we're using epoxy, we can write code using both desktop and ES symbols and decide what to use at runtime. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpFQNXmwiXjv.pgp

Re: [PATCH 05/15] glamor: Add a screen argument to drop an ifdef from glamor_set_alu().

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpqvfYuU6tc0.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 06/15] glamor: Pass pixmaps around to unifdef glamor_iformat_for_depth().

Eric Anholt e...@anholt.net writes: - !glamor_pict_format_is_compatible(picture-format, - pixmap-drawable.depth)) + !glamor_pict_format_is_compatible(picture-format, pixmap)) Should this function just take

Re: [PATCH 07/15] glamor: Unifdef the cache format indices.

Eric Anholt e...@anholt.net writes: We only ask for GL_RGB on desktop GL as far as I can see, but now if GLES2 did happen to ask for GL_RGB it would return a cache index instead of -1. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com --

Re: [PATCH 08/15] glamor: Move glamor_get_tex_format_type_from_pictformat to a .c file.

Eric Anholt e...@anholt.net writes: A pair of 150 lines of inlined switch statements in a header file is crazy. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpvTCOkggy48.pgp Description: PGP signature

Re: [PATCH 09/15] glamor: Unifdef the picture-format-to-format-and-type functions.

Eric Anholt e...@anholt.net writes: There's no way these should be in a header file, but I'll leave that cleanup until later. I don't understand this comment; did you flip the order of 08/15 and 09/15 at some point and not rewrite it? The change it self is: Reviewed-by: Keith Packard

Re: [PATCH 10/15] glamor: Move shader precision stuff from build time to shader compile time.

Eric Anholt e...@anholt.net writes: This is the last desktop-versus-ES2 build ifdef in core glamor. Nice. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgp8WbpQET9Yh.pgp Description: PGP signature ___

Re: [PATCH 11/15] glamor: Fix typo in setting v_position's attrib location.

Eric Anholt e...@anholt.net writes: Assuming it was the first attribute assigned by the GL, it would have ended up with location 0 anyway. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpVFwnk3ddah.pgp Description: PGP signature

Re: [PATCH 12/15] glamor: Don't bother keeping references to shader stages for gradients.

Eric Anholt e...@anholt.net writes: They never get reattached to any other program, so saving them to unreference later is a waste of code. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpGpP29oT12X.pgp Description:

Re: [PATCH 13/15] glamor: Fix linking of the gradient shaders on GLES2.

Eric Anholt e...@anholt.net writes: GLES2 sensibly doesn't allow you to attach multiple shaders for the same stage to a single program. This means we have to attach the whole thing in one glShaderSource call. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com

Re: [PATCH 14/15] glamor: Move the EGL DRI3 code to GLAMOR_HAS_GBM.

Eric Anholt e...@anholt.net writes: There's nothing dependent on the presence of DRI3 code in the server for this, but it does rely on GBM. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpnNgw2YaoEu.pgp Description: PGP signature

Re: [PATCH 15/15] xephyr: Allow initializing glamor with gles2 (on GLX).

Eric Anholt e...@anholt.net writes: This should be useful for glamor development, so you can test both paths (which are significantly different, and apparently glamor_gradient.c was broken on GLES2 as of the import). Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard

Re: [PATCH 6/6] mi: fix printf warnign about size_t format specifier

Peter Hutterer peter.hutte...@who-t.net writes: mieq.c:290:26: warning: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'size_t' [-Wformat=] pnprintf supports size_t since 5ea21560dd071ea4ab8743d087fd5fe1f092 With Hans' fixes, these all look good to me.

Re: [PATCH] configure: Don't add GLX_SYS_LIBS to XORG_SYS_LIBS

Peter Hutterer peter.hutte...@who-t.net writes: On Wed, Feb 05, 2014 at 11:10:47AM -0500, Adam Jackson wrote: libglx.so is linked against libGL.so, but Xorg itself should not be. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Merged.

Re: [PATCH 5/5] miinitext: introduce LoadExtensionList() to replace over LoadExtension()

Emil Velikov emil.l.veli...@gmail.com writes: Looping around LoadExtension() meant that ExtensionModuleList was reallocated on every extension. Using LoadExtensionList() we pass an array thus the function can do the reallocation in one go, and then loop and setup the ExtensionModuleList.

Re: [PATCH 1/5] miinitext: move AddStaticExtensions() to LoadExtension()

Emil Velikov emil.l.veli...@gmail.com writes: Separate the function from NewExtensionModule() as the former does only memory reallocation. No functional change. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpP9Szw99gc8.pgp Description: PGP signature

Re: [PATCH 2/5] miinitext: drop sentinel detection during LoadExtension

Emil Velikov emil.l.veli...@gmail.com writes: All the sentinels from the extension lists were removed, thus the only case were this would trigger is when the code is broken badly. (given the remaining restructuring coming, this is fine; in general, this should probably be an assert failure

Re: [PATCH 3/5] miinitext: constify staticExtensions

Emil Velikov emil.l.veli...@gmail.com writes: The array is readonly and should not be tampered with. And the signature of LoadExtension is already const as well. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpew5IgCNp8E.pgp Description: PGP signature

Re: [PATCH] glx: Remove left-over glthread.c

Adam Jackson a...@redhat.com writes: On Wed, 2014-01-22 at 15:08 -0800, Eric Anholt wrote: Jon TURNEY jon.tur...@dronecode.org.uk writes: Commit be668096 glx: convert to direct GL dispatch (v2) removes glthread.c from Makefile.am along with the rest of the dispatch table code, but

[PATCH] glx: Ignore unused function warnings

indirect_dispatch_swap.c, which is autogenerated from a mesa script, contains the function 'bswap_CARD64', which is never used in the file. While it would be nice to fix this upstream, that's hard, so this change causes these warnings to be ignored for just this directory. Signed-off-by: Keith

Re: [PATCH 1/5] glx: Stop relying on libGL ABI bugs for glGetCompressedTexImage().

Adam Jackson a...@nwnk.net writes: 1-4 of this series is: Reviewed-by: Adam Jackson a...@redhat.com Merged. bf4f023..76eedb0 master - master -- keith.pack...@intel.com pgpAy1uljNYQE.pgp Description: PGP signature ___ xorg-devel@lists.x.org:

Re: [PATCH] __glGetProcAddress: explictly cast function pointers to void *

Alan Coopersmith alan.coopersm...@oracle.com writes: Fixes Solaris Studio compiler warning error: glxext.c, line 557: warning: assignment type mismatch: pointer to void = pointer to function(void) returning void glxext.c, line 559: error: operands have incompatible types:

Re: [PATCH] configure.ac: add missing test

Hans de Goede hdego...@redhat.com writes: Hi, Thanks, this is my bad. Note I already posted a fix for this myself too. Either way, this is: Reviewed-by: Hans de Goede hdego...@redhat.com Merged. 08c7df9..9eecc9a master - master -- keith.pack...@intel.com pgpx4C8kFkeSZ.pgp

Re: [PATCH] DIX/ConfineTo: Improve algorithm to jump to the nearest point inside

Egbert Eich e...@freenet.de writes: Hi Keith, sorry for delaying this. I was occupied with other things and therefore wanted to wait for a bigger time window. Thanks for your review in any case. +static uint32_t +ConfineToBox(int x, int y, BoxPtr box, int *px, int16_t *py)

Re: [PATCH] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

Egbert Eich e...@freedesktop.org writes: It would be nice if someone took a look at this issue. So far noone has commented on this patch. I'd prefer someone who actually understands IPV6 to review this. -- keith.pack...@intel.com pgpz1w9JgcRyA.pgp Description: PGP signature

Re: [PATCH 2/2] libxf86config: libxf86config_internal - libxf86config

Egbert Eich e...@freedesktop.org writes: Now since the installable libxf86config is gone, rename libxf86config_internal to libxf86config. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpEG9HLJLAVK.pgp Description: PGP signature

Re: [PATCH 1/2] libxf86config: Remove

Egbert Eich e...@freedesktop.org writes: The library used by the Xserver to read and parse the configuration file could be built so that it culd be installed as a separate lib and used by external programs. Apparently there has not been any interest in this for quite a while as this library

Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

Eric Anholt e...@anholt.net writes: Keith Packard kei...@keithp.com writes: Any time the colormap is changed, the entire screen needs to be repainted to match. Revviewed-by: Eric Anholt e...@anholt.net Merrged: 9eecc9a..ae796d4 master - master -- keith.pack...@intel.com

Re: [PATCH] [DIX/ConfineTo] Don't bother about the bounding box when grabbing a shaped window

Egbert Eich e...@freedesktop.org writes: Limiting the the cursor coordinates on the bounding box of a shaped window before applying ConfineTo leads to strange cursor placement when the pointer is located outside the vertial and horizontal strip of this bounding box. Ignoring the bounding

Re: [PATCH RESEND2 xserver] Default font path: remove the check for ${sysconfdir}/X11/fontpath.d

Gaetan Nadon mems...@videotron.ca writes: The location ${sysconfdir}/X11/fontpath.d is unknown at configuration time (only at make time) as evidenced by the configuration output: checking for ${prefix}/etc/X11/fontpath.d... no Unlike font-util for the X fonts, there is no mechanism to