Re: [PATCH RFC] Xorg: Add a suid root wrapper

Hi, On 03/06/2014 06:40 AM, Alan Coopersmith wrote: On 03/ 5/14 07:51 AM, Hans de Goede wrote: This commit adds a little suid root wrapper, which is a bit weird, first we strip the suid-root bit of the Xorg binary, and then we add a wrapper ? Have you looked at Debian's Xwrapper and

Re: [PATCH RFC 0/1] Xorg: Add a suid root wrapper

From: Hans de Goede hdego...@redhat.com Date: Wed, 5 Mar 2014 16:51:51 +0100 Hi All, Let me repeat the commit msg here as that explains it all: With the recent systemd-logind changes it is possible to install the Xorg binary without suid root rights and still have everything working

Re: [PATCH RFC] Xorg: Add a suid root wrapper

From: Hans de Goede hdego...@redhat.com Date: Wed, 5 Mar 2014 16:51:52 +0100 If you end up going with this wrapper approach anyway despite my previous message, here are some comments. Oh, and it's good that this is optional. diff --git a/hw/xfree86/Xorg.sh b/hw/xfree86/Xorg.sh new file

Re: [PATCH RFC 0/1] Xorg: Add a suid root wrapper

Hi Mark, On 03/06/2014 01:23 PM, Mark Kettenis wrote: snip Oh dear, the wrapper script is back! Before you go further down this road, may I point out the privilege seperation support that we've had in xenocara (Xorg for OpenBSD) for years now? As Ilja van Sprundel says, Xorg guys should

Re: [PATCH RFC] Xorg: Add a suid root wrapper

Hi, Thanks for the review! On 03/06/2014 01:46 PM, Mark Kettenis wrote: From: Hans de Goede hdego...@redhat.com Date: Wed, 5 Mar 2014 16:51:52 +0100 If you end up going with this wrapper approach anyway despite my previous message, here are some comments. Oh, and it's good that this is

[PATCH 3/6] glamor: Add a note about the state of GL_ARB_map_buffer_range.

GLES2 Xephyr is failing due to lack of glMapBuffer() with the read bits set, and I decided to see if we can just switch everything to glMapBufferRange(). I'm undecided, and it largely depends on whether we find people are interested in using glamor for the windows X server. Signed-off-by: Eric

[PATCH 5/6] glamor: Fix a mismatched glamor_get/put_context().

We don't call GL in this function any more, so we can just drop the get. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 5 - 1 file changed, 5 deletions(-) diff --git a/glamor/glamor_gradient.c b/glamor/glamor_gradient.c index 9f6f1b1..6a7b528 100644 ---

[PATCH 4/6] dix: Remove incorrect comment about privates.

PRIVATE_ALL was apparently dropped before this comment was added in commit 495fc3eb2d6c98bde82ae1278f89fcf131fd9bf8. Signed-off-by: Eric Anholt e...@anholt.net --- dix/privates.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dix/privates.c b/dix/privates.c index

[PATCH 2/6] glamor: Fix a spelling mistake in GLAMOR_PIXMAP_FBO_NOT_EXACT_SIZE.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 2 +- glamor/glamor_render.c | 2 +- glamor/glamor_utils.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index f1440f3..119e4d9 100644 ---

[PATCH 6/6] xephyr: Don't forget to glViewport() before drawing the screen.

Fixes misrendering with cairogears. I had noticed the failure while trying to figure out what was going on with traps. Cairogears was apparently putting its results on the screen through putimage, which is a texture upload, so the last GL drawing was done to the size of the cairogears window,

little glamor cleanups (and a dix cleanup)

Here are some trivial patches from the glamor-server branch for review. I'm planning to send out the VBO changes next, which get us closer to making glamor not actually suck for performance. These are on the glamor-cleanups branch of my tree, branched from glamor-pull-request.

[PATCH 1/6] glamor: remove dead global variable.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 77197b5..f1440f3 100644 --- a/glamor/glamor_pixmap.c +++ b/glamor/glamor_pixmap.c @@ -697,7 +697,6 @@

Re: [PATCH RFC] Xorg: Add a suid root wrapper

On 03/ 6/14 04:46 AM, Mark Kettenis wrote: +canonical=$(readlink -f $0) POSIX doesn't specify readlink(1), so it might not be available on all systems. Solaris doesn't seem to have it. Perhaps just have configure substitute the installation path here? Solaris 11 and later have it, and I no

Re: [PULL] glamor xephyr and xorg changes

Eric Anholt e...@anholt.net writes: Eric Anholt (6): xephyr: Build support for rendering with glamor using a -glamor option. xephyr: Pass incoming XCB events to the Xlib event filter. xorg: Build a glamor_egl module. xorg: Connect up the glamor XV code, xorg DDX-only

[PATCH xmodmap] Add support for hyphen as placeholder for preserving a current keysym

So far, a keycode or keysym command always overwrote the entire list of keysyms associated with a keycode. However, users often want to modify only some of the keysyms in the list, e.g. only the keysyms assigned when the Mode_switch key is pressed. With this patch, it is now possible to reassign

Re: [PATCH 4/6] dix: Remove incorrect comment about privates.

Am 2014-03-06 18:00, schrieb Eric Anholt: PRIVATE_ALL was apparently dropped before There wasn't any PRIVATE_ALL key neither in xserver nor in glamor. I guess it's just a wrong reference to privates.h, so it's the same as the enum DevPrivateKey itself.

Re: [PATCH 3/6] glamor: Add a note about the state of GL_ARB_map_buffer_range.

Am 2014-03-06 18:00, schrieb Eric Anholt: +/* We'd like to require GL_ARB_map_buffer_range or OpenGL ES 3 or + * GL_OES_map_buffer_range, since it offers more information to + * the driver than plain old glMapBuffer() or glBufferSubData(). + * It's been supported on Mesa on the

Re: little glamor cleanups (and a dix cleanup)

Patches 1-5 are: Reviewed-by: Markus Wick markus at selfnet.de Am 2014-03-06 18:00, schrieb Eric Anholt: Here are some trivial patches from the glamor-server branch for review. I'm planning to send out the VBO changes next, which get us closer to making glamor not actually suck for

Re: [PATCH] dix: Clear any existing selections before initializing privates

Andrew Eikum aei...@codeweavers.com writes: Hi, we're less than a month out from the end of the 1.16 merge window[1]. Thanks for the reminder, and sorry for not getting it merged earlier! da08316..78e508c master - master -- keith.pack...@intel.com pgpiR6_F7UBnb.pgp Description: PGP

[PATCH] glx: Clear new FBConfig attributes to 0 by default.

The visualSelectGroup wasn't getting set (since our DRI drivers don't use it), and and since it's the top priority in the sort order, you got random sorting of your visuals unless malloc really returned you new memory. This manifested as Xephyr -glamor rendering to a multisampled window on my

Re: [PATCH] glx: Clear new FBConfig attributes to 0 by default.

On Don, 2014-03-06 at 19:07 -0800, Eric Anholt wrote: The visualSelectGroup wasn't getting set (since our DRI drivers don't use it), and and since it's the top priority in the sort order, you got random sorting of your visuals unless malloc really returned you new memory. This manifested as

Re: [PULL 1.15] First set of 1.15 fixes

Merged. Updating 2ea973e..f41ab8c On 02/18/2014 06:37 PM, Peter Hutterer wrote: Not sure if you still want to be the stable maintainer, but if so: here's your first set of cherry-picks. Mostly general cleanups that I found ont he branch, Carlos' patch fixes a crash with some tablet devices

Re: [PULL 1.14 and 1.15] XQuartz Hardening

1.14 merged. 200f988..4ab897c server-1.14-branch - server-1.14-branch 1.15 merged. f41ab8c..b332cd2 server-1.15-branch - server-1.15-branch On 01/22/2014 04:22 PM, Jeremy Huddleston Sequoia wrote: The 1.14 pull request is below. Please also pull changes for 1.15 when that branch