Re: Issues adding driver support for present extension

2014-04-22 Thread Frank Binns
Do let me know if that helps at all; I'm sorry I didn't get it out for review earlier. Thanks, that fixed some of the issues I was seeing. I've also had to make some additional changes to fix some other problems. I'll do my best to get some patches sent out in the next few days. Thanks

Re: [PATCH] os: Add -displayfd into -help text

2014-04-22 Thread Robert Ancell
Shall I resend it? I think I have set git send-email up correctly now. On Tue, Apr 22, 2014 at 5:17 PM, Keith Packard kei...@keithp.com wrote: Robert Ancell robert.anc...@canonical.com writes: ErrorF(-cc intdefault color visual class\n); ErrorF(-nocursor

Re: [PATCH] xfixes: Forbid manipulating clip for source-only pictures (#28968)

2014-04-22 Thread Adam Jackson
On Mon, 2014-04-21 at 21:51 -0700, Keith Packard wrote: Adam Jackson a...@redhat.com writes: Just throw BadPicture instead of crashing. It's not currently a meaningful thing to do anyway, RenderSetPictureRectangles would error if you tried (which this patch changes to BadPicture as well

Re: [PATCH] fb: Fix origin of source picture in fbGlyphs

2014-04-22 Thread Peter Harris
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2014-04-21 23:51, Keith Packard wrote: I've merged your fix and added your test app to the commit message so that the next time we find that this is broken, we can make sure the fix doesn't break this case again... Good idea. Thanks. It

Re: [PATCH] os: Add -displayfd into -help text

2014-04-22 Thread Keith Packard
Robert Ancell robert.anc...@canonical.com writes: Shall I resend it? I think I have set git send-email up correctly now. Sure, we'll at least get to test your setup. -- keith.pack...@intel.com pgp69gCNz6OZ2.pgp Description: PGP signature ___

Re: [PATCH] fb: Fix origin of source picture in fbGlyphs

2014-04-22 Thread Keith Packard
Peter Harris phar...@opentext.com writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2014-04-21 23:51, Keith Packard wrote: I've merged your fix and added your test app to the commit message so that the next time we find that this is broken, we can make sure the fix doesn't break

Re: [PATCH] xfixes: Forbid manipulating clip for source-only pictures (#28968)

2014-04-22 Thread Keith Packard
Adam Jackson a...@redhat.com writes: #include X11/Xlib.h #include X11/extensions/Xrender.h #include X11/extensions/Xfixes.h int main(void) { XRenderColor c = { 0, 0, 0, 0 }; Display *dpy = XOpenDisplay(NULL); Picture p = XRenderCreateSolidFill(dpy, c);

Re: Branching libXfont 1.4 1.5

2014-04-22 Thread Julien Cristau
On Sun, Apr 20, 2014 at 19:17:58 -0700, Alan Coopersmith wrote: I've reproduced this here as well. Here's my proposal to handle this incompatible change: - make a libXfont-1.4-branch to use for stable releases to get bug fixes to users of xorg-server-1.15 and older. It's configure.ac

Re: [PATCH] xfixes: Forbid manipulating clip for source-only pictures (#28968)

2014-04-22 Thread Adam Jackson
On Tue, 2014-04-22 at 07:52 -0700, Keith Packard wrote: Duh. Ok, so all three paths fail, two with segfaults and one with BadDrawable. In fairness you're probably right about the CT_PIXMAP paths being effectively unhittable, my commit message was really talking about the conceptual problem not

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Eric Anholt
Michel Dänzer mic...@daenzer.net writes: On 22.04.2014 04:08, Eric Anholt wrote: I think the must-do items for glamor in 1.16 will be done. As I mentioned before, there's also at least one fix for a memory leak in copy_n_to_n that needs to be ported from the standalone glamor tree, if

[PATCH xf86-input-synaptics] Add support for INPUT_PROP_TOPBUTTONPAD

2014-04-22 Thread Hans de Goede
Add a TopClickPad boolean config option which defaults to true for devices with the INPUT_PROP_TOPBUTTONPAD and false for all other devices. Only parse the SecondarySoftButtonAreas when this option is true, effectively disabling the top buttons when it is false. This means that it is now safe to

Re: [PATCH] Add a command line argument for disabling indirect GLX.

2014-04-22 Thread Julien Cristau
On Mon, Apr 21, 2014 at 17:13:41 -0700, Eric Anholt wrote: The attack surface for indirect GLX is huge, and it's of no use to most people (if you get an indirect GL context, you're better served by a immediate X error than actually trying to use an indirect GL context and finding out that it

Re: [PATCH] xfixes: Forbid manipulating clip for source-only pictures (#28968)

2014-04-22 Thread Keith Packard
Adam Jackson a...@redhat.com writes: I'm debating whether it's worth forcing clips to be regions in the DIX code in the next merge window. Probably? There are some pathological regions where expanding them to a8 masks could be less data and/or less iteration, but I'm not sure it'd be worth

Re: [PATCH] present: Queue flips for later execution

2014-04-22 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: When a flip (or unflip) is pending and a flip request comes in, leave it queued until the pending flip completes and then execute it. Signed-off-by: Keith Packard kei...@keithp.com --- present/present.c | 126

Re: [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-22 Thread Adam Jackson
On Fri, 2014-04-18 at 11:40 -0700, Eric Anholt wrote: @@ -545,9 +541,8 @@ _glamor_copy_n_to_n(DrawablePtr src, fail: -glamor_get_context(glamor_priv); +glamor_make_current(glamor_priv); glamor_set_alu(screen, GXcopy); -glamor_put_context(glamor_priv); if (ok)

[PULL] glamor-fixes

2014-04-22 Thread Eric Anholt
Here's a pair of reviewed (and s-o-bed) fixes for glamor. Hopefully tomorrow I can get a request in for the indirect GLX and get_image stuff. The following changes since commit ba2432a020a9f9bd0892f643117795336ba0fc16: xfixes: Forbid manipulating clip for source-only pictures (#28968)

Re: [PATCH] present: Queue flips for later execution

2014-04-22 Thread Keith Packard
Eric Anholt e...@anholt.net writes: vblank-pixmap = NULL; vblank-idle_fence = NULL; +vblank-flip = FALSE; +if (vblank-flip_ready) +present_re_execute(vblank); } } So, when we're replacing a previous

[PATCH] Add a command line argument for disabling indirect GLX.

2014-04-22 Thread Eric Anholt
The attack surface for indirect GLX is huge, and it's of no use to most people (if you get an indirect GL context, you're better served by a immediate X error than actually trying to use an indirect GL context and finding out that it doesn't support doing anything you want, slowly). This flag

Re: [PULL] glamor-fixes

2014-04-22 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Eric Anholt (1): glamor: Fix accelerated rendering of GTK's ARGB vs xBGR composites. Jamey Sharp (1): Make glamor build with --enable-debug. Merged. ba2432a..e924034 master - master -- keith.pack...@intel.com pgp2NY_cArkcr.pgp

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Adam Jackson
On Fri, 2014-04-18 at 11:39 -0700, Eric Anholt wrote: Here it is, at long last. I was stumped for several days with a weird fbo incomplete that was happening after my first round of fixes, and it took a day's detour of cooking up a Xephyr with DRI3 to get a fast debug environment and figure

Re: [PATCH xf86-input-synaptics] Always count tripletap + click as 3 fingerclick on pads with 3 touches

2014-04-22 Thread Peter Hutterer
On Fri, Apr 11, 2014 at 08:41:36PM +0200, Hans de Goede wrote: When trying to do a 3 fingerclick on a touchpad which only tracks 2 touches, this may register as a 3 or 2 fingerclick depending on the order in which the touchpad detects the fingers. If the 2 outer fingers of the 3 get seen

Re: [PATCH] Add a command line argument for disabling indirect GLX.

2014-04-22 Thread Keith Packard
Eric Anholt e...@anholt.net writes: The attack surface for indirect GLX is huge, and it's of no use to most people (if you get an indirect GL context, you're better served by a immediate X error than actually trying to use an indirect GL context and finding out that it doesn't support doing

[PATCH] glamor: Wire alpha to 1 for pictures without alpha bits

2014-04-22 Thread Keith Packard
When sourcing a picture that has no alpha values, make sure any texture fetches wire the alpha value to one. This ensures that bits beyond the depth of the pixmap, or bits other than the RGB values aren't used. Here's the actual patch: From 30ef8c0ec2808aa89a392ea8e744e12cec1bec37 Mon Sep

Re: rendercheck: warnings cleanups and a new test

2014-04-22 Thread Keith Packard
Eric Anholt e...@anholt.net writes: keithp sent me some code for a new test that reproduced a bug he was experiencing in glamor, so I pulled out rendercheck to add the testcase to it and found that it was really verbose with all the new warnings. The new warnings didn't appear to reveal

Re: [PATCH 01/12] glamor: Fix a missing set of the GL context.

2014-04-22 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keith.com -- keith.pack...@intel.com pgpA2SAaiYTeB.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 09/12] glamor: Replace glamor_get/put_context() with just glamor_make_current().

2014-04-22 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On Fri, 2014-04-18 at 11:40 -0700, Eric Anholt wrote: @@ -545,9 +541,8 @@ _glamor_copy_n_to_n(DrawablePtr src, fail: -glamor_get_context(glamor_priv); +glamor_make_current(glamor_priv); glamor_set_alu(screen, GXcopy); -

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Keith Packard
Eric Anholt e...@anholt.net writes: BTW, the 'glamor: Add glamor_transfer based glamor_get_image and glamor_put_image' commit in your glamor-fixes branch still breaks the libreoffice icons for me. Are you guys seeing that as well? Nope, don't see that here. I've sent a patch that fixes this

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: Minor comment on 9/12 that I don't think is a blocker. Otherwise, series plus Michel's fix are: I found a couple of other spurious glamor_make_current calls which I mentioned. I'm easy as to whether those are fixed before this lands or not; I assume Eric

[PATCH] os: Add -displayfd into -help text

2014-04-22 Thread Robert Ancell
Add -displayfd into -help text. It was mentioned in the man page but seem to have been missed from the -help text. --- os/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/os/utils.c b/os/utils.c index 60e828e..1555dbd 100644 --- a/os/utils.c +++ b/os/utils.c @@ -501,6 +501,7 @@

XorgEvoc participation and GL/GLSL tests for GL 4.0 and newer

2014-04-22 Thread Check Nyah
Hi, I am Nyah Check, a sophomore student of computer engineering at the University of Buea in Cameroon(Africa), and a GSoC participant for 2013, where i worked with BRL-CAD. I'll like to work on the Xorg project through the XorgEvoc program. I would like to work on the GL/GLSL tests project for

Re: [PATCH] hw/xwin: link dynamically and export symbols

2014-04-22 Thread Yaakov (Cygwin/X)
On 2014-04-22 00:18, Keith Packard wrote: Yaakov (Cygwin/X) writes: From: Yaakov Selkowitz With my patch to fix shared libXfont to work correctly on Cygwin/Win32, there is no need for -static anymore. But, XWin.exe must export its symbols in order for them to override libXfont's stubs. I

Re: [PATCH xf86-input-synaptics] Add support for INPUT_PROP_TOPBUTTONPAD

2014-04-22 Thread Peter Hutterer
On Tue, Apr 22, 2014 at 06:58:11PM +0200, Hans de Goede wrote: Add a TopClickPad boolean config option which defaults to true for devices with the INPUT_PROP_TOPBUTTONPAD and false for all other devices. Only parse the SecondarySoftButtonAreas when this option is true, effectively disabling