Hi,
On 07/15/2014 01:19 AM, Keith Packard wrote:
Hans de Goede hdego...@redhat.com writes:
Note the robustness patch needs to be applied after the fix, otherwise
the switch-case in the fix will fail to compile due to a duplicate
label.
This is better than my version as it effectively
Hi,
On 07/14/2014 03:41 PM, Daniel Stone wrote:
Hi,
On 14 July 2014 13:51, Hans de Goede hdego...@redhat.com wrote:
On 07/14/2014 02:43 PM, Julien Cristau wrote:
On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote:
Can I / we please get a reply from you on this ?
As explained
Hi,
On 07/15/2014 10:42 AM, Hans de Goede wrote:
snip
It might not be strictly harmful in some cases, but it's not the sort of
thing I want to encourage. 'Always include xorg-server.h before any X
header ever' is a really simple rule to remember for driver developers;
muddying the water,
Hans de Goede hdego...@redhat.com writes:
1) I was not around when the OdevAttributes stuff got added, but I
think the idea behind it was to be able to add new atrributes without
breaking ABI (as was done this cycle when adding the driver string,
although that needed a bit of a fixup).
The
On 15.07.2014 17:43, Hans de Goede wrote:
On 07/15/2014 10:42 AM, Hans de Goede wrote:
It might not be strictly harmful in some cases, but it's not the sort of
thing I want to encourage. 'Always include xorg-server.h before any X
header ever' is a really simple rule to remember for driver
14.07.2014 19:41, Daniel Stone wrote:
os.h isn't safe to necessarily safe to include without xorg-server.h, as
it drags in misc.h, which has: extern _X_EXPORT void SwapLongs(CARD32
*list, unsigned long count);
Again, CARD32 is unsigned long without xorg-server.h, which makes it
64-bit on those
Hi,
On 07/15/2014 11:33 AM, Keith Packard wrote:
Hans de Goede hdego...@redhat.com writes:
1) I was not around when the OdevAttributes stuff got added, but I
think the idea behind it was to be able to add new atrributes without
breaking ABI (as was done this cycle when adding the driver
While we have keyboard focus, the server's xkb code is already locking
and latching modifiers appropriately while processing keyboard
events.
Since there is no guaranteed order between wl_keyboard key and
modifiers events, if we got the modifiers event with a locked or
latched modifier and then
On Sat, Jul 12, 2014 at 12:46:15PM -0700, Alan Coopersmith wrote:
On 07/12/14 07:46 AM, Thomas Klausner wrote:
Can someone please review this series?
(I can push it myself.)
You might find more interested parties on dri-devel than on xorg-devel.
Thank you for the hint, I've just sent the
Hans de Goede hdego...@redhat.com writes:
I think defining 2 inlines for the 2 getter functions is a good idea.
I'll see if I can't make sure they provide some level of type safety too.
Can you resend the patch as a proper top-level mail with the inlines
added? Then I'll review it.
Thanks.
As noted in the comment in the file, X.Org controls the main X11 keysym
definitions, so adds new keysyms there, not in the XFree86 vendor space.
Reported-by: Gioele Barabucci gio...@svario.it
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
XF86keysym.h | 31
This allows drivers to compile using the old OdevAttributes API
against a new server. It generates compiler errors if the caller uses
the wrong or undefined attribute types, or if the caller provides an
incorrect default value for an integer attribute.
Signed-off-by: Keith Packard
Here's a 'real' version of the proposed OdevAttributes API
change. This one provides a patch which adds a backward compatible API
for drivers. I made that API perform compile-time checks on the
attribute and default values provided to make sure drivers won't get
surprised by the semantic
OdevAttributes are a fixed set of values with known types; instead of
storing them in a linked list and requiring accessor/settor functions,
replace the list header, struct OdevAttributes, with a struct that
directly contains the values. This provides for compile-time
typechecking of the values,
14 matches
Mail list logo
