On Mon, Oct 03, 2011 at 12:01:23PM -0700, Keith Packard wrote:
On Wed, 28 Sep 2011 13:57:27 -0700, Jamey Sharp ja...@minilop.net wrote:
Hi Keith! Here's some reviewed code deletion (hooray!) and the fix to
make kdrive build again after the last pull.
There was a comment requesting
On Tue, Oct 04, 2011 at 02:15:53PM +1000, Peter Hutterer wrote:
On Mon, Oct 03, 2011 at 09:02:19PM -0700, Keith Packard wrote:
On Tue, 4 Oct 2011 13:26:35 +1000, Peter Hutterer
peter.hutte...@who-t.net wrote:
Non-text part: multipart/signed
Store desktop dimensions in
For patches 1 through 9:
Reviewed-by: Jamey Sharp ja...@minilop.net
For patch 10 on, I had to call a lifeguard to rescue me from drowning in
input semantics. I like the sound of unify multiscreen pointer
behaviour between RandR and Xinerama though. :-)
Jamey
On Tue, Oct 04, 2011 at 03:23:56PM
On Tue, Oct 04, 2011 at 03:35:41PM +1000, Peter Hutterer wrote:
On Mon, Oct 03, 2011 at 10:02:28PM -0700, Jamey Sharp wrote:
On Tue, Oct 04, 2011 at 02:15:53PM +1000, Peter Hutterer wrote:
On Mon, Oct 03, 2011 at 09:02:19PM -0700, Keith Packard wrote:
On Tue, 4 Oct 2011 13:26:35 +1000
Commit by Jamey Sharp and Josh Triplett.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
dix/pixmap.c |7 ++-
exa/exa_classic.c|3 ---
exa/exa_driver.c |5 -
exa/exa_mixed.c |5
This replaces AllocatePixmap, which was previously called by the screen
hooks.
Commit by Jamey Sharp and Josh Triplett.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
Xext/shm.c |5 +--
composite/compalloc.c
in the git repository at:
git://anongit.freedesktop.org/~jamey/xserver pixmap-hooks
Jamey Sharp (3):
Have FreePixmap call screen hooks, not the other way around.
Introduce CreatePixmap, allocating a header and calling screen hooks.
Move pixmap size limit checking to CreatePixmap
, XAA_PIXMAP_OP_PROLOGUE would already have cleared
it.
In CopyArea, in any cases where the open-coded sync check actually ran,
it was immediately followed by an unconditional SYNC_CHECK in the
expansion of XAA_PIXMAP_OP_PROLOGUE, which would then be a no-op.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw
Since every fallback checks whether it needs to sync, just do it in the
prologue, like the pixmap ops do.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/xfree86/xaa/xaaFallback.c | 20
hw/xfree86/xaa/xaawrap.h |6 --
2 files changed, 4 insertions(+), 22
These are the only fallbacks that were ever choosing not to sync. This
patch makes them consistent with not only the other fallbacks, but also
with the pixmap fallbacks as of Luc Verhaegen's commit in 2008,
59f9fb4b8c031df69b3592a26b77e744ff4a556e.
Signed-off-by: Jamey Sharp ja...@minilop.net
.
The following changes since commit e45a5c9dcf77fc61bfed055f7d7a437741d07315:
Make GC clientClip always be a region. (2011-09-28 13:27:04 -0700)
are available in the git repository at:
git://anongit.freedesktop.org/~jamey/xserver cleanup-xaa
Jamey Sharp (4):
XAA: Delete redundant open
They were already doing nearly identical work, although now the ops may
short-circuit in the pixmap case if pGC-pCompositeClip is an empty
region; before, only the fallback ops could do that.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/xfree86/xaa/xaaFallback.c | 67 ++---
hw
: Remove unused bios_devmem.c
pci: Deprecate the PCITAG type
int10: Use pciaccess rom fetch for !PC machines
configure: change PCI function checking by a meaningful version of the library
darwin: configure: Force some irrelevant options to off on darwin
Reviewed-by: Jamey Sharp ja...@minilop.net
5aa826cdd1f2e768bedf23d399703a5d0b6302be introduced this new test
without ignoring the build product.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
test/.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/test/.gitignore b/test/.gitignore
index 0e1ed42..4c0a231
On Sat, Oct 01, 2011 at 11:20:25PM -0700, Jeremy Huddleston wrote:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
I think this series needs a Tested-by: though. I'll give it a go on
Monday if nobody beats me to it.
I'll hold off on requesting a pull, then. Thanks for the reviews!
Jamey
On Fri, Sep 30, 2011 at 08:53:25AM +1000, Peter Hutterer wrote:
On Thu, Sep 29, 2011 at 12:10:29PM -0700, Jamey Sharp wrote:
I use these settings in my nested/dummy testing, which seem to suffice
for me:
Section ServerFlags
Option AutoEnableDevices false
Option AutoAddDevices
On 10/2/11, Daniel Stone dan...@fooishbar.org wrote:
On 2 October 2011 09:19, Jeremy Huddleston jerem...@apple.com wrote:
Peter, any thoughts on this?
I think using * (1 16) * (1 16) is a better idea than (1ULL 32).
And I think ldexp is a much better idea than either. :-) It's more
clear,
On Wed, Sep 28, 2011 at 03:46:08PM -0700, Aaron Plattner wrote:
This breaks rendering to the root window. For example, run xsetroot
-solid green Part of the rendering is clipped away on one of the
screens. E.g., on my setup with a 1024x768 screen and a 1920x1080
screen to the right of it,
Reviewed-by: Jamey Sharp ja...@minilop.net
On Sat, Oct 01, 2011 at 08:43:52AM -0700, Alan Coopersmith wrote:
Fixes Sun compiler warning:
xkbAccessX.c, line 128: warning: implicit function declaration:
init_device_event
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xkb
I can
run dummy non-root without problems. Does it look acceptable?
I don't see anything wrong with it, so I'm happy to provide my
Reviewed-by: Jamey Sharp ja...@minilop.net
but since it's security-related I'd like to see somebody else review
it too before it gets merged. Others will have
I think this patch is totally sensible.
Reviewed-by: Jamey Sharp ja...@minilop.net
For the other patch in the series, xfree86/modes: Let the driver handle
the transform, I don't think I can review it. I don't know the relevant
code and the patch touches quite a bit.
I tried to see if I could
On Fri, Sep 30, 2011 at 12:10:05AM +0700, Antoine Martin wrote:
As discussed a while back [1], there are a number of issues which can
only be resolved by using an Xdummy binary server in order to replace
Xvfb with a more modern equivalent. The only alternative I can think of
would be to add a
is specified, this not require systemd installed.
Replace patch with path, and insert this *does* not.
Otherwise, I'd prefer somebody who cares about XDM to review, but I'm
happy to throw in my:
Reviewed-by: Jamey Sharp ja...@minilop.net
___
xorg-devel
Looks sane to me, for whatever that's worth:
Reviewed-by: Jamey Sharp ja...@minilop.net
On 9/27/11, Alan Coopersmith alan.coopersm...@oracle.com wrote:
The LookupWindow function was deprecated in xserver commit ed75b056511ccb4
and removed during the Xorg 1.11 merge window by commit
This is subsumed by earlier proposed patches; see this thread:
http://lists.x.org/archives/xorg-devel/2011-September/025497.html
On Wed, Sep 28, 2011 at 09:55:26AM -0700, Aaron Plattner wrote:
Older versions of GCC produce a warning when this attribute is used.
Signed-off-by: Aaron Plattner
On Wed, Sep 28, 2011 at 11:02:42AM -0700, Aaron Plattner wrote:
Xserer-spec.xml still lists ChangeClip in the mi section in the
list of server routines for porting, and DestroyClip in the ddx
section.
Good catch! Amended locally and on my published review-pending branch,
thanks.
Can't you
On Wed, Sep 28, 2011 at 11:48:38AM -0700, Aaron Plattner wrote:
On 09/26/2011 10:53 PM, Jamey Sharp wrote:
- for (i = nRects; i-- 0; ) {
...
+for (i = nRects; i-- 0; ) {
Whitespace error: i-- 0
The patch got mangled somewhere in transit. In my git tree, and in
Patchwork
On Wed, Sep 28, 2011 at 01:13:26PM -0700, Aaron Plattner wrote:
Reviewed-by: Aaron Plattner aplatt...@nvidia.com
Thanks!
On 09/28/2011 12:58 PM, Jamey Sharp wrote:
Yeah, I don't think that belongs in this commit. Actually, I want to
delete Xnest entirely, along with all the other non-xfree86
repository at:
git://anongit.freedesktop.org/~jamey/xserver reviewed
Jamey Sharp (3):
kdrive: Fix build for opaque InputOption structure.
Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.
Make GC clientClip always be a region.
Xext/panoramiX.c
this someplace */
- xalloc((num_adaptors + 1) * sizeof(XF86VideoAdaptorPtr*));
+ newAdaptors = malloc((num_adaptors + 1) *
sizeof(XF86VideoAdaptorPtr *));
Why did you delete this comment?
Otherwise,
Reviewed-by: Jamey Sharp ja...@minilop.net
If you'd produce another patch to delete
Reviewed-by: Jamey Sharp ja...@minilop.net
On Mon, Sep 26, 2011 at 10:41:50PM -0400, Matt Turner wrote:
Signed-off-by: Matt Turner matts...@gmail.com
---
src/mga_dri.c| 24
src/mga_driver.c | 20 ++--
src/mga_merge.c |6 ++
src
Reviewed-by: Jamey Sharp ja...@minilop.net
On Mon, Sep 26, 2011 at 10:41:52PM -0400, Matt Turner wrote:
Signed-off-by: Matt Turner matts...@gmail.com
---
src/mga_driver.c | 14 +-
src/mga_merge.c |2 +-
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/src
Reviewed-by: Jamey Sharp ja...@minilop.net
On Mon, Sep 26, 2011 at 10:58:24PM -0400, Matt Turner wrote:
I wonder if there are any other patterns we haven't seen yet?
Signed-off-by: Matt Turner matts...@gmail.com
---
hw/xfree86/fbdevhw/fbdevhw.c |2 --
1 files changed, 0 insertions
Commit 05284a03f9002b03a66ae355b34790ec02b726f0 missed fixing up
kdrive's use of the old non-opaque structure.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/kdrive/src/kinfo.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/hw/kdrive/src/kinfo.c b/hw
)
are available in the git repository at:
git://anongit.freedesktop.org/~jamey/xserver review-pending
Jamey Sharp (4):
kdrive: Fix build for opaque InputOption structure.
Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.
Make GC clientClip always be a region
Nothing ever set clientClip to anything but a region or NULL, so delete
the clientClipType field and change clientClip from (pointer) to
(RegionPtr).
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix/gc.c | 51 +--
exa/exa_accel.c
.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
Xext/panoramiX.c | 181 +-
Xext/panoramiX.h |1 -
Xext/panoramiXprocs.c | 354 -
Xext/panoramiXsrv.h |3 +-
Xext/shm.c| 38 ++
Xext/xvdisp.c
Use the mi implementation of these functions instead, moving them to
dix/gc.c.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
Xext/panoramiX.c | 32 --
dix/gc.c | 87 +--
doc/Xserver-spec.xml | 74
On Sun, Sep 25, 2011 at 08:18:31AM -0400, Gaetan Nadon wrote:
On Sat, 2011-09-24 at 19:50 -0700, Jeremy Huddleston wrote:
Should we move XCB from its own product into an xorg component for
consistency?
Yes, it is important to implement the proper X.Org project architecture.
I'll take
On Sun, Sep 25, 2011 at 01:50:01PM -0400, Matt Turner wrote:
Dave pointed out that there are a couple drivers (sis, sisusb, vmware)
that use the swapl/swaps macros. My recent patch series dropped the n
argument from the macros, causing these drivers to not build.
Ideally, we'd like a
Reviewed-by: Jamey Sharp ja...@minilop.net
On Sat, Sep 24, 2011 at 12:01:11AM -0700, Jeremy Huddleston wrote:
The ABI changed in the previous series of changes, so bump the ABI version for
the next release.
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
I believe this is correct
Reviewed-by: Jamey Sharp ja...@minilop.net
On Sat, Sep 24, 2011 at 10:31:26AM -0700, Alan Coopersmith wrote:
xhost needs the Family definitions from X11/Xauth.h to build, but
doesn't call any libXau functions, so doesn't need to link against it.
Fixes Solaris ld -z guidance warning:
ld
Looks good to me!
Reviewed-by: Jamey Sharp ja...@minilop.net
On 9/23/11, Rami Ylimäki rami.ylim...@vincit.fi wrote:
The 'Dispatch' function accesses freed client structure if a client
happens to kill itself in a request. For example, I have a test client
that is used to check that it handles
I'd rather see a real loop than one simulated by an extra variable and
a goto. You just need to move the fbdevHWSetMode up to where the break
statement is, and only break if setting the mode succeeded--right?
Jamey
On 9/22/11, Dave Airlie airl...@gmail.com wrote:
From: Adam Jackson
This patch makes sense to me, but I have a couple of requests:
I'm not sure why you extracted out a separate function; I'm not
convinced that makes the code more clear, in this case.
More importantly, I'd like to see justification in the commit message
for deleting LBX support here. I seem to
Reviewed-by: Jamey Sharp ja...@minilop.net
Seems like there ought to be a better way than listing which compilers
support it, though. I considered an autoconf test to check whether
__builtin_constant_p is defined, but that doesn't tell you which
compiler is pulling in misc.h each time it's used
Reviewed-by: Jamey Sharp ja...@minilop.net
On Thu, Sep 22, 2011 at 05:55:33PM -0700, Alan Coopersmith wrote:
The more recent inclusions of this file haven't been checking for
HAVE_STDINT_H, so might as well make the older ones consistent.
Signed-off-by: Alan Coopersmith alan.coopersm
Reviewed-by: Jamey Sharp ja...@minilop.net
What I said for Alan's patch goes for this one too:
Seems like there ought to be a better way than listing which compilers
support it, though. I considered an autoconf test to check whether
__builtin_constant_p is defined, but that doesn't tell you
On 9/20/11, Dirk Wallenstein hals...@t-online.de wrote:
On Tue, Sep 20, 2011 at 09:54:35AM +0200, Matthieu Herrb wrote:
I recently looked at the X.Org patchwork
(http://patchwork.freedesktop.org/project/Xorg/list/). It also
appears to have a lot of stale data. Any plans to clean it up too ?
I'm a bit skeptical... Would ldexp(frac, -32) work for you? Otherwise
I'd argue for (UINT64_C(1) 32).
Jamey
On Tue, Sep 20, 2011 at 10:19:54AM +1000, Peter Hutterer wrote:
Reported-by: Jeremy Huddleston jerem...@apple.com
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
something
repository at:
git://anongit.freedesktop.org/~jamey/xserver reviewed
Jamey Sharp (11):
x86emu: There is no NO_INLINE implementation of unaligned access here.
configure.ac: Remove unused XORG_OS_PCI variable.
configure.ac: XORG_OS is not used, so delete it.
Remove PC98
Sharp wrote:
This reverts commit bc0c56c407117d1545e20d21f7d30eb3472d618b since we're
breaking ABI anyway.
Conflicts:
ChangeLog
dix/colormap.c
dix/pixmap.c
dix/window.c
include/pixmapstr.h
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix
On Tue, Sep 20, 2011 at 03:30:31PM +1000, Peter Hutterer wrote:
i'd remove the space before '(' but otherwise
Are you talking about this hunk?
On Sat, Sep 17, 2011 at 03:22:32AM -0500, Jamey Sharp wrote:
-extern _X_EXPORT DevPrivateKeyRec cursorScreenDevPriv[MAXSCREENS];
-#define
Alan Coopersmith explains:
XmuSnprintf() can be replaced by snprintf() now. (It was a
implementation X provided for it's libraries to use in the days
before all platforms we cared about had snprintf in libc.)
Reported-by: walter harms wha...@bfs.de
Signed-off-by: Jamey
.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
I tested this patch when I originally posted it last year using a pair
of xf86-video-dummy screens and x11vnc. After rebasing, I've re-tested
using two xf86-video-nested screens. It works great and deletes a bunch
of code. I'd really appreciate review
I've built each patch in the series and minimally tested that each
resulting server works with the xf86-video-nested driver, a window
manager, and an xterm. That means I'm not testing most of the changed
code paths, but I'm doing what I can on this airplane...
Patches 3 and 4 don't compile
This reverts commit bc0c56c407117d1545e20d21f7d30eb3472d618b since we're
breaking ABI anyway.
Conflicts:
ChangeLog
dix/colormap.c
dix/pixmap.c
dix/window.c
include/pixmapstr.h
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix/colormap.c |7
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/dmx/input/lnx-keyboard.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c
index 5bfb881..5b92f3b 100644
--- a/hw/dmx/input/lnx-keyboard.c
+++ b/hw/dmx/input/lnx
The following patches should be independent, except that the last three
won't apply cleanly in another order. I think they're mostly pretty
obvious, so I hope they get reviewed. I didn't manage to get them
reviewed around XDS last year, although I don't think I even managed to
send out the patches
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/dmx/glxProxy/glxcmds.c | 41 ++---
hw/dmx/glxProxy/glxscreens.c | 39 ---
hw/dmx/glxProxy/render2swap.c |2 +-
3 files changed, 39 insertions(+), 43 deletions
Also fix up XineramaInitData's caller, XineramaReinitData.
Commit by Jamey Sharp and Josh Triplett.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
Xext/panoramiX.c | 12 ++--
Xext/panoramiXsrv.h |2 +-
hw/dmx
Commit by Jamey Sharp and Josh Triplett.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
Xext/shm.c |6 +-
dix/dispatch.c |1 -
2 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/Xext/shm.c b/Xext/shm.c
index b08af82
Use new per-screen privates API instead.
Commit by Jamey Sharp and Josh Triplett.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Josh Triplett j...@joshtriplett.org
---
dix/cursor.c |2 +-
dix/dispatch.c |2 +-
hw/dmx/dmxcursor.h
This field was never read at any time in the git history.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
hw/xnest/GC.c |3 ---
hw/xnest/XNGC.h |1 -
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw/xnest/GC.c b/hw/xnest/GC.c
index 7968b4f..48fe4dc 100644
--- a/hw
Use the mi implementation of these functions instead, moving them to
dix/gc.c.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
Xext/panoramiX.c | 32 --
dix/gc.c | 87 +--
doc/Xserver-spec.xml | 74
Nothing ever set clientClip to anything but a region or NULL, so delete
the clientClipType field and change clientClip from (pointer) to
(RegionPtr).
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix/gc.c | 51 +--
exa/exa_accel.c
On Thu, Sep 15, 2011 at 09:13:09PM -0700, Alan Coopersmith wrote:
On 09/15/11 20:51, Jamey Sharp wrote:
On Thu, Sep 15, 2011 at 06:42:59PM -0700, Alan Coopersmith wrote:
On 09/15/11 13:07, Jamey Sharp wrote:
It looks to me like you should also delete VTSYSRQ from
hw/xfree86/parser
The following changes since commit 0caeef6146bee5fb1827ab25db191685dde9d4b4:
Version bumped to 1.11 (2011-08-26 16:46:13 -0700)
are available in the git repository at:
git://anongit.freedesktop.org/~jamey/xserver reviewed
Jamey Sharp (6):
x86emu: There is no NO_INLINE implementation
On Wed, Sep 14, 2011 at 10:33:55PM -0700, Chase Douglas wrote:
+if ! test x$UNSTABLE_LIB = xyes; then
+AC_MSG_ERROR([This branch contains elements which have not yet been
finalised. When this branch is updated, you will probably need to recompile
both the any clients using the library,
Reviewed-by: Jamey Sharp ja...@minilop.net
On Wed, Sep 14, 2011 at 08:17:39PM -0500, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/fbdevhw/fbdevhw.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/fbdevhw
this patch is the right thing to do
even if it doesn't make any difference on the platforms that already
supported the xfree86 DDX.
https://www.gnu.org/s/libtool/manual/libtool.html#Modules-for-libltdl
Therefore:
Reviewed-by: Jamey Sharp ja...@minilop.net
But I'd also like to hear from Gaetan
Reviewed-by: Jamey Sharp ja...@minilop.net
On Wed, Sep 14, 2011 at 08:17:39PM -0500, Jeremy Huddleston wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
hw/xfree86/fbdevhw/fbdevhw.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/fbdevhw
not something we should be
condoning anymore.
Kill it with fire, but while you're at it, untangle the hideous
mess of MGA_HAL() macros too.
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Adam Jackson a...@redhat.com
---
So, like this? I've left the MGA_NOT_HAL macros alone because
Reviewed-by: Jamey Sharp ja...@minilop.net
On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote:
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com
---
hw/xfree86/os-support/bsd/bsd_bell.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw
Based purely on code inspection, this patch looks right to me.
Reviewed-by: Jamey Sharp ja...@minilop.net
On Thu, Sep 15, 2011 at 11:20:22PM +0600, Alexandr Shadchin wrote:
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com
---
hw/xfree86/common/xf86Globals.c |1
Again, based purely on code inspection, this looks right.
Reviewed-by: Jamey Sharp ja...@minilop.net
On Thu, Sep 15, 2011 at 11:20:23PM +0600, Alexandr Shadchin wrote:
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com
---
hw/xfree86/os-support/bsd/bsd_init.c |5 +
1 files
, though; something like:
Since OsInit closes stdin before the xfree86 DDX opens the
console, fstat on stdin will always fail, so it's safe to delete
code that attempts it.
I'd also like a better short description than Remove dead code.
Still:
Reviewed-by: Jamey Sharp ja
It looks to me like you should also delete VTSYSRQ from
hw/xfree86/parser/xf86tokens.h.
If you fix that,
Reviewed-by: Jamey Sharp ja...@minilop.net
I can't review the remaining patches in this series because I'm not
familiar enough with the BSDs.
Jamey
On Thu, Sep 15, 2011 at 11:20:28PM +0600
On Thu, Sep 15, 2011 at 01:30:02PM -0700, Chase Douglas wrote:
Personally, I would prefer a monolithic tree with separate branches for
backporting driver changes to older server versions. I would also prefer
each driver having a stated policy of how many back revisions of servers
are supported
On Thu, Sep 15, 2011 at 07:28:25PM -0400, Gaetan Nadon wrote:
On Wed, 2011-09-14 at 10:07 -0500, Jamey Sharp wrote:
configure --with-int10=yes is not a valid configuration, and the check
It depends what is the definition of valid in this context. Running
./configure --with-int10 will set
On Thu, Sep 15, 2011 at 06:42:59PM -0700, Alan Coopersmith wrote:
On 09/15/11 13:07, Jamey Sharp wrote:
It looks to me like you should also delete VTSYSRQ from
hw/xfree86/parser/xf86tokens.h.
Please ensure that any changes result in the X server simply ignoring
the VTSysReq option
I retract this patch. I didn't see this section of
hw/xfree86/int10/Makefile.am:
if I386_VIDEO
I386_VIDEO_CFLAGS = -D_PC
endif
configure.ac is setting I386_VIDEO on i*86 and x86_64/amd64.
Jamey
On Tue, Sep 13, 2011 at 05:36:48PM -0500, Jamey Sharp wrote:
I can't find any evidence that _PC has
configure --with-int10=yes is not a valid configuration, and the check
for sys/vm86.h and sys/io.h is not used. Delete it.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
configure.ac|4
include/dix-config.h.in |6 --
2 files changed, 0 insertions(+), 10 deletions
On Wed, Sep 14, 2011 at 10:39:53AM -0500, Alan Coopersmith wrote:
On 09/14/11 10:07 AM, Jamey Sharp wrote:
configure --with-int10=yes is not a valid configuration, and the check
for sys/vm86.h and sys/io.h is not used. Delete it.
AM_CONDITIONAL(INT10_VM86, [test x$INT10 = xvm86
to not ship int10 support.
Signed-off-by: Adam Jackson a...@redhat.com
Reviewed-by: Jamey Sharp ja...@minilop.net
---
I'd like to resurrect this patch that ajax proposed a year ago. The
thread where it was last discussed is here:
http://lists.x.org/archives/xorg-devel/2010-July/011163.html
Throughout the xserver git history, the generic portion of the int10
module has always used other methods for reading the video BIOS. For
some time now it's been purely libpciaccess based. This commented-out
use of xf86ReadBIOS is entirely superfluous.
Signed-off-by: Jamey Sharp ja...@minilop.net
Excellent, thanks Sam.
Reviewed-by: Jamey Sharp ja...@minilop.net
Peter says he'll route this through his tree, so I'll leave it to him.
Jamey
On Wed, Sep 14, 2011 at 10:00:45AM +0800, Sam Spilsbury wrote:
From cf2cd8c03551c42d73a21ac5077904c8ec8ee4bd Mon Sep 17 00:00:00 2001
From: Sam
be more clear if you delete the if statement. Just
unconditionally mask off the SendEvent bit; if it already wasn't set,
the statement will just have no effect.
Still, either way:
Reviewed-by: Jamey Sharp ja...@minilop.net
Jamey
signature.asc
Description: Digital signature
As far as I can tell, none of this code has been used since the
beginning of git history.
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Adam Jackson a...@redhat.com
Cc: Corbin Simpson mostawesomed...@gmail.com
---
I don't have any mga hardware to test with, but I have compile-tested
this patch
Patch produced with:
unifdef -UNO_INLINE -B
This change isn't relevant to the similar code in
xfree86/common/compiler.h, because x86emu is expected to someday move
out of xserver entirely and so should not depend on any xserver headers.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Jamey Sharp ja...@minilop.net
---
configure.ac |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index bc34c72..6c4fffd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1573,7 +1573,6 @@ if test x$XORG = xyes
This is the last mention after ccfaf82367c9d057fd8314ce36b47f0a8eb696b6
quit using the variable.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
configure.ac |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2ac1f2e..bc34c72 100644
I can't find any evidence that _PC has ever been defined.
Patch created by fixing the documentation that referenced _PC, and
running:
for f in `git grep -Fwl _PC -- '*.[ch]'`; do
unifdef -U_PC -B $f | sponge $f;
done
Signed-off-by: Jamey Sharp ja...@minilop.net
Gaetan Nadon wrote:
Alan Coopersmith wrote:
I think we recently dropped PC98 support from the X server, so I'd
be okay with dropping the documentation now.
Let's make them be right, shall we?
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Alan Coopersmith alan.coopersm
On Fri, Sep 02, 2011 at 01:59:12PM +1000, Peter Hutterer wrote:
Hints appreciated on how to make get_desktop_dimensions() more efficient.
Presumably this could be precalculated on screen changes only but frankly I
have no idea where to hook in here.
Since this is DIX-level code, wouldn't
Still
Reviewed-by: Jamey Sharp ja...@minilop.net
:-)
On Fri, Aug 26, 2011 at 09:38:19PM -0700, Alan Coopersmith wrote:
Fortunately, the massive decrease in the cost of whitespace in the past
decade has allowed us to be much more generous with it, and much more
consistent in its application
On 8/25/11, Alan Coopersmith alan.coopersm...@oracle.com wrote:
I had unindented those so they didn't line wrap at 80 columns - which style
would people prefer? lines longer than 80 columns? splitting the messages
into multiple adjacent strings for the compilers to concatenate? or just
Using git diff -w,
Reviewed-by: Jamey Sharp ja...@minilop.net
Extra bonus points for the excellent commit message.
Although it looks like the diff could still get a little better:
On Thu, Aug 25, 2011 at 09:59:00PM -0700, Alan Coopersmith wrote:
+xf86DrvMsg(f-d.pI2CBus-scrnIndex, X_INFO
Reviewed-by: Jamey Sharp ja...@minilop.net
but there are a few things I'd quibble about. First, of course, the
debian/changelog hunk doesn't go upstream. :-) A patch to the upstream
repo in git-format-patch format would be easier to apply; see
http://wiki.x.org/wiki/Development/Documentation
I have a few comments, I guess.
- The indentation in the GetReqExtra definition didn't work out. Looks
like it should be tabs and tabs only, there.
- This patch turns a buffer overrun into a null-pointer dereference if
there's any caller that hasn't been updated. (While you've hit all the
101 - 200 of 566 matches
Mail list logo
