Re: libXaw3d hosting on freedesktop

2011-08-01 Thread Pat Kane
Matt, Thank you for working on Xaw3d issues. I have an old, and reliable, X client that will work better after your changes are merged. Pat --- On Mon, Aug 1, 2011 at 1:43 PM, Matt Turner matts...@gmail.com wrote: On Mon, Aug 1, 2011 at 2:13 PM, Alan Coopersmith

Re: Spinning in _XReply

2011-02-21 Thread Pat Kane
On Mon, Feb 21, 2011 at 7:51 PM, Jeremy Huddleston jerem...@apple.com wrote: So... what should we do about this? A good first step would be to try come up with a small-ish test case, or to at least figure out how to reproduce the problem on another system. I use EMACS on my RHEL6 and

Re: Spinning in _XReply

2011-02-21 Thread Pat Kane
On Mon, Feb 21, 2011 at 9:38 PM, Jeremy Huddleston jerem...@apple.com wrote: IDL is a data visualization package used a lot by astrophysicists \ (http://www.ittvis.com/ProductServices/IDL.aspx) Thanks, I'll take a look at IDL.  Should we actualy support calling _XReply from an error

Xorg code style guide?

2011-02-02 Thread Pat Kane
Do we have an Xorg code style guide? [1] I'm trying to improve the XShape man pages and would like to include a small example program, so I'd like to format it correctly (dot all the T's and cross all the I's :-) Pat --- [1] By default I'll just look at some of the latest GIT change sets

Re: Xorg code style guide?

2011-02-02 Thread Pat Kane
Do we have an Xorg code style guide? Just after I sent that email Google found this link: http://www.x.org/wiki/CodingStyle sorry for the noise. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: supporting non-rectangular windows

2011-02-01 Thread Pat Kane
thanks in advance On Tue, Feb 1, 2011 at 7:15 AM, Pat Kane pekan...@gmail.com wrote: You  should add a line like this too:  XSelectInput(dsp, win, ExposureMask|ButtonPressMask|ButtonReleaseMask ); On Mon, Jan 31, 2011 at 9:39 AM, Pat Kane pekan...@gmail.com wrote: Add this line just

Re: supporting non-rectangular windows

2011-01-31 Thread Pat Kane
Add this line just before the event loop: XMapWindow(dsp, win); Pat --- On Mon, Jan 31, 2011 at 2:05 AM, Prasanta Sadhukhan psadhuk...@gmail.com wrote: Thanks for the pointer. I saw that the example use widget API through XCreateManagedWIdget APIs. Are this required to use the shape

Re: supporting non-rectangular windows

2011-01-31 Thread Pat Kane
You should add a line like this too: XSelectInput(dsp, win, ExposureMask|ButtonPressMask|ButtonReleaseMask ); On Mon, Jan 31, 2011 at 9:39 AM, Pat Kane pekan...@gmail.com wrote: Add this line just before the event loop:  XMapWindow(dsp, win); Pat --- On Mon, Jan 31, 2011 at 2:05 AM

Re: Spinning in _XReply

2011-01-29 Thread Pat Kane
28 __XReply + 512 (in libX11.6.dylib) [0x6d50c0] ... 11 __XReply + 240 (in libX11.6.dylib) [0x6d4fb0] I just took a quick look at xcb_io.c to see what _XReply is doing, and I doubt that it is reentrant. The

Re: [PATCH modular 7/8] build.sh: improve error msg by adding full make command

2011-01-04 Thread Pat Kane
Is there a way to retry the failed make with V=1 set? It would be nice to see the full command line that failed. BTW, thanks for your work in cleaning up the build script, it is much nice to use these days. I'm currently trying a build from 76 tarballs -- I'll let you know what I had to do to

Re: Utility to combine (reparent) windows from different apps into a single tabbed window.

2010-12-22 Thread Pat Kane
Take a look at http://library.gnome.org/devel/libwnck/stable/intro.html libwnck is the Window Navigator Construction Kit Pat --- On Wed, Dec 22, 2010 at 6:02 AM, Charlie Ross ro...@cs.colostate.edu wrote: Hiya,   I have been thinking about a utility which would collect several windows

[PATCH xditview] make sure filename is a regular file.

2010-12-07 Thread Pat Kane
This is the second version of patch. It now uses fstat instead of stat as recommended in review comments from: Philipp Hagemeister phi...@phihag.de. Bug was reported by: Krzysztof Żelechowski giecr...@stegny.2a.pl Signed-off-by: Pat Kane pekan...@gmail.com P.S. also attached, in case

Re: [PATCH damageproto (rev3) 1/3] Document changes in damage proto version 1.2

2010-12-02 Thread Pat Kane
On Thu, Dec 2, 2010 at 8:02 PM, Aaron Plattner aplatt...@nvidia.com wrote: ... James doesn't have an fd.o account, so I'll push them on his behalf. How does one get an fd.o account these days? I've tried a couple of times with out luck[1]. Pat --- [1] I just assumed the fd.o bogon-filters

Re: [PATCH] include: let BitIsOn() return a boolean value.

2010-11-25 Thread Pat Kane
Okay then, fine with me -- ship it. On Wed, Nov 24, 2010 at 10:57 PM, Peter Hutterer peter.hutte...@who-t.net wrote: tbh, I'd rather not explain C constructs in comments unless really really necessary. We currently have 18 occurances of !! in the server code

Re: [PATCH] include: let BitIsOn() return a boolean value.

2010-11-24 Thread Pat Kane
What the deal with the !! operator? I read it as a double logical negation. A NOOP, does it have some useful side effect? On Wed, Nov 24, 2010 at 10:30 AM, walter harms wha...@bfs.de wrote: Am 24.11.2010 07:25, schrieb Keith Packard: On Wed, 24 Nov 2010 14:40:11 +1000, Peter Hutterer

Re: [PATCH] include: let BitIsOn() return a boolean value.

2010-11-24 Thread Pat Kane
Okay, with that info and if you could make the macro something like this: #define BitIsOn(ptr, bit) (!!(((BYTE *) (ptr))[(bit)3] (1 ((bit) 7 /* !! converts to boolean */ then: Reviewed: Pat Kane pekan...@gmail.com Pat P.S. I love C, it is my favorite assembly code. -- PEK

Re: Respository vandalism by r...@...fd.o

2010-11-24 Thread Pat Kane
.. we can go forward with development releases I agree. Since Adam and Daniel did the right thing and admitted to the prank[1] we can go forward with a release. Pat --- [1] admitting to making a blunder is hard to do, I know from personal experience, so I think both Adam and Daniel

Re: driver/xf86-input-keyboard wants IDevPtr

2010-11-18 Thread Pat Kane
On Wed, Nov 17, 2010 at 6:29 PM, Peter Hutterer peter.hutte...@who-t.net wrote: I've got patches ready for all but the penmount driver I think, just need to upstream them. IIRC the acecad patches are on the list waiting for some review lovin'. I will give your patches of 'review love' after

build.sh build order for mesa and makedepend

2010-11-15 Thread Pat Kane
Mesa needs makedepend, but util/makedepend is done much later in the build script. Pat --- ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

driver/xf86-input-keyboard wants IDevPtr

2010-11-15 Thread Pat Kane
I am getting errors while trying to build git master input drivers because some of them have lines like this: static InputInfoPtr KbdPreInit(InputDriverPtr drv, IDevPtr dev, int flags); ./xf86-input-keyboard/src/kbd.c:KbdPreInit(InputDriverPtr drv, IDevPtr dev, int flags) Looks like

build.sh broken on Solaris 10

2010-11-11 Thread Pat Kane
The following build.sh lines do not work with Solaris 10 /bin/sh local rtn local needs_config=0 local line local module local component looks like build.sh is turning into a bash script, which is okay, but if so, please fix the first line of the file. Pat ---

Re: build.sh broken on Solaris 10

2010-11-11 Thread Pat Kane
You guys have added some really nice features to build.sh, like -L, thank you. I would not mind if you required that it be a bash script, just that the 1st line says it is a /bin/sh script. If anyone really thinks that this build.sh script needs to be compatible with a very old /bin/sh I will

Re: [PATCH] Allow os/backtrace.c to compile on Solaris 10.

2010-11-10 Thread Pat Kane
On Wed, Nov 10, 2010 at 1:42 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: It should be fine to just include these headers unconditionally.  That would reduce the #ifdef clutter a bit. I think you are right, but I did not want to break builds on other systems this close to a release...

Re: [PULL] revert arm backtrace fix, introduce client id tracking

2010-11-10 Thread Pat Kane
On Wed, Nov 10, 2010 at 4:54 PM, Keith Packard kei...@keithp.com wrote: Seems like just sticking new fields in the client and having the OS initialize them when the client connects would make most of this code unnecessary. Yeah, I have a local hack that uses the 3 pad bytes in

Re: [RFC] merged void driver

2010-11-06 Thread Pat Kane
On Sat, Nov 6, 2010 at 5:05 PM, Peter Hutterer peter.hutte...@who-t.net wrote: ...  the simple solution is to ditch support for older X servers (I don't think anyone really cares about void supporting the last 3 server releases) but exactly at that point it starts making sense merging the

Re: [PATCH] xserver: Enable visible cursor on start without -retro #26798

2010-10-21 Thread Pat Kane
I would like to have a visible cursor by default. The ugly root weave can stay hidden -- but I kinda like it, since it looks really bad on crufty displays. Oh, and I think the bike shed needs to be painted a slightly darker shade of black (-BR ?). Pat --- On Thu, Oct 21, 2010 at 12:46 AM,

Re: [PATCH] Use external tool for creating backtraces on crashes if available.

2010-10-11 Thread Pat Kane
On Mon, Oct 11, 2010 at 4:50 AM, Matthias Hopf mh...@suse.de wrote: What do you think - would it make sense to call gdb on solaris if it is installed, or always pstack? My Solaris preference is to call stack dumpers in this order[1]: mdb, gdb, adb, pstack it would be nice if the script

Re: xhost: /etc/X*.hosts

2010-10-07 Thread Pat Kane
Try: man Xserver | grep /etc/X on my Ubuntu system it gives: /etc/Xn.hosts Initial access control list for display number n On Thu, Oct 7, 2010 at 1:19 PM, Jeremy Huddleston jerem...@apple.com wrote: This was reported to me and I thought I should pass it along...

Re: xhost: /etc/X*.hosts

2010-10-07 Thread Pat Kane
:37 PM, Jeremy Huddleston jerem...@apple.com wrote: On Oct 7, 2010, at 11:27, Pat Kane wrote: Try:     man Xserver | grep /etc/X on my Ubuntu system it gives: /etc/Xn.hosts                 Initial access control list for display   number n Ok, so then is that another instance that needs

Re: access to bugs.freedesktop.org failed

2010-10-05 Thread Pat Kane
When I try to access bugs.freedesktop.org I get the usual warning about a bogus web site certificate, I have to add an exception, but then I can access the page. Pat --- On Tue, Oct 5, 2010 at 9:45 AM, walter harms wha...@bfs.de wrote: Hi list, i have problems accessing bugs.freedesktop.org,  

Re: [PATCH] xfree86: Add 18bpp support

2010-09-28 Thread Pat Kane
On Tue, Sep 28, 2010 at 1:15 AM, Kai-Uwe Behrmann k...@gmx.de wrote: Just a curious question, Who is using 6+6+6 encoding for what? Many handheld devices use TFT LCDs (Thin film transistor liquid crystal display) which have 6 bits per RGB. See http://en.wikipedia.org/wiki/TFT_LCD Pat

Re: Out-of-tree/off-site X.Org documentation

2010-09-26 Thread Pat Kane
I use this one when I need to explain copy/cut/paste: http://www.jwz.org/doc/x-cut-and-paste.html On Fri, Sep 24, 2010 at 4:59 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Anyone else have others to contribute/suggest? ___

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread Pat Kane
In the original code if 'i' is equal to 10 then the line (void) memmove((char*)par, (char*)params, i * sizeof(String) ); moves ten things, which is okay. The next line: bzero( par[i], (10-i) * sizeof(String) ); moves zero things to a bad address, which is probably okay, but I bet some code

Re: patch: libXt-1.0.8 fix possible array overflow

2010-09-23 Thread Pat Kane
setting the limit to i=9 would fix that. But then the line (void) memmove((char*)par, (char*)params, i * sizeof(String) ); would be wrong since it would move nine instead of ten things. ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 0/3] xserver: Client ID tracking

2010-08-31 Thread Pat Kane
On Tue, Aug 31, 2010 at 3:35 AM, Rami Ylimäki rami.ylim...@vincit.fi wrote: ... You are right in that we mainly care about local clients, because in practice on our system all clients will be local. But I think that having a good way to identify local clients is still very important

Re: Old O'Reilly X books

2010-08-26 Thread Pat Kane
I'd love to have another copy of The X Window System Server X Version 11, Release 5 By Elias Israel and Erik Fortune and copy of the Maroon X bible (Digital Press?) would be nice too. The only interesting dead trees that I have to trade is an old xerox copy of HAKMEM (AI Memo 239)

Re: Old O'Reilly X books

2010-08-26 Thread Pat Kane
);/* HAKMEM 169 */ ... On Thu, Aug 26, 2010 at 7:32 AM, Pat Kane pekan...@gmail.com wrote: The only interesting dead trees that I have to trade is an old xerox copy of HAKMEM (AI Memo 239) ___ xorg-devel@lists.x.org: X.Org development Archives

Re: Old O'Reilly X books

2010-08-26 Thread Pat Kane
2) 0x); n = (n + (n 4)) 0x0f0f0f0f; n += n 8; n += n 16; return ((unsigned int) (n 0xff)); } On Thu, Aug 26, 2010 at 10:11 AM, Aaron Plattner aplatt...@nvidia.com wrote: On Thu, Aug 26, 2010 at 05:43:53AM -0700, Pat Kane wrote: BTW, while trying

You are not authorized to access bug #28801.

2010-08-20 Thread Pat Kane
When I try to access bug 28801 https://bugs.freedesktop.org/show_bug.cgi?id=28801 I get the message: You are not authorized to access bug #28801. I can see the bugs just fine. Why does bugzilla hate me? [insert your own joke here] Pat --- ___

Re: Fwd: Profiling Xorg

2010-08-12 Thread Pat Kane
The NetBSD gprof(1) man page says to use the -pg flag: http://netbsd.gw.com/cgi-bin/man-cgi?gprof+1+NetBSD-current On Thu, Aug 12, 2010 at 12:43 AM, Daniel Stone dan...@fooishbar.org wrote: On Thu, Aug 12, 2010 at 07:17:36AM +0200, Matthew Fincham wrote: I sent the email below to the

Re: Fwd: Profiling Xorg

2010-08-12 Thread Pat Kane
BTW, here is an interesting line from the Bugs section of the manual: The profiled program must call exit(2) or return normally for the profiling information to be saved in the gmon.out file. Pat --- On Thu, Aug 12, 2010 at 11:26 AM, Pat Kane pekan...@gmail.com wrote

Re: [PATCH:xf86-input-mouse] MouseCtrl doesn't need to save values we never use

2010-08-12 Thread Pat Kane
The change does not break my Solaris 10 build. Reviewed-by: Patrick E. Kane pekane52 at gmail.com Pat On Thu, Aug 12, 2010 at 8:33 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Aug 11, 2010 at 09:43:24PM -0700, Alan Coopersmith wrote: Makes it into a no-op, like evdev's

Re: [PATCH build] Add -L command-line option to list components to build.

2010-08-10 Thread Pat Kane
I think the lines # Create the log file directory $SUDO mkdir -p ${DESTDIR}${PREFIX}/var/log should be inside of if [ -z $LISTONLY ]; then Reviewed-by: Patrick E. Kane pekane52 at gmail.com Pat --- On Mon, Aug 9, 2010 at 11:39 PM, Trevor Woerner twoer...@gmail.com wrote: From:

Re: [PATCH] os: Turn off the scheduler alarm after an arbitrary length of time

2010-07-30 Thread Pat Kane
On Thu, Jul 29, 2010 at 4:41 PM, Adam Jackson a...@redhat.com wrote: ... the continuous stream of SIGALRM shows up in strace and thus people report infinite stream of SIGALRM rather than whatever the bug actually is. I really hate those SIGALRMs. Reviewed-by: Patrick E. Kane

Re: [PATCH] edid: Fix the HDTV sync pulse adjustment

2010-07-29 Thread Pat Kane
... and the excellent commit message at https://patchwork.kernel.org/patch/89095/ answers all my questions. On Thu, Jul 29, 2010 at 4:09 PM, Pat Kane pekan...@gmail.com wrote: On Thu, Jul 29, 2010 at 12:25 PM, Adam Jackson a...@nwnk.net wrote: ... The corresponding kernel code is a bit cleaner

Re: [PATCH] edid: Fix the HDTV sync pulse adjustment

2010-07-27 Thread Pat Kane
Reviewed-by: Patrick E. Kane pekan...@gmail.com The lines of context appear to show that both hsize and vsize are being changed, could include a comment to explain why only HSync* needs to be adjusted? In any event, thanks for the patch. Pat --- On Tue, Jul 27, 2010 at 4:34 PM, Adam Jackson

Re: XDS2010 talks will be recorded?

2010-07-25 Thread Pat Kane
Michael, It would be cool if you could record the talks. In many talks the QA at the end, which can the most interesting part, was hard to hear.If a presenter repeats the Q that is very helpfull. Thank you, Pat On Sun, Jul 18, 2010 at 9:29 PM, Michael Larabel

Re: [PATCH] Update Xserver-spec for new devPrivates API

2010-07-23 Thread Pat Kane
Reviewed-by: Patrick E. Kane pekan...@gmail.com Thanks for updating the docs and header file. Pat --- On Fri, Jul 23, 2010 at 1:59 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---  doc/xml/Xserver-spec.xml |  139

Re: [PATCH] Correct function name in dixRegisterPrivateKey comments

2010-07-23 Thread Pat Kane
Reviewed-by: Patrick E. Kane pekan...@gmail.com Thanks for updating the docs and header file. Pat --- On Fri, Jul 23, 2010 at 1:59 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---  include/privates.h |    4 ++--  1

Re: [PULL] Xserver doc fixes

2010-07-23 Thread Pat Kane
Reviewed-by: Patrick E. Kane pekan...@gmail.com I reviewed the DTrace part of the patch at http://lists.x.org/archives/xorg-devel/2010-June/010532.html and for extra credit I tested the dtrace scripts. I really _like_ dtrace. Pat --- On Fri, Jul 23, 2010 at 12:35 AM, Alan Coopersmith

Re: [PULL] Xserver doc fixes

2010-07-23 Thread Pat Kane
Tested-by: Patrick E. Kane pekan...@gmail.com I tested the DTrace part of the patch at http://lists.x.org/archives/xorg-devel/2010-June/010532.html Pat --- On Fri, Jul 23, 2010 at 12:35 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: No one volunteered a reviewed-by, but Gaetan

[PATCH] xf86-input-mouse: Update sun_mouse devPrivates code #29049

2010-07-16 Thread Pat Kane
Update the sun_mouse devPrivates code to conform to the new API (introducted by commit faeebead7bfcc78535757ca7acc1faf7554c03b7) that requires the PrivateKey to be registered. See BUG 29049. Signed-off-by: Patrick E. Kane pekan...@gmail.com --- src/sun_mouse.c | 12 1 files

Re: Xorg on Solaris 10?

2010-07-13 Thread Pat Kane
On Mon, Jun 21, 2010 at 9:09 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Pat Kane wrote: Does anyone try to compile the current Xorg git tree on Solaris 10? (not OpenSolaris)? We are having GCC problems on 64 bit systems  [looks like GCC bugs but I've not taken a very detailed

Xorg on Solaris 10?

2010-06-20 Thread Pat Kane
Does anyone try to compile the current Xorg git tree on Solaris 10? (not OpenSolaris)? We are having GCC problems on 64 bit systems [looks like GCC bugs but I've not taken a very detailed look yet.] Pat ___ xorg-devel@lists.x.org: X.Org

Re: performance of pci_device_get_{vendor, device}_name() in X server startup

2010-06-08 Thread Pat Kane
On Tue, Jun 8, 2010 at 8:40 PM, Matt Turner matts...@gmail.com wrote: The output of `lspci -vv` is already a nearly required piece of any bug report, so I don't think we're losing anything here. I agree. I have debugged several PCI card problems over the years and I have always needed to

Re: Please revert Xorg decision to disable Ctrl-Alt-Backspace

2009-03-31 Thread Pat Kane
I am an old EMACS luser and have never lost EMACS work due to the C-A-BS feature. And at least this solution would enable users who in rapidly increasing numbers are using virtualization on their desktops from having to kill all their virtual machines because they have to power cycle