Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-15 Thread Hans de Goede
Hi, On 07/14/2014 03:41 PM, Daniel Stone wrote: Hi, On 14 July 2014 13:51, Hans de Goede hdego...@redhat.com wrote: On 07/14/2014 02:43 PM, Julien Cristau wrote: On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Can I / we please get a reply from you on this ? As explained

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-15 Thread Hans de Goede
Hi, On 07/15/2014 10:42 AM, Hans de Goede wrote: snip It might not be strictly harmful in some cases, but it's not the sort of thing I want to encourage. 'Always include xorg-server.h before any X header ever' is a really simple rule to remember for driver developers; muddying the water,

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-15 Thread Michel Dänzer
On 15.07.2014 17:43, Hans de Goede wrote: On 07/15/2014 10:42 AM, Hans de Goede wrote: It might not be strictly harmful in some cases, but it's not the sort of thing I want to encourage. 'Always include xorg-server.h before any X header ever' is a really simple rule to remember for driver

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-15 Thread Alexander E. Patrakov
14.07.2014 19:41, Daniel Stone wrote: os.h isn't safe to necessarily safe to include without xorg-server.h, as it drags in misc.h, which has: extern _X_EXPORT void SwapLongs(CARD32 *list, unsigned long count); Again, CARD32 is unsigned long without xorg-server.h, which makes it 64-bit on those

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-14 Thread Hans de Goede
Hi Daniel, Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making os.h safe to include which really is an orthogonal problem, The glamor.h usage of os.h was just a (bad) example. Regards, Hans On 07/03/2014 10:50 PM, Hans de Goede

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-14 Thread Julien Cristau
On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Hi Daniel, Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making os.h safe to include which really is an orthogonal problem, The glamor.h usage of os.h was just a (bad)

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-14 Thread Hans de Goede
Hi, On 07/14/2014 02:43 PM, Julien Cristau wrote: On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Hi Daniel, Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making os.h safe to include which really is an orthogonal

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-14 Thread Daniel Stone
Hi, On 14 July 2014 13:51, Hans de Goede hdego...@redhat.com wrote: On 07/14/2014 02:43 PM, Julien Cristau wrote: On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-03 Thread Hans de Goede
Hi Daniel, On 07/03/2014 12:07 AM, Daniel Stone wrote: Hi, On 2 July 2014 20:14, Hans de Goede hdego...@redhat.com wrote: include/os.h defines protyptes for various non ansi-c str functions, such as str[n]casecmp and strndup. The definition of the prototypes is guarded by #ifndef

[PATCH] headers: Fix build errors with latest glibc

2014-07-02 Thread Hans de Goede
include/os.h defines protyptes for various non ansi-c str functions, such as str[n]casecmp and strndup. The definition of the prototypes is guarded by #ifndef HAVE_STRFOO, but HAVE_STRFOO is defined by xorg-server.h which is not included by all users of os.h. E.g. glamor.h does not and should not

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-02 Thread Keith Packard
Hans de Goede hdego...@redhat.com writes: include/os.h defines protyptes for various non ansi-c str functions, such as str[n]casecmp and strndup. The definition of the prototypes is guarded by #ifndef HAVE_STRFOO, but HAVE_STRFOO is defined by xorg-server.h which is not included by all users

Re: [PATCH] headers: Fix build errors with latest glibc

2014-07-02 Thread Daniel Stone
Hi, On 2 July 2014 20:14, Hans de Goede hdego...@redhat.com wrote: include/os.h defines protyptes for various non ansi-c str functions, such as str[n]casecmp and strndup. The definition of the prototypes is guarded by #ifndef HAVE_STRFOO, but HAVE_STRFOO is defined by xorg-server.h which is