Re: [PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-31 Thread Chris Wilson
On Wed, 30 May 2012 14:25:40 -0700, Keith Packard kei...@keithp.com wrote: Chris Wilson ch...@chris-wilson.co.uk writes: +extern _X_EXPORT void +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); The name doesn't seem very descriptive to me -- what is 'Intern' supposed

Re: [PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-31 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: On Wed, 30 May 2012 14:25:40 -0700, Keith Packard kei...@keithp.com wrote: Chris Wilson ch...@chris-wilson.co.uk writes: +extern _X_EXPORT void +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); The name doesn't seem very

Re: [PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-30 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: +extern _X_EXPORT void +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); The name doesn't seem very descriptive to me -- what is 'Intern' supposed to mean? /** + * Fills in a copy of mode, removing all stale pointer

[PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-29 Thread Chris Wilson
We stash a copy of the desiredMode on the crtc so that we can restore it after a vt switch. This copy is a simple memcpy and so also stashes a references to the pointers contained within the desiredMode. Those pointers are freed the next time the outputs are probed and mode list rebuilt, resulting

[PATCH] xf86/modes: Defang stale pointers when copying modes

2012-03-16 Thread Chris Wilson
We stash a copy of the desiredMode on the crtc so that we can restore it after a vt switch. This copy is a simple memcpy and so also stashes a references to the pointers contained within the desiredMode. Those pointers are freed the next time the outputs are probed and mode list rebuilt, resulting