Re: [PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-17 Thread Hans de Goede
Hi, On 16-04-15 17:28, Ray Strode wrote: It's possible to receive a message reply in the message filter if a previous message call timed out locally before the reply arrived. The message_filter function only handles signals, at the moment, and does not properly handle message replies. This

Re: [PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-17 Thread Ray Strode
Hi, Ray, you may want to reduce the number of context lines a bit next time you post patches. Nope, definitely don't. my default config produces patches with a lot of context intentionally. I want driveby readers who aren't motivated enough to go to the source tree to still be able to do a

Re: [PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-17 Thread Hans de Goede
Hi, On 17-04-15 15:07, Ray Strode wrote: Hi, Ray, you may want to reduce the number of context lines a bit next time you post patches. Nope, definitely don't. my default config produces patches with a lot of context intentionally. I want driveby readers who aren't motivated enough to go to

Re: [PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-17 Thread Ray Strode
Hi, On Fri, Apr 17, 2015 at 10:43 AM, Hans de Goede You may be making life easier for casual reviewers, but you are making life harder for the people actually merging your patches as the chances of a conflict increase enormously with such a large context. Well, we all know how to deal with

Re: [PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-17 Thread Keith Packard
Hans de Goede hdego...@redhat.com writes: Reviewed-by: Hans de Goede hdego...@redhat.com Keith, can you pick these 2 up directly please? Merged. 41932df..b102971 master - master -- -keith signature.asc Description: PGP signature ___

[PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

2015-04-16 Thread Ray Strode
It's possible to receive a message reply in the message filter if a previous message call timed out locally before the reply arrived. The message_filter function only handles signals, at the moment, and does not properly handle message replies. This commit changes the message_filter function to