Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-15 Thread Michel Dänzer
On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote: The real fix is the patch from attachment 25038, not the DestroyWindow hook. If the context is destroyed first, it will remove itself from the glxAllContexts list so the DrawableGone destructor won't touch it. On the other hand,

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-15 Thread Kristian Høgsberg
2010/4/15 Michel Dänzer mic...@daenzer.net: On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote: The real fix is the patch from attachment 25038, not the DestroyWindow hook.  If the context is destroyed first, it will remove itself from the glxAllContexts list so the DrawableGone

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-15 Thread Michel Dänzer
On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote: 2010/4/15 Michel Dänzer mic...@daenzer.net: On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote: The real fix is the patch from attachment 25038, not the DestroyWindow hook. If the context is destroyed first, it will

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-15 Thread Kristian Høgsberg
2010/4/15 Michel Dänzer mic...@daenzer.net: On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote: 2010/4/15 Michel Dänzer mic...@daenzer.net: On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote: The real fix is the patch from attachment 25038, not the DestroyWindow hook.  If

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-15 Thread Michel Dänzer
On Thu, 2010-04-15 at 08:26 -0400, Kristian Høgsberg wrote: 2010/4/15 Kristian Høgsberg k...@bitplanet.net: 2010/4/15 Michel Dänzer mic...@daenzer.net: On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote: 2010/4/15 Michel Dänzer mic...@daenzer.net: On Wed, 2010-04-14 at 15:13

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-15 Thread Kristian Høgsberg
On Thu, 15 Apr 2010 15:48:00 +0200, Michel Dänzer mic...@daenzer.net wrote: On Thu, 2010-04-15 at 08:26 -0400, Kristian Høgsberg wrote: 2010/4/15 Kristian Høgsberg k...@bitplanet.net: 2010/4/15 Michel Dänzer mic...@daenzer.net: On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote:

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-14 Thread Kristian Høgsberg
2010/4/10 Michel Dänzer mic...@daenzer.net: On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote: Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to force a specific resource destruction order in the DestroyWindow hook. I don't think DRI2DestroyDrawable was the only

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-14 Thread Kristian Høgsberg
2010/4/14 Michel Dänzer mic...@daenzer.net: On Wed, 2010-04-14 at 10:43 -0400, Kristian Høgsberg wrote: 2010/4/10 Michel Dänzer mic...@daenzer.net: On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote: Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to force a

Re: [PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-10 Thread Michel Dänzer
On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote: Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to force a specific resource destruction order in the DestroyWindow hook. I don't think DRI2DestroyDrawable was the only reason for this, see e.g. commit

[PATCHv2 2/2] glx: Drop DestroyWindow hook

2010-04-09 Thread Kristian Høgsberg
Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to force a specific resource destruction order in the DestroyWindow hook. Signed-off-by: Kristian Høgsberg k...@bitplanet.net --- glx/glxscreens.c | 28 glx/glxscreens.h |1 - 2 files changed,