Ok. The test is huge for the format. The whole format number(nformats) is 16,
that includes a8r8g8b8,x8r8g8b8,a8,r5g6b5...x2b10g10r10. I think your suggest's
format is used often. So I will point these format to tests. And maybe use one
color. And test blend,composite,cacompoiste with
Hi, All,
Through communication with you, I have a certain understanding of this
Gamma correction RAM (PAR PDR registers) principle.
Now I use the ddd tools to debugging the xscreensaver-xserver, when I
debug the server (about Get Gamma Ramp), The function: xf86GetGammaRamp -
On Fri, 2010-05-21 at 15:51 +0800, Huang, FrankR wrote:
Ok. The test is huge for the format. The whole format number(nformats)
is 16, that includes a8r8g8b8,x8r8g8b8,a8,r5g6b5...x2b10g10r10. I
think your suggest's format is used often. So I will point these
format to tests. And maybe use one
Ok. composite blend first.
Then expand to others.
Seem huge, but I think I can handle it :)
Hard begin, easy to follow.
But I don't know if the rendercheck can cover the most test cases.
Thanks,
Frank
-Original Message-
From: Jonathan Morton [mailto:jonathan.mor...@movial.com]
Sent:
And after that, I think I can give patch to rendercheck:)
-Original Message-
From: Jonathan Morton [mailto:jonathan.mor...@movial.com]
Sent: 2010年5月21日 16:17
To: Huang, FrankR
Cc: xorg-devel@lists.x.org; gtk-l...@gnome.org
Subject: RE: GTK progressbar call on XRenderComposite
On Fri,
Uggh, it appears this patch is ineffective compared to the previous
version. Turning on sprite debugging shows the Save/Restore functions
are still called.
[ 162.260] SetCursor restore 2
[ 162.264] SaveUnderCursor 2
Hi, All,
Through communication with you, I have a certain understanding of this
Gamma correction RAM (PAR PDR registers) principle.
Now I use the ddd tools to debugging the xscreensaver-xserver, when I
debug the server (about Get Gamma Ramp), The function: xf86GetGammaRamp -
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86Bus.c |2 --
hw/xfree86/os-support/bus/Pci.c |1 -
hw/xfree86/os-support/bus/Pci.h |2 --
hw/xfree86/vbe/vbe.c|1 -
4 files changed, 0 insertions(+), 6 deletions(-)
diff --git
IOADDRESS type definition encompass more than just pci code, so move it to
common.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86str.h |1 +
hw/xfree86/os-support/bus/xf86Pci.h |3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Although API is break, luckily any drivers right now is using such monster.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86Bus.c| 16
hw/xfree86/common/xf86Helper.c |2 +-
hw/xfree86/common/xf86VGAarbiter.c |2 +-
RAC is the champion of remaining trash for sure!
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86Bus.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86Bus.h b/hw/xfree86/common/xf86Bus.h
index b22e2e7..e161c7f 100644
Move all PCI procedures from xf86Helper.c to a more meaningful place (namely
xf86pciBus.c). xf86Helper.c is free of PCI code now.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86Helper.c | 503
Should go together within commit df14682a.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86str.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h
index e5713db..9e6b150 100644
---
Should be gone in commits 3c03d9f1 and a9d7d659a respectively.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/os-support/bus/Pci.h |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/hw/xfree86/os-support/bus/Pci.h
xf86MatchDevice will never be called in configuration time.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86Helper.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index
This function had a wrong name and was just logging the primary device. No one
cares about it honestly.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86Bus.c | 37 -
hw/xfree86/common/xf86Configure.c |2 --
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86.h | 57 +
1 files changed, 27 insertions(+), 30 deletions(-)
diff --git a/hw/xfree86/common/xf86.h b/hw/xfree86/common/xf86.h
index 68c3744..d8629a8 100644
---
On Thu, 2010-05-20 at 11:27 -0700, Jamey Sharp wrote:
On Thu, May 20, 2010 at 11:17 AM, Adam Jackson a...@nwnk.net wrote:
The numbers, sadly, are pretty clear:
717000.0 518000.0 ( 0.72) Map window via parent (4 kids)
That's not really a performance hit I'm willing to take.
A
Tiago Vignatti wrote:
IOADDRESS type definition encompass more than just pci code, so move it to
common.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86str.h |1 +
hw/xfree86/os-support/bus/xf86Pci.h |3 +--
2 files changed, 2
On Fri, 21 May 2010 14:43:17 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
Although API is break, luckily any drivers right now is using such monster.
diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h
index 485c15a..e5713db 100644
---
On Fri, 21 May 2010 14:43:19 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
RAC is the champion of remaining trash for sure!
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
Reviewed-by: Keith Packard kei...@keithp.com
--
keith.pack...@intel.com
pgpnmhMUtcGTe.pgp
On Wed, 5 May 2010 17:14:41 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
Keith, no one took this one. Care to pull it?
I though I had replied suggesting that this should depend on what support was
provided in the system libXfont instead of having the server be
configured separately.
From: Tiago Vignatti tiago.vigna...@nokia.com
Date: Fri, 21 May 2010 14:43:16 +0300
IOADDRESS type definition encompass more than just pci code, so move it to
common.
diff --git a/hw/xfree86/os-support/bus/xf86Pci.h
b/hw/xfree86/os-support/bus/xf86Pci.h
index ce1336b..a9a2779 100644
On Wed, 5 May 2010 17:54:07 +0200, Peter Korsgaard peter.korsga...@barco.com
wrote:
This is equivalent to the evdev patch sent earlier:
I'd like to see someone from the input team review this before I include
it in the server. In particular, the last I heard, there was a
suggestion that we
On Thu, 2010-05-20 at 10:46 -0700, Jamey Sharp wrote:
This eliminates a poorly-named, poorly-documented field from the
ScreenRec, using a previously-unused flag bit in each GC instead.
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Keith Packard kei...@keithp.com
Reviewed-by: Keith
On Thu, 2010-05-20 at 17:56 -0700, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Adam Jackson a...@redhat.com
- ajax
signature.asc
Description: This is a digitally signed message part
___
On Thu, 2010-05-20 at 17:56 -0700, Alan Coopersmith wrote:
From: Aaron Zang aaron.z...@sun.com
When Xorg is started on display :0, this ioctl is called to grant the
user the rights traditionally associated with /dev/console (before VT
support was added), such as access to local peripheral
On Thu, 06 May 2010 10:30:25 -0400, Adam Jackson a...@nwnk.net wrote:
On Wed, 2010-05-05 at 15:45 -0700, Keith Packard wrote:
On Wed, 5 May 2010 16:25:28 -0400, Adam Jackson a...@redhat.com wrote:
+
+/* if we don't need to backfill, we're done */
+if (pWin-backgroundState
On Fri, 2010-05-21 at 07:38 -0700, Keith Packard wrote:
On Fri, 21 May 2010 14:43:16 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
-extern _X_EXPORT IOADDRESS xf86MapLegacyIO(struct pci_device *dev);
+extern _X_EXPORT unsigned long xf86MapLegacyIO(struct pci_device *dev);
Context:
https://bugzilla.redhat.com/show_bug.cgi?id=533879
If you've got a 24bpp framebuffer, you poor misguided soul you, then you
have a conundrum. Pixmaps are 32bpp but Windows aren't. Suppose you
make a Picture out of a Window. You would think you'd be required to
use one of the Formats
On Thu, May 20, 2010 at 11:44 PM, Oliver McFadden
oliver.mcfad...@nokia.com wrote:
- if (cs-pCursorHideCounts != NULL || !CursorVisible) {
- ret = ((*pScreen-RealizeCursor)(pDev, pScreen, pInvisibleCursor)
- (*pScreen-DisplayCursor) (pDev, pScreen, pInvisibleCursor));
-
Hi,
On Thu, May 20, 2010 at 05:02:15PM +0200, ext Keith Packard wrote:
git://people.freedesktop.org/~keithp/xserver fix-private-usage
I see that you're registering some structures that are used only in xfree86
ddx using dix devPrivates. But for this ddx seems we have a similar mechanism
to of
On Tue, 11 May 2010 14:12:52 -0400, Adam Jackson a...@nwnk.net wrote:
I just want it to not trivially crash my server. I could care less
about correctness for this.
How about this?
From 50be5e8ff00e734506d2bb0c25054d7648f0cf1e Mon Sep 17 00:00:00 2001
From: Keith Packard kei...@keithp.com
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
This patch is not working so far because ScreenRec is not allocated yet when
dixSetPrivate is being called inside xf86VGAarbiterScrnInit. AddScreen is only
called afterwards.
Now I can think in two choices: either I hide vgaarb device
On Fri, 21 May 2010 14:05:41 +1000
Peter Hutterer peter.hutte...@who-t.net wrote:
On Thu, May 20, 2010 at 09:19:03AM -0700, Jesse Barnes wrote:
On Mon, 29 Mar 2010 10:04:28 -0700
Jesse Barnes jbar...@virtuousgeek.org wrote:
On Mon, 22 Mar 2010 15:03:30 -0700
Jesse Barnes
On Fri, 21 May 2010 17:10:59 +0100, Chris Wilson ch...@chris-wilson.co.uk
wrote:
The implementation should be fixed though, let's return BadMatch and
stop this silent corruption.
If existing apps are using these formats, it seems reasonable to expect
us to make them work. It seems like the
On Fri, 21 May 2010 19:02:32 +0300, Vignatti Tiago (Nokia-D/Helsinki)
tiago.vigna...@nokia.com wrote:
So makes sense to deprecate the ddx one and use only dix?
Alas, the ScrnInfoRec has a different lifetime than the ScreenRec, so
I'm not sure we could deprecate the DDX one. Would take some
On Fri, 21 May 2010 18:48:14 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
Send only screen index instead the whole rec for lock and remove the argument
of unlock.
nak -- the arbiter presumably needs to run during server initialization
before the screen is allocated, which means that
Moving IOADDRESS over, but leaving the other ibviously related ones
behind, seems a bad idea to me.
I'm waiting for an answer to the questions posed here before merging
this patch.
--
keith.pack...@intel.com
pgpcc5muSVNCr.pgp
Description: PGP signature
On Fri, May 21, 2010 at 04:40:59PM +0200, ext Keith Packard wrote:
On Fri, 21 May 2010 14:43:17 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
Although API is break, luckily any drivers right now is using such monster.
diff --git a/hw/xfree86/common/xf86str.h
On Fri, May 21, 2010 at 04:21:26PM +0200, ext Alan Coopersmith wrote:
Tiago Vignatti wrote:
IOADDRESS type definition encompass more than just pci code, so move it to
common.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/common/xf86str.h |1 +
On Fri, May 21, 2010 at 04:55:23PM +0200, ext Mark Kettenis wrote:
From: Tiago Vignatti tiago.vigna...@nokia.com
Date: Fri, 21 May 2010 14:43:16 +0300
IOADDRESS type definition encompass more than just pci code, so move it to
common.
diff --git a/hw/xfree86/os-support/bus/xf86Pci.h
On Fri, May 21, 2010 at 04:54:01PM +0200, ext Keith Packard wrote:
On Wed, 5 May 2010 17:14:41 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
Keith, no one took this one. Care to pull it?
I though I had replied suggesting that this should depend on what support was
provided in
On Thu, May 20, 2010 at 11:59 PM, Jeremy Huddleston jerem...@apple.com wrote:
In case anyone's interested, I've posted an updated log from building the
XQuartz server with clang SA:
http://people.freedesktop.org/~jeremyhu/clang/2010-05-20-1/
The first one I examined (Assigned value is
On Fri, 21 May 2010 19:50:56 +0300, Vignatti Tiago (Nokia-D/Helsinki)
tiago.vigna...@nokia.com wrote:
Did I change your opinion? :)
No, brevity is not always a compelling argument. In this case, I'd
rather have clarity.
--
keith.pack...@intel.com
pgpJOvAu4Vzly.pgp
Description: PGP
On Fri, May 21, 2010 at 06:43:11PM +0200, ext Keith Packard wrote:
On Fri, 21 May 2010 18:48:14 +0300, Tiago Vignatti tiago.vigna...@nokia.com
wrote:
Send only screen index instead the whole rec for lock and remove the
argument
of unlock.
nak -- the arbiter presumably needs to run
As of e2929db7b737413cf93fbebdf4d15abdfebff05c, doPolyText uses pFont
consistently rather than looking it up again from the saved XID.
clang noticed that fid = oldfid could run when oldfid hadn't been
initialized yet.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix/dixfonts.c |6 ++
On Mon, 2010-05-10 at 11:48 -0400, Adam Jackson wrote:
Signed-off-by: Adam Jackson a...@redhat.com
Resend, trivial dead code deletion.
- ajax
signature.asc
Description: This is a digitally signed message part
___
xorg-devel@lists.x.org: X.Org
On Fri, May 21, 2010 at 11:07 AM, Adam Jackson a...@nwnk.net wrote:
On Mon, 2010-05-10 at 11:48 -0400, Adam Jackson wrote:
Signed-off-by: Adam Jackson a...@redhat.com
Resend, trivial dead code deletion.
Which I even provided a reviewed-by tag for. Keith?
Jamey
As of e2929db7b737413cf93fbebdf4d15abdfebff05c, doPolyText uses pFont
consistently rather than looking it up again from the saved XID.
clang noticed that oldfid = fid could run when fid hadn't been
initialized yet.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
Same patch, with a commit
The analyzer is correct. It sees the call to miFillPolyHelper on line 1849 and
assumes that pGC can change:
miFillPolyHelper (pDrawable, pGC, pixel, spanData, y, h, left, right, nleft,
nright);
because it is not const:
static void
miFillPolyHelper (DrawablePtr pDrawable, GCPtr pGC, unsigned
Reviewed-by: Jeremy Huddleston jerem...@apple.com
Tested-by: Jeremy Huddleston jerem...@apple.com
On May 21, 2010, at 11:12, Jamey Sharp wrote:
As of e2929db7b737413cf93fbebdf4d15abdfebff05c, doPolyText uses pFont
consistently rather than looking it up again from the saved XID.
clang
This patch sequence starts out by moving the region implementation
from mi to dix, changing the names of all of the functions to
eliminate the leading mi. This patch includes a sed script which was
used to mechanically change all of the files, the only manual edits
were to move the region.c file
This makes the region code changes source compatible with existing
code, although none of them are used within the server source itself.
Signed-off-by: Keith Packard kei...@keithp.com
---
include/regionstr.h | 39 +++
1 files changed, 39 insertions(+), 0
On Fri, 21 May 2010 20:49:06 +0300, Vignatti Tiago (Nokia-D/Helsinki)
tiago.vigna...@nokia.com wrote:
You gave the nak for the wrong patch from the series, right? First patch is
only a cleanup.
No, it's not a cleanup, it's an API change which passes the job of
computing the argument into the
On Fri, 21 May 2010 11:10:20 -0700, Jamey Sharp ja...@minilop.net wrote:
On Fri, May 21, 2010 at 11:07 AM, Adam Jackson a...@nwnk.net wrote:
On Mon, 2010-05-10 at 11:48 -0400, Adam Jackson wrote:
Signed-off-by: Adam Jackson a...@redhat.com
Resend, trivial dead code deletion.
Which I
It looks like renaming miSubtractSpans to SubtractSpans was an accident?
With that fixed, this looks perfectly sensible.
Reviewed-by: Jamey Sharp ja...@minilop.net
Jamey
___
xorg-devel@lists.x.org: X.Org development
Archives:
On Fri, 21 May 2010 13:27:20 -0700, Jamey Sharp ja...@minilop.net wrote:
It looks like renaming miSubtractSpans to SubtractSpans was an accident?
With that fixed, this looks perfectly sensible.
Yeah, the sed script was a bit incautious. I've fixed the sed script and
regenerated the branch.
On Fri, 21 May 2010 15:12:47 -0700, Jamey Sharp ja...@minilop.net wrote:
I get different results from running fix-region than are reflected in
this patch. I think the script is giving the right output, and the
patch is wrong in places.
I think that's fixed in the new push I just made; are you
On Fri, May 21, 2010 at 3:14 PM, Keith Packard kei...@keithp.com wrote:
On Fri, 21 May 2010 13:27:20 -0700, Jamey Sharp ja...@minilop.net wrote:
It looks like renaming miSubtractSpans to SubtractSpans was an accident?
With that fixed, this looks perfectly sensible.
Yeah, the sed script was a
On Fri, 21 May 2010 15:36:07 -0700, Jamey Sharp ja...@minilop.net wrote:
Seems like the deletions of mi prefixes in region.c should still go
in this first commit, though, not in Change region implementation
from macros to inline functions. The latter looks kind of broken now.
Yeah, you're
On Fri, May 21, 2010 at 3:32 PM, Keith Packard kei...@keithp.com wrote:
On Fri, 21 May 2010 15:12:47 -0700, Jamey Sharp ja...@minilop.net wrote:
I get different results from running fix-region than are reflected in
this patch. I think the script is giving the right output, and the
patch is
On Fri, 21 May 2010 15:57:47 -0700, Jamey Sharp ja...@minilop.net wrote:
This seems to work:
git diff --check |
sed -n 's!^\([^:]*\):\([^:]*\):.*!sed -i \2 s/[ \t]*$//; \2 s/
*\t/\t/g \1!p' |
sh
I'm inordinately pleased at using sed to generate sed scripts.
Very cool. Pushed.
--
On Fri, May 21, 2010 at 5:18 PM, Keith Packard kei...@keithp.com wrote:
Very cool. Pushed.
I have one thing I'm still confused about before I give my reviewed-by
for the series. Change region implementation from macros to inline
functions has an assortment of renamings in region.c to remove the
Keith Packard kei...@keithp.com writes:
There isn't any reason to have this in mi. Everything except the file
rename was done with the included script 'fix-miregion'.
Would it be useful to split this commit into two: one that just
renames the file and one that is the result of running the
Keith Packard kei...@keithp.com writes:
There isn't any reason to have this in mi. Everything except the file
rename was done with the included script 'fix-miregion'.
Didn't realize that the hand-rolled changes commit used to be part
of this. The comment I have on that part is that it seems to
Keith Packard kei...@keithp.com writes:
There isn't any reason to have this in mi. Everything except the file
rename was done with the included script 'fix-miregion'.
There is a search-and-replace bug here:
- * to miValidateTree. Bob Scheifler changed the representation to be more
+ * to
Chris Wilson ch...@chris-wilson.co.uk writes:
On Fri, 21 May 2010 11:44:39 -0400, Adam Jackson a...@redhat.com wrote:
Context:
https://bugzilla.redhat.com/show_bug.cgi?id=533879
If you've got a 24bpp framebuffer, you poor misguided soul you, then you
have a conundrum. Pixmaps are
Signed-off-by: Jamey Sharp ja...@minilop.net
---
This patch depends on Keith's change-region-api series.
Jeremy, I'd be curious to see a clang run with this series applied,
since that was the immediate motivation for it.
After hand-inspecting about 1,500 references to the region functions,
I'm
For AtomError, this should fix a clang warning; in the other cases it's
just good documentation.
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Jeremy Huddleston jerem...@apple.com
---
include/dix.h|2 +-
include/dixstruct.h |2 +-
include/extnsionst.h |2 +-
3 files
On Fri, May 21, 2010 at 11:19 AM, Jeremy Huddleston jerem...@apple.com wrote:
The analyzer is correct. It sees the call to miFillPolyHelper on line
1849 and assumes that pGC can change because it is not const ...
My guess is that applying const correctly in many places will help
the SA avoid
71 matches
Mail list logo
