Re: [PATCH] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Hutterer
On Tue, May 24, 2011 at 07:31:53AM +0200, Peter Korsgaard wrote: Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, +++ b/src/evdev.c @@ -1683,8 +1683,10 @@ EvdevProbe(InputInfoPtr pInfo) pEvdev- flags |= EVDEV_BUTTON_EVENTS; } } else if (TestBit(ABS_PRESSURE,

Re: [PATCH] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Korsgaard
Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, With this change, the only thing differentiating between touchpads and touchscreens is the presence of BTN_TOOL_FINGER. Peter Right, but if I read this correctly, you've removed a condition Peter and now any device with

Re: [PATCH] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Hutterer
On Tue, May 24, 2011 at 08:47:58AM +0200, Peter Korsgaard wrote: Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, With this change, the only thing differentiating between touchpads and touchscreens is the presence of BTN_TOOL_FINGER. Peter Right, but if I read this

Re: [PATCH] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Korsgaard
Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, Yes, but all of this is in a has abs X/Y check. Keyboards presumably don't have absolute X/Y axes? Peter you'd be surprised :) Peter $ evtest /dev/input/event3 Peter Input driver version is 1.0.1 Peter Input device ID: bus

Re: [PATCH] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Hutterer
On Tue, May 24, 2011 at 08:58:03AM +0200, Peter Korsgaard wrote: Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, Yes, but all of this is in a has abs X/Y check. Keyboards presumably don't have absolute X/Y axes? Peter you'd be surprised :) Peter $ evtest

Re: [PATCH] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Korsgaard
Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, Argh, what then? Check for devices with abs X/Y, no rel X/Y and BTN_LEFT? Or do you have other crazy devices doing that as well? Peter i'm pretty sure that for any combination of axes you can think Peter of, there will be a

[PATCHv2] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Korsgaard
Some touchscreens (like the Lumio crystaltouch in single touch mode) send BTN_LEFT rather than BTN_TOUCH: Input driver version is 1.0.1 Input device ID: bus 0x3 vendor 0x202e product 0x5 version 0x111 Input device name: LUMIO Inc LUMIO CrystalTouch ver 1.1C Supported events: Event type 0 (Sync)

Re: [PATCHv2] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Hutterer
On Tue, May 24, 2011 at 09:44:05AM +0200, Peter Korsgaard wrote: Some touchscreens (like the Lumio crystaltouch in single touch mode) send BTN_LEFT rather than BTN_TOUCH: merged, thanks. one more thing for the future. for patches not to the xserver, please put the component in as [PATCH

Re: Xlib voodoo XWidthOfScreen, etc

2011-05-24 Thread Daniel Stone
On Mon, May 23, 2011 at 10:04:47AM -0700, Jamey Sharp wrote: There could be magic in libXrandr to fiddle with the contents of the Display, but I'd be surprised... Especially since you'd still need to have called into that library to get the magic hooked up. It does, provided you call

[PATCH:xserver 2/2] xkb: Fix case checks for Latin 8.

2011-05-24 Thread Cyril Brulebois
Spotted by -Wlogical-op: | CC xkbfmisc.lo | xkbfmisc.c: In function '_XkbKSCheckCase': | xkbfmisc.c:104:3: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op] | xkbfmisc.c:118:3: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

[PATCH:xproto 1/2] Sort Latin 8 keysyms by codepoints.

2011-05-24 Thread Cyril Brulebois
The overall chaos misled implementors into writing interval checks to determine the case, but that doesn't work too well when lines aren't sorted. Sort performed by calling “sort -k 3” on the part between #ifdef XK_LATIN8 and #endif. Signed-off-by: Cyril Brulebois k...@debian.org ---

Re: [PATCH evdev v2] Export product/vendor ID through a property.

2011-05-24 Thread Peter Korsgaard
Peter == Peter Hutterer peter.hutte...@who-t.net writes: Peter Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Peter Reviewed-by: Daniel Stone dan...@fooishbar.org Peter --- Peter Changes to v1: Peter - EVIOCGID returns a struct input_id, use that instead of ushort[4]; Peter no

Re: [PATCH xfree86] Signed-off-by: Oleh Nykyforchyn oleh....@gmail.com

2011-05-24 Thread Dan Nicholson
On Mon, May 23, 2011 at 7:26 AM, Oleh Nykyforchyn oleh@gmail.com wrote: On Mon, 23 May 2011 05:54:55 -0700 Dan Nicholson dbn.li...@gmail.com wrote: The whole reason why the current setup is weird is that it's completely implicit what type of matching happens in each statement.

Re: [PATCH] fb: Fix memcpy abuse

2011-05-24 Thread Soeren Sandmann
Keith Packard kei...@keithp.com writes: On Mon, 23 May 2011 14:34:55 +0200, Soeren Sandmann sandm...@cs.au.dk wrote: I think Keith said that the merge window for 1.11 closes May 29th though, so there may not be enough time. That's the current schedule, with the release happening on August

Re: xclock/oclock endian mismatch in Xfbdev [SOLVED]

2011-05-24 Thread Soeren Sandmann
Dushara Jayasinghe dushara.jayasin...@hydrix.com writes: I had a look at the pixman code but what's required to add the format that suits the hardware is not immediately obvious to me. The CPU peripheral is configured as 1bpp (packed). The MSbit is the left most pixel. I'm guessing that I

Re: [PATCH xfree86] Signed-off-by: Oleh Nykyforchyn oleh....@gmail.com

2011-05-24 Thread Oleh Nykyforchyn
On Tue, 24 May 2011 05:54:33 -0700 Dan Nicholson dbn.li...@gmail.com wrote: The man page does say what type of matching each uses, but it's still not that discoverable. You are right, it's my fault that I missed this info. What do You think about such an approach? Frankly, I'm not crazy

GPLv3 (Re: [ANNOUNCE] xcb-util 0.3.8)

2011-05-24 Thread Jeremy Huddleston
This is the first released tarball from X.org and XCB that requires autoconf-2.62 to autoconf. What is needed from 2.62 that isn't in 2.61? 2.62 is released under GPLv3 making it very difficult for users to rebuild the configure script. On Apr 25, 2011, at 09:53, Arnaud Fontaine wrote:

Re: [PATCH:mkfontscale] Add _X_ATTRIBUTE_PRINTF to functions taking printf format arguments

2011-05-24 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On May 23, 2011, at 18:34, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- list.h |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/list.h b/list.h index 463933d..686fd9b

[PATCH 01/14] Xext: Get rid of useless checks.

2011-05-24 Thread Cyril Brulebois
As noted in a comment, that can't actually happen. Those warnings go away accordingly: | CC xvmc.lo | xvmc.c: In function 'XvMCExtensionInit': | xvmc.c:671:21: warning: the comparison will always evaluate as 'false' for the address of 'XvMCScreenKeyRec' will never be NULL [-Waddress] |

[PATCH 05/14] configure: Bump dependency on xproto.

2011-05-24 Thread Cyril Brulebois
Bumping this dependency means some additional macros can be used, like _X_UNUSED. Signed-off-by: Cyril Brulebois k...@debian.org --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 655c0e4..632e839 100644 --- a/configure.ac

[PATCH 04/14] mi: Avoid implicit declaration of 'verify_internal_event'.

2011-05-24 Thread Cyril Brulebois
Those warnings go away accordingly: | CC mieq.lo | mieq.c: In function 'mieqEnqueue': | mieq.c:159:5: warning: implicit declaration of function 'verify_internal_event' [-Wimplicit-function-declaration] | mieq.c:159:5: warning: nested extern declaration of 'verify_internal_event'

[PATCH 02/14] Xext: Get rid of buggy/useless check.

2011-05-24 Thread Cyril Brulebois
XvMCScreenKey is defined as XvMCScreenKeyRec's address, so will never be NULL. If a check for XvMC adaptors is needed, that's not the way to implement it. This warning goes away accordingly: | CC xvmc.lo | xvmc.c: In function 'ProcXvMCListSubpictureTypes': | xvmc.c:490:22: warning: the

[PATCH 03/14] dix: Avoid implicit declaration of 'verify_internal_event'.

2011-05-24 Thread Cyril Brulebois
Those warnings go away accordingly: | CC events.lo | events.c: In function 'DeliverDeviceEvents': | events.c:2485:5: warning: implicit declaration of function 'verify_internal_event' [-Wimplicit-function-declaration] | events.c:2485:5: warning: nested extern declaration of

[PATCH 07/14] fb: Mark some variables as unused.

2011-05-24 Thread Cyril Brulebois
There's no use for the values set through the various macro calls (fbGetDrawable and fbGetDrawablePixmap), so mark those variables as unused. The following warnings go away accordingly: | CC libfb_la-fb24_32.lo | fb24_32.c: In function 'fb24_32ReformatTile': | fb24_32.c:544:19: warning:

[PATCH 06/14] fb: Simplify logic, get rid of set but unused variable.

2011-05-24 Thread Cyril Brulebois
wrapped is only useful is FB_ACCESS_WRAPPER is set; simplify the logic accordingly, and only set it when that's defined. The following warning goes away accordingly: | CC libfb_la-fbarc.lo | fbarc.c: In function 'fbPolyArc': | fbarc.c:71:11: warning: variable 'wrapped' set but not used

[PATCH 08/14] miext: Mark some variables as unused.

2011-05-24 Thread Cyril Brulebois
There's no use for the values set through the various macro calls (fbGetDrawable and fbGetDrawablePixmap), so mark those variables as unused. The following warnings go away accordingly: | CC shpacked.lo | shpacked.c: In function 'shadowUpdatePacked': | shpacked.c:55:19: warning: variable

[PATCH 09/14] xfixes: Mark some variables as unused.

2011-05-24 Thread Cyril Brulebois
Calling Unwrap() is just a way of performing an assignment while keeping a backup of the original value. In the CursorCloseScreen function, the backup value doesn't seem to be useful, but Unwrap() is used anyway (probably to stay in line with other functions). As a consequence, mark those

[PATCH 11/14] hw/dmx: Mark text widgets as unused.

2011-05-24 Thread Cyril Brulebois
They are unused in the sense they're not getting any callback set up. Those warnings go away accordingly: | CC xdmxconfig-xdmxconfig.o | xdmxconfig.c: In function ‘main’: | xdmxconfig.c:881:29: warning: variable ‘quittext’ set but not used [-Wunused-but-set-variable] | xdmxconfig.c:880:53:

[PATCH 12/14] dmx/examples: Fix missing key_click_percent assignment.

2011-05-24 Thread Cyril Brulebois
Thanks to gcc's -Wunused-but-set-variable, stop ignoring the percent parameter, and add it to the XKeyboardControl structure before the XChangeKeyboardControl call. This warning goes away accordingly: | CC xbell-xbell.o | xbell.c: In function ‘main’: | xbell.c:74:22: warning: variable

[PATCH 13/14] xfree86/os-support: Mark some variables as unused.

2011-05-24 Thread Cyril Brulebois
Keep on setting them (since the strtok() calls have side-effects), but mark them as unused, since they aren't used afterwards (except in dead code which should probably go away). Those warnings go away accordingly: | CC lnx_acpi.lo | lnx_acpi.c: In function 'lnxACPIGetEventFromOs': |

[PATCH 14/14] xfree86/os-support: Mark one more variable as unused.

2011-05-24 Thread Cyril Brulebois
Removing the data_l computing would lead data to be unused in turn, and a comment confirms it's apparently useless. Keep it anyway just in case, and only mark the computed length as unused for now. This warning goes away accordingly: | CC lnx_acpi.lo | lnx_acpi.c: In function

Re: [PATCHv2] evdev: handle touchscreens without BTN_TOUCH

2011-05-24 Thread Peter Korsgaard
Peter == Peter Hutterer peter.hutte...@who-t.net writes: Peter On Tue, May 24, 2011 at 09:44:05AM +0200, Peter Korsgaard wrote: Some touchscreens (like the Lumio crystaltouch in single touch mode) send BTN_LEFT rather than BTN_TOUCH: Peter merged, thanks. Thanks. Peter one more thing

Re: [PATCH:x11proto] Add comments to Xfuncproto.h noting required xproto versions for each macro

2011-05-24 Thread Cyril Brulebois
Jeremy Huddleston jerem...@apple.com (23/05/2011): Helpful. Indeed! Acked-by: Cyril Brulebois k...@debian.org Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH libXt] Update README for documentation reference

2011-05-24 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon mems...@videotron.ca --- README |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/README b/README index 45663cb..7f78bcc 100644 --- a/README +++ b/README @@ -3,7 +3,8 @@ libXt - X Toolkit Intrinsics library Documentation for this library can

Re: [PATCH libXt] Update README for documentation reference

2011-05-24 Thread Alan Coopersmith
On 05/24/11 11:40 AM, Gaetan Nadon wrote: Signed-off-by: Gaetan Nadon mems...@videotron.ca --- README |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/README b/README index 45663cb..7f78bcc 100644 --- a/README +++ b/README @@ -3,7 +3,8 @@ libXt - X Toolkit

[PATCH XTS] xts5: BadDevice takes an int*, not an XID*

2011-05-24 Thread Aaron Plattner
startup.c: In function ‘init_xinput’: startup.c:505: error: passing argument 2 of ‘_xibaddevice’ from incompatible pointer type /usr/include/X11/extensions/XInput.h:162: note: expected ‘int *’ but argument is of type ‘XID *’ Signed-off-by: Aaron Plattner aplatt...@nvidia.com ---

[PATCH XTS] tet: tet_getvar needs to take a const char* argument

2011-05-24 Thread Aaron Plattner
config.c: In function ‘initconfig’: config.c:394: error: passing argument 1 of ‘_initconfig’ from incompatible pointer type config.c:328: note: expected ‘char * (*)(const char *)’ but argument is of type ‘char * (*)(char *)’ Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- I'm thinking of

Re: [PATCH libXt] Update README for documentation reference

2011-05-24 Thread Cyril Brulebois
Gaetan Nadon mems...@videotron.ca (24/05/2011): Signed-off-by: Gaetan Nadon mems...@videotron.ca Reviewed-by: Cyril Brulebois k...@debian.org Mraw, KiBi. signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH: bigreqproto] Add olinks to functions decribed in libX11 documentation. (take 2)

2011-05-24 Thread Matt Dew
On 05/23/2011 10:23 PM, Peter Hutterer wrote: On Mon, May 23, 2011 at 07:58:36PM -0400, Gaetan Nadon wrote: On Mon, 2011-05-23 at 13:48 -0600, Matt Dew wrote: This patch is used with the libX11 patch. It turns the functions listed in this doc into hyperlinks to the declarations that are in

Re: [PATCH 01/14] Xext: Get rid of useless checks.

2011-05-24 Thread Alan Coopersmith
On 05/24/11 09:41 AM, Cyril Brulebois wrote: As noted in a comment, that can't actually happen. Those warnings go away accordingly: | CC xvmc.lo | xvmc.c: In function 'XvMCExtensionInit': | xvmc.c:671:21: warning: the comparison will always evaluate as 'false' for the address of

[PULL updated] input abi bump to 13.0

2011-05-24 Thread Peter Hutterer
I removed the product/vendor ID property patch from the pull request. IRC discussion showed that this may be better in a XI 2.1 request. Other patches unchanged. The following changes since commit 0de7cec90738a7a5020150309866bb0e23b6f479: xfree86: bump to video ABI 11 (2011-05-23 09:38:21

[PATCH v2] randr: check rotated virtual size limits correctly

2011-05-24 Thread Aaron Plattner
Commit d1107918d4626268803b54033a07405122278e7f introduced checks to the RandR path that cause RRSetScreenConfig requests to fail if the size is too large. Unfortunately, when RandR 1.1 rotation is enabled it compares the rotated screen dimensions to the unrotated limits, which causes 90- and

Re: XRes v1.2 resourceproto integration

2011-05-24 Thread Alan Coopersmith
On 05/24/11 12:41 AM, Erkki Seppala wrote: Hello, I've been (slowly) trying to get the XRes v1.2 integrated into the X server, and the first bit to integrate (before the rest of the changes result in compilable code) is the protocol. It appears that you have been the last person to touch

Re: [PATCH 03/14] dix: Avoid implicit declaration of 'verify_internal_event'.

2011-05-24 Thread Jeremy Huddleston
Peter already has this one in his tree. On May 24, 2011, at 09:41, Cyril Brulebois wrote: Those warnings go away accordingly: | CC events.lo | events.c: In function 'DeliverDeviceEvents': | events.c:2485:5: warning: implicit declaration of function 'verify_internal_event'

Re: [PATCH 04/14] mi: Avoid implicit declaration of 'verify_internal_event'.

2011-05-24 Thread Jeremy Huddleston
This one is also already in Peter's tree. On May 24, 2011, at 09:41, Cyril Brulebois wrote: Those warnings go away accordingly: | CC mieq.lo | mieq.c: In function 'mieqEnqueue': | mieq.c:159:5: warning: implicit declaration of function 'verify_internal_event'

Re: [PATCH 01/14] Xext: Get rid of useless checks.

2011-05-24 Thread Jeremy Huddleston
1,2: Ditto Alan's Response 3,4: Duplicates 5,6: Reviewed-by: Jeremy Huddleston jerem...@apple.com 7,8,9: Disgusted-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Jeremy Huddleston jerem...@apple.com 10: Reviewed-by: Jeremy Huddleston jerem...@apple.com 11: I'd

Re: [PATCH XTS] xts5: BadDevice takes an int*, not an XID*

2011-05-24 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On May 24, 2011, at 13:03, Aaron Plattner wrote: startup.c: In function ‘init_xinput’: startup.c:505: error: passing argument 2 of ‘_xibaddevice’ from incompatible pointer type /usr/include/X11/extensions/XInput.h:162: note: expected ‘int *’

Re: [PATCH XTS] tet: tet_getvar needs to take a const char* argument

2011-05-24 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On May 24, 2011, at 13:18, Aaron Plattner wrote: config.c: In function ‘initconfig’: config.c:394: error: passing argument 1 of ‘_initconfig’ from incompatible pointer type config.c:328: note: expected ‘char * (*)(const char *)’ but argument

Re: [PATCH XTS] xts5: BadDevice takes an int*, not an XID*

2011-05-24 Thread Peter Hutterer
On Tue, May 24, 2011 at 01:03:20PM -0700, Aaron Plattner wrote: startup.c: In function ‘init_xinput’: startup.c:505: error: passing argument 2 of ‘_xibaddevice’ from incompatible pointer type /usr/include/X11/extensions/XInput.h:162: note: expected ‘int *’ but argument is of type ‘XID *’

Re: [PATCH XTS] tet: tet_getvar needs to take a const char* argument

2011-05-24 Thread Peter Hutterer
On Tue, May 24, 2011 at 01:18:12PM -0700, Aaron Plattner wrote: config.c: In function ‘initconfig’: config.c:394: error: passing argument 1 of ‘_initconfig’ from incompatible pointer type config.c:328: note: expected ‘char * (*)(const char *)’ but argument is of type ‘char * (*)(char *)’

Re: [PATCH:macros] Add AC_LANG_DEFINES_PROVIDED to XORG_RAW_CPP to silence autoconf warnings

2011-05-24 Thread Alan Coopersmith
Anyone want to comment or review before I push and cut a macros 1.14.0 release? -alan- On 05/16/11 05:56 PM, Alan Coopersmith wrote: Since we're intentionally doing a special case to just check cpp output, and not a full program compilation, add the magic macro to silence:

Re: [RFC] Inclusing of xkbset in xorg/app

2011-05-24 Thread Peter Hutterer
On Fri, May 20, 2011 at 10:58:33AM +0100, Daniel Stone wrote: Hi, On Fri, May 20, 2011 at 09:29:17AM +1000, Peter Hutterer wrote: On Thu, May 19, 2011 at 07:55:11AM +0100, Daniel Stone wrote: On Thu, May 19, 2011 at 09:28:23AM +1000, Peter Hutterer wrote: One other option is to add

Re: [RFC PATCH inputproto] specs: Add new SwitchClass

2011-05-24 Thread Peter Hutterer
On Mon, May 23, 2011 at 10:38:54AM +0100, Daniel Stone wrote: On Mon, May 23, 2011 at 12:27:48PM +1000, Peter Hutterer wrote: I had this at some point for XI 2.0 but kicked it out due to time reasons. Not sure I'll be able to implement the server support by the 1.11 merge window so this may

[PATCH v2] input: deliver raw events unconditionally for XI 2.1 clients.

2011-05-24 Thread Peter Hutterer
Deliver raw events regardless whether there is a grab on or not for clients supporting 2.1 or later. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- On Sat, May 21, 2011 at 01:21:28PM +0100, Daniel Stone wrote: On Wed, May 11, 2011 at 02:59:35PM +1000, Peter Hutterer wrote: @@

Re: [Xcb] GPLv3 (Re: [ANNOUNCE] xcb-util 0.3.8)

2011-05-24 Thread Arnaud Fontaine
Hi, Jeremy Huddleston jerem...@freedesktop.org writes: This is the first released tarball from X.org and XCB that requires autoconf-2.62 to autoconf. What is needed from 2.62 that isn't in 2.61? 2.62 is released under GPLv3 making it very difficult for users

Re: [PATCH 02/30] dix: Stop setting oldMaster for nothing.

2011-05-24 Thread Tomas Carnecky
On 5/20/11 5:35 PM, Cyril Brulebois wrote: -oldmaster = GetMaster(dev, MASTER_ATTACHED); dev-master = master; Does the GetMaster() function have any side effects? tom ___ xorg-devel@lists.x.org: X.Org development Archives: