[PATCH v2 3/4] dix: Silence -Wunused-variable warning by moving window.c off of legacy region defines

window.c:223:15: warning: unused variable 'pScreen' [-Wunused-variable,Unused Entity Issue] ScreenPtr pScreen = pWin->drawable.pScreen; ^ Signed-off-by: Jeremy Huddleston Sequoia --- dix/window.c | 9 - 1 file changed, 4 insertions(+), 5

[PATCH v2 2/4] glx: Fix header length error checking in __glXDisp_RenderLarge

glxcmds.c:2206:46: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare,Semantic Issue] if ((cmdlen = safe_pad(hdr->length)) < 0) ^ ~ Signed-off-by: Jeremy Huddleston Sequoia ---

[PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

osinit.c:161:24: warning: unused variable 'devnull' [-Wunused-variable,Unused Entity Issue] static const char *devnull = "/dev/null"; ^ osinit.c:162:10: warning: unused variable 'fname' [-Wunused-variable,Unused Entity Issue] char fname[PATH_MAX]; ^

[PATCH v2 1/4] randr: Silence -Wshift-negative-value warnings

rrtransform.c:199:23: warning: shifting a negative signed value is undefined [-Wshift-negative-value,Semantic Issue] rot_cos = F(-1); ^ rrtransform.c:114:14: note: expanded from macro 'F' ^~ ../render/picture.h:200:24: note:

Re: [PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

Actually, only this last one is "v2". The others I just still need a Reviewed-by: for, but they're unchanged from earlier. Sorry for any confusion. > On Oct 18, 2015, at 23:12, Jeremy Huddleston Sequoia > wrote: > > osinit.c:161:24: warning: unused variable 'devnull'

[PATCH 2/2] xorg-wrapper: fix build without libdrm

Signed-off-by: Samuel Thibault --- configure.ac | 2 -- hw/xfree86/xorg-wrapper.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7db7187..220478a 100644 --- a/configure.ac +++ b/configure.ac

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

On Mon, Oct 19, 2015 at 10:43:45 +0200, Hans de Goede wrote: > Hi, > > On 18-10-15 19:26, Julien Cristau wrote: > >When the server is privileged, we shouldn't be passing the user's > >environment directly. > > > >Signed-off-by: Julien Cristau > > I've no real objections

Re: [PATCH] xorg-wrapper: fix build without libdrm

Mark Kettenis, le Mon 19 Oct 2015 12:26:27 +0200, a écrit : > > If you're doing this with certain platforms in mind, maybe > > we need to only not check for libdrm on those platforms ? > > Does it make sense at all to use the wrapper on platforms without drm? We need some setuid wrapper, yes,

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 14:00, Samuel Thibault wrote: Mark Kettenis, le Mon 19 Oct 2015 12:26:27 +0200, a écrit : If you're doing this with certain platforms in mind, maybe we need to only not check for libdrm on those platforms ? Does it make sense at all to use the wrapper on platforms without

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

Hi, On 19-10-15 12:57, Julien Cristau wrote: On Mon, Oct 19, 2015 at 10:43:45 +0200, Hans de Goede wrote: Hi, On 18-10-15 19:26, Julien Cristau wrote: When the server is privileged, we shouldn't be passing the user's environment directly. Signed-off-by: Julien Cristau

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 14:40:46 +0200, a écrit : > To me hurd is the exception here. So maybe change the patch to drop > the configure libdrm check for hurd ? Like is done for cygwin and darwin? Sure. > If that is done I'm fine with the #ifdef LIBDRM in the wrapper itself. I have

[PATCH 1/2] hurd: disable detecting drm

Signed-off-by: Samuel Thibault --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index e434720..7db7187 100644 --- a/configure.ac +++ b/configure.ac @@ -752,6 +752,11 @@ case $host_os in

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 10:53, Samuel Thibault wrote: Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : @@ -237,6 +242,7 @@ int main(int argc, char *argv[]) close(fd); } } +#endif This turns needs_root_rights=auto into needs_root_rights=yes do we really want

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > In which case would you want to build without libdrm anyways ? Can you > explain the use-case for this patch ? Systems with no drm support, simply :) Samuel ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

Hi, On 18-10-15 19:26, Julien Cristau wrote: When the server is privileged, we shouldn't be passing the user's environment directly. Signed-off-by: Julien Cristau I've no real objections against this, and I can see this being a good thing from a security pov, but I'm

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 18-10-15 18:48, Samuel Thibault wrote: Signed-off-by: Samuel Thibault --- configure.ac | 2 -- hw/xfree86/xorg-wrapper.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > On 19-10-15 10:53, Samuel Thibault wrote: > >Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : > >>>@@ -237,6 +242,7 @@ int main(int argc, char *argv[]) > >>> close(fd); > >>> } > >>> } > >>>+#endif

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 11:03, Samuel Thibault wrote: Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : In which case would you want to build without libdrm anyways ? Can you explain the use-case for this patch ? Systems with no drm support, simply :) Actually I do not think it is that

Re: [PATCH] xorg-wrapper: fix build without libdrm

Samuel Thibault, le Mon 19 Oct 2015 11:25:08 +0200, a écrit : > Hans de Goede, le Mon 19 Oct 2015 11:14:21 +0200, a écrit : > > On 19-10-15 11:03, Samuel Thibault wrote: > > >Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > > >>In which case would you want to build without libdrm

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : > >@@ -237,6 +242,7 @@ int main(int argc, char *argv[]) > > close(fd); > > } > > } > >+#endif > > > > This turns needs_root_rights=auto into needs_root_rights=yes do we really > want that > when not building

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 11:14:21 +0200, a écrit : > On 19-10-15 11:03, Samuel Thibault wrote: > >Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > >>In which case would you want to build without libdrm anyways ? Can you > >>explain the use-case for this patch ? > > > >Systems

Re: [PATCH xserver v2] xorg-wrapper: when starting the server as root, reset its environment

Hi, On 19-10-15 15:42, Julien Cristau wrote: When the server is privileged, we shouldn't be passing the user's environment directly. Clearing the environment is recommended by the libdbus maintainers, see https://bugs.freedesktop.org/show_bug.cgi?id=52202 Bugzilla:

[PATCH xserver v2] xorg-wrapper: when starting the server as root, reset its environment

When the server is privileged, we shouldn't be passing the user's environment directly. Clearing the environment is recommended by the libdbus maintainers, see https://bugs.freedesktop.org/show_bug.cgi?id=52202 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83849 Signed-off-by: Julien

Backport fix for exposing core and ES contexts on Xwayland to the next stable release

Hello, The current stable Xorg server release, 1.17.2, doesn’t support the creation of a core profile OpenGL context, or of a GLES context, only exposing compatibility profiles instead (so 3.0 on Mesa, see [1]). This is a request to cherry-pick commit 2d719433 [2] from master to the next 1.17

Re: [PATCH 1/2] hurd: disable detecting drm

Hi, On 19-10-15 14:47, Samuel Thibault wrote: Signed-off-by: Samuel Thibault OK, re-checking the LIBDRM deps this should work, so this series is: Reviewed-by: Hans de Goede Adam, can you pick these 2 up ? Regards, Hans ---

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

On Wed, 2015-10-14 at 15:44 -0700, Jeremy Huddleston Sequoia wrote: > > On Oct 14, 2015, at 15:33, Alan Coopersmith wrote: > > > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: > > > rrtransform.c:199:23: warning: shifting a negative signed value > > > is undefined

Re: [PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

On Sun, 2015-10-18 at 23:14 -0700, Jeremy Huddleston Sequoia wrote: > Actually, only this last one is "v2". > > The others I just still need a Reviewed-by: for, but they're > unchanged from earlier.  Sorry for any confusion. These last four all look fine.  I've added my r-b to those, and merged

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

> On Oct 19, 2015, at 08:31, Adam Jackson wrote: > > On Wed, 2015-10-14 at 15:44 -0700, Jeremy Huddleston Sequoia wrote: >>> On Oct 14, 2015, at 15:33, Alan Coopersmith wrote: >>> >>> On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: rrtransform.c:199:23: warning:

Re: X server commit process

On Fri, 2015-10-16 at 23:39 -0700, Keith Packard wrote: > Jeremy Huddleston Sequoia writes: > > > What is the current process for pulling into release branches?  Are > > the breakdowns the same, or is someone specific going to manage > > release branches? > > We didn't

[PULL] XQuartz -- Fix launching with ASan

Hey ajax, Thanks for merging the warning fixes I sent. I was actually going to just roll them into this pull-request once they were reviewed, but now it's just down to two XQuartz changes. Thanks, Jeremy The following changes since commit ec6294116cc41ff1c3be081b626952fb7e614244: osinit:

Re: [PATCH 1/2] hurd: disable detecting drm

On Mon, 2015-10-19 at 15:03 +0200, Hans de Goede wrote: > Hi, > > On 19-10-15 14:47, Samuel Thibault wrote: > > Signed-off-by: Samuel Thibault > > OK, re-checking the LIBDRM deps this should work, so this series is: > > Reviewed-by: Hans de Goede

Re: [PATCH xserver 01/24] fonts: Continue when font calls return Suspended more than once

On Mon, 2015-09-21 at 07:16 +0100, Keith Packard wrote: > Patch 3ab6cd31cbdf8095b2948034fce5fb645422d8da fixed Xinerama > interactions with font servers by not putting clients to sleep > multiple times. However, it introduced additional changes dealing with > libXfont routine returning Suspended

Re: [PATCH:libX11] Get rid of some extraneous ; at the end of C source lines

On Tue, 2015-09-29 at 00:26 +0200, Thomas Klausner wrote: > Reviewed-by: Thomas Klausner Merged: remote: I: patch #60532 updated using rev dbcb847a08c44d99e4e1de2ba777d63238fb0e03. remote: I: 1 patch(es) updated to state Accepted. To

Re: [PATCH libXi] Don't use raw serial numbers in XIEvents

On Mon, Oct 19, 2015 at 04:28:12PM -0700, Jasper St. Pierre wrote: > On Sun, Oct 18, 2015 at 7:59 PM, Peter Hutterer > wrote: > > cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). > > This > > I assume this is meant to read "in->sequenceNumber

Re: [PATCH libXi] Don't use raw serial numbers in XIEvents

On Sun, Oct 18, 2015 at 7:59 PM, Peter Hutterer wrote: > cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). This I assume this is meant to read "in->sequenceNumber is an Xlib concoction"? Otherwise, it doesn't make sense. > serial may be

Re: X server commit process

> On Oct 19, 2015, at 08:56, Julien Cristau wrote: > > On Mon, Oct 19, 2015 at 11:47:09 -0400, Adam Jackson wrote: > >> I don't think there's anyone currently working on 1.16 or older. >> > I'm still interested in 1.16 as that's what Debian 8 ships, but at this > point I

Re: [PATCH xserver v2] xorg-wrapper: when starting the server as root, reset its environment

On Mon, 2015-10-19 at 16:01 +0200, Hans de Goede wrote: > Hi, > > On 19-10-15 15:42, Julien Cristau wrote: > > When the server is privileged, we shouldn't be passing the user's > > environment directly. > > > > Clearing the environment is recommended by the libdbus maintainers, > > see > >

Re: [PULL] XQuartz -- Fix launching with ASan

On Mon, 2015-10-19 at 09:15 -0700, Jeremy Huddleston Sequoia wrote: > Hey ajax, > > Thanks for merging the warning fixes I sent.  I was actually going to > just roll them into this pull-request once they were reviewed, but > now it's just down to two XQuartz changes. No problem, I'm trying to be