Re: [RFC xserver v7 14/14] dri3: Enable DRI3 version 1.1

On Thu, 2018-03-01 at 16:53 -0800, Keith Packard wrote: > Louis-Francis Ratté-Boulianne writes: > > > Enable DRI3 v1.1 now that all functions have been implemented and > > that there is at least one backend implementing the driver hooks > > (modesetting/glamor). > > > >

Re: [PATCH xserver] Require libdrm 2.4.89 or newer

On Fri, 2018-03-02 at 17:05 -0800, Keith Packard wrote: > Both autotools and meson build systems had complicated logic around > what version of libdrm to require for various options. Remove that and > just check for a new enough version to support all of the options > which need libdrm. > >

Re: [PATCH:xf86-video-fbdev] Use #ifdef instead of #if to avoid build error

On Sun, 2018-03-04 at 17:34 -0800, Alan Coopersmith wrote: > fbdev.c:491:21: error: #if with no expression > #if HAVE_SHADOW_3224 > ^ > > Signed-off-by: Alan Coopersmith Merged, thanks: remote: I: patch #207943 updated using rev

Re: [xserver 08/10] meson: Make SHM extension optional

On Thu, 2018-03-01 at 12:58 +0100, Laurent Carlier wrote: > v2: check for header 'sys/shm.h' Merged these v2s: remote: I: patch #207571 updated using rev 238219e7312e2b5d972a8620b02379009686a005. remote: I: patch #207572 updated using rev e02afb94783a25c21b07e44a7b615acdd86fa3f7. remote: I:

[ANNOUNCE] xserver 1.20 RC1

Plattner (1): randr: Use RRTransformEqual in RRCrtcPendingTransform Adam Jackson (196): configure: Enable glamor when building just Xwayland composite: Fix repaint of borders (v2) dix: Rename (and retype) PixmapPerDepth[1] to defaultStipple dix: Clear

Re: xserver 1.20 RC1 tomorrow

On Wed, 2018-02-28 at 00:42 +, Daniel Stone wrote: > > 3) https://patchwork.freedesktop.org/series/30946/ > > DMA fences for DRI3. Does have at least one ABI change that looks > > essential, in misync. > > I would certainly like to see this land, but there are some open > questions it'd be

Re: [PATCH v8 00/14] DRI3 multi-plane and modifier support

On Wed, 2018-02-28 at 01:45 +, Daniel Stone wrote: > Hi, > > On 28 February 2018 at 01:19, Daniel Stone > wrote: > > The major change is that the DRI3 protocol version has been bumped > > from > > 1.1 to 1.2, as there was previously a dri3proto-1.1 release, only > >

Re: [PATCH xorgproto v8 02/14] presentproto: PresentCompleteModeSuboptimalCopy flag

On Wed, 2018-02-28 at 01:19 +, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > If the Complete event has this mode, the client is not using > the more optimal format/modifier for the buffer allocation. The > client must explicitely inform the server that it

Re: [PATCH xserver 3/7] randr: Support "non-desktop" property

ei...@keithp.com> > > Reviewed-by: Adam Jackson <a...@nwnk.net> > > [...] > > > @@ -442,6 +465,7 @@ ProcRRGetOutputInfo(ClientPtr client) > > .crtc = output->crtc ? output->crtc->id : None, > > .mmWidth = output->mmWidth, >

[PATCH xserver] randr: Fix a crash on initialization with GPU screens

tput.c:333 ... Reported-by: Michel Dänzer <mic...@daenzer.net> Signed-off-by: Adam Jackson <a...@redhat.com> --- randr/randr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/randr/randr.c b/randr/randr.c index 339ad3ece..feb54bcc8 100644 --- a/randr/randr.c +++ b/randr/ra

Re: xserver 1.20 RC1 tomorrow

On Wed, 2018-02-28 at 00:42 +, Daniel Stone wrote: > Hi, > > On 27 February 2018 at 21:59, Adam Jackson <a...@nwnk.net> wrote: > > 2) https://patchwork.freedesktop.org/series/27289/ > > DRI3 v1.2. Has some ABI changes, but none that are essential, the old > >

xserver 1.20 RC1 tomorrow

I'd like to call the (xfree86) ABI frozen in RC1, and I think for the remaining changes I'd like to see landed for 1.20 we can mostly land them without ABI breaks. To enumerate: 1) https://patchwork.freedesktop.org/series/38022/ Xwayland streams support. No xfree86 changes. 2)

Re: [PATCH xserver] protocol.txt: add GLX req. 35 - SetClientInfo2ARB

On Tue, 2018-02-27 at 17:05 +, Emil Velikov wrote: > From: Emil Velikov > > Noticed while skimming for the typo'd version ;-) > > Signed-off-by: Emil Velikov Nice catch. Merged, thanks: remote: I: patch #207149 updated using rev

Re: [PATCH xserver 5/7] Add RandR leases with modesetting driver support [v6]

On Mon, 2018-02-12 at 13:51 -0800, Keith Packard wrote: > +static void > +drmmode_validate_leases(ScrnInfoPtr scrn) > +{ > +ScreenPtr screen = scrn->pScreen; > +rrScrPrivPtr scr_priv = rrGetScrPriv(screen); > +modesettingPtr ms = modesettingPTR(scrn); > +drmmode_ptr drmmode =

Re: Depth 30 enablement for modesetting-ddx and fixups for glamor. Rev 3

On Tue, 2018-02-27 at 03:05 +0100, Mario Kleiner wrote: > Revision 3, with r-b's by Antoine Martin tacked on, thanks. Antoine, i > left that one /* XXX handle 2 10 10 10 and 1555 formats; ... */ comment > in place. As far as i understand it is meant to be a todo for depth 30 and > depth 16 formats

Re: [PATCH xserver] modesetting: Fix fallback for lack of new vblank kernel API.

On Mon, 2018-02-26 at 22:25 -0800, Keith Packard wrote: > Mario Kleiner writes: > > > Turns out that the kernel DRM ioctl handling returns EINVAL > > instead of ENOTTY if one tries to call the new drmCrtcGetSequence() > > Thanks for fixing this. I must have missed

Re: [PATCH xserver] render: Store and use all 16bpc of precision for solid pixels (v2)

On Mon, 2018-02-26 at 11:30 -0500, Adam Jackson wrote: > On Mon, 2018-02-26 at 17:00 +0100, Michel Dänzer wrote: > > On 2018-02-26 04:33 PM, Adam Jackson wrote: > > > diff --git a/fb/fbpict.c b/fb/fbpict.c > > > index 7ea0b668f8..759f0d5db7 100644 > > > --- a

Re: [PATCH xserver] modesetting: Do not close uninitialized dri2 screen

On Thu, 2018-02-15 at 06:46 -0600, Jeff Smith wrote: > If a dri2 screen is not successfully initialized, attempting to close it > results in a null dereference. > > Maintain a flag indicating whether the dri2 screen was successfully > initialized, and check it before attempting to close the dri2

[PATCH xserver] glamor: unifdef XORG_VERSION_CURRENT

This is always true now that glamor is in-tree. Signed-off-by: Adam Jackson <a...@redhat.com> --- glamor/glamor_utils.h | 4 1 file changed, 4 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 7597b92dc..84371f769 100644 --- a/glamor/glamor_utils.h +++ b/

Re: [PATCH xserver] glx: Don't pass NULL to glxGetClient

On Mon, 2018-02-26 at 17:30 +0100, Michel Dänzer wrote: > From: Michel Dänzer > > These guards were dropped by the commit below, but it turns out they're > needed. Fixes crash on VT switch. Mea culpa. I think this snuck in as part of an attempt on my part to get rid of

Re: [PATCH xserver] render: Store and use all 16bpc of precision for solid pixels (v2)

On Mon, 2018-02-26 at 17:00 +0100, Michel Dänzer wrote: > On 2018-02-26 04:33 PM, Adam Jackson wrote: > > This plumbs the full width color for solid pictures through to fb, exa, > > and glamor. External drivers and acceleration code may wish to make a > > similar change

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

On Fri, 2018-02-23 at 15:57 -0800, Keith Packard wrote: > > You might be right that we _should not_ expose formats not present in > > the hardware, though Render has kinda already lost that fight by making > > a1 and a4 mandatory. But the Render code today, and forever, is making > > the

Re: [PATCH xserver 07/10] meson: Check if SYSV IPC is available

On Sat, 2018-02-24 at 21:14 +0100, Laurent Carlier wrote: > > If we're going to make this optional based on anything it should be the > > presence of . If you don't have that there's certainly no > > point building the support, and if you do you might as well see if it > > works at runtime. > > >

[PATCH xserver] render: Store and use all 16bpc of precision for solid pixels (v2)

This plumbs the full width color for solid pictures through to fb, exa, and glamor. External drivers and acceleration code may wish to make a similar change for sufficiently new servers. v2: Don't break ABI (Michel Dänzer) Signed-off-by: Adam Jackson <a...@redhat.com> Reviewed-by: Keith P

Re: [PATCH xserver 1/2] render: Store all 16bpc of precision for solid pictures

On Mon, 2018-02-26 at 12:16 +0100, Michel Dänzer wrote: > On 2018-02-23 10:08 PM, Adam Jackson wrote: > > Signed-off-by: Adam Jackson <a...@redhat.com> > > [...] > > > diff --git a/render/picturestr.h b/render/picturestr.h > > index 33baef9bf..5d479f18e

[PATCH xserver 2/2] render: Simplify miCompositeRects

Make a solid-fill picture for this instead of a 1x1 pixmap. In principle the backend can accelerate this directly, and we also get to preserve all the bits of the fill color. Signed-off-by: Adam Jackson <a...@redhat.com> --- render/mirect.

[PATCH xserver 0/2] Minor Render cleanups

Some more little things found while testing the depth 30 series. Sadly neither one fixes the rendercheck issues, but neither do they break anything, and the result is definitely simpler. exa/exa_render.c| 4 +++- fb/fbpict.c | 16 +++-- glamor/glamor_program.c | 7

[PATCH xserver 1/2] render: Store all 16bpc of precision for solid pictures

Signed-off-by: Adam Jackson <a...@redhat.com> --- exa/exa_render.c| 4 +++- fb/fbpict.c | 16 +++- glamor/glamor_program.c | 7 --- glamor/glamor_render.c | 14 -- glamor/glamor_utils.h | 9 + render/picture.c

Re: [PATCH xserver] composite: Fix use-after-free in compReparentWindow

On Thu, 2018-02-22 at 22:25 -0800, Keith Packard wrote: > Peter Harris writes: > > > If an implicitly redirected window is unredirected by the reparent > > operation, cw will be a stale pointer. > > > > Signed-off-by: Peter Harris > > Reviewed-by:

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

On Thu, 2018-02-22 at 16:52 -0800, Keith Packard wrote: > > switch (bpp) { > > case 16: > > /* depth 12 formats */ > > -if (pDepth->depth >= 12) { > > -addFormat(formats, , PICT_x4r4g4b4, > > pDepth->depth); > > -

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

On Fri, 2018-02-23 at 10:51 +0100, Michel Dänzer wrote: > On 2018-02-22 10:53 PM, Adam Jackson wrote: > > "depth" for a picture format is the sum of bits of a/r/g/b, and not x. > > The default format list was creating an x8r8g8b8 format at depth 32, > > which is wron

[PATCH xserver 2/3] render: Cosmetic cleanup to default format creation

Signed-off-by: Adam Jackson <a...@redhat.com> --- render/picture.c | 70 ++-- 1 file changed, 27 insertions(+), 43 deletions(-) diff --git a/render/picture.c b/render/picture.c index 1952785b2..f0638a39f 100644 --- a/render/picture.c

[PATCH xserver 1/3] render: Remove some 24bpp handling

This can't happen anymore. Signed-off-by: Adam Jackson <a...@redhat.com> --- render/picture.c | 8 1 file changed, 8 deletions(-) diff --git a/render/picture.c b/render/picture.c index 9e4036e7d..1952785b2 100644 --- a/render/picture.c +++ b/render/picture.c @@ -293,14

[PATCH xserver 0/3] Render format list cleanups

Testing Mario's depth-30 series revealed some non-glamor bugs. I'm a little nervous about 3/3 removing the 'depth 32' x8r8g8b8 format as there could easily be code relying on it existing, but at least cairo seems to get this right. - ajax ___

[PATCH xserver 3/3] render: Fix default picture format initialization

"depth" for a picture format is the sum of bits of a/r/g/b, and not x. The default format list was creating an x8r8g8b8 format at depth 32, which is wrong. Likewise, servers supporting depth 30 would get an x8r8g8b8 format at depth 30, which is nonsense. Signed-off-by: Ad

Re: [PATCH xserver] mi: Mention extension loading in verbose logs

On Wed, 2018-02-21 at 17:12 +, Emil Velikov wrote: > From: Emil Velikov > > Listing the extensions is useful, despite being annoying for normal > usecases. Print it only when extra (lvl 3) vebose is requested. > > v2: Move the logging to InitExtensions(), as

Re: [PATCH xserver 6/6] mi: Mention extension loading in verbose logs

On Mon, 2018-02-19 at 15:18 +, Emil Velikov wrote: > From: Emil Velikov > > Listing the extensions is useful, despite being annoying for normal > usecases. Print it only when extra (lvl 3) vebose is requested. I appreciate lowering the log verbosity, but this

Re: [PATCH xserver] xwayland: Fix backwards need_rotate logic (v2)

On Tue, 2018-02-20 at 18:48 +0100, Olivier Fourdan wrote: > Hi, > > On 20 February 2018 at 18:41, Jason Ekstrand wrote: > > When xdg_output support was added to Xwayland, need_rotate parameter was > > added to output_get_new_size where true gave you the old pre-xdg_output >

Re: [PATCH xserver] Xephyr: Avoid calling xcb_shm_detach() twice

On Tue, 2018-02-20 at 18:07 +0300, Alexander Volkov wrote: > This call was forgotten to be removed in > 90996f5909aab4bc9aa4011a6a6d0555a7aa3adf in which > hostx_destroy_shm_segment() was introduced, which > itself does it. Merged, thanks: remote: I: patch #205633 updated using rev

[PATCH xserver 2/2] glx: Fix indirect no-config contexts

We would throw BadValue here for the GLX_SCREEN attribute. The upper dispatch layer already checks this, we can ignore it here. Signed-off-by: Adam Jackson <a...@redhat.com> --- glx/glxdri2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 25ee

[PATCH xserver 1/2] glx: Enable GLX_ARB_create_context_no_error (v2)

: Remember to ignore the attribute (Eric Anholt) Signed-off-by: Adam Jackson <a...@redhat.com> --- glx/createcontext.c| 4 glx/extension_string.c | 1 + glx/extension_string.h | 1 + glx/glxdri2.c | 7 ++- glx/glxdriswrast.c | 2 ++ glx/glxserver.h| 4 6

Re: [RFC xserver v6 09/14] modesetting: Create scanout buffers using supported modifiers

On Thu, 2018-02-15 at 23:15 -0500, Louis-Francis Ratté-Boulianne wrote: > Use most optimal buffer format (e.g. tiled/compressed) available > for scanout. > > v2: Don't use multi-plane modifier to create scanout buffer > > v3: Add flag to retrieve modifiers set from enabled CRTCs only > > v4:

Re: [RFC xserver v6 05/14] modesetting: Use atomic modesetting API for pageflip if available

On Thu, 2018-02-15 at 23:15 -0500, Louis-Francis Ratté-Boulianne wrote: > In order to flip between compressed and uncompressed buffers - > something drmModePageFlip explicitly bans us from doing - we need > to port use the atomic modesetting API. It's only 'fake' atomic > though given we still

Re: [PATCH xserver 04/10] meson: Make DGA extension optional

On Sun, 2018-02-18 at 10:58 +0100, Laurent Carlier wrote: > Signed-off-by: Laurent Carlier Merged 1-4: remote: I: patch #205373 updated using rev 82d9e99bf99660537a11d9475369c43814cad664. remote: I: patch #205374 updated using rev

Re: [PATCH xserver 07/10] meson: Check if SYSV IPC is available

On Sun, 2018-02-18 at 10:58 +0100, Laurent Carlier wrote: > diff --git a/meson.build b/meson.build > index 107c055..983604a 100644 > --- a/meson.build > +++ b/meson.build > @@ -96,6 +96,21 @@ nettle_dep = dependency('nettle') > dbus_required = get_option('systemd_logind') == 'true' > dbus_dep =

Re: [PATCH xserver 05/10] meson: Make APM support optional

On Sun, 2018-02-18 at 10:58 +0100, Laurent Carlier wrote: > diff --git a/hw/xfree86/os-support/meson.build > b/hw/xfree86/os-support/meson.build > index dfb613e..683aca0 100644 > --- a/hw/xfree86/os-support/meson.build > +++ b/hw/xfree86/os-support/meson.build > @@ -35,6 +35,9 @@ if

Re: [PATCH xserver] os: avoid uninitialized offsets in backtrace

On Thu, 2018-02-15 at 23:47 -0600, Jeff Smith wrote: > When xorg_backtrace calls unw_get_proc_name and an error occurs, offset > might not be set for the current frame. > > Initialize offset for each frame so that the offset from another frame > cannot be used inadvertently. remote: I: patch

Re: [PATCH xserver] hw/xwin: Update for glxvnd

On Fri, 2018-02-16 at 16:44 +, Jon Turney wrote: > - Link with libglxvnd in meson.build > - Call xorgGlxCreateVendor() like all other DDX remote: Updating patchwork state for https://patchwork.freedesktop.org/project/Xorg/list/ remote: I: patch #205278 updated using rev

Re: [PATCH xserver 2/5] glx: Use vnd layer for dispatch (v4)

On Mon, 2018-02-05 at 15:00 -0500, Adam Jackson wrote: > The big change here is MakeCurrent and context tag tracking. We now > delegate context tags entirely to the vnd layer, and simply store a > pointer to the context state as the tag data. If a context is deleted > while it's

Re: [PATCH xcb] Fix hanging issue in _XReply

On Fri, 2018-01-05 at 16:49 +0200, Ian Ray wrote: > From: Tatu Frisk > > Assume event queue is empty if another thread is blocking waiting for event. > > If one thread was blocking waiting for an event and another thread sent a > reply to the X server, both threads got

Re: [PATCH] glx: Do not call into Composite if it is disabled.

On Tue, 2018-02-13 at 10:33 +0100, Michal Srb wrote: > Otherwise X server crashes if GLX is enabled and Composite disabled. For > example the compIsAlternateVisual function will try to lookup CompScreenPtr > using the CompScreenPrivateKey, but that was never initialized if Composite is > disabled.

Re: [PATCH 2/3] meson: Make more extensions optional

On Tue, 2018-02-13 at 22:33 +0100, Laurent Carlier wrote: > Just mimic autoconf file for xf86bigfont, screensaver, > xres, xace and xinerama extensions > > Signed-off-by: Laurent Carlier This broke the build if DMX was enabled, some of the #ifs there didn't get converted

Re: [PATCH xserver 1/2] animcur: Change which CursorPtr we save in external state

On Mon, 2018-02-12 at 15:41 -0500, Adam Jackson wrote: > On Mon, 2018-02-12 at 15:35 -0500, Adam Jackson wrote: > > Formerly spriteInfo->anim.pCursor would point to the animated cursor (or > > NULL if not animated). That value would also be available in > > spriteInfo->

Re: [PATCH xserver] Xephyr: Require xcb-shm version 1.9.3 or newer

On Wed, 2018-02-07 at 14:08 +0300, Alexander Volkov wrote: > It's needed for FD-passing. > > Signed-off-by: Alexander Volkov Merged, thanks: remote: I: patch #203162 updated using rev 8510f542e5474b719f7d7edba7ef0cc05af0271e. remote: I: 1 patch(es) updated to state

Re: [PULL] branch for 1.19.7

On Tue, 2018-02-13 at 23:53 +0200, Timo Aaltonen wrote: > Adam Jackson kirjoitti 13.02.2018 klo 22:55: > > On Tue, 2018-02-13 at 17:44 +0200, Timo Aaltonen wrote: > > > > > > xfree86: Add options support for OutputClass Options > > > > This on

Re: [PULL] branch for 1.19.7

On Tue, 2018-02-13 at 17:44 +0200, Timo Aaltonen wrote: > Hi > > So here's a branch with the OutputClass commits backported, plus one animcur > commit which was missing from the others that already got cherry-picked? > (and I got asked to backport for Ubuntu..) Yeah, I'd skipped that one

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

On Fri, 2018-02-09 at 15:20 +0200, Timo Aaltonen wrote: > On 07.02.2018 16:18, Mario Kleiner wrote: > > > Thanks for the review and merge. This also needs to get picked into the > > server 1.19 branch. Are there plans to tag a new 1.19.7 release soon? > > I'm worried that if spring distro updates

Re: [PATCH xserver 1/2] animcur: Change which CursorPtr we save in external state

On Mon, 2018-02-12 at 15:35 -0500, Adam Jackson wrote: > Formerly spriteInfo->anim.pCursor would point to the animated cursor (or > NULL if not animated). That value would also be available in > spriteInfo->sprite->current, so instead lets use anim.pCursor to point > to

[PATCH xserver 2/2] xfixes: Restore monitoring of animated cursors

This was broken by: commit aa6651f83c698e8cc40de61aad36c73ca7a6adcf Author: Adam Jackson <a...@redhat.com> Date: Thu Jun 8 16:23:12 2017 -0400 xfixes: Remove the CursorCurrent array As of that change we look up the current cursor dynamically instead of trying to

[PATCH xserver 1/2] animcur: Change which CursorPtr we save in external state

Formerly spriteInfo->anim.pCursor would point to the animated cursor (or NULL if not animated). That value would also be available in spriteInfo->sprite->current, so instead lets use anim.pCursor to point to the current animation element. Signed-off-by: Adam Jackson <a...@redhat.com&

Re: [PATCH xorgproto 0/2] randr: Add leases and non-desktop property

On Mon, 2018-02-05 at 12:39 -0800, Keith Packard wrote: > I've just taken my randrproto patches and cherry-picked them into > xorgproto, then cleaned up the bits for the randrproto version > number. Merged: To ssh://git.freedesktop.org/git/xorg/proto/xorgproto 0da7778..e681f8d master ->

Re: [RFC 3/3] xwayland: Add glamor egl_backend for EGLStreams

On Wed, 2018-02-07 at 17:07 -0500, Lyude Paul wrote: > One of the biggest differences with this is that EGLStreams give no way > of doing rendering directly to the allocated resources unless you are > able to set the EGLSurface producers as the current read/draw texture > through

Re: [PATCH xserver 1/5] modesetting: Don't call xf86HandleColorMaps() at screen depth 30.

On Thu, 2018-02-08 at 12:14 +0100, Mario Kleiner wrote: > That in turn is a problem, because the size of the hw lut > crtc->gamma_size is fixed to 256 slots on all kms-drivers > when using the legacy gamma_set ioctl, What exactly is the non-legacy ioctl? - ajax

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

On Tue, 2018-02-06 at 10:48 +0100, Giuseppe Bilotta wrote: > On Tue, Feb 6, 2018 at 10:03 AM, walter harms wrote: > > It would be nice to have an explanation why this change. > > The change is to align the description of the protocol with what the > protocol actually sends (see

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

CrmjzJVhB0PdaE0y9A3Zqx2CEYhUPvtI6PeGSEo=6MOlztrQC3tRtcJvqesPVJ1ri_ILRWLMh-iZbrs7NJ0= > > Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> > > Cc: Thomas Hellstrom <thellst...@vmware.com> > > Cc: Adam Jackson <a...@redhat.com> > > Reviewed-b

Re: [PATCH xserver v2] xwayland: Don't process cursor warping without an xwl_seat

On Tue, 2018-02-06 at 12:41 -0500, Lyude Paul wrote: > Unfortunately, on my machine Xwayland immediately crashes when I try to > start it. gdb backtrace: > > #0 0x774f0e79 in wl_proxy_marshal () from > target:/lib64/libwayland-client.so.0 > #1 0x00413172 in

Re: [PATCH 14/19] present: Add window flip mode

On Tue, 2018-02-06 at 12:21 +0100, Michel Dänzer wrote: > On 2018-02-05 09:08 PM, Adam Jackson wrote: > > On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > > > > > > > The inability to queue a presentation to the next MSC is more of a > > > > &g

Re: Anyone have a backup of XFree86 CVS?

On Mon, 2018-02-05 at 15:24 -0500, Adam Jackson wrote: > I've asked this a couple of times on IRC, repeating it here for wider > distribution. I had thought I had a git import laying around somewhere > but I can't seem to find it. cvs.xfree86.org hasn't been alive in a > long ti

Re: [PATCH xorgproto 1/2] randr: Add Leases. [v4]

On Mon, 2018-02-05 at 12:39 -0800, Keith Packard wrote: > randrproto.pc.in| 2 +- Please be sure to bump the pc version in meson.build too. (If there's a more convenient way to only bump things once, great, let's do that instead.) > +7.6. Extension Requests added in version

Re: [PATCH xserver 3/3] xfree86: Only call PreInit handler if it exists for device

On Sun, 2018-02-04 at 23:17 -0600, Jeff Smith wrote: > DoConfigure() attempts to call the PreInit handler on a device without > checking that the handler exists. > > Check that the PreInit handler exists for a device before attempting to > call it. This is a bit strange to me as the PreInit hook

Anyone have a backup of XFree86 CVS?

I've asked this a couple of times on IRC, repeating it here for wider distribution. I had thought I had a git import laying around somewhere but I can't seem to find it. cvs.xfree86.org hasn't been alive in a long time, and it'd be a shame if that history just got lost, fragmentary as it was. If

Re: [PATCH 14/19] present: Add window flip mode

On Mon, 2018-02-05 at 12:53 +0100, Michel Dänzer wrote: > > > The inability to queue a presentation to the next MSC is more of a step > > > back compared to the status quo. > > > > I'm about to go write up some ideas I'm working on that will make it > > possible to more regularly display

[PATCH xserver 2/5] glx: Use vnd layer for dispatch (v4)

private thunk, not the backend. (Kyle Brenneman) v4: Fix deletion of ghost contexts (Kyle Brenneman) Signed-off-by: Adam Jackson <a...@redhat.com> vnd layer fixup --- configure.ac | 2 +- glx/createcontext.c| 2 - glx/glxcmds.c

Re: [PATCH xserver 2/4] glx: Use vnd layer for dispatch (v3)

On Mon, 2018-02-05 at 12:05 -0700, Kyle Brenneman wrote: > In __glXDisp_DestroyContext, doesn't it need to record the fake XID that > it generates? If I'm reading it right, if the client deletes a current > context and later unbinds it, then xorgGlxMakeCurrent will call > FreeResourceByType

Re: xorgproto build system (was Re: [PATCH xserver 00/10] Implement RandR 1.6)

On Mon, 2018-02-05 at 10:38 -0500, Adam Jackson wrote: > Now, can we call the meson build official and do the releases from > that, probably yes with some more work. Update: "some more work" is turning out to be more than I want to spend on this at the moment. release.sh's use

xorgproto build system (was Re: [PATCH xserver 00/10] Implement RandR 1.6)

On Sat, 2018-02-03 at 14:28 -0800, Keith Packard wrote: > Adam Jackson <a...@nwnk.net> writes: > > > Got impatient and hacked on this a bit more: > > > > https://cgit.freedesktop.org/xorg/proto/xorgproto/ > > Thanks for taking this on. It looks great. &g

Re: [RFC xserver v5 05/14] modesetting: Use atomic modesetting API for pageflip if available

On Mon, 2017-11-06 at 16:30 -0500, Louis-Francis Ratté-Boulianne wrote: > +#ifdef GLAMOR_HAS_DRM_ATOMIC > +if (ms->atomic_modeset) { > +drmModeAtomicReq *req = drmModeAtomicAlloc(); > + > +if (!req) > +return 1; > + > +ret |= plane_add_prop(req,

Re: [PATCH xserver 1/2] shm, xwayland: prefer atomic close-on-exec without O_TMPFILE

On Fri, 2017-07-07 at 16:31 +0200, Jan Beich wrote: > Signed-off-by: Jan Beich Added the equivalent bits to the meson build (hence the failure below) and merged: remote: E: failed to find patch for rev 1e23f03dd5fb6c981ef6d64c084f72fc6820ed71. remote: I: 0 patch(es) updated

Re: [PATCH xserver 2/3] modesetting: Check for -1 before converting to unsigned int.

On Mon, 2017-03-27 at 15:03 +0300, m...@suse.com wrote: > From: Michal Srb > > dri2.c:516:21: warning: comparison of unsigned expression < 0 is always false > [-Wtautological-compare] > if (front->name < 0) > > Prevents a failure from being ignored. > --- Merged these two:

Re: [PATCH xserver] Xdmx: fix input driver initialization code paths

On Mon, 2017-11-06 at 15:26 +0200, Raimonds Cicans wrote: > Problem: Xdmx exit with error "(Fatal Error) dmx: Unknown input argument: " > if local input driver is specified (example: -input local,usb-kbd,usb-mou). > > Cause: code block for remote input drivers is placed in code path common > for

Re: [PATCH xserver] Xephyr: Call forgotten XShmDetach if can't mmap SHM segment

On Fri, 2018-02-02 at 15:17 +0300, Alexander Volkov wrote: > --- > hw/kdrive/ephyr/hostx.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) remote: I: patch #202076 updated using rev 93c16b0524711cd3cd8e32f151c53b5d6522e967. remote: I: 1 patch(es) updated to state Accepted. To

Re: [PATCH v2 xserver 00/11] modesetting: MS_ALL_IN_ONE

On Sat, 2017-01-07 at 16:01 +0800, Qiang Yu wrote: > V2: add PATCH 11 to support GPUScreen capable of display > > This is for hybrid drm device use case that one drm device > is only capable of display and the other is only capable of > rendering. Is this series still relevant? If so, have you

[PATCH xserver 1/4] glx: Import glxvnd server module (v2)

2: Use separate functions to set/get a context tag's private data, and call the backend's MakeCurrent when a client disconnects to unbind the context. (Kyle Brenneman) Signed-off-by: Adam Jackson <a...@redhat.com> --- glx/Makefile.am | 8 +- glx/meson.build |

[PATCH xserver 4/4] miinitext: Remove separate extension toggle list

This was only separate because GLX was loadable. The frontend is now linked statically, so we can use the static extension list directly. Signed-off-by: Adam Jackson <a...@redhat.com> --- mi/miinitext.c | 173 + 1 file chang

[PATCH xserver 2/4] glx: Use vnd layer for dispatch (v3)

private thunk, not the backend. (Kyle Brenneman) Signed-off-by: Adam Jackson <a...@redhat.com> --- configure.ac | 2 +- glx/createcontext.c| 2 - glx/glxcmds.c | 212 + glx/glxcmdsswap.c | 98 +--

[PATCH xserver 3/4] miinitext: Load GLX on the mi path

Add a stub for Xnest so it continues to link, but otherwise we support GLX on every server so there's no need to make every DDX add it. Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/dmx/dmxinit.c | 3 --- hw/kdrive/ephyr/ephyrinit.c| 16

Re: [PATCH xserver 1/2] randr: Fix rotation check in ProcRRSetScreenSize()

On Tue, 2018-01-30 at 13:06 -0800, Alex Goins wrote: > It sounds like this patch is the one we want. Can it be merged? remote: I: patch #196514 updated using rev 6b26a7bda9efa93440734ede0382a3e9a6761365. remote: I: 1 patch(es) updated to state Accepted. To

Re: [PATCH xserver 4/7] glx: Use vnd layer for dispatch (v2)

On Wed, 2018-01-10 at 13:57 -0700, Kyle Brenneman wrote: > xorgGlxThunkRequest should be calling addXIDMap and removeXIDMap, not > the internal handlers. I'm not sure that can be right. If it did, and adding the map failed, there's no way to get the backend to clean up; at least, not the way

Re: [PATCH xserver 2/2] Xephyr: Prefer using MIT-SHM FD-passing when possible

On Wed, 2018-01-31 at 15:57 -0800, Keith Packard wrote: > Alexander Volkov writes: > > > This makes the shared memory visible only for the Xephyr > > and the X server to which it is connected. > > And looks good as well. > > Reviewed-by: Keith Packard

Re: [PATCH xserver 1/4] os: Always return microseconds from GetTimeInMicros()

On Tue, 2017-12-26 at 22:10 -0600, Jeff Smith wrote: > When a monotonic clock is not available, GetTimeInMicros() returns the > time in nanoseconds. Instead, return the time in microseconds, as the > name indicates. > > Signed-off-by: Jeff Smith Merged this one as it's

[PATCH xserver 8/8] xfree86: Remove the rest of ->SetOverscan

Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/common/xf86Init.c | 2 -- hw/xfree86/common/xf86cmap.c | 3 +-- hw/xfree86/common/xf86cmap.h | 2 +- hw/xfree86/common/xf86str.h | 2 -- hw/xfree86/doc/ddxDesign.xml | 27 --- hw/xfree86/vgahw/v

[PATCH xserver 6/8] xf86cmap: Remove the colormap private

We're no longer using it for anything, yay. Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/common/xf86cmap.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86cmap.c index 0f4926c18..0025b7b22

[PATCH xserver 4/8] xf86cmap: Always recalculate colors

Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/common/xf86cmap.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86cmap.c index 93c38a692..a01d02cb3 100644 --- a/hw/xfree86/common/xf86

[PATCH xserver 7/8] dix: Remove colormap private fixup

The old xfree86 colormap system was the only thing that would register a colormap private after the colormap was created. Since that's gone now we can remove the special case. Signed-off-by: Adam Jackson <a...@redhat.com> --- dix/privates.c | 21 + include/priv

[PATCH xserver 5/8] xf86cmap: Compute colors as needed

... instead of saving them in the colormap private. Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/common/xf86cmap.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86cmap.c index a01

[PATCH xserver 0/7] xfree86 colormap cleanup

I found it a bit weird that we were special-casing colormaps in the privates code the same way as we did for screens and devices. As far as I can tell, the xfree86 code is the only thing that needs that, and not for especially good reasons. This series is an attempt to fix that. If you're like

[PATCH xserver 3/8] xf86cmap: Remove overscan machinery

Only drivers using this are trident and xgixp. Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/common/xf86cmap.c | 169 --- 1 file changed, 169 deletions(-) diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86cmap.c

[PATCH xserver 2/8] xf86cmap: Remove numColors from the colormap private

We can compute this as needed instead. Signed-off-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/common/xf86cmap.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86

[PATCH xf86-video-vesa 1/4] Don't build old probe method on sufficiently new servers

If we have pciaccess and not ISA support VESAProbe is effectively return FALSE, and the server will issue a potentially confusing fallback message if VESAPciProbe failed and ->Probe is non-NULL. Signed-off-by: Adam Jackson <a...@redhat.com> --- src/vesa.c | 6 ++ 1 file changed, 6 i

[PATCH xf86-video-vesa 3/4] Use VBEFreeVBEInfo not free

A VbeInfoBlock has substructure, just freeing the object will leak. Unfortunately VBEFreeVBEInfo does not check for NULL first so we have to. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=25029 Signed-off-by: Adam Jackson <a...@redhat.com> --- src/vesa.c | 3 ++- 1 file chan

<    1   2   3   4   5   6   7   8   9   10   >