[PATCH] Fixes v5: Pointer barriers

2010-12-08 Thread Adam Jackson
v2: Review fixes: - Take any drawable to name the screen, don't require a window - Pointer barriers, not Cursor barriers - Elaborate on the interaction with XI2 and with absolute devices - Elaborate on the coordinate rules Signed-off-by: Adam Jackson a...@redhat.com --- COPYING|1

[PATCH] x86emu: Fix more mis-decoding of the data prefix

2010-12-10 Thread Adam Jackson
://www.intel.com/Assets/PDF/manual/253666.pdf Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/x86emu/ops.c | 63 +- 1 files changed, 45 insertions(+), 18 deletions(-) diff --git a/hw/xfree86/x86emu/ops.c b/hw/xfree86/x86emu/ops.c index

[PATCH 2/2] xfree86: Remove the teeth from SIGIO input processing

2010-12-13 Thread Adam Jackson
an optimization for the second case. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86Events.c | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/hw/xfree86/common/xf86Events.c b/hw/xfree86/common/xf86Events.c index 5166adc..c42b5ce

[PATCH 1/2] xfree86: use a thread for the generation of input events

2010-12-13 Thread Adam Jackson
the access of the mi queue by the main and input threads. Two pipes to emit alert events (such hotplug ones) and guarantee the proper communication between them was also used. [ajax: Build fixes for non-Xorg, per-OS defaults] Reviewed-by: Adam Jackson a...@redhat.com Co-authored-by: Fernando Carrijo

[PATCH] Revert composite: Convert compWindowUpdate to use TraverseTree

2010-12-13 Thread Adam Jackson
This reverts commit 648c8871c92727d7b6b16859f27f12266a06a16e. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=32077 Signed-off-by: Adam Jackson a...@redhat.com --- composite/compwindow.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git

Re: [PATCH] Fix detection of multi-function cards

2010-12-14 Thread Adam Jackson
On Wed, 2010-12-01 at 18:42 -0800, Bryce Harrington wrote: Bit 7 of the pci device header type is an indicator of multi-function devices, so needs to be masked when examining the bridge type. Thanks go to Chih-Pin Wu for finding the bug and its fix. Applied, thanks. - ajax signature.asc

Re: [PATCH] Take width into account when choosing default mode

2010-12-14 Thread Adam Jackson
On Fri, 2010-12-03 at 07:20 +0100, Thierry Vignaud wrote: On 16 November 2010 00:59, Thierry Vignaud thierry.vign...@gmail.com wrote: Actually the latest bit got added after (maybe by pcpa?) Here you are anyway: the fixed patch from one of best gurus of old Mandriva (pixel) Will it get

Re: [PATCH libX11] Fix XQueryColors() doesn't return if ncolors is 65536.

2010-12-14 Thread Adam Jackson
On Fri, 2010-12-03 at 17:11 -0500, Matt Turner wrote: From: Kusanagi Kouichi sl...@ma.neweb.ne.jp Fixes bugs: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=278984 https://bugs.freedesktop.org/show_bug.cgi?id=9160 --- The patch looks like it only makes the whitespace mess

Re: [PATCH ark] Don't assume that FB address registers are initialized properly

2010-12-14 Thread Adam Jackson
On Fri, 2010-12-03 at 19:26 -0500, Matt Turner wrote: From: Ondrej Zary li...@rainbow-software.org https://bugs.freedesktop.org/show_bug.cgi?id=28249 Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part

Re: [PATCH libXfont] Fix Font lookup by fontfile is slow on certain patterns.

2010-12-14 Thread Adam Jackson
On Fri, 2010-12-03 at 20:11 -0500, Matt Turner wrote: From: Takano Akio al...@hyper.cx https://bugs.freedesktop.org/show_bug.cgi?id=7832 I like this algorithm a lot more, but I'm not completely convinced of its correctness. In particular, I think you can get it to match a - with a *, which I

Re: [PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-14 Thread Adam Jackson
the card. Patch looks correct though. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: Reviewed patches from the Ubuntu tree

2010-12-14 Thread Adam Jackson
On Mon, 2010-12-06 at 11:23 +1100, Christopher James Halse Rogers wrote: I've been cleaning up the Ubuntu X packages, and I've run across some patches that have been reviewed some time ago but aren't yet in master. Resending them, since I've clearly dropped them on the floor at one point.

Re: [PATCH libFS] Export only public API symbols

2010-12-14 Thread Adam Jackson
On Mon, 2010-12-06 at 12:21 -0300, Cristian Rodríguez wrote: Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org Checked against the public header and the effective ABI of everything in Fedora linked against libFS, looks fine. Applied, thanks. - ajax signature.asc Description:

Re: [PATCH libXScrnSaver] Export only public API symbols

2010-12-14 Thread Adam Jackson
On Mon, 2010-12-06 at 12:27 -0300, Cristian Rodríguez wrote: Signed-off-by: Cristian Rodríguez cristian.rodrig...@opensuse.org Seems like a no-op to me, the only (non-linker-magic) symbols in libXss all start with XScreenSaver already. - ajax signature.asc Description: This is a digitally

Re: [PATCH 2/2] Remove {xf86, }LoaderRe{q, f}Sym{bols, Lists} and their symbols

2010-12-14 Thread Adam Jackson
On Mon, 2010-12-13 at 10:48 -0200, Paulo Zanoni wrote: According to xserver commit 71a83d68ab07536c0778d13cd7da974c40e77457 they do nothing since 2006. Signed-off-by: Paulo Zanoni pzan...@mandriva.com Kill 'em all. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc

Re: [RFC][PATCH] dix/mi/composite: Suppress ClipNotify during window redirection UnmapWindow

2010-12-14 Thread Adam Jackson
On Mon, 2010-12-13 at 19:15 +0200, ville.syrj...@nokia.com wrote: From: Ville Syrjälä ville.syrj...@nokia.com When window redirection is changed, UnmapWindow() is called internally, which leads to windows temporarily getting unrealized. When a window is unrealized, ClipNotify() is called

Re: [PATCH 2/2 xgixp] Replace X{c, r, }alloc and Xfree for stdlib functions

2010-12-14 Thread Adam Jackson
On Mon, 2010-12-13 at 16:33 -0200, Paulo Zanoni wrote: Signed-off-by: Paulo Zanoni pzan...@mandriva.com Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org

Re: State of XDBE

2010-12-14 Thread Adam Jackson
On Tue, 2010-12-14 at 08:08 +0100, Lars Segerlund wrote: Hi All, I am trying to add support for xdbe in xcb, which in itself looks simple, but someone said that xdbe is deprecated ? The major toolkits don't bother to use it, so presumably they think explicitly managing the backing pixmap

Re: [RFC][PATCH] dix/mi/composite: Suppress ClipNotify during window redirection UnmapWindow

2010-12-15 Thread Adam Jackson
On Wed, 2010-12-15 at 20:14 +0200, Ville Syrjälä wrote: On Tue, Dec 14, 2010 at 03:57:18PM -0500, ext Adam Jackson wrote: The result from this sounds reasonable and correct. The implementation should probably be a new CompositeClipNotify wrapper, rather than forcing the knowledge

Re: [PATCH] xfree86: Remove unused xf86inSuspend

2010-12-16 Thread Adam Jackson
On Wed, 2010-12-15 at 14:59 -0500, Adam Jackson wrote: What is this, I don't even. It was point out to me on IRC that this _is_ in fact used in the kbd driver, to suppress event processing while suspended. I believe it can be removed entirely even there though. Right after setting that flag we

Re: [PATCH 1/2] xfree86: use a thread for the generation of input events

2010-12-16 Thread Adam Jackson
On Wed, 2010-12-15 at 23:08 +0100, Mark Kettenis wrote: Yes, that is the additional locking that's necessary. I'd say you'll need a mutex that you lock in x86BlockSIGIO() and unlock in xf86UnblockSIGIO() and lock/unlock around each event that you process in the input thread. It's more

[PATCH] Remove SCO support

2010-12-16 Thread Adam Jackson
This has never been buildable in any modular server release. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xf86bigfont.c|2 +- configure.ac |1 - hw/xfree86/common/compiler.h | 13 -- hw/xfree86/common/scoasm.h

[PATCH 1/5] xfree86: Symmetrize xf86AccessEnter and xf86AccessLeave

2010-12-16 Thread Adam Jackson
Enter was changing server operating state, Leave wasn't. Which was wholly redundant, since all callers of Enter would immediately change the operating state to exactly what Enter had just done. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86Bus.c |2 -- 1 files

[PATCH 0/5] Input thread v2

2010-12-16 Thread Adam Jackson
This lays some groundwork for landing threaded input by tidying up the use of SIGIO within the server. It's still not complete, as it still does not add mutexes around the input state, but at least the first four patches should stand on their own. - ajax

[PATCH 2/5] xfree86: Remove xf86EnterServerState

2010-12-16 Thread Adam Jackson
section for the duration of the caller's stack frame, but those two effectively disable SIGIO after their return and re-enable on their next entry. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86.h |1 - hw/xfree86/common/xf86Bus.c| 33

[PATCH 3/5] xfree86: Convert some xf86BlockSIGIO to OsBlockSignals

2010-12-16 Thread Adam Jackson
means block input events. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/ddc/ddc.c | 11 --- hw/xfree86/int10/helper_exec.c |5 +++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/ddc/ddc.c b/hw/xfree86/ddc/ddc.c index 7c7dc9c..179f42c

[PATCH 4/5] xfree86: Reduce SIGIO block/unblock traffic

2010-12-16 Thread Adam Jackson
Push/pop the SIGIO block outside the loop rather than every time through it. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86Events.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/common/xf86Events.c b/hw/xfree86/common

[PATCH 5/5] input: use a thread for the generation of input events

2010-12-16 Thread Adam Jackson
in InputThreadUnregisterDev - Fix build with --disable-input-thread - Merge SIGIO strength reduction Co-authored-by: Fernando Carrijo fcarr...@freedesktop.org Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 30 +++ dix/main.c

Re: [PATCH] randr: check for virtual size limits before set crtc

2010-12-16 Thread Adam Jackson
On Thu, 2010-12-16 at 22:30 +0200, Tiago Vignatti wrote: Return a error if the screen is configured to an invalid size. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part

Re: [PATCH v2] xfree86/modes: Take rotation into account when checking mode size

2010-12-16 Thread Adam Jackson
be used with a specific output, but that information doesn't seem to be readily available when these checks are done. So just assume that either orientation is fine. I think this is as right as we can do given how xf86ProbeOutputModes works. Reviewed-by: Adam Jackson a...@redhat.com - ajax

[PATCH] Remove SCO support

2010-12-16 Thread Adam Jackson
This has never been buildable in any modular server release. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xf86bigfont.c|2 +- configure.ac |1 - hw/xfree86/common/Makefile.am |1 - hw/xfree86/common/compiler.h

Re: [PATCH 5/5] input: use a thread for the generation of input events

2010-12-17 Thread Adam Jackson
On Fri, 2010-12-17 at 15:24 +0200, Tiago Vignatti wrote: you left MaxInputDevices out of the disabling macro. Also, I liked in the previous patchset when you used the second commit to explain that now we have two input processing methods: - input thread - main loop dispatch where the

Re: xdm - xdmcp

2010-12-20 Thread Adam Jackson
On Sat, 2010-12-18 at 10:59 -0500, Gaetan Nadon wrote: On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find the following symbols: _XdmcpAuthSetup _XdmcpAuthDoIt _XdmcpWrapperToOddParity I don't

Re: [PATCH] randr: Add additional cursor confinement hook in the ScreenRec

2010-12-20 Thread Adam Jackson
On Mon, 2010-11-15 at 16:23 -0500, Adam Jackson wrote: And use it to confine cursor motion to within the bounds of a single CRTC, iff all the CRTCs within a ScreenRec are reachable from each other. If not you get the same cursor floats within the bounding rect behaviour you get now. v2

Re: [PATCH] x86emu: Fix more mis-decoding of the data prefix

2010-12-20 Thread Adam Jackson
On Fri, 2010-12-10 at 14:47 -0500, Adam Jackson wrote: cc2c73ddcb4370a7c3ad439cda4da825156c26c9's three-cent titanium tax doesn't go too far enough. Fix the rest of the call and jmp instructions to handle the data prefix correctly. Reference: Intel 64 and IA-32 Architectures Software

[PULL] Minor 1.10 fixes

2010-12-20 Thread Adam Jackson
The following changes since commit e7dc253452a1ba64718a08fdc070405b494f53cd: Merge remote branch 'alanc/master' (2010-12-20 00:48:45 -0800) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (6): xfree86: Remove unused

Re: [PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle

2010-12-20 Thread Adam Jackson
On Mon, 2010-12-20 at 20:03 +0200, Ville Syrjälä wrote: On Mon, Dec 20, 2010 at 01:04:07PM -0500, ext Adam Jackson wrote: This can't be right, I don't think. You've eliminated the Map/Unmap cycle - entirely laudable, thank you for taking it on - but in doing so you're not replacing

Re: [PATCH] xlib: Initilize event type

2011-01-03 Thread Adam Jackson
On Thu, 2010-12-23 at 09:44 +1000, Peter Hutterer wrote: On Wed, 22 Dec 2010 19:21:13 +0200, Pauli ext-pauli.niemi...@nokia.com wrote: Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Applied, thanks. - ajax signature.asc

Re: [PATCH keyboard] Removed unused code

2011-01-03 Thread Adam Jackson
On Tue, 2010-12-28 at 17:41 +0500, Alexandr Shadchin wrote: Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com Applied, thanks. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH keyboard] Small fix include

2011-01-03 Thread Adam Jackson
On Tue, 2010-12-28 at 17:45 +0500, Alexandr Shadchin wrote: Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com Applied, thanks. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xrdb] Call C preprocessor with -P option (changed behaviour in GCC 4.5)

2011-01-03 Thread Adam Jackson
On Tue, 2010-12-28 at 16:58 +0100, Ulrich Mueller wrote: http://bugs.freedesktop.org/show_bug.cgi?id=32701 http://bugs.gentoo.org/show_bug.cgi?id=347758 Signed-off-by: Ulrich Mueller u...@gentoo.org This looks like a safe change in that all the extant cpp's seem to accept -P with the same

Re: ebeam xinput driver : ask for review

2011-01-03 Thread Adam Jackson
On Wed, 2010-12-29 at 19:42 +0100, Yann Cantin wrote: Hi, I've coded a xinput driver for ebeam device, and wanted to know if it's possible to have it reviewed by someone. I'll provide more background info if it's of interest. Send a link to the source (or email it to the list if it's

Re: [PATCH 00/11] Allow registering only wakeup or block handler

2011-01-03 Thread Adam Jackson
. (This actually eliminates a NoopDDA and a random static handler in server that I run) Happy New Year! Much love for this series, 9% speedup on roundtrip-bound performance is a nice win. I suspect this is already queued in Daniel's tree but if it's not, for the series: Reviewed-by: Adam Jackson

[PULL] 1.10 fixes

2011-01-04 Thread Adam Jackson
The following changes since commit 261d0d16af797bb52d4c778e220296d7f2b28e14: Fix asprintf typo in commit d2c42b10 (2010-12-31 13:07:24 +) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (1): x86emu: Fix more mis-decoding

[PATCH] dix: Add a Screen method for additional cursor confinement

2011-01-05 Thread Adam Jackson
This just reserves the slot in the ABI and adds the call to position updates. Confining cursors to CRTCs will come soon. Signed-off-by: Adam Jackson a...@redhat.com --- include/scrnintstr.h |4 mi/mipointer.c |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff

[PATCH] dix: Add a Screen method for additional cursor confinement

2011-01-05 Thread Adam Jackson
This just reserves the slot in the ABI. Confining cursors to CRTCs will come soon. v2: Just reserve the slot. Signed-off-by: Adam Jackson a...@redhat.com --- include/scrnintstr.h |4 1 file changed, 4 insertions(+), 0 deletions(-) diff --git a/include/scrnintstr.h b/include

Re: [PATCH] Include ShmGetImage tests for x11perf

2011-01-06 Thread Adam Jackson
and just collect and discard the replies. Still, worth adding. With the MidCopyPix thing fixed: Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development

[PULL] Cursor confinement ABI

2011-01-06 Thread Adam Jackson
) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (1): dix: Add a Screen method for additional cursor confinement include/scrnintstr.h |4 1 files changed, 4 insertions(+), 0 deletions(-) - ajax signature.asc Description

[PATCH 0/3] Fedora hack merge

2011-01-06 Thread Adam Jackson
A collection of things I've been carrying too long in Fedora. Should be uncontroversial though, I'm just tired of rebasing them. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH 1/3] os: Add -displayfd option.

2011-01-06 Thread Adam Jackson
. As a consequence, if X fails to start when using -displayfd, it's not because the display was in use, so there's no point in retrying the X launch on a higher display number. Signed-off-by: Adam Jackson a...@redhat.com --- dix/globals.c |1 + doc/man/Xserver.man |7 + include/opaque.h|1

[PATCH 2/3] xfree86: If the driver found modes on an output, don't add more

2011-01-06 Thread Adam Jackson
still add default modes as normal. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/modes/xf86Crtc.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index c4470c3..dba5f28 100644 --- a/hw/xfree86

[PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-06 Thread Adam Jackson
Use _LP64 (verified on gcc and sun compilers) instead of _XSERVER64 in internal header usage, and always define _XSERVER64 for modules if _LP64 is defined. Prevents differing xorg-server.h between 32 and 64 bit packages. Signed-off-by: Adam Jackson a...@redhat.com --- include/colormapst.h

[PULL 1.9] xfree86(ish) updates

2011-01-06 Thread Adam Jackson
at: ssh://people.freedesktop.org/~ajax/xserver server-1.9-xfree86 Adam Jackson (1): x86emu: Fix more mis-decoding of the data prefix Daniel Stone (1): GetTimeInMillis: Use CLOCK_MONOTONIC_COARSE where available Pauli Nieminen (2): render: Don't filter 0 return from GetTimeInMillis

Re: [PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-07 Thread Adam Jackson
On Fri, 2011-01-07 at 00:51 +0100, Mark Kettenis wrote: --- a/include/colormapst.h +++ b/include/colormapst.h @@ -103,12 +103,12 @@ typedef struct _ColormapRec { VisualPtr pVisual; short class; /* PseudoColor or DirectColor */ -#if defined(_XSERVER64)

[PATCH 4/5] resource: Remove expectID hack

2011-01-08 Thread Adam Jackson
be true, and we'll no longer catch XID collisions at all. Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index a5737f3..4545a70 100644 --- a/dix/resource.c +++ b/dix

[PATCH 5/5] resource: Fix indentation

2011-01-08 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 4545a70..eb26f11 100644 --- a/dix/resource.c +++ b/dix/resource.c @@ -889,21 +889,21

[PATCH 1/5] resource: Remove a useless iteration

2011-01-08 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 6bd2403..07fcc65 100644 --- a/dix/resource.c +++ b/dix/resource.c @@ -382,7 +382,6 @@ GetXIDRange(int client, Bool

[PATCH 2/5] resource: s/NullResource/NULL/g

2011-01-08 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 07fcc65..fcda116 100644 --- a/dix/resource.c +++ b/dix/resource.c @@ -167,7 +167,6 @@ typedef struct _Resource

[PATCH 3/5] resource: Remove a redundant field from client resource tracking

2011-01-08 Thread Adam Jackson
We only ever need log2(buckets) when rebuilding the table, which is comparatively rare. Compute it when we need it instead of tracking it by hand. Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff

Re: [PATCH] xfree86/modes: Be sure to only use new EDID for physical output dimensions

2011-01-10 Thread Adam Jackson
...@mokafive.com Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH bitmap] Remove unused, leaky scanline.

2011-01-10 Thread Adam Jackson
On Sat, 2011-01-08 at 20:15 -0500, Trevor Woerner wrote: From: Trevor Woerner twoer...@gmail.com The pointer, scanline, doesn't appear to be used anymore, and is leaking memory. Signed-off-by: Trevor Woerner twoer...@gmail.com Reviewed-by: Adam Jackson a...@redhat.com - ajax

[PATCH] resource: Remove a useless iteration

2011-01-10 Thread Adam Jackson
v2: More aggressive loop rewrite pointed out by Daniel. Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c | 28 1 files changed, 12 insertions(+), 16 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 6bd2403..ed8cc35 100644 --- a/dix

Re: [PULL] Cursor confinement ABI

2011-01-10 Thread Adam Jackson
On Thu, 2011-01-06 at 15:01 -0500, Adam Jackson wrote: Apologies for no r-b on the list, but: Also apologies for not cc'ing Keith. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] resource: Remove a useless iteration

2011-01-10 Thread Adam Jackson
On Mon, 2011-01-10 at 17:49 +, Daniel Stone wrote: On Mon, Jan 10, 2011 at 12:44:23PM -0500, Adam Jackson wrote: v2: More aggressive loop rewrite pointed out by Daniel. Sorry, I should've mentioned this the first time -- only realised after I sent the mail -- but: +for (i = 0; i

[PATCH] resource: Micro-tune resource hash computation

2011-01-10 Thread Adam Jackson
We do actually call Hash() on resource lookup, so let's not make it more expensive than necessary. The compiler isnmay not be smart enough to notice that we only ever have a power of two count of buckets, so flatten the log2 math so it doesn't have to know. Signed-off-by: Adam Jackson

Re: [PATCH 1/3] Add pixman_composite_trapezoids().

2011-01-13 Thread Adam Jackson
On Wed, 2011-01-12 at 08:49 -0500, Søren Sandmann Pedersen wrote: This function is an implementation of the X server request Trapezoids. That request is what the X backend of cairo is using all the time; by moving it into pixman we can hopefully make it faster. This looks like it loses the

Re: [PATCH] resource: Micro-tune resource hash computation

2011-01-13 Thread Adam Jackson
On Wed, 2011-01-12 at 12:04 -0800, Jamey Sharp wrote: If Hash is performance critical, is there a strong reason not to replace it with this? return id (clientTable[client].buckets - 1); I'd be interested to see evidence justifying mixing higher-order bits into the hash. I really doubt

Re: [PATCH 4/4] xf86/xv: Only register PostValidateTree hook when there is work to do

2011-01-16 Thread Adam Jackson
On Jan 14, 2011, at 8:44 AM, Pauli wrote: @@ -1151,8 +1149,7 @@ xf86XVPostValidateTree(WindowPtr pWin, WindowPtr pLayerWin, VTKind kind) if (ScreenPriv-PostValidateTree) { pScreen-PostValidateTree = ScreenPriv-PostValidateTree; (*pScreen-PostValidateTree)(pWin, pLayerWin,

Re: [PATCH -cirrus] Add a check for max_pitch values for GD5446 / FAUmachine

2011-01-16 Thread Adam Jackson
On Jan 14, 2011, at 5:50 PM, Bryce Harrington wrote: The GD 5446 uses 9 bits to store the pitch value, which then get shifted by 3 bits to the left in the graphic card. For the resolution of 1360x768 however, X sets the pitch to 1408, which hence results in an actual used pitch by the card of

Re: [PATCH 0/6] Move main() from DIX to DDXen

2011-01-17 Thread Adam Jackson
On Jan 17, 2011, at 9:20 AM, Jon TURNEY wrote: This is more in the nature of a RFC, but this is the least-bad approach I have managed to come up with. I don't really have a problem with this series, but your motivations seem odd: * libdix comes in 2 different flavours, depending on if it's

[PATCH 1/2] mi: Call pScreen-ConstrainCursorHarder from the position update path

2011-01-18 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- mi/mipointer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/mi/mipointer.c b/mi/mipointer.c index 554397a..1f08133 100644 --- a/mi/mipointer.c +++ b/mi/mipointer.c @@ -229,6 +229,10 @@ miPointerSetCursorPosition

[PATCH 2/2] randr: Add RRConstrainCursorHarder

2011-01-18 Thread Adam Jackson
-by: Adam Jackson a...@redhat.com --- randr/randr.c|2 + randr/randrstr.h |5 ++- randr/rrcrtc.c | 154 ++ 3 files changed, 160 insertions(+), 1 deletions(-) diff --git a/randr/randr.c b/randr/randr.c index c22657e..6b3af0f 100644

Re: Laptop Panel brightness control

2010-01-04 Thread Adam Jackson
On Mon, 2009-12-28 at 15:59 +0100, Sylvain Defresne wrote: Hello, In 2006 a property laptop_panel.brightness_in_hardware was added to HAL [1] to inform client of different handling of the bightness control key by the BIOS (some BIOSes forward the event to the userspace, some handle them

Re: [PATCH v2] kdrive: Remove bus mouse driver

2010-01-04 Thread Adam Jackson
On Mon, 2010-01-04 at 02:04 +0600, Mikhail Gusarov wrote: Bus mice aren't anymore, do not keep dead code around. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel

Re: [PATCH 0/9] Another round of kdrive cleanups

2010-01-04 Thread Adam Jackson
On Sat, 2010-01-02 at 20:32 +0600, Mikhail Gusarov wrote: More janitorial stuf, plus substantial changes: - compiling out kbd/mouse/evdev if needed - drop unused overlay fb support For the series, Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description

Re: [PATCH 0/7] Third round of kdrive cleanups

2010-01-04 Thread Adam Jackson
' For the series, Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Remove mibank wrapper

2010-01-04 Thread Adam Jackson
On Mon, 2010-01-04 at 13:18 -0800, Keith Packard wrote: On Mon, 4 Jan 2010 15:32:49 -0500, Adam Jackson a...@redhat.com wrote: +static int +miScanLineWidth( Is there any driver still using this function? I'd rather see it disappear than live on without having any users. No driver uses

Re: [PATCH] modes: Remove the ClockRanges type

2010-01-05 Thread Adam Jackson
On Tue, 2009-11-10 at 12:59 -0800, Keith Packard wrote: Excerpts from Adam Jackson's message of Tue Nov 10 11:56:36 -0800 2009: Signed-off-by: Adam Jackson a...@redhat.com I don't see any reason not to merge this one; anyone care to differ? Reviewed-by: Keith Packard kei...@keithp.com

Re: small EDID library (possible start)

2010-01-06 Thread Adam Jackson
On Wed, 2010-01-06 at 11:13 +0100, Kai-Uwe Behrmann wrote: That is Adam Jackson's parse-edid.c with lots of global variables and no library interface at all (2009). That is fine for the intented usage as command line tool, but unfortunedly not a comfortable base for a library. Yeah, that's

Re: [PATCH] set_fontset_extents crash after get_rotate_fontname fix in 2bef065b70f7

2010-01-06 Thread Adam Jackson
on bad fonts. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

[REVIEW] DMX2 DIX merge

2010-01-06 Thread Adam Jackson
I'm trying to pick up the DIX pieces of David Reveman's old dmx-2 branch, since they look broadly reasonable. The major themes are: a) Enabling support for the Composite stack in Xinerama mode b) Exposing animated cursors to the DDX for acceleration c) Integrating RANDR and Xinerama at the

Re: [REVIEW] DMX2 DIX merge

2010-01-06 Thread Adam Jackson
On Wed, 2010-01-06 at 14:25 -0800, Keith Packard wrote: On Wed, 06 Jan 2010 16:12:15 -0500, Adam Jackson a...@nwnk.net wrote: c) Integrating RANDR and Xinerama at the protocol layer It seems like we could use the current Panoramix implementation at least for now, even if you want to do

Re: [REVIEW] DMX2 DIX merge

2010-01-07 Thread Adam Jackson
On Wed, 2010-01-06 at 17:26 -0800, Keith Packard wrote: On Wed, 06 Jan 2010 17:39:15 -0500, Adam Jackson a...@nwnk.net wrote: I described this wrong. It corrects the RANDR geometry to account for the Xin muxer's idea of the root window size, but XRRGetScreenResources still only gives you

Re: libminitrue

2010-01-07 Thread Adam Jackson
On Thu, 2010-01-07 at 14:38 +0100, Kai-Uwe Behrmann wrote: The above library appears rather early in development. Too early to come with patches for extending? Not at all, please do. Also, the name is a rather lame joke. If anyone has better suggestions, I'm all ears. - ajax signature.asc

Re: [PATCH] Do not define members of include/eventstr.h:EventType enum conditionally

2010-01-07 Thread Adam Jackson
patch to both master and 1.7 branches, please? Thanks. Nice find. Should definitely merge this. Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel mailing list xorg

Re: [REVIEW] DMX2 DIX merge

2010-01-07 Thread Adam Jackson
On Thu, 2010-01-07 at 08:02 -0800, Keith Packard wrote: On Thu, 07 Jan 2010 10:04:45 -0500, Adam Jackson a...@nwnk.net wrote: If we consider a non-transformative, non-GL compositor, then I think it's pretty straightforward. Pixmaps created relative to the root window start life in system

Re: [REVIEW] DMX2 DIX merge

2010-01-07 Thread Adam Jackson
On Thu, 2010-01-07 at 11:09 -0500, Alex Deucher wrote: On Thu, Jan 7, 2010 at 11:02 AM, Keith Packard kei...@keithp.com wrote: On Thu, 07 Jan 2010 10:04:45 -0500, Adam Jackson a...@nwnk.net wrote: I'm not even really sure what direct rendered GLX means in the context of Xinerama. I can see

[PATCH] Eliminate per-test timing calibration.

2010-01-07 Thread Adam Jackson
Instead, use setitimer() to receive a SIGALRM after the requested number of seconds elapses, and change the tests to report back the true number of iterations. Signed-off-by: Adam Jackson a...@redhat.com --- do_arcs.c| 12 -- do_blt.c | 102

Re: [PATCH] Eliminate per-test timing calibration.

2010-01-07 Thread Adam Jackson
On Thu, 2010-01-07 at 15:24 -0500, Peter Harris wrote: On 2010-01-07 14:54, Adam Jackson wrote: void diff --git a/x11perf.c b/x11perf.c index 15eb04d..410967c 100644 --- a/x11perf.c +++ b/x11perf.c @@ -38,12 +38,18 @@ SOFTWARE. #define Time_t time_t #include stdlib.h

[PATCH] randr: Unify the core primary output and the xf86 compat output

2010-01-08 Thread Adam Jackson
These are logically the same thing, but RANDR didn't have a primary output concept until recently. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86cmap.c | 10 +-- hw/xfree86/modes/xf86Crtc.c| 137 --- hw/xfree86/modes/xf86Crtc.h

Re: [PATCH] s/tinyX/Kdrive/ in Kdrive usage message

2010-01-11 Thread Adam Jackson
On Sun, 2010-01-10 at 15:17 -0500, Gaetan Nadon wrote: FYI, in proto/randrproto/randrproto.txt: 0.0: This prototype implemented resize and rotation in the TinyX server Used approximately the protocol described in the Usenix paper. Appeared in the TinyX server

Re: [PATCH] main: move config_init() after InitInput()

2010-01-11 Thread Adam Jackson
://bugs.debian.org/564256 Reported-by: Sedat Dilek sedat.di...@googlemail.com Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Adam Jackson a...@redhat.com - ajax signature.asc Description: This is a digitally signed message part ___ xorg

Re: Debugging X with GDB

2010-01-11 Thread Adam Jackson
On Mon, 2010-01-11 at 16:26 +0200, Jonathan Morton wrote: On Mon, 2010-01-11 at 09:01 -0500, Daniel Jacobowitz wrote: On Sun, Jan 10, 2010 at 07:42:16PM -0500, Bernie Innocenti wrote: airlied I think X might change TTY state and piss gdb off I'd imagine this is it, but it's impossible

Re: [REVIEW] DMX2 DIX merge

2010-01-11 Thread Adam Jackson
On Thu, 2010-01-07 at 14:46 -0800, Aaron Plattner wrote: On Thu, Jan 07, 2010 at 07:04:45AM -0800, Adam Jackson wrote: On Wed, 2010-01-06 at 17:26 -0800, Keith Packard wrote: On Wed, 06 Jan 2010 17:39:15 -0500, Adam Jackson a...@nwnk.net wrote: But that's still kind of gross, since your

Re: libpciaccess x86 backend

2010-02-04 Thread Adam Jackson
On Tue, 2010-01-19 at 21:10 +0200, Tiago Vignatti wrote: On Tue, Jan 19, 2010 at 06:37:43PM +0100, ext Samuel Thibault wrote: Tiago Vignatti, le Tue 19 Jan 2010 18:44:06 +0200, a écrit : change the name for gnuhurd_pci.c makes more sense for me, given all file there now are OS related.

[PATCH] kdrive: Remove Xfbdev.

2010-02-08 Thread Adam Jackson
Use Xorg with the fbdev driver. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac| 14 - hw/kdrive/Makefile.am |7 +- hw/kdrive/fbdev/.gitignore |2 - hw/kdrive/fbdev/Makefile.am | 29 -- hw/kdrive/fbdev/Xfbdev.man | 28 -- hw/kdrive/fbdev/fbdev.c

[PULL] Fedora patch merge

2010-02-08 Thread Adam Jackson
True - TRUE and False - FALSE are available in the git repository at: git://people.freedesktop.org/~ajax/xserver.git fedora-merge Adam Jackson (3): os: Add -displayfd option. xfree86: If the driver found modes on an output, don't add more xfree86: Fix the sdk headers

Re: [PATCH] kdrive: Remove Xfbdev.

2010-02-08 Thread Adam Jackson
On Mon, 2010-02-08 at 20:30 +0100, Mikhail Gusarov wrote: Twas brillig at 14:27:40 08.02.2010 UTC-05 when a...@redhat.com did gyre and gimble: AJ Use Xorg with the fbdev driver. Nack. Xfree86 DDX is still too heavy to be used in embedded stuff where Xfbdev is used. Let's chop some

Re: [PATCH] kdrive: Remove Xfbdev.

2010-02-08 Thread Adam Jackson
On Mon, 2010-02-08 at 22:12 +0100, Mikhail Gusarov wrote: Twas brillig at 16:07:17 08.02.2010 UTC-05 when a...@nwnk.net did gyre and gimble: AJ Use Xorg with the fbdev driver. Nack. Xfree86 DDX is still too heavy to be used in embedded stuff where Xfbdev is used. Let's chop some

[PATCH] xfree86: Add qxl driver to autodetect logic.

2010-02-08 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86AutoConfig.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86AutoConfig.c b/hw/xfree86/common/xf86AutoConfig.c index 1c4595e..384c7e5 100644 --- a/hw/xfree86/common

<    1   2   3   4   5   6   7   8   9   10   >