Re: [PATCH xf86-input-evdev 2/2 v2] Add support for masked valuators

2011-01-22 Thread Chase Douglas
On 01/05/2011 10:33 PM, Peter Hutterer wrote: On Wed, Jan 05, 2011 at 03:27:06PM -0500, Chase Douglas wrote: With the X server now supporting masked valuators for XI2, enable support in X evdev. This kills backwards compatibility with X Input ABI 12 thanks! we need some extra configure

[PATCH xf86-input-evdev 1/3] Remove support for X input ABI 13

2011-01-22 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/draglock.c |5 - src/emuMB.c|4 - src/emuWheel.c |4 - src/evdev.c| 446 +--- src/evdev.h| 25 +--- 5 files changed, 12 insertions(+), 472 deletions

[PATCH xf86-input-evdev 2/3] Switch to goto logic for error handling when adding classes

2011-01-22 Thread Chase Douglas
This will be necessary for the addition of multitouch functionality. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/evdev.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 2bab6fe..2596f87 100644

[PATCH xf86-input-evdev 3/3 v3] Add support for masked valuators

2011-01-22 Thread Chase Douglas
With the X server now supporting masked valuators for XI2, enable support in X evdev. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/emuWheel.c |5 +- src/evdev.c| 187 +++ src/evdev.h|6 +- 3 files changed

Re: [PATCH (v5) xserver 7/8] Input: Add initial multitouch support from Xi 2.1

2011-01-23 Thread Chase Douglas
On 01/23/2011 03:16 PM, Cyril Brulebois wrote: Hi Daniel, Daniel Stone dan...@fooishbar.org (19/01/2011): --- a/dix/getevents.c +++ b/dix/getevents.c […] +int +GetTouchEvents(EventList *events, DeviceIntPtr pDev, TouchPointInfoPtr ti, + uint16_t type, uint32_t flags, const

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Chase Douglas
On 01/23/2011 06:38 PM, Cyril Brulebois wrote: Daniel Stone dan...@fooishbar.org (19/01/2011): From: Chase Douglas chase.doug...@canonical.com This multitouch addition only supports slotted MT evdev protocol devices. Support must be enabled at configure time using --enable-multitouch

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Chase Douglas
On 01/23/2011 06:59 PM, Cyril Brulebois wrote: Cyril Brulebois k...@debian.org (24/01/2011): Need to check the xi minor version in the server as well: | evdev.c: In function ‘EvdevPostQueuedEvents’: | evdev.c:862: warning: implicit declaration of function ‘xf86PostTouchEvent’ | evdev.c:862:

Re: [PATCH (v5) evdev 2/4] Add experimental XI 2.1 multitouch support

2011-01-23 Thread Chase Douglas
On 01/23/2011 07:09 PM, Cyril Brulebois wrote: Daniel Stone dan...@fooishbar.org (19/01/2011): +#ifdef MULTITOUCH +free(pEvdev-mtMask); +pEvdev-mtMask = NULL; +for (i = 0; i EVDEV_MAXQUEUE; i++) +free(pEvdev-queue[i].touchMask); +pEvdev-queue[i].touchMask =

Re: [PATCH xf86-input-evdev 3/3 v3] Add support for masked valuators

2011-01-23 Thread Chase Douglas
On 01/23/2011 07:24 PM, Peter Hutterer wrote: On Sat, Jan 22, 2011 at 04:40:50PM -0500, Chase Douglas wrote: With the X server now supporting masked valuators for XI2, enable support in X evdev. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- please, please always state what

Re: [PATCH xf86-input-evdev 1/3] Remove support for X input ABI 13

2011-01-23 Thread Chase Douglas
On 01/23/2011 10:42 PM, Peter Hutterer wrote: On Sat, Jan 22, 2011 at 04:40:48PM -0500, Chase Douglas wrote: Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/draglock.c |5 - src/emuMB.c|4 - src/emuWheel.c |4 - src/evdev.c| 446

[PATCH xf86-input-evdev 3/3 v4] Add support for masked valuators

2011-01-24 Thread Chase Douglas
With the X server now supporting masked valuators for XI2, enable support in X evdev. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Changes from v3: - Fix a dumb copy/paste error preventing relative mode devices from working (See EvdevProcessValuators where one line change

[PATCH xserver xi2.1] Only check non-finished touches when finding indirect touch sprites

2011-01-24 Thread Chase Douglas
Should be squashed into big xi2.1 patch. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Xi/exevents.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Xi/exevents.c b/Xi/exevents.c index fbe5912..96689e4 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c

Re: PendingBegin flag on XI_TouchMotionUnowned events?

2011-01-25 Thread Chase Douglas
On 01/25/2011 04:58 AM, Daniel Stone wrote: On Tue, Jan 25, 2011 at 11:35:37AM +1000, Peter Hutterer wrote: On Mon, Jan 24, 2011 at 12:25:25PM -0500, Chase Douglas wrote: We currently have a mechanism for clients selecting for unowned events to receive motion and finish events (through

Re: [PATCH] Xi: constify XIChangeDeviceProperty()

2011-02-02 Thread Chase Douglas
On 01/30/2011 10:54 PM, Peter Hutterer wrote: We don't modify value, make it official. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Chase Douglas chase.doug...@canonical.com --- Xi/xiproperty.c|2 +- include/exevents.h |2 +- 2 files changed, 2

Re: PendingBegin flag on XI_TouchMotionUnowned events?

2011-02-02 Thread Chase Douglas
On 01/25/2011 12:11 PM, Chase Douglas wrote: On 01/25/2011 04:58 AM, Daniel Stone wrote: On Tue, Jan 25, 2011 at 11:35:37AM +1000, Peter Hutterer wrote: On Mon, Jan 24, 2011 at 12:25:25PM -0500, Chase Douglas wrote: We currently have a mechanism for clients selecting for unowned events

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-10 Thread Chase Douglas
On 02/08/2011 05:53 AM, Daniel Stone wrote: Hi, Attached is the diff between the last multitouch spec posted to the list, and what I've just pushed to my p.fd.o repository. This takes in a lot of stuff I discussed with Peter during LCA, including: Pointer emulation: We'd hoped it'd be

[PATCH xi2.1 xserver] Reallocate touches outside of signal context

2011-02-10 Thread Chase Douglas
the array of touches. It also memsets the new touches. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Xi/exevents.c | 34 ++ dix/devices.c |9 ++--- dix/inpututils.c | 17 + include/inputstr.h |1 + 4 files

[PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-02-22 Thread Chase Douglas
Also includes resolutions for dependent devices and implicit grabs and how to handle slave touch device attachment and touch selections. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Diff is against latest patch sent by Daniel Stone. See http://cgit.freedesktop.org/~cndougla

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-01 Thread Chase Douglas
On 02/22/2011 10:06 AM, Chase Douglas wrote: Also includes resolutions for dependent devices and implicit grabs and how to handle slave touch device attachment and touch selections. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Diff is against latest patch sent by Daniel

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-03-02 Thread Chase Douglas
On 03/02/2011 06:29 AM, Daniel Stone wrote: Hi, On Wed, Mar 02, 2011 at 04:34:30PM +1000, Peter Hutterer wrote: On Tue, Feb 08, 2011 at 10:53:19AM +, Daniel Stone wrote: --- a/XI2.h +++ b/XI2.h @@ -67,6 +67,7 @@ #define XIGrabtypeEnter 2 #define

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-02 Thread Chase Douglas
On 03/02/2011 02:29 AM, Peter Hutterer wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: Also includes resolutions for dependent devices and implicit grabs and how to handle slave touch device attachment and touch selections. Signed-off-by: Chase Douglas chase.doug

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-02 Thread Chase Douglas
On 03/02/2011 05:58 AM, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: --- a/XI2.h +++ b/XI2.h @@ -32,6 +32,7 @@ #define Dont_Check 0 #endif #define XInput_2_0 7 +#define XInput_2_1

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-02 Thread Chase Douglas
On 03/02/2011 06:34 AM, Daniel Stone wrote: Hi, On Wed, Mar 02, 2011 at 10:58:08AM +, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: +In order to prevent touch events delivered to one window while pointer events +are implicitly grabbed by another

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-07 Thread Chase Douglas
On 03/07/2011 01:28 AM, Peter Hutterer wrote: On Wed, Mar 02, 2011 at 09:25:40AM -0500, Chase Douglas wrote: On 03/02/2011 02:29 AM, Peter Hutterer wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: Touch grabs are similar to standard input event grabs in that they take

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-08 Thread Chase Douglas
On 03/08/2011 12:41 AM, Peter Hutterer wrote: On Wed, Mar 02, 2011 at 11:35:41AM -0500, Chase Douglas wrote: On 03/02/2011 05:58 AM, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: @@ -132,16 +133,16 @@ /* Device event flags (common) */ /* Device event

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-10 Thread Chase Douglas
I'll be sending an update to the protocol soon. I've picked out just a few comments here to reply to. The rest should be covered by the updated protocol. On 03/08/2011 11:59 PM, Peter Hutterer wrote: On Tue, Mar 08, 2011 at 10:24:42AM -0500, Chase Douglas wrote: On 03/08/2011 12:41 AM, Peter

[PATCH xi2.1 inputproto] Many more updates to the XI 2.1 protocol

2011-03-10 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- To see the full protocol spec as I make changes, go to: http://cgit.freedesktop.org/~cndougla/inputproto I have taken all the feedback thus far and generated a new patch against the inputproto. There are a lot of changes, and some

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-11 Thread Chase Douglas
On 03/11/2011 12:15 AM, Peter Hutterer wrote: On Thu, Mar 10, 2011 at 03:39:18PM -0500, Chase Douglas wrote: On 03/08/2011 11:59 PM, Peter Hutterer wrote: On Tue, Mar 08, 2011 at 10:24:42AM -0500, Chase Douglas wrote: On 03/08/2011 12:41 AM, Peter Hutterer wrote: On Wed, Mar 02, 2011 at 11:35

Re: [PATCH inputproto] Add minimal asciidoc syntax

2011-03-15 Thread Chase Douglas
them up as we go. Reviewed-by: Chase Douglas chase.doug...@canonical.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xi2.1 inputproto] Many more updates to the XI 2.1 protocol

2011-03-22 Thread Chase Douglas
On 03/18/2011 02:23 AM, Peter Hutterer wrote: On Thu, Mar 10, 2011 at 03:47:41PM -0500, Chase Douglas wrote: Signed-off-by: Chase Douglas chase.doug...@canonical.com --- To see the full protocol spec as I make changes, go to: http://cgit.freedesktop.org/~cndougla/inputproto

[PATCH 1/2] Clean up getValuatorEvents with token concatenation

2011-03-28 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/eventconvert.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/dix/eventconvert.c b/dix/eventconvert.c index 7834d68..9fce447 100644 --- a/dix/eventconvert.c +++ b/dix/eventconvert.c

[PATCH 2/2] Handle non continuous valuator data in getValuatorEvents

2011-03-28 Thread Chase Douglas
-by: Chase Douglas chase.doug...@canonical.com --- dix/eventconvert.c | 24 +--- 1 files changed, 13 insertions(+), 11 deletions(-) diff --git a/dix/eventconvert.c b/dix/eventconvert.c index 9fce447..edecf6c 100644 --- a/dix/eventconvert.c +++ b/dix/eventconvert.c @@ -358,27 +358,30

Re: [PATCH 2/2] Handle non continuous valuator data in getValuatorEvents

2011-03-28 Thread Chase Douglas
On 03/28/2011 03:02 PM, Jamey Sharp wrote: Hi Chase! I thoroughly sympathize with removing code duplication, especially once it's gotten complicated like this, but please, no macro magic... After trying a bunch of alternatives with GCC 4.4.5 on x86-64 to see whether it would generate sane

[PATCH 1/2 v2] Clean up getValuatorEvents using array loop logic

2011-03-28 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/eventconvert.c | 20 ++-- 1 files changed, 6 insertions(+), 14 deletions(-) diff --git a/dix/eventconvert.c b/dix/eventconvert.c index 7834d68..9192080 100644 --- a/dix/eventconvert.c +++ b/dix/eventconvert.c

[PATCH 2/2 v2] Handle non continuous valuator data in getValuatorEvents

2011-03-28 Thread Chase Douglas
-by: Chase Douglas chase.doug...@canonical.com --- dix/eventconvert.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/dix/eventconvert.c b/dix/eventconvert.c index 9192080..3285133 100644 --- a/dix/eventconvert.c +++ b/dix/eventconvert.c @@ -364,19 +364,18

Re: multitouch and synaptics clickpad status

2011-03-30 Thread Chase Douglas
(Sorry for the line wrap or any ill formatted text. Thunderbird is buggy and won't show me messages when I have soo many unread :). I'm having to use Mail on OS X.) On Mar 4, 2011, at 1:54 PM, Daniel Kurtz wrote: Back in October Chase Douglas [1] kicked off a flurry of patches

[PATCH] Don't report old relative values in getValuatorEvents

2011-03-31 Thread Chase Douglas
Relative valuator values should not be reported in any future events. If a relative valuator value is not set in an internal event, set the value to 0 for XI 1.x valuator events sent over the wire. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/eventconvert.c |4 +++- 1

Re: [PATCH 2/2 v2] Handle non continuous valuator data in getValuatorEvents

2011-03-31 Thread Chase Douglas
On 03/30/2011 08:45 PM, Simon Thum wrote: On 03/29/2011 03:39 AM, Peter Hutterer wrote: On Mon, Mar 28, 2011 at 04:04:48PM -0400, Chase Douglas wrote: This allows for masked valuators to be handled properly in XI 1.x events. Any unset valuators in the device event are set to the last known

[PATCH xf86-input-synaptics resend] Revert Default to 2-finger emulation when HW supports it

2011-04-01 Thread Chase Douglas
, spurious right clicks and scroll events are triggered. Fixes: http://bugs.launchpad.net/bugs/742213 This reverts commit ffa6dc2809734a6aaa690e9133d6761480603a68. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Forgot to Cc xorg-devel on the first patch sending. src/synaptics.c

[PATCH 1/2 xf86-input-evdev] Ensure events are posted when entering into proximity

2011-04-04 Thread Chase Douglas
Fixes LP: #736829 (https://bugs.launchpad.net/bugs/573006) Re-fixes old X.Org Bug 29645 http://bugs.freedesktop.org/show_bug.cgi?id=29645 Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/evdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/evdev.c

[PATCH 2/2 xf86-input-evdev] Ensure all known valuator values are stored when out of proximity

2011-04-04 Thread Chase Douglas
The current code overwrites *all* the stored axis values with whatever came in from evdev. Evdev is a stateful protocol, so it only sends us updates to the axis values that have changed. We need to only update the values that have changed. Signed-off-by: Chase Douglas chase.doug...@canonical.com

[PULL 1.10] Masked valuator fixes for XI 1.x valuator events

2011-04-05 Thread Chase Douglas
The following changes since commit 49afcc76a1c799e18931cc762431975c5c059437: XQuartz: Bump bundle version to 2.6.2 (2011-04-04 09:38:35 -0700) are available in the git repository at: git://anongit.freedesktop.org/~cndougla/xserver server-1.10-masked-valuator-fixes Chase Douglas (3

Re: [PATCH] Don't report old relative values in getValuatorEvents

2011-04-06 Thread Chase Douglas
think you are right... If the internal event is converted to XI 1.x after the device is removed, this could cause a NULL pointer dereference. I'll send another patch to fix this up. Thanks, -- Chase On Mar 31, 2011, at 08:29, Chase Douglas wrote: Relative valuator values should not be reported

[PATCH] Fix unset valuator handling for XI 1.x valuator events again

2011-04-06 Thread Chase Douglas
Set the valuator values for unset masked absolute valuators in the internal device event. This ensures the values will always be correct in getValuatorEvents even if the device has been removed. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/eventconvert.c | 14

Re: [PATCH] Fix unset valuator handling for XI 1.x valuator events again

2011-04-06 Thread Chase Douglas
masked in the events. Core events still don't have valuators. So I'm hoping this will kill the bug dead once and for all :). Thanks, -- Chase On Apr 6, 2011, at 11:51, Chase Douglas wrote: Set the valuator values for unset masked absolute valuators in the internal device event. This ensures

Re: [RFC PATCH inputproto 0/3] Push 2.1 work into a branch

2011-04-08 Thread Chase Douglas
that branch. Any comments or suggestions? Similar branches will have to be added to libXi and xserver. This all sounds good to me :). As for the patches: Reviewed-by: Chase Douglas chase.doug...@canonical.com Thanks! ___ xorg-devel@lists.x.org

[PULL 1.10 v2] Masked valuator fixes for XI 1.x valuator events

2011-04-08 Thread Chase Douglas
The following changes since commit 1f51fe4f748b2997e466863d8387bd6791b32931: Xi: fix querydevice request swapping (2011-04-07 08:36:59 +1000) are available in the git repository at: git://people.freedesktop.org/~cndougla/xserver.git server-1.10-masked-valuator-fixes Chase Douglas (4

Regression due to 81fbb96c54f78a7cd96433294ee003c7ef6a772a on 1.10.0.902

2011-04-14 Thread Chase Douglas
Hi Jeremy, A regression has been found in 1.10.0.902 due to commit 81fbb96c54f78a7cd96433294ee003c7ef6a772a. Please see this bug for more details: https://bugs.freedesktop.org/show_bug.cgi?id=36146. This is causing issues with easystroke. Thanks, -- Chase

[PATCH xf86-input-evdev] Copy out of proximity values into current values selectively

2011-04-15 Thread Chase Douglas
Otherwise, an event that causes us to go into proximity with some new valuator values will retain some old valuator values from when last in proximity. This change ensures that all values posted while out of proximity are accounted for. Signed-off-by: Chase Douglas chase.doug...@canonical.com

[PATCH xf86-input-synaptics] Drain XRecord connection of any events after handling replies

2011-04-15 Thread Chase Douglas
or Xlib, but it does paper over the issue for now. https://bugs.launchpad.net/bugs/754470 http://bugs.freedesktop.org/show_bug.cgi?id=31921 Signed-off-by: Chase Douglas chase.doug...@canonical.com --- I'm offering this up as a work around for whatever real bug exists. It probably should

Re: [PATCH xf86-input-synaptics] Drain XRecord connection of any events after handling replies

2011-04-19 Thread Chase Douglas
On 04/18/2011 12:01 AM, Peter Hutterer wrote: On Fri, Apr 15, 2011 at 03:29:57PM -0400, Chase Douglas wrote: If the X server sends an event to the XRecord connection the event will never be handled. This will cause the event queue to fill up in Xlib and lead to syndaemon running away at 100

Re: [PATCH] dix: only transform valuators when we need them.

2011-04-25 Thread Chase Douglas
On 04/21/2011 03:35 AM, Peter Hutterer wrote: Unconditionally drop the valuators back into the mask when they were there in the first place. Otherwise, sending identical coordinates from the driver on a translated device causes the valuator mask to be alternatively overwritten with the

Re: [PULL] Accumulated small input changes

2011-04-29 Thread Chase Douglas
any R-b tag. I've checked it out here: http://cgit.freedesktop.org/~daniels/xserver/commit/?h=for-keithid=628c5854e15dbc4c57a01286a721e9fa8cf809e9 You can add: Reviewed-by: Chase Douglas chase.doug...@canonical.com Thanks, -- Chase ___ xorg-devel

Re: [PATCH] dix: only transform valuators when we need them.

2011-05-04 Thread Chase Douglas
On 05/03/2011 03:28 AM, Peter Hutterer wrote: On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: On 04/21/2011 03:35 AM, Peter Hutterer wrote: Unconditionally drop the valuators back into the mask when they were there in the first place. Otherwise, sending identical coordinates

Re: evdev: support for touchscreens not providing BTN_TOUCH

2011-05-20 Thread Chase Douglas
On 05/20/2011 09:08 AM, Peter Korsgaard wrote: Hi, I've recently tested a lumio crystaltouch touchscreen on Linux, and xf86-input-evdev unfortunately gets confused and handles it as a mouse. It provides the following events: Input driver version is 1.0.1 Input device ID: bus 0x3 vendor

Re: evdev: support for touchscreens not providing BTN_TOUCH

2011-05-23 Thread Chase Douglas
On 05/22/2011 04:48 PM, Peter Korsgaard wrote: Chase == Chase Douglas chase.doug...@canonical.com writes: Chase This is classic works on android! multitouch support. It's the Chase reason I wrote documentation for the evdev protocol in the Linux Chase kernel. The kernel driver needs

[PATCH xserver] Convert server to masked input valuators

2010-10-05 Thread Chase Douglas
-off-by: Chase Douglas chase.doug...@canonical.com --- Xext/xtest.c | 10 +- dix/getevents.c| 237 +-- dix/inpututils.c | 33 ++ hw/dmx/input/dmxevents.c | 52 + hw/kdrive/src/kinput.c

[PATCH xf86-input-evdev] Add support for masked valuators

2010-10-05 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com With the X server now supporting masked valuators for XI2, enable support in X evdev. Note that this leaves around a lot of cruft that should be removed, but the code allows for backwards compatibility with X servers 1.10. Signed-off-by: Chase

Re: [PATCH xserver] Convert server to masked input valuators

2010-10-05 Thread Chase Douglas
On Tue, 2010-10-05 at 15:59 -0700, Jesse Adkins wrote: +if (type == MotionNotify +CountBits(mask-mask, mask-len) = 0) Should be == 0. CountBits doesn't return negative values. I like to be safe, so I always encode = 0 when I want to check for positive values. What if CountBits is

[PATCH 1/3] Input: synaptics - add multitouch support

2010-10-08 Thread Chase Douglas
input module works around this issue we can enable it by default. Credit goes to Tobyn Bertram for reverse engineering the protocol. Reported-by: Tobyn Bertram Signed-off-by: Chase Douglas chase.doug...@canonical.com --- drivers/input/mouse/synaptics.c | 78

[PATCH 2/3] Input: synaptics - add multitouch multifinger support

2010-10-08 Thread Chase Douglas
-off-by: Chase Douglas chase.doug...@canonical.com --- drivers/input/mouse/synaptics.c | 24 +--- drivers/input/mouse/synaptics.h |1 + 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index

[PATCH 3/3] Input: synaptics - remove touches over button click area

2010-10-08 Thread Chase Douglas
. Tested on a Dell Mini 1012 with synaptics_multitouch=1 and synaptics_button_thresh=4100. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- drivers/input/mouse/synaptics.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/drivers/input/mouse

Re: [PATCH 0/3] Input: synaptics - multitouch and multifinger support

2010-10-08 Thread Chase Douglas
On Fri, 2010-10-08 at 18:37 +0200, Takashi Iwai wrote: At Fri, 8 Oct 2010 10:57:57 -0400, Chase Douglas wrote: Tobyn Bertram reverse engineered the multitouch protocol for Synaptics devices. I've been able to take his work and produce a series of commits to enable MT and multifinger

Re: [PATCH xserver] Convert server to masked input valuators

2010-10-14 Thread Chase Douglas
On Thu, 2010-10-14 at 13:31 +1000, Peter Hutterer wrote: On Tue, Oct 05, 2010 at 04:07:56PM -0400, Chase Douglas wrote: XI2 allows for input event valuators to be masked. The current input module API only allows for ranges to be specified. This fixes all internal plumbing to use masks

Re: [PATCH] dix: update comments for GetPointerEvents and friends

2010-10-15 Thread Chase Douglas
. Remove comment about SwitchCoreKeyboard() for the same reason. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me, and I think it would have helped me a little a few months ago :). Reviewed-by: Chase Douglas chase.doug...@canonical.com

Re: [PATCH] fix a sign problem with valuator data.

2010-10-15 Thread Chase Douglas
cause issues except for values 2^31. I don't think that ever happens :). Reviewed-by: Chase Douglas chase.doug...@canonical.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH evdev] Rename CountBits to EvdevCountBits.

2010-10-20 Thread Chase Douglas
On Wed, 2010-10-20 at 10:45 +1000, Peter Hutterer wrote: Avoid name collision with the server. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Chase Douglas chase.doug...@canonical.com ___ xorg-devel@lists.x.org: X.Org

[PATCH] test: input - set valuators mask for event to core conversion

2010-10-21 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Commit de8be07cc0a8163b6ef04455706fd5ca2cebe587 adds a requirement to event to core conversion that at least one of the X or Y valuators are set in the valuator mask. This commit fixes the event conversion test to be compliant. Signed-off-by: Chase

Re: [PATCH] Add support for per-axis valuator modes (Relative/Absolute)

2010-10-21 Thread Chase Douglas
On Fri, 2010-10-22 at 13:05 +1000, Peter Hutterer wrote: From: Chase Douglas chase.doug...@canonical.com The XI2 protocol supports per-axis modes, but the server so far does not. This change adds support in the server. A complication is the fact that XI1 does not support per-axis modes

Re: [PATCH 0/9] mixed valuator mode cleanup patches

2010-10-22 Thread Chase Douglas
. Reviewed-by: Chase Douglas chase.doug...@canonical.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] test: input - set valuators mask for event to core conversion

2010-10-22 Thread Chase Douglas
On Fri, 2010-10-22 at 13:31 +0200, Julien Cristau wrote: On Thu, Oct 21, 2010 at 22:41:09 -0400, Chase Douglas wrote: From: Chase Douglas chase.doug...@ubuntu.com Commit de8be07cc0a8163b6ef04455706fd5ca2cebe587 adds a requirement to event to core conversion that at least one of the X

[RFC XI 2.1 - xserver 1/9] Fix GPE Y axis scaling

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index 9b5e6df..d2f1025 100644 --- a/dix/getevents.c +++ b/dix

[RFC XI 2.1 - xserver 3/9] Export all valuator_mask_* functions

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Input drivers may use valuator masks for internal state. Having all the valuator_mask_* functions available will help. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- include/input.h |8 +++- include/inpututils.h |8

[RFC XI 2.1 - xserver 4/9] Input: Pass sprite instead of device to FixUpEventFromWindow

2010-11-12 Thread Chase Douglas
From: Daniel Stone dan...@fooishbar.org Since FixUpEventFromWindow only uses the sprite trace to determine the window stack, pass in a sprite instead of hardcoding the device sprite, so we can deliver to windows other than the one currently containing the sprite. Signed-off-by: Daniel Stone

[RFC XI 2.1 - xserver 5/9] Input: Pass sprite instead of device to XYToWindow

2010-11-12 Thread Chase Douglas
From: Daniel Stone dan...@fooishbar.org XYToWindow calculates the position of the cursor and updates the sprite trace, but does nothing else with the device. Pass a SpritePtr instead so we can update an alternate focus instead of hardcoding the device's sprite. Signed-off-by: Daniel Stone

[RFC XI 2.1 - xserver 6/9] Make EventIsDeliverable non-static

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com --- dix/events.c| 13 + include/input.h | 13 + 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/dix/events.c b/dix/events.c index 0f98914..9c56bb5 100644 --- a/dix/events.c +++ b/dix/events.c

[RFC XI 2.1 - xserver 7/9] Reorder AxisInfo elements

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Reorder elements so they can be uniform with the upcoming TouchAxisInfo elements required for coordinate scaling. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- include/inputstr.h |4 ++-- 1 files changed, 2 insertions(+), 2

[RFC XI 2.1 - xserver 8/9] Input: Add initial multitouch support from Xi 2.1

2010-11-12 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Xi/exevents.c | 107 Xi/extinit.c |3 + Xi/xiquerydevice.c | 95 Xi/xiquerydevice.h |3 + Xi

[RFC XI 2.1 - xserver 9/9] test: input - set all touch events at once

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Clients can't select for the three touch events individually, so ensure the test doesn't try to do so. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- test/xi2/protocol-xiselectevents.c | 48 1

[RFC XI 2.1 - xf86-input-evdev 1/3] Add support for masked valuators

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com With the X server now supporting masked valuators for XI2, enable support in X evdev. Note that this leaves around a lot of cruft that should be removed, but the code allows for backwards compatibility with X servers 1.10. Signed-off-by: Chase

[RFC XI 2.1 - xf86-input-evdev 2/3] Add experimental XI 2.1 multitouch support

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com This multitouch addition only supports slotted MT evdev protocol devices. Support must be enabled at configure time using --enable-multitouch. It is built on the masked valuator support in XInput ABI 12, so do not attempt to build it for an earlier ABI

[RFC XI 2.1 - xf86-input-evdev 3/3] Use MTDev for multitouch devices

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com MTDev translates all multitouch devices to the slotted evdev protocol. This provides a clean and uniform interface and reduces message handling inside the input module and X. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- configure.ac

[RFC XI 2.1 - libXi] Add multitouch support from Xi 2.1

2010-11-12 Thread Chase Douglas
Add support to libXi for all the Xi 2.1 additions to the spec: TouchClass, TouchBegin, TouchEnd and TouchMotion, as well as touch grabs. Based on an initial patch by Daniel Stone. Signed-off-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Chase Douglas chase.doug...@canonical.com

[RFC XI 2.1 - xinput 1/3] Print XI2 device event child window in hex too

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com This fixes an obvious error in the current print formatting. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/test_xi2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/test_xi2.c b/src/test_xi2.c index

[RFC XI 2.1 - xinput 2/3] Zero out entire mask when selecting for raw events

2010-11-12 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/test_xi2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/test_xi2.c b/src/test_xi2.c index fea36a8..30bb0fa 100644 --- a/src/test_xi2.c +++ b/src/test_xi2

[RFC XI 2.1 - xinput 3/3] Add experimental multitouch support from XI 2.1

2010-11-12 Thread Chase Douglas
From: Daniel Stone dan...@fooishbar.org This patch adds experimental support for listening to touch streams (TouchBegin, TouchMotion and TouchEnd) with test-xi2, as well as showing TouchClass information with list. Signed-off-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Chase Douglas

[xserver PATCH 0/3] Masked valuators fixes

2010-11-15 Thread Chase Douglas
These three patches fix two bugs with masked valuators and export the masked valuator helper functions. I have patched evdev to use masked valuators and found the helper functions to be helpful there as well. That said, I'm not sure how things should be structured now that inpututils.h contains

[xserver PATCH 1/3] Fix GPE Y axis scaling

2010-11-15 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index 9b5e6df..d2f1025 100644 --- a/dix/getevents.c +++ b/dix

[xserver PATCH 2/3] Fix transformAbsolute

2010-11-15 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com transformAbsolute must use old values if valuator mask doesn't have new ones, and it must only set new values if there was a change. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- dix/getevents.c | 12 1 files changed, 8

[xserver PATCH 3/3] Export all valuator_mask_* functions

2010-11-15 Thread Chase Douglas
From: Chase Douglas chase.doug...@ubuntu.com Input drivers may use valuator masks for internal state. Having all the valuator_mask_* functions available will help. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- include/input.h |8 +++- include/inpututils.h |8

Re: [RFC XI 2.1 - inputproto] Add touch classes and events, bump to 2.1

2010-11-15 Thread Chase Douglas
On 11/12/2010 08:57 PM, Cyril Brulebois wrote: Hi, Chase Douglas chase.doug...@canonical.com (12/11/2010): Introduce multitouch support through a new TouchClass, as well as new TouchBegin, TouchEnd and TouchMotion events. Bump to version 2.1. Signed-off-by: Daniel Stone dan

Re: [RFC XI 2.1 - xserver 6/9] Make EventIsDeliverable non-static

2010-11-15 Thread Chase Douglas
On 11/12/2010 10:13 PM, Cyril Brulebois wrote: Cyril Brulebois k...@debian.org (13/11/2010): +extern WindowPtr XYToWindow(SpritePtr pSprite, int x, int y); ^^ ^^ Collateral damage? Apparently, that was intended, since it's used in a later commit (“Input: Add

Re: [RFC XI 2.1 - xserver 8/9] Input: Add initial multitouch support from Xi 2.1

2010-11-15 Thread Chase Douglas
On 11/12/2010 09:23 PM, Cyril Brulebois wrote: Chase Douglas chase.doug...@canonical.com (12/11/2010): --- a/include/inputstr.h +++ b/include/inputstr.h @@ -49,6 +49,8 @@ SOFTWARE. #ifndef INPUTSTRUCT_H #define INPUTSTRUCT_H +#include X11/extensions/XI2proto.h + This one makes

Re: [RFC XI 2.1 - xserver 5/9 (master)] Input: Pass sprite instead of device to XYToWindow

2010-11-15 Thread Chase Douglas
On 11/12/2010 09:33 PM, Cyril Brulebois wrote: From: Daniel Stone dan...@fooishbar.org XYToWindow calculates the position of the cursor and updates the sprite trace, but does nothing else with the device. Pass a SpritePtr instead so we can update an alternate focus instead of hardcoding the

Re: [RFC XI 2.1 - inputproto] Add touch classes and events, bump to 2.1

2010-11-15 Thread Chase Douglas
On 11/15/2010 01:35 PM, Chase Douglas wrote: On 11/12/2010 08:57 PM, Cyril Brulebois wrote: Hi, Chase Douglas chase.doug...@canonical.com (12/11/2010): Introduce multitouch support through a new TouchClass, as well as new TouchBegin, TouchEnd and TouchMotion events. Bump to version 2.1

Re: [RFC XI 2.1 - xinput 2/3] Zero out entire mask when selecting for raw events

2010-11-17 Thread Chase Douglas
On 11/17/2010 12:24 AM, Peter Hutterer wrote: On Fri, Nov 12, 2010 at 05:35:16PM -0500, Chase Douglas wrote: From: Chase Douglas chase.doug...@ubuntu.com Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/test_xi2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[RFC XI 2.1 - xinput 2/3 v2] Zero out entire mask when selecting for different events

2010-11-17 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- src/test_xi2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test_xi2.c b/src/test_xi2.c index fea36a8..5b56397 100644 --- a/src/test_xi2.c +++ b/src/test_xi2.c @@ -324,7 +324,7 @@ test_xi2(Display

Re: [RFC XI 2.1 - xserver 7/9] Reorder AxisInfo elements

2010-11-17 Thread Chase Douglas
On 11/17/2010 01:11 AM, Peter Hutterer wrote: On Fri, Nov 12, 2010 at 05:35:08PM -0500, Chase Douglas wrote: From: Chase Douglas chase.doug...@ubuntu.com Reorder elements so they can be uniform with the upcoming TouchAxisInfo elements required for coordinate scaling. Signed-off-by: Chase

Re: [RFC XI 2.1 - inputproto] Add touch classes and events, bump to 2.1

2010-11-17 Thread Chase Douglas
On 11/17/2010 01:25 AM, Peter Hutterer wrote: On Fri, Nov 12, 2010 at 05:35:01PM -0500, Chase Douglas wrote: diff --git a/XI2.h b/XI2.h index 6ba1377..f3ee7f0 100644 --- a/XI2.h +++ b/XI2.h @@ -32,10 +32,12 @@ #define Dont_Check 0 #endif #define XInput_2_0

[RFC XI 2.1 - inputproto] Add touch classes and events, bump to 2.1

2010-11-17 Thread Chase Douglas
-by: Chase Douglas chase.doug...@canonical.com --- XI2.h| 19 +- XI2proto.h | 25 XI2proto.txt | 191 +- configure.ac |2 +- 4 files changed, 231 insertions(+), 6 deletions(-) diff --git a/XI2.h b/XI2.h index

  1   2   3   4   5   6   7   8   9   10   >