Re: [PATCH 0/8] More warning fixes and build cleanups

2011-01-23 Thread Matt Turner
On Mon, Jan 24, 2011 at 4:18 AM, Adam Jackson a...@redhat.com wrote: What it says on the box. - ajax For the series: Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH 05/32] [libx11] Pointer pBuf returned from fgets(buf, 256, stream) is never used

2011-01-27 Thread Matt Turner
2011/1/27 Erkki Seppälä erkki.sepp...@vincit.fi: Removed unused assignment Reviewed-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi ---  src/xcms/cmsColNm.c |    2 +-  1 files changed, 1 insertions(+), 1

Re: [PATCH 01/32] [libx11] Using freed pointer e

2011-02-12 Thread Matt Turner
On Sat, Feb 12, 2011 at 11:00 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= erkki.sepp...@vincit.fi Date: Thu, 27 Jan 2011 09:53:44 +0200 Reordered code to first to do the comparison and then to release data Your static analysis tool isn't all

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2011-02-28 Thread Matt Turner
On Sat, Dec 11, 2010 at 10:24 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Sat, 11 Dec 2010 22:52:25 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl From: Alan Hourihane al...@fairlite.co.uk Date: Thu, 09 Dec 2010 13:00:54 + On Thu, 2010-12-09 at 13:41 +0100, Mark

Re: [PATCH glint v2] Make pm2's xv driver collect options like all other drivers.

2011-02-28 Thread Matt Turner
On Sat, Dec 11, 2010 at 4:38 AM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports had to be named 'Input' for input options, and 'Output' for output options. This

Re: [PATCH:libXt 1/2] Incorrect cast in XtCvtIntToPixmap could cause bus error on 64-bit machines

2011-03-04 Thread Matt Turner
no extra arguments,                    (String *) NULL, (Cardinal *)NULL); -    done(Pixmap, *(Pixmap*)fromVal-addr); +    done(Pixmap, *(int*)fromVal-addr);  }  #ifdef MOTIFBC -- 1.7.3.2 Makes sense to me, and will be good for alpha too. Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH:xman] Remove xmu dependency by inlining AssignMax macro

2011-03-04 Thread Matt Turner
a good idea? Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] [glint] Fix uploading YV12 data to texture buffer on BE machines

2011-03-11 Thread Matt Turner
On Mon, Feb 28, 2011 at 11:32 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: On BE machines various hardware byteswapping options are used for the framebuffer aperture.  Which option gets used depends on the depth of the framebuffer.  Uploading YV12 data to the texture buffer is done through

[PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-23 Thread Matt Turner
Fixes: http://bugs.gentoo.org/show_bug.cgi?id=360227 Problem is easily seen during compile: -DDFLT_XKB_CONFIG_ROOT='/usr/share/X11/xkb' --- src/xkbcomp/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xkbcomp/Makefile.am b/src/xkbcomp/Makefile.am

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-23 Thread Matt Turner
On Thu, Mar 24, 2011 at 3:29 AM, Matt Turner matts...@gmail.com wrote: This is for libxkbcommon, meant to modify the subject line. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 1:13 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Wed, Mar 23, 2011 at 8:29 PM, Matt Turner matts...@gmail.com wrote: Fixes: http://bugs.gentoo.org/show_bug.cgi?id=360227 Problem is easily seen during compile:        -DDFLT_XKB_CONFIG_ROOT='/usr/share/X11/xkb

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 1:20 PM, Gaetan Nadon mems...@videotron.ca wrote: This is what I get on Ubuntu before the patch:     -DDFLT_XKB_CONFIG_ROOT=\/home/nadon/xorg/src/share/X11/xkb\ Is this a platform difference? I kind of think so. With the patch I get:

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 10:14 AM, Daniel Stone dan...@fooishbar.org wrote: On Thu, Mar 24, 2011 at 09:20:39AM -0400, Gaetan Nadon wrote: On Wed, 2011-03-23 at 23:29 -0400, Matt Turner wrote: Fixes: http

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 7:19 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 10:14 AM, Daniel Stone dan...@fooishbar.org wrote: On Thu, Mar 24, 2011 at 09:20:39AM -0400, Gaetan Nadon wrote: On Wed, 2011

Re: [PATCH] dix: Small refactor to resource deletion

2011-03-24 Thread Matt Turner
On Thu, Mar 24, 2011 at 8:52 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com --- Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Sun, Mar 13, 2011 at 10:11 PM, Christian Weisgerber na...@mips.inka.de wrote: GTK+3 blows up on LP64 archs with strict alignment.  This comes down to an unaligned access error in libXi, specifically in the XIButtonClass case in copy_classes() in XExtInt.c.    cls_lib-num_buttons =

Re: Alignment error in libXi

2011-03-25 Thread Matt Turner
On Fri, Mar 25, 2011 at 6:19 AM, Jeremy Huddleston jerem...@apple.com wrote: On Mar 24, 2011, at 11:06 PM, Matt Turner wrote: Is this one of those cases where someone, long ago, thought using longs was inherently good? Can we just change labels to be an array of ints, or is that too easy

Re: [PATCH] fix overquoting of $(XKBCONFIGROOT)

2011-03-25 Thread Matt Turner
On Thu, Mar 24, 2011 at 10:44 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Thu, Mar 24, 2011 at 2:17 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:19 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 24, 2011 at 7:09 PM, Dan Nicholson dbn.li...@gmail.com wrote

Re: [PATCH] Fix __STDC_VERSION__ tests.

2011-04-20 Thread Matt Turner
On Wed, Apr 20, 2011 at 5:02 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

[PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Matt Turner
Either way, it doesn't matter much. Signed-off-by: Matt Turner matts...@gmail.com --- The follow-up patch to this which removes the temporary variables used by the swap macros is too big for the mailing list, so please review it here: http://cgit.freedesktop.org/~mattst88/xserver/commit/?id

[PATCH 3/6] Use abs() on integers, not fabs()

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/modes/xf86Crtc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index c2814d4..92c75b1 100644 --- a/hw/xfree86/modes/xf86Crtc.c +++ b/hw/xfree86

[PATCH 4/6] Remove unnecessary #undefs of [f]abs and old comments

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- glx/glxserver.h |6 -- hw/dmx/glxProxy/glxserver.h |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/glx/glxserver.h b/glx/glxserver.h index 891315b..6bcf7d3 100644 --- a/glx/glxserver.h +++ b/glx

[PATCH 5/6] Replace Fabs() macro with fabs() function

2011-04-27 Thread Matt Turner
gcc generates better code with fabs() anyway. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h |3 --- mi/miarc.c |2 +- mi/mifpoly.h|6 +++--- mi/miwideline.c |2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/include/misc.h b/include

[PATCH 6/6] Silence printf format warnings in helper_exec.c

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/int10/helper_exec.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exec.c index ec84200..8cca28a 100644 --- a/hw/xfree86

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Matt Turner
On Thu, Apr 28, 2011 at 12:44 AM, Keith Packard kei...@keithp.com wrote: On Wed, 27 Apr 2011 19:33:01 -0400, Matt Turner matts...@gmail.com wrote: The follow-up patch to this which removes the temporary variables used by the swap macros is too big for the mailing list, so please review it here

Re: [PATCH 3/6] Use abs() on integers, not fabs()

2011-04-28 Thread Matt Turner
2011/4/28 Michel Dänzer mic...@daenzer.net: On Mit, 2011-04-27 at 19:33 -0400, Matt Turner wrote: Signed-off-by: Matt Turner matts...@gmail.com ---  hw/xfree86/modes/xf86Crtc.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-28 Thread Matt Turner
On Thu, Apr 28, 2011 at 4:36 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Thu, Apr 28, 2011 at 2:33 AM, Matt Turner matts...@gmail.com wrote: diff --git a/include/misc.h b/include/misc.h index 803f5ba..b7a3fd2 100644 --- a/include/misc.h +++ b/include/misc.h @@ -240,32 +240,17

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-05-13 Thread Matt Turner
On Fri, May 13, 2011 at 4:43 PM, Keith Packard kei...@keithp.com wrote: On Fri, 29 Apr 2011 14:46:23 +0300, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: And of course, if none of the swapl/swaps/cpswapl/cpswaps are supposed to deal with unaligned pointers, then this is not an issue

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-06-03 Thread Matt Turner
On Fri, Jun 3, 2011 at 11:10 AM, Cyril Brulebois k...@debian.org wrote: Julien Cristau jcris...@debian.org (28/02/2011): On Mon, Feb 28, 2011 at 02:15:39 +, Matt Turner wrote: Since newport doesn't even compile anymore (since the RAC removal), this probably isn't helpful at all

Re: [PATCH 02/27] Input: Add round_towards_zero helper

2011-06-03 Thread Matt Turner
On Fri, Jun 3, 2011 at 10:59 AM, Daniel Stone dan...@fooishbar.org wrote: lrint() exists to round _away_ from zero, but there's no equivalent for rounding towards zero, aside from tediously calling fesetenv(), which isn't hugely portable anyway, then lround().  Great. Signed-off-by: Daniel

Re: [PATCH 2/4] x86emu: Silence compiler warnings.

2011-06-05 Thread Matt Turner
On Sun, Jun 5, 2011 at 1:58 PM, Cyril Brulebois k...@debian.org wrote: Both if/else match, so usage of ip32 or ip16 will only happen after the proper one has been initialized. As a consequence, let's silence those warnings by initializing both variables to 0: |   CC     ops.lo | ops.c: In

Re: [Xorg-driver-geode] xf86-video-geode: Changes to 'master'

2010-10-11 Thread Matt Turner
On Mon, Oct 11, 2010 at 9:38 PM, Huang, FrankR frankr.hu...@amd.com wrote: [snip] OK, let me see if I can explain: The purpose of the *_mode_valid function in each device-dependent X (xf86-video-ati, xf86-video-intel) is to allow the driver to decide whether a particular mode (mode is a

Re: [PATCH 1/3] xfree86: drop linux libc5 support from the SIGIO code

2010-10-14 Thread Matt Turner
number of input devices usable  * at the same time plus one entry for DRM support. -- 1.7.2.3 Ha. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH 1/5] config: Don't look for .o drivers anymore

2010-10-14 Thread Matt Turner
char *patlist[] = {(.*)_drv\\.so, (.*)_drv\\.o, NULL}; +    static const char *patlist[] = {(.*)_drv\\.so, NULL};     ret = LoaderListDirs(subdirs, patlist);     /* fix up the probe order for video drivers */ -- 1.7.2.3 For the series: Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH RESEND 1/4] xkb: init mapWidth and symsPerKey arrays to 0.

2010-10-15 Thread Matt Turner
On Fri, Oct 15, 2010 at 2:02 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: Twas brillig at 12:02:56 15.10.2010 UTC+10 when peter.hutte...@who-t.net did gyre and gimble:  PH -    CARD16              symsPerKey[XkbMaxLegalKeyCode + 1];  PH +    CARD8              

Re: [PATCH] xserver: Enable visible cursor on start without -retro #26798

2010-10-20 Thread Matt Turner
Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PATCH]libXt-1.0.8/src/Keyboard.c fix NULL-pointer check

2010-10-24 Thread Matt Turner
On Sun, Oct 24, 2010 at 8:42 AM, walter harms wha...@bfs.de wrote: Alan Coopersmith schrieb: While we're accommodating with one-off patches in weird formats, if you're going to be sending series, or plan on continuing to send patches, you need to start using git to create them, working of

Re: [PATCH] shadow: Optimize shadowUpdatePacked(). (#26973)

2010-10-28 Thread Matt Turner
On Tue, Sep 21, 2010 at 10:29 AM, Matt Turner matts...@gmail.com wrote: On Sat, Sep 11, 2010 at 5:55 PM, Matt Turner matts...@gmail.com wrote: From: Adam Jackson a...@redhat.com Signed-off-by: Matt Turner matts...@gmail.com --- I was bug triaging and came across 26973 and remembered seeing

Re: [PATCH] xfree86: fix two compiler warnings - unused variable ati, atimisc

2010-11-04 Thread Matt Turner
; -    char **ati, **atimisc;     int i;     /* walk to the end of the list */ -- 1.7.3.2 Reviewed-by: Matt Turner matts...@gmail.com ati and atimisc are still listed, along with lots of other dead and outdated modules, in hw/xfree86/doc/devel/Registry. Maybe cleaning hw/xfree86/doc/devel

Re: [PATCH] xfree86: fix compiler warnings - unused variable i

2010-11-04 Thread Matt Turner
-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] shadow: Optimize shadowUpdatePacked(). (#26973)

2010-11-07 Thread Matt Turner
On Sat, Sep 11, 2010 at 5:55 PM, Matt Turner matts...@gmail.com wrote: From: Adam Jackson a...@redhat.com Signed-off-by: Matt Turner matts...@gmail.com --- I was bug triaging and came across 26973 and remembered seeing it on the ml at some point recently. Here's a patch, as suggested by ajax

Re: [PATCH] try the newport driver on mips

2010-11-07 Thread Matt Turner
On Sat, Mar 6, 2010 at 1:03 PM, Matt Turner matts...@gmail.com wrote: On Sat, Mar 6, 2010 at 3:23 AM, Brice Goglin brice.gog...@gmail.com wrote: *From:* Bernhard R. Link brl...@debian.org http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=566545 Attached patch should tell the autodection code

Re: [PATCH] try the newport driver on mips

2010-11-08 Thread Matt Turner
On Mon, Nov 8, 2010 at 6:13 AM, Julien Cristau jcris...@debian.org wrote: On Mon, Nov  8, 2010 at 08:30:37 +0100, Mark Kettenis wrote: Actually, I don't think this is a good idea.  Unless I'm mistaken, the newport driver only supports one particular range of SGI graphics hardware.  There are

Re: [PATCH 1/2] Remove more superfluous if(p) checks around free(p).

2010-11-08 Thread Matt Turner
-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] Remove more superfluous if(p!=NULL) checks around free(p).

2010-11-08 Thread Matt Turner
)        nameRtrn[0]= '\0'; -    if (buf != NULL) -        free(buf); +    free(buf);     return FALSE;  } -- 1.7.2.3 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH] Remove superfluous if(p!=NULL) checks around free(p); p=NULL;

2010-11-10 Thread Matt Turner
On Wed, Nov 10, 2010 at 10:06 AM, Cyril Brulebois k...@debian.org wrote: This patch has been generated by the following Coccinelle semantic patch: @@ expression E; @@ -  if (E != NULL) { -   free(E); ( -   E = NULL; | -   E = 0; ) -  } + free(E); + E = NULL; Signed-off-by: Cyril

Re: [PATCH] Remove more superfluous if(p!=NULL) checks around free(p); p=NULL; p_foo=0;

2010-11-10 Thread Matt Turner
); +       map-acts= NULL; +       map-num_acts= map-size_acts= 0;     }     if ((whatXkbKeyBehaviorsMask)(map-behaviors!=NULL)) {        free(map-behaviors); -- 1.7.2.3 I think this should be OK. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel

Re: [PATCH] Remove more superfluous if(p!=NULL) checks around free(p).

2010-11-10 Thread Matt Turner
-base.GLXextensions = xnfalloc(buffer_size);             __glXGetExtensionString(screen-glx_enable_bits, screen-base.GLXextensions); -- 1.7.2.3 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] Make pm2's xv driver collect options like all other drivers.

2010-11-11 Thread Matt Turner
Wow. A real patch for pm2? Are you compile testing or do you have real hardware? On Thu, Nov 11, 2010 at 10:48 PM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports

Re: Fix serious X server crash (xinerama + any QT app)

2010-11-13 Thread Matt Turner
That looks like a pretty obvious typo, so Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Patches to stop libtool droppings (#4898)

2010-11-19 Thread Matt Turner
On Fri, Nov 19, 2010 at 10:01 PM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-11-19 at 14:58 -0800, Jesse Adkins wrote: Following this is a whopping 66 patches. These patches cover every driver listed under cgit.freedesktop.org/xorg/driver/ (So wacom and some other got skipped). I

Re: [PATCH 02/13] render: repack PictureRec

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 04/13] dix: Remove the backing store leftovers

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com - * Copyright (c) 1987 by the Regents of the University of California Should we be sad or happy to see this go? Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH 06/13] dix: Remove unused ChangeSaveUnder hooks

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com git grep tells me these are not used anywhere else. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 07/13] dix: reshuffle WindowOptRec to fill a hole on LP64

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com ---  include/windowstr.h |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/windowstr.h b/include/windowstr.h index 29b95fc..0b66ebb 100644 ---

Re: [PATCH 08/13] render: Reshuffle and cull dead field from GlyphSetRec

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 12/13] mi: Remove unused miAllocateGCPrivateIndex

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Appears unused in the xserver and the DDXs. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 13/13] xfree86: Remove unused xf86PixmapKeyRec

2010-11-23 Thread Matt Turner
On Tue, Nov 23, 2010 at 7:45 PM, Adam Jackson a...@redhat.com wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH 07/13] dix: reshuffle WindowOptRec to fill a hole on LP64

2010-11-23 Thread Matt Turner
On Wed, Nov 24, 2010 at 1:37 AM, Peter Harris phar...@opentext.com wrote: On 2010-11-23 20:10, Matt Turner wrote: Probably just me not spotting the obvious, but I see xserver $ git grep 'VisualID' | grep typedef hw/dmx/dmxclient.h:typedef unsigned long VisualID64; hw/xnest/Xnest.h:typedef

Re: Respository vandalism by r...@...fd.o

2010-11-24 Thread Matt Turner
On Wed, Nov 24, 2010 at 6:58 AM, Luc Verhaegen l...@skynet.be wrote: On Wed, Nov 24, 2010 at 08:27:12PM +1000, Peter Hutterer wrote: On 24/11/10 19:38 , Luc Verhaegen wrote: Conspiracy theories? I did not imply that you were the one starting with the conspiracy theories, and I think

Re: [PATCH] xf86OutputRename: Replace another strlen/malloc/strcpy set with strdup

2010-11-26 Thread Matt Turner
On Fri, Nov 26, 2010 at 8:32 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Probably missed by coccinelle patches since this only became a malloc() after a recent xalloc-malloc conversion. Reviewed-by: Matt Turner matts

Re: [PATCH 2/3] Move xchomp inside #ifdef __linux__

2010-11-29 Thread Matt Turner
On Tue, Nov 30, 2010 at 4:22 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH 08/11] Convert hw/xfree86/parser code to use Xasprintf() calls

2010-11-30 Thread Matt Turner
); +                               if (Xasprintf(s, %ul %ul, val1, val.num) == -1) +                                   s = NULL;                                break;                        case XAXIS:                                s = strdup(x); -- Reviewed-by: Matt Turner matts...@gmail.com

Re: [PATCH 04/11] FindModuleInSubdir: Stop allocating one more byte than needed

2010-11-30 Thread Matt Turner
(dirpath) + 1);             sprintf(ret, %s%s, dirpath, tmpBuf);             break;         } -- Good catch. Did you just happen to notice this, or find it in some more automated way? Reviewed-by: Matt Turner matts...@gmail.com Is there any reason we shouldn't use Xasprintf here instead

Re: [PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-11-30 Thread Matt Turner
On Tue, Nov 30, 2010 at 6:06 PM, Ferry Huberts maili...@hupie.com wrote: Signed-off-by: Ferry Huberts ferry.hube...@pelagic.nl Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] Fix detection of multi-function cards

2010-12-01 Thread Matt Turner
On Thu, Dec 2, 2010 at 2:42 AM, Bryce Harrington br...@canonical.com wrote: Bit 7 of the pci device header type is an indicator of multi-function devices, so needs to be masked when examining the bridge type. Thanks go to Chih-Pin Wu for finding the bug and its fix. Signed-off-by: Bryce

[PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-02 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- Why are we doing VBEInit if we're not subsequently calling vbeDoEDID? src/s3.h|1 - src/s3_driver.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/s3.h b/src/s3.h index 49b8a54..0875fc9 100644

[PATCH xrdb] predefined cpp macros can produce unexpected results (bug 3413)

2010-12-03 Thread Matt Turner
From: Matthieu Herrb matthieu.he...@laas.fr GNU cpp is predefining a number of symbols, depending on the host and target architecture. This can produce some unexpected results: for example, the expansion of CLIENTHOST if the host name is i386.my.domain. The attached patch creates a new -undef

[PATCH gccmakedep] Fix gccmakedep from mutilates arguments containing ' or *

2010-12-03 Thread Matt Turner
From: Peter Breitenlohner p...@mppmu.mpg.de Fixes https://bugs.freedesktop.org/show_bug.cgi?id=7414 --- gccmdep.cpp | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gccmdep.cpp b/gccmdep.cpp index ff4b12a..6c7c05f 100644 --- a/gccmdep.cpp +++ b/gccmdep.cpp @@

[PATCH iceauth] Make iceauth manpage describe commands. (fd.o bug#2354)

2010-12-03 Thread Matt Turner
From: David Nusinow dnusi...@debian.org --- iceauth.man | 84 +++ 1 files changed, 84 insertions(+), 0 deletions(-) diff --git a/iceauth.man b/iceauth.man index 72b2ab0..a3eed7e 100644 --- a/iceauth.man +++ b/iceauth.man @@ -36,5 +36,89

[PATCH trident] trident cyberblade FIFO status check (bug 3304)

2010-12-03 Thread Matt Turner
From: Laurence Darby lda...@tuffmail.com --- I verified that it compiled, but I don't have hardware to test. src/blade_accel.c | 27 ++- 1 files changed, 26 insertions(+), 1 deletions(-) diff --git a/src/blade_accel.c b/src/blade_accel.c index 31d97df..6a624b9 100644

[PATCH libX11] Fix XQueryColors() doesn't return if ncolors is 65536.

2010-12-03 Thread Matt Turner
From: Kusanagi Kouichi sl...@ma.neweb.ne.jp Fixes bugs: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=278984 https://bugs.freedesktop.org/show_bug.cgi?id=9160 --- The patch looks like it only makes the whitespace mess worse, so if this gets committed, we should fix the

[PATCH libXaw] fix potential infinte loop in XawBoxQueryGeometry() (bug 11569)

2010-12-03 Thread Matt Turner
From: Glenn Burkhardt gbburkha...@verizon.net Originally sent to xorg@ back in July 2007. http://lists.x.org/archives/xorg/2007-July/025997.html --- Please don't ignore it this time. src/Box.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Box.c b/src/Box.c

[PATCH libXfont] Fix Font lookup by fontfile is slow on certain patterns.

2010-12-03 Thread Matt Turner
From: Takano Akio al...@hyper.cx https://bugs.freedesktop.org/show_bug.cgi?id=7832 --- src/fontfile/fontdir.c | 67 +--- 1 files changed, 18 insertions(+), 49 deletions(-) diff --git a/src/fontfile/fontdir.c b/src/fontfile/fontdir.c index

[PATCH] Add component= to bugzilla link for DDXs' README

2010-12-03 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- After triaging bugs for a few days, the main thing I've learned is that people cannot figure out where to file a bug if their lives depended on it. Not that anyone actually reads the README, but does anyone have any objections to adding component

Re: [PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-03 Thread Matt Turner
On Sat, Dec 4, 2010 at 6:53 AM, Jesse Adkins jesserayadk...@gmail.com wrote: Perhaps a dumb question, but why is there a vbeFree after a vbeInit? To free memory allocated by vbeInit. If your question is why is vbeInit called if it doesn't then call vbeDoEDID()... well, that I don't know. Matt

Re: [PATCH s3] Add missing call to vbeFree (bug 4417)

2010-12-04 Thread Matt Turner
On Sat, Dec 4, 2010 at 2:18 AM, Jesse Adkins jesserayadk...@gmail.com wrote: I should have been more clear. I really was wondering why there's a vbeInit right before a vbeFree. It seems like that would end up being a rather long no-op. It looks like the vbe pointer is never used by the

Re: [PATCH] Make pm2's xv driver collect options like all other drivers.

2010-12-04 Thread Matt Turner
On Fri, Nov 12, 2010 at 3:48 AM, Jesse Adkins jesserayadk...@gmail.com wrote: The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports had to be named 'Input' for input options, and 'Output' for output options. This

Re: [PATCH 4/7] Convert hw/xfree86/parser code to use asprintf() calls

2010-12-04 Thread Matt Turner
:                                s = strdup(x); -- 1.7.3.2 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:xorg-macros] Use AC_LANG_PROGRAM in XORG_CHECK_MALLOC_ZERO to clear autoconf-2.68 warnings

2010-12-05 Thread Matt Turner
) was leaking, but now I see that it is realloc()'d to 0. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-07 Thread Matt Turner
On Tue, Dec 7, 2010 at 8:07 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: No need for byteswapping in YV12 decoding on BE machines The hardware seems to do the proper thing already, so always use the same code on both little-endian and big-endian machines.  Fixes xv YV12 on a TechSource

Re: [PULL] Warning fixes, *LookupID* riddance, logic fix.

2010-12-10 Thread Matt Turner
On Tue, Dec 7, 2010 at 6:13 PM, Cyril Brulebois k...@debian.org wrote: The following changes since commit 780754050bc9cb1489f92a2a890ab5665e3e6358:  Fix GLX_LIBS vs. DMX_LIBS order. (2010-12-07 09:24:16 -0800) are available in the git repository at:  

Re: where is KMS API docs?

2010-12-14 Thread Matt Turner
On Tue, Dec 14, 2010 at 2:59 PM, Jeremy C. Reed r...@reedmedia.net wrote: Where is the documentation for the KMS API? Any man pages? If not written, please point me to any specifications or source used for learning the API. Thanks My summer of code project's purpose was to create

Re: [PATCH xserver] configure: use backticks rather than $() for commands

2010-01-07 Thread Matt Turner
On Thu, Jan 7, 2010 at 3:06 PM, Gaetan Nadon mems...@videotron.ca wrote: This patch to xserver configure.ac is to increase code portability to non POSIX system by using backticks rather than $() for command substitution for BUILD_DATE and BUILD_TIME. Signed-off-by: Gaetan Nadon

Re: [PATCH] Revert Make sys.c use unaligned access functions provided in compiler.

2010-01-08 Thread Matt Turner
On Fri, Jan 8, 2010 at 11:44 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: On Tue, Dec 29, 2009 at 08:09:06PM +0100, ext Keith Packard wrote: On Mon, 28 Dec 2009 14:02:02 -0500, Matt Turner matts...@gmail.com wrote: The fix here isn't to add back in a bunch of duplicated Alpha assembly

[PATCH] Use generic unaligned access functions in sys.c

2010-01-14 Thread Matt Turner
Gets rid of alpha assembly. CC: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/x86emu/sys.c | 237 +++ 1 files changed, 75 insertions(+), 162 deletions(-) diff --git a/hw/xfree86/x86emu/sys.c b/hw

Re: [PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

2010-02-03 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH util-macros 2/2] Add -Wformat=2 to the default CWARNFLAGS

2010-02-03 Thread Matt Turner
___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel mailing list xorg-devel@lists.x.org http

[PATCH] Remove Linux-2.4/PPC64 checks

2010-02-15 Thread Matt Turner
We don't support the 2.4 series kernels anymore, no point in checking for them. Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/common/compiler.h | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common

[PATCH] Use C-style comments in x86emu

2010-02-15 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/x86emu/validate.c|2 +- hw/xfree86/x86emu/x86emu/prim_x86_gcc.h |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/x86emu/validate.c b/hw/xfree86/x86emu/validate.c index 239f6c1

Re: [PATCH] Use C-style comments in x86emu

2010-02-16 Thread Matt Turner
On Tue, Feb 16, 2010 at 11:09 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Mon, Feb 15, 2010 at 08:05:24PM -0500, Matt Turner wrote: Signed-off-by: Matt Turner matts...@gmail.com So while this won't break anything, are there actually any compilers that we support which choke

Re: [PATCH v2] parser: corrected xf86getBoolValue to use case insensitive compare

2010-02-16 Thread Matt Turner
It was in the main tree, committed by Oliver, but then it disappeared. This was all just a couple days ago. Matt ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

Voodoo spec sheets missing since ~ died

2010-02-23 Thread Matt Turner
Links on http://wiki.x.org/wiki/DataSheets are broken after people.freedesktop.org's ~ died. Could you throw your specs folder back up on the server, Eric? Thanks, Matt ___ xorg-devel mailing list xorg-devel@lists.x.org

Re: [PATCH] try the newport driver on mips

2010-03-06 Thread Matt Turner
    } Seems like a good idea. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PULL] Minor bug-fixes discovered by static analysis.

2010-03-06 Thread Matt Turner
pExaScr-access of size 6 at position 6 with index variable i This looks like it's got a typo in it. 'pPixmap),);' - notice the extra comma.      fb: fbFinishScreenInit: leaked_storage: Variable (visuals|depths) goes out of scope Reviewed-by: Matt Turner matts...@gmail.com      parser

Re: [RFC] Define/use pad() and pad_mask() instead of open coding it

2010-03-11 Thread Matt Turner
On Thu, Mar 11, 2010 at 8:05 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Mar 11, 2010 at 07:33:30PM -0500, Matt Turner wrote: à la the Linux Kernel's ALIGN and __ALIGN_MASK macros. Not even compile tested, some files might need to include misc.h. CC: Peter Hutterer peter.hutte

Re: [RFC] Define/use pad() and pad_mask() instead of open coding it

2010-03-11 Thread Matt Turner
On Thu, Mar 11, 2010 at 8:37 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Mar 11, 2010 at 08:19:04PM -0500, Matt Turner wrote: On Thu, Mar 11, 2010 at 8:05 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Mar 11, 2010 at 07:33:30PM -0500, Matt Turner wrote: à la

[RFC] Define/use pad() instead of open coding it

2010-03-11 Thread Matt Turner
à la the Linux Kernel's ALIGN macro. Not even compile tested, some files might need to include misc.h. CC: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Matt Turner matts...@gmail.com --- hw/dmx/dmxpict.c |2 +- hw/kdrive/ephyr/XF86dri.c |6

[PATCH] Don't bother checking for O_ASYNC, glibc's had it since '98.

2010-03-11 Thread Matt Turner
No, seriously. 1998. Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/os-support/shared/sigio.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/hw/xfree86/os-support/shared/sigio.c b/hw/xfree86/os-support/shared/sigio.c index aed5654..88f1d49

Re: [PATCH] Fix x86emu builds when using non-gnu compilers

2010-03-17 Thread Matt Turner
://lists.x.org/mailman/listinfo/xorg-devel Acked-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

  1   2   3   4   5   >