From: Tormod Volden debian.tor...@gmail.com
savage_exa.c: In function ‘SavageUploadToScreen’:
savage_exa.c:545: warning: passing argument 1 of ‘memcpy’ discards qualifiers
from pointer target type
/usr/include/bits/string3.h:49: note: expected ‘void * restrict’ but argument
is of type ‘volatile
From: Tormod Volden debian.tor...@gmail.com
sed -i 's/xalloc/malloc/g; s/xcalloc/calloc/g; s/xfree/free/g'
Also replace xrealloc with realloc.
---
src/savage_dga.c|6 ++--
src/savage_dri.c| 70 +-
src/savage_driver.c | 22
From: Tormod Volden debian.tor...@gmail.com
savage_dga.c: In function ‘Savage_OpenFramebuffer’:
savage_dga.c:393: warning: cast to pointer from integer of different size
savage_dri.c: In function ‘SAVAGEDRIScreenInit’:
savage_dri.c:924: warning: cast to pointer from integer of different size
From: Tormod Volden debian.tor...@gmail.com
Silence -Wall warnings.
The functions are just #if'ed out, to be left for inspiration.
---
src/savage_accel.c |3 ++-
src/savage_cursor.c |2 ++
src/savage_exa.c|1 -
src/savage_video.c |5 +
4 files changed, 5 insertions
From: Tormod Volden debian.tor...@gmail.com
Removes the last bunch of -Wall build warnings.
savage_dri.c:490: warning: format â%08lxâ expects type âlong unsigned
intâ,
but argument 5 has type âdrm_handle_tâ
...
---
The remaining warnings that I see are more tricky, since
From: Tormod Volden debian.tor...@gmail.com
These registers are cleared after suspend/resume, so set them
up again in EnterVT.
---
Is there any other suitable function that is called on resume,
where this can be placed?
Similar things (registers) are set up in SavageInitialize2DEngine
From: Tormod Volden debian.tor...@gmail.com
The tiled surface registers were only setup in SAVAGEDRIScreenInit,
however, after suspend/resume these registers must be set up again.
So factor it out in a new function so it can be reused.
---
The follow-up patch will call this new function
On Sun, Jan 23, 2011 at 9:18 PM, Alex Deucher wrote:
No, this is part of why UMS sucks. During suspend the card is powered
down, so on resume, the driver has to re-init everything. All that
has to happen in EnterVT. All of your savage patches look good to me:
Reviewed-by: Alex Deucher
On Sat, Feb 12, 2011 at 10:43 PM, Mark Kettenis wrote:
This isn't really the right way to fix things. At least the casts
should use uintptr_t instead of int. That way you won't truncate
addresses on true 64-bit architectures. Or just leave these warnings
there as a reminder of the
From: Tormod Volden debian.tor...@gmail.com
Bit-masking the result of a boolean negation seems pointless,
so I guess this is what was intended: Only look at bit 0 of the
inStatus result.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
Hi,
A few savage patches. Review is appreciated
From: Tormod Volden debian.tor...@gmail.com
Move DRI stuff from savage_driver.c to savage_dri.c
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
This one should not change any behavior, but prepares for the next
patch. It is very much modeled after the function structure of the
radeon
From: Tormod Volden debian.tor...@gmail.com
This should fix resume with AGP. After all these years...
https://bugzilla.kernel.org/show_bug.cgi?id=4607
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
This was always the killer bug for my laptop. Wish I were 5 years earlier...
It turned
From: Tormod Volden debian.tor...@gmail.com
Also clean out some unused prototypes from savage_driver.h
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
Cheers,
Tormod
src/savage_dri.c|2 +-
src/savage_driver.h | 14 --
2 files changed, 1 insertions(+), 15
On Wed, Apr 20, 2011 at 11:36 PM, Matt Turner wrote:
Man, somebody didn't know operator precedence. Probably good that git
history doesn't go back that far. :)
BTW, I just learned about -Wlogical-op (not part of -Wall) which
unfortunately does not catch this issue. But it found some similar
From: Tormod Volden debian.tor...@gmail.com
Found with CFLAGS=-Wlogical-op
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
I hope I don't break the magic. BTW, LCD_ACTIVE is 0x02.
src/savage_driver.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src
From: Tormod Volden debian.tor...@gmail.com
Instead maintain our own list of supported PCI IDs.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
src/savage_dri.c|1 -
src/savage_driver.c |1 +
src/savage_driver.h |1 -
src/savage_hwmc.c |1 -
src/savage_i2c.c
From: Tormod Volden debian.tor...@gmail.com
For instance, the handling of week=0xff or week=0 was not working,
as could be seen from by the data/sharp-* examples.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
edid-decode.c | 20 +---
1 files changed, 9 insertions
as a follow-up.
Cheers,
Tormod
If you change the 1.4 check (and that matches the spec), or if you remove the
1.4 check,
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Dec 17, 2011, at 15:24, Tormod Volden wrote:
From: Tormod Volden debian.tor...@gmail.com
For instance, the handling
From: Tormod Volden debian.tor...@gmail.com
So that the version conformance flags can be used in other code.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
edid-decode.c | 38 +++---
1 files changed, 19 insertions(+), 19 deletions(-)
diff --git
From: Tormod Volden debian.tor...@gmail.com
For instance, the handling of week=0xff or week=0 was not working,
as could be seen from the data/sharp-* examples.
Only EDID version 1.4 requires the year to be 2006 or later.
Actually, data/sharp-aquos-hdmi reports 1.3 but seems to use month
0xff
From: Tormod Volden debian.tor...@gmail.com
Do not check edid pointer since it was already done.
Remove commented return statement.
Also separate declaration from code, which fixes remaining
gcc -pedantic warnings.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
edid-decode.c |8
On Wed, Dec 21, 2011 at 10:23 AM, walter harms wha...@bfs.de wrote:
Am 20.12.2011 22:17, schrieb Tormod Volden:
From: Tormod Volden debian.tor...@gmail.com
So that the version conformance flags can be used in other code.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
edid
From: Tormod Volden debian.tor...@gmail.com
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
Fixes build failure here at least.
src/s3v_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/s3v_driver.c b/src/s3v_driver.c
index 2cc04ce..0440014 100644
From: Tormod Volden debian.tor...@gmail.com
sed -i 's/xalloc/malloc/g; s/xcalloc/calloc/g; s/xrealloc/realloc/g;
s/xfree(/free(/g'
Also added a missing unistd.h include for usleep().
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
src/s3v_accel.c |1 +
src/s3v_dga.c|6
From: Tormod Volden debian.tor...@gmail.com
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
src/s3v.h|3 ---
src/s3v_accel.c |1 +
src/s3v_dga.c|1 -
src/s3v_driver.c |5 +++--
src/s3v_hwcurs.c |1 +
src/s3v_i2c.c|1 -
src/s3v_pciids.h | 18
From: Johannes Obermayr johannesoberm...@gmx.de
[Tormod: Remove unnecessary else and fix spelling in messages]
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
How about this then? For consistency do the same to other functions.
Fixed up some glaring spelling mistakes while I
On Fri, Jan 13, 2012 at 10:44 PM, Jeremy Huddleston jerem...@apple.com wrote:
Reviewed-by: Jeremy Huddleston jerem...@apple.com
On Jan 13, 2012, at 13:18, Tormod Volden wrote:
From: Johannes Obermayr johannesoberm...@gmx.de
[Tormod: Remove unnecessary else and fix spelling in messages
'.
The tdfx patch 0001-Fix-RPMLINT-warning-64bit-portability-issue.patch is
Reviewed-by: Tormod Volden debian.tor...@gmail.com
and has been pushed it to git. Thanks.
(To sum up: The trident patch is obsolete, and the xgi patch was
amended and applied.)
Tormod
,
Peter
Other than those two things,
Reviewed-by: Tormod Volden debian.tor...@gmail.com
Tormod
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Tue, Jan 17, 2012 at 6:35 AM, Peter Hutterer
peter.hutte...@who-t.net wrote:
XF86DRI is defined by xorg-server.h, so --disable-dri in the driver
itself does exactly nothing other than not fill in the CFLAGS and thus stop
the driver from compiling.
Signed-off-by: Peter Hutterer
From: Tormod Volden debian.tor...@gmail.com
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
The change should be fine by itself, but the reason I changed this is
that with the latest stack (upgraded to 1.12RC etc) the second call to
VBEGetVBEInfo would return corrupted values. There, I
On Thu, Feb 16, 2012 at 11:35 PM, Julien Cristau jcris...@debian.org wrote:
On Wed, Feb 15, 2012 at 23:07:12 +0100, Tormod Volden wrote:
From: Tormod Volden debian.tor...@gmail.com
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
The change should be fine by itself, but the reason
On Sun, Feb 19, 2012 at 2:36 PM, Gaetan Nadon mems...@videotron.ca wrote:
Reorder statements to be consistent with other modules so things
are easier to find.
...
+# Initialize X.Org macros 1.8 or later for MAN_SUBSTS set by
XORG_MANPAGE_SECTIONS
+m4_ifndef([XORG_MACROS_VERSION],
+
From: Tormod Volden debian.tor...@gmail.com
Also fix some formatting and typos.
---
edid-decode.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/edid-decode.c b/edid-decode.c
index cb6fec2..923556a 100644
--- a/edid-decode.c
+++ b/edid-decode.c
@@ -219,7
-by: Hans-Juergen Mauser hjmau...@gmx.net
Reviewed-by: Tormod Volden debian.tor...@gmail.com
---
src/savage_video.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/savage_video.c b/src/savage_video.c
index 9f860c7..7d571ad 100644
--- a/src/savage_video.c
+++ b
From: Tormod Volden debian.tor...@gmail.com
There is no reason to do the division using floats as long as
the result is an integer and there is no risk of intermediate
overflow.
This is in the code for Old chipsets. Integer division was already
used in the parallel code for New chipsets.
Also
On Sat, Sep 17, 2011 at 1:03 PM, walter harms wrote:
if (S3_MOBILE_TWISTER_SERIES(psav-Chipset)
- psav-FPExpansion) {
- drw_w = (((float)(drw_w * psav-XExp1)/(float)psav-XExp2)+1);
- drw_h = (float)(drw_h * psav-YExp1)/(float)psav-YExp2+1;
- dstBox-x1 =
On Sat, Sep 17, 2011 at 5:52 PM, Matt Turner wrote:
I don't know the hardware or Xv, but the changes look reasonable.
There are enough changes in -savage since the last release to warrant
a new one. Once this lands, let's do a new -savage release.
Yes, that is my plan. There is a couple of
From: Tormod Volden debian.tor...@gmail.com
Linux kernel 2.6.30 - 2.6.39 had broken drm maps which would result
in assorted problems. Leave a message in the log if it looks like
the framebuffer map and the aperture map are mixed up.
https://bugs.freedesktop.org/show_bug.cgi?id=32511
Signed-off
On Thu, Oct 6, 2011 at 3:05 PM, Antoine Martin wrote:
This allows us to run the server as a normal user whilst still
being able to use the -modulepath, -logfile and -config switches
We define a xf86PrivsElevated which will do the checks and cache
the result in case it is called more than once.
On Mon, Oct 10, 2011 at 6:43 PM, Antoine Martin wrote:
I have been using this patch for days without any visible side effects.
Can I please get some reviewed-by / acks?
Any functional issues aside, your patch will need some style polishing
before it can get any rubber stamps:
Subject: [PATCH
On Mon, Oct 10, 2011 at 9:04 PM, Antoine Martin wrote:
And another blooper, sorry for the spam. Correct patch attached.
Need sleep, will pick this up tomorrow.
Subject: [PATCH xserver] check for elevated privileges not uid=0 (V3)
Couldn't find any reference to it, so I just removed
On Thu, Oct 13, 2011 at 10:55 PM, Michal Suchanek wrote:
v3: reword based in input from Alan Coopersmith
To nitpick on the nitpicking (at the risk of bikeshedding):
+Asks the driver not to clear the background on startup, if the driver
supports that.
The other option descriptions start with
On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston jerem...@apple.com wrote:
So, what's the point of having all these in common? Why don't they just live
in the drivers? It seems silly to have these defined in the server's SDK
rather than the driver that will consume them, since it means
From: Tormod Volden debian.tor...@gmail.com
We already use atipciids.h instead most places.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
Actually, the PCI_VENDOR_ macros could better be maintained in a central
location, but I just added the one missing here for now.
Tormod
src
On Sun, Oct 30, 2011 at 12:12 AM, Jeremy Huddleston jerem...@apple.com wrote:
On Oct 29, 2011, at 14:01, Tormod Volden wrote:
On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston jerem...@apple.com
wrote:
So, what's the point of having all these in common? Why don't they just
live
On Wed, Apr 27, 2011 at 10:59 PM, TImo Aaltonen tjaal...@ubuntu.com wrote:
On 13.04.2011 18:22, TImo Aaltonen wrote:
On 06.04.2011 19:50, Timo Aaltonen wrote:
Here's a first set of patches to xf86-video-sis, hoping to narrow down
the diff against Thomas Winischofer's 'sisfree' (*) package and
[s3switch is a tool for switching outputs on S3 Savage cards]
Hi,
Due to popular request, I would like to revive the s3switch tool and
maintain it. It is still shipped in Fedora, based on a patch set from
Debian and a couple of additional patches, but meanwhile it has
ironically been dropped from
On Wed, Sep 15, 2010 at 7:56 AM, Trevor Woerner wrote:
-if [ $1 = lib ] [ $2 = libX11 ] [ x$USE_XCB = xNO ]; then
+if [ $1 = lib ] [ $2 = libX11 ] [ x${USE_XCB} = xNO ];
then
MOD_SPECIFIC=--with-xcb=no
fi
Any reason to not write just [ $USE_XCB = NO ] ? Then we could
On Wed, Sep 15, 2010 at 1:56 PM, Mikhail Gusarov wrote:
$ echo $a
$ [ zz = $a ]
No problem with quotes, you can even put it the intuitive way with the
variable first:
$ [ $a = zz ]
___
xorg-devel@lists.x.org: X.Org development
Archives:
---
build.sh | 65 ++---
1 files changed, 28 insertions(+), 37 deletions(-)
diff --git a/build.sh b/build.sh
index fa6a321..20aee43 100755
Reviewed-by: Tormod Volden lists.tor...@gmail.com
On Wed, Sep 15, 2010 at 2:09 PM, Trevor Woerner
On Tue, Apr 21, 2009 at 9:36 AM, umang gupta umang@gmail.com wrote:
X clears the contents of the framebuffer when it starts, so the
display is briefly all black
while X starts.
Not so in recent xserver AFAICT, for instance the radeon driver was
recently fixed to do the above:
On Fri, May 10, 2013 at 11:04 AM, Pander wrote:
On 05/07/2013 09:24 PM, Connor Behan wrote:
SiS drivers support EXA and will probably use that by default when
you start one of the newer Xservers that lacks XAA. This could
easily crash if the SiS EXA hooks haven't been updated in awhile so
On Sat, May 18, 2013 at 7:52 PM, Pander wrote:
(manual) patch results in
[74.465] (II) LoadModule: sisimedia
[74.465] (II) Loading /usr/lib/xorg/modules/drivers/sisimedia_drv.so
[74.465] (EE) Failed to load
/usr/lib/xorg/modules/drivers/sisimedia_drv.so:
From: Andy MacLean andy-...@themacleans.org.uk
This patch has been used in Debian, Ubuntu and Gentoo for years.
https://bugs.freedesktop.org/show_bug.cgi?id=18472
https://launchpad.net/bugs/292214
https://bugs.gentoo.org/show_bug.cgi?id=265100
Signed-off-by: Andy MacLean
From: Tormod Volden debian.tor...@gmail.com
https://launchpad.net/bugs/1180986
Signed-off-by: Tormod Volden debian.tor...@gmail.com
Reviewed-by: Robert Jacobs robert.n.jac...@gmail.com
Tested-by: Robert Jacobs robert.n.jac...@gmail.com
---
src/mga_driver.c |2 ++
1 file changed, 2
On Fri, Oct 18, 2013 at 1:29 AM, Matt Dew wrote:
Today was the nominal 1.14.4-rc2 release. I've gotten no
nominations, pull or cherry-pick requests since 1.14.3 was released.
Can I assume 1.14.3 has been good to folks or that people are
anxiously awaiting the chocolaty goodness of 1.15? Or
From: Tormod Volden debian.tor...@gmail.com
VBE was already skipped in the normal path, but not when setting
the PROBE_DETECT flag.
Should avoid bus error seen in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622606 and
http://lists.x.org/archives/xorg/2012-February/053969.html
Signed-off
On Tue, Oct 22, 2013 at 4:51 AM, Matt Dew wrote:
Hi Tormod,
I only take cherry-picks or pulls. Not individual patches.
Keith,
Thoughts on applying that to master?
Matt
On 10/18/2013 05:05 PM, Tormod Volden wrote:
Please consider Connor's patch (resent yesterday, Message-Id
On Thu, Nov 7, 2013 at 4:45 AM, Keith Packard wrote:
Many system headers have warnings when compiled with this flag.
Signed-off-by: Keith Packard kei...@keithp.com
At the risk of sounding pendantic, is your spelling a pun? Or trap :)
Tormod
___
From: Tormod Volden debian.tor...@gmail.com
Thanks to Connor Behan for the fix.
This replaces commit e9109a0b which was plain wrong.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
Hoping for remedy for old sins. Only compile-tested.
Tormod
src/mga_exa.c |2 +-
1 file changed
From: Tormod Volden debian.tor...@gmail.com
Thanks to Connor Behan for the suggestion.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
Also not tested on hardware.
Tormod
src/mga_exa.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mga_exa.c b/src/mga_exa.c
index
On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote:
On 03.03.2015 05:01, Tormod Volden wrote:
mgaDownloadFromScreen(PixmapPtr pSrc, int x, int y, int w, int h,
char *dst, int dst_pitch)
{
+if (!pSrc)
+ return FALSE;
+
PMGA(pSrc);
char *src
On Tue, Mar 3, 2015 at 9:21 PM, Alex Deucher wrote:
On Tue, Mar 3, 2015 at 2:21 PM, Tormod Volden wrote:
On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote:
About patch 1, since mgaDownloadFromScreen doesn't do anything fancier
than memcpy, you can just remove it altogether and leave
pExa
On Wed, Feb 25, 2015 at 2:01 PM, Mark Kettenis wrote:
That pretty much confirms the code doesn't work (before or after your
change). Probably the answer is to revert the
exaGetPixmapFirstPixel() changes you made (here and in other drivers).
Oops, yes, now I see that using
65 matches
Mail list logo
