Re: [PATCH xserver 2/2] Eliminate coordinate mode in PolyPoint, PolyLines and FillPolygon ops

Adam Jackson writes: > You want to make this non-static, so in the xinerama case you can do > this translation once at the top level. ... > You're not correcting stuff->coordMode in place, which means under > xinerama you'll mutate geometry once per screen, which ain't right.

[PATCH xserver 02/10 v2] glamor: Require that 16bpp pixmap depths match for Render copies.

The copy optimization in d37329cba42fa8e72fe4be8a7be18e512268b5bd replicated a bug from last time we did a copy optimization, and didn't get rendercheck run on it. This is effectively a re-cherry-pick of 510c8605641803f1f5b5d2de6d3bb422b148e0e7. Fixes rendercheck -t blend -o src -f

[PATCH xserver] Enable XTRANS_SEND_FDS on FreeBSD and DragonFly too

This code is based on a local patch which had actually been sitting in FreeBSD ports since 2015. Signed-off-by: François Tigeot --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c09b854..b9e27d0 100644

Re: [PATCH xserver] os: Eliminate NewOutputPending

Hi, On 09/22/2016 11:34 AM, Keith Packard wrote: By removing clients from output_pending_clients list when flushing is attempted, that list now becomes the list of clients that need flushing, which is equivalent to what NewOutputPending was used for. Clients are added to output_pending_clients

Re: [PATCH xbitmaps] Install pkgconfig file into arch-dependent location

On 09/23/16 12:05 AM, Emil Velikov wrote: On 23 September 2016 at 07:31, Julien Cristau wrote: On Thu, Sep 22, 2016 at 19:12:13 +0200, Heiko Becker wrote: Signed-off-by: Heiko Becker --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH xserver 02/10 v2] glamor: Require that 16bpp pixmap depths match for Render copies.

On 23/09/16 04:57 PM, Eric Anholt wrote: > The copy optimization in d37329cba42fa8e72fe4be8a7be18e512268b5bd > replicated a bug from last time we did a copy optimization, and didn't > get rendercheck run on it. Actually, I'm pretty sure I did run rendercheck, but didn't notice the regression due

Re: [PATCH xbitmaps] Install pkgconfig file into arch-dependent location

On 23 September 2016 at 07:31, Julien Cristau wrote: > On Thu, Sep 22, 2016 at 19:12:13 +0200, Heiko Becker wrote: > >> Signed-off-by: Heiko Becker >> --- >> Makefile.am | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [PATCH xf86-video-dummy v2] Remove pointless empty functions

On 22/09/16 23:14, Aaron Plattner wrote: > These functions might be useful in a real driver, but with no > hardware, they're pointless. Get rid of them. > > v2: Rebase, get rid of pointless calls to DUMMYAdjustFrame, return TRUE from > DUMMYSwitchMode. > > Signed-off-by: Aaron Plattner

Re: [PATCH xbitmaps] Install pkgconfig file into arch-dependent location

On Thu, Sep 22, 2016 at 19:12:13 +0200, Heiko Becker wrote: > Signed-off-by: Heiko Becker > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 060112d..9a89bbe 100644 > --- a/Makefile.am > +++

Re: [PATCH 1/1] Simplify, statement is always true.

Hi, On 09/22/2016 03:08 AM, Maya Rashish wrote: pVideo->bus is uint8_t, always less than 256. Signed-off-by: Maya Rashish LGTM: Reviewed-by: Hans de Goede Regards, Hans --- hw/xfree86/common/xf86pciBus.c | 6 +- 1 file changed, 1 insertion(+),

[PATCH xserver 06/10 v2] test: Make the piglit-running script callable with an arbitrary server.

v2: Check that SERVER_COMMAND is set. Signed-off-by: Eric Anholt --- test/.gitignore| 1 + test/Makefile.am | 1 + test/scripts/{xvfb-piglit.sh => run-piglit.sh} | 16 -- test/scripts/xvfb-piglit.sh

[PATCH xserver 08/10 v2] test: Update piglit HTML even when tests all pass.

I was confused by the behavior I'd written before. keithp and mattst88 responded with shock that I would have made it so surprising, as well. v2: Point to index.html instead of problems.html, which won't exist if we had no problems. Signed-off-by: Eric Anholt ---

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

On 23/09/16 03:46 PM, Hans de Goede wrote: > On 09/20/2016 04:58 AM, Michel Dänzer wrote: > >> If there are other drivers which can't call xf86HandleColormaps for some >> reason, a better solution would be to combine the per-screen gamma set >> via pScrn->ChangeGamma with the per-CRTC gamma set

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hi, On 09/20/2016 04:58 AM, Michel Dänzer wrote: On 17/09/16 07:00 PM, Hans De Goede wrote: Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 code. Leaving pScrn->ChangeGamma NULL in most

[PATCH xserver 05/10 v2] test: Add a little xinit-like program for starting servers for testing.

The normal xinit is racy because it doesn't use -displayfd. This implements the bare minimum for testing purposes, using -displayfd to sequence starting the client, and avoids adding yet another dependency to the server. v2: Fix asprintf error checks. Signed-off-by: Eric Anholt

[PATCH xserver] modesetting: Do not call drmModeSetCursor2() twice on every cursor change

Each xf86ScreenSetCursor() call calls: xf86DriverLoadCursorARGB() infoPtr->ShowCursor() In succession, ending up in 2 drmModeSetCursor2() calls, with the second effectively being a no-op. Keep track of having set the cursor already in drmmode_load_cursor_argb_check() and unless hide() was called

Re: [PATCH xbitmaps] Install pkgconfig file into arch-dependent location

On 23 September 2016 at 08:07, Alan Coopersmith wrote: > On 09/23/16 12:05 AM, Emil Velikov wrote: >> >> On 23 September 2016 at 07:31, Julien Cristau wrote: >>> >>> On Thu, Sep 22, 2016 at 19:12:13 +0200, Heiko Becker wrote: >>>

Re: [PATCH xbitmaps] Install pkgconfig file into arch-dependent location

On 09/23/16 12:34, Emil Velikov wrote: > On 23 September 2016 at 08:07, Alan Coopersmith > wrote: >> On 09/23/16 12:05 AM, Emil Velikov wrote: >>> >>> On 23 September 2016 at 07:31, Julien Cristau wrote: On Thu, Sep 22, 2016 at 19:12:13

Re: [PATCH xserver] modesetting: only fall back to drmModeSetCursor() on -EINVAL

Hi All, On 09/16/2016 06:51 PM, Michael Thayer wrote: This change effectively reverts commit 074cf58. We were falling back from drmModeSetCursor2() to drmModeSetCursor() whenever the first failed. This fall-back only makes sense on pre-mid-2013 kernels which implemented the cursor_set hook

Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

Hi All, On 09/16/2016 06:52 PM, Michael Thayer wrote: When the X server asks us to load a hardware cursor, that request is always followed up by a request to show it if we report success, or to hide it if we report failure. Therefore it makes no sense to suppress the request if the cursor is

Re: [PATCH xserver] Enable XTRANS_SEND_FDS on FreeBSD, DragonFly and OpenBSD

Hi, Sure, here's the second version. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

Hi, On 09/23/2016 11:13 AM, Michel Dänzer wrote: On 23/09/16 03:46 PM, Hans de Goede wrote: On 09/20/2016 04:58 AM, Michel Dänzer wrote: If there are other drivers which can't call xf86HandleColormaps for some reason, a better solution would be to combine the per-screen gamma set via

Re: [PATCH xserver] Enable XTRANS_SEND_FDS on FreeBSD and DragonFly too

On Fri, Sep 23, 2016 at 09:58:10AM +0200, François Tigeot wrote: > This code is based on a local patch which had actually been sitting in > FreeBSD ports since 2015. > > Signed-off-by: François Tigeot > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH xserver] Enable XTRANS_SEND_FDS on FreeBSD, DragonFly and OpenBSD

This code is based on local patches which had been sitting in FreeBSD and OpenBSD ports. Reviewed-by: Matthieu Herrb Signed-off-by: François Tigeot --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac

[Pull request]: couple of fixes for xwayland

The following changes since commit d0c5d205a919fc1d2eb599356090b58b1bf0176d: dix: Make InitCoreDevices() failures more verbose. (2016-09-21 21:11:40 +1000) are available in the git repository at: git://people.freedesktop.org/~ofourdan/xserver xwayland for you to fetch changes up to

Re: [xserver] modesetting: Consume all available udev events at once

Hi, On 12/11/2015 01:05 PM, Daniel Martin wrote: From: Daniel Martin We get multiple udev events for actions like docking a laptop into its station or plugging a monitor to the station. By consuming as much events as we can, we reduce the number of output

Re: [PATCH xserver 02/10 v2] glamor: Require that 16bpp pixmap depths match for Render copies.

Michel Dänzer writes: > On 23/09/16 04:57 PM, Eric Anholt wrote: >> The copy optimization in d37329cba42fa8e72fe4be8a7be18e512268b5bd >> replicated a bug from last time we did a copy optimization, and didn't >> get rendercheck run on it. > > Actually, I'm pretty sure I did

Re: 2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

Hi, On 09/23/2016 04:33 PM, Matthieu Herrb wrote: Hi Adam, Keith, any chance to get those 2 patches merged for 1.19 ? It would reduce the number of local patches I'm maintaining outside of os/os-support. https://patchwork.freedesktop.org/patch/64866/

Re: PATCH xserver small memory leaks fixes

Hi David, On 05/05/2016 10:39 AM, David CARLIER wrote: Hi all, This is a small patch to fix couple of small memory leaks. Hope it s useful. It is thanks for your patch, I've split 2 bits out into small patches and I've dropped the os/rpcauth.c change I think that you are doing the right

Re: xfree86: Fix null pointer dereference

Hi, On 01/13/2016 07:47 AM, Kyle Guinn wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93675 Signed-off-by: Kyle Guinn Thanks for the patch, I've queued this up at: https://cgit.freedesktop.org/~jwrdegoede/xserver For a 1.19 bug-fix pull-req I'm preparing at.

Re: [PATCH xserver 2/2] Eliminate coordinate mode in PolyPoint, PolyLines and FillPolygon ops

On Fri, 2016-09-23 at 01:15 +0300, Keith Packard wrote: > +static void > +FixCoordModePrevious(int npt, xPoint *ppt) > +{ > +int x, y; > + > +x = ppt->x; > +y = ppt->y; > +npt--; > +while (npt--) { > +ppt++; > +x = (ppt->x += x); > +y = (ppt->y += y); >

Re: [PATCH xserver 2/2] XF86VidMode: Fix free() on walked pointer

On 23 September 2016 at 12:50, Hans de Goede wrote: > Based on: https://patchwork.freedesktop.org/patch/85636/ > > Rewritten to just not walk the pointer. > Since the free is just outside of context one could mention it and/or elaborate a bit in general. Regardless the patch

[xserver PULL for 1.19] Various modesetting and other fixes

Hi Adam, Keith, Here is a pull-req consisting of a bunch of fixes written by me reviewed by others as well as a bunch of fixes from patchwork / the list which I've picked up and which are reviewed by me. Note there is one unreviewed patch in here v2 of: "glx: Always enable

2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

Hi Adam, Keith, any chance to get those 2 patches merged for 1.19 ? It would reduce the number of local patches I'm maintaining outside of os/os-support. https://patchwork.freedesktop.org/patch/64866/ https://patchwork.freedesktop.org/patch/65081/ If needed I can resend the patches there.

[PATCH xserver 2/2] XF86VidMode: Fix free() on walked pointer

Based on: https://patchwork.freedesktop.org/patch/85636/ Rewritten to just not walk the pointer. Signed-off-by: Hans de Goede --- Xext/vidmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xext/vidmode.c b/Xext/vidmode.c index 499a2a8..ea3ad13

[PATCH xserver 1/2] Xext: Fix a memory leak

Based on: https://patchwork.freedesktop.org/patch/85636/ Rewritten to also free the resources allocated by panoramix_setup_ids(). Signed-off-by: Hans de Goede --- Xext/shm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xext/shm.c b/Xext/shm.c

Re: [PATCH xserver 1/2] Xext: Fix a memory leak

Hi, On 09/23/2016 03:23 PM, Emil Velikov wrote: On 23 September 2016 at 12:50, Hans de Goede wrote: Based on: https://patchwork.freedesktop.org/patch/85636/ Rewritten to also free the resources allocated by panoramix_setup_ids(). The codeflow is a bit nasty to read,

Re: xfree86: Fix null pointer dereference

Hi, On 09/23/2016 03:33 PM, Eric Engestrom wrote: On Fri, Sep 23, 2016 at 03:12:18PM +0300, Hans de Goede wrote: Hi, On 01/13/2016 07:47 AM, Kyle Guinn wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93675 Signed-off-by: Kyle Guinn Thanks for the patch, I've

Re: 2 patches for glamor on OpenBSD (without DRI3/XSHM_FENCE)

On Fri, Sep 23, 2016 at 04:45:37PM +0300, Hans de Goede wrote: > Hi, > > On 09/23/2016 04:33 PM, Matthieu Herrb wrote: > > Hi > > > > Adam, Keith, any chance to get those 2 patches merged for 1.19 ? > > It would reduce the number of local patches I'm maintaining outside of > > os/os-support. > >

Re: xfree86: Fix null pointer dereference

On Fri, Sep 23, 2016 at 03:12:18PM +0300, Hans de Goede wrote: > Hi, > > On 01/13/2016 07:47 AM, Kyle Guinn wrote: > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93675 > > > > Signed-off-by: Kyle Guinn > > Thanks for the patch, I've queued this up at: > >

Re: [PATCH xserver] modesetting: Do not call drmModeSetCursor2() twice on every cursor change

Each xf86ScreenSetCursor() call calls: xf86DriverLoadCursorARGB() infoPtr->ShowCursor() In succession, ending up in 2 drmModeSetCursor2() calls, with the second effectively being a no-op. Keep track of having set the cursor already in drmmode_load_cursor_argb_check() and unless hide() was

Re: [PATCH xserver 1/2] Xext: Fix a memory leak

On 23 September 2016 at 12:50, Hans de Goede wrote: > Based on: https://patchwork.freedesktop.org/patch/85636/ > > Rewritten to also free the resources allocated by > panoramix_setup_ids(). > The codeflow is a bit nasty to read, but the patch is perfectly correct.

Re: [PATCH xserver 05/10 v2] test: Add a little xinit-like program for starting servers for testing.

On Fri, Sep 23, 2016 at 10:58:54 +0300, Eric Anholt wrote: > The normal xinit is racy because it doesn't use -displayfd. This > implements the bare minimum for testing purposes, using -displayfd to > sequence starting the client, and avoids adding yet another dependency > to the server. > > v2:

Re: [PATCH] remove dead code in dummy driver

On 09/22/2016 04:30 PM, Bob Terek wrote: > On 09/21/2016 10:22 AM, Aaron Plattner wrote: >> On 09/20/2016 02:07 AM, Eric Engestrom wrote: >>> On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: Signed-off-by: Antoine Martin >>> >>> Reviewed-by: Eric

Re: [PATCH 1/1] Simplify, statement is always true.

On 09/21/2016 05:08 PM, Maya Rashish wrote: > pVideo->bus is uint8_t, always less than 256. > > Signed-off-by: Maya Rashish > --- > hw/xfree86/common/xf86pciBus.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/hw/xfree86/common/xf86pciBus.c

Re: [PATCH xserver 05/10] test: Add a little xinit-like program for starting servers for testing.

Hey cool, On Friday, September 23, 2016, Eric Anholt wrote: > > The normal xinit is racy because it doesn't use -displayfd.  This > implements the bare minimum for testing purposes, using -displayfd to > sequence starting the client, and avoids adding yet another dependency > to