Re: [PATCH xserver 0/5] Prepare makefiles for automake 2.0 mandatory subdir-objects

are not the ideal solution, in fact, no solution at all for many. To my knowledge, this leaves us with the ideal solution I call code re-factoring to replace the cherry-picking of reusable source files which is exemplified by Jon Turney 's patch earlier in this thread. I've CC Emil Velikov for Mesa

Re: [PATCH 4/5] miinitext: avoid allocating a sentinel ExtensionModule

Hello gents, Can someone take a look at this patch please. Keith already covered the rest of the series but this patch went below his radar. Thanks Emil On 05/02/14 16:20, Emil Velikov wrote: With all the logic now in place there is no need to allocate a separate ExtensionModule to be used

Re: [Mesa-dev] Student interested in gsoc at xorg

On 04/03/14 06:58, lazaro E Lespes wrote: Hello All, Hi Lazaro, The last February 26, I sent and introduction mail to mesa-dev@ lists.freedesktop.org because I'm interested in participate in gsoc at xorg. I did not get any feedback so I don't know if my mail arrived to the list. Below, I

[PULL] LoadExtension clean-up series

extension_loader_cleanup for you to fetch changes up to f95f72838ba07b3f83e9fb320d6db85c79174f3c: miinitext: introduce LoadExtensionList() to replace over LoadExtension() (2014-03-14 14:03:32 +) Emil Velikov (5

[PATCH libX11] x11-xcb: Move internal dependencies to

-off-by: Emil Velikov emil.l.veli...@gmail.com --- Please keep me Cc'd as I'm not subscribed to the list. -Emil x11-xcb.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x11-xcb.pc.in b/x11-xcb.pc.in index 315a9d1..195f470 100644 --- a/x11-xcb.pc.in +++ b/x11-xcb.pc.in

[PATCH] configure.ac: Add resourceproto and scrnsaverproto to SDK_REQUIRED_MODULES

Note: This is a candidate for the master and 1.13 branches Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index e686614..c464a9d 100644 --- a/configure.ac +++ b/configure.ac @@ -1028,12

Re: [PATCH] configure.ac: Add resourceproto and scrnsaverproto to SDK_REQUIRED_MODULES

On Mon, 22 Oct 2012 18:59:18 +0100, Gaetan Nadon mems...@videotron.ca wrote: On 12-10-21 03:29 PM, Emil Velikov wrote: Note: This is a candidate for the master and 1.13 branches Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 2 ++ 1 file changed, 2 insertions

[PATCH v2] configure.ac: Include missing proto declarations in SDK_REQUIRED_MODULES

workarounds to avoid issues while building video and input ddx drivers Evidently this is what XV and XINERAMA do, so let's fix the last few NOTE: This is a candidate for the 1.13 branch v2: Add commit message, include xf86bigfontproto Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

[PATCH v3] configure.ac: Include missing proto declarations in SDK_REQUIRED_MODULES

various workarounds to avoid issues while building video and input ddx drivers Evidently this is what XV and XINERAMA do, so let's fix the last few NOTE: This is a candidate for the 1.13 branch v2: Add commit message, include xf86bigfontproto v3: Spelling typos Signed-off-by: Emil Velikov emil.l.veli

Re: [PATCH v3] configure.ac: Include missing proto declarations in SDK_REQUIRED_MODULES

On 23/10/12 20:40, Emil Velikov wrote: Namely - resourceproto, scrnsaverproto and xf86bigfontproto When compiling xserver with the above enabled, their respective headers are included in xorg/extinit.h, thus they become part of the sdk (xorg-server-devel as known by distribution packagers

[PATCH] configure.ac: Include missing proto declarations in SDK_REQUIRED_MODULES

Commits a1d41e311c21e, 7d859bd87834d 3ed2c6e11298c made extinit.h require the XF86 Big Font, XRes ScrnSaver proto headers, but failed to add them to the SDK_REQUIRED_MODULES so pkg-config would find them for driver builds. Cc: Daniel Stone dan...@fooishbar.org Signed-off-by: Emil Velikov

[PATCH] configure.ac: Include missing proto declarations in SDK_REQUIRED_MODULES

Commits a1d41e311c21e, 7d859bd87834d 3ed2c6e11298c made extinit.h require the XF86 Big Font, XRes ScrnSaver proto headers, but failed to add them to the SDK_REQUIRED_MODULES so pkg-config would find them for driver builds. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Daniel

[PATCH 1/5] miinitext: move AddStaticExtensions() to LoadExtension()

Separate the function from NewExtensionModule() as the former does only memory reallocation. No functional change. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- mi/miinitext.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mi/miinitext.c b/mi/miinitext.c

[PATCH 4/5] miinitext: avoid allocating a sentinel ExtensionModule

With all the logic now in place there is no need to allocate a separate ExtensionModule to be used as a sentinel. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- mi/miinitext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mi/miinitext.c b/mi/miinitext.c index

[PATCH 3/5] miinitext: constify staticExtensions

The array is readonly and should not be tampered with. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- mi/miinitext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/miinitext.c b/mi/miinitext.c index 099ac42..ce2e4bc 100644 --- a/mi/miinitext.c +++ b/mi

[PATCH 2/5] miinitext: drop sentinel detection during LoadExtension

All the sentinels from the extension lists were removed, thus the only case were this would trigger is when the code is broken badly. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- mi/miinitext.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mi/miinitext.c b/mi/miinitext.c

[PATCH 5/5] miinitext: introduce LoadExtensionList() to replace over LoadExtension()

Looping around LoadExtension() meant that ExtensionModuleList was reallocated on every extension. Using LoadExtensionList() we pass an array thus the function can do the reallocation in one go, and then loop and setup the ExtensionModuleList. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com

Re: DRI3/Present fixes for Mesa 10.3+

Hi Mario, On 25/11/14 03:00, Mario Kleiner wrote: Hi Here three patches against mesa to fix use of the OML_sync_control extension under DRI3/Present and restore behaviour compatible to the DRI2 implementation, so applications like mine, which were written and tested against DRI2, don't fail

Re: [PATCH 3/4] Include config.h before any other headers.

On Saturday, 7 February 2015, Alan Coopersmith alan.coopersm...@oracle.com wrote: Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Though I wonder if now you can drop the explicit #define _GNU_SOURCE in linux_sysfs.c now that you moved the config.h up to the same spot, since the

[PATCH 1/4] Include the POSIX dfcntl.h instead of sys/dfcntl.h

The former is part of the POSIX standard, and (unlike the latter) is more widely available. Cc: Adam Jackson a...@redhat.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/pciaccess_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

[PATCH 2/4] Add missing guards around config.h inclusion

From: Chih-Wei Huang cwhu...@linux.org.tw In some cases the header may not exist, leading to compilation issues. Add the ifdef HAVE_CONFIG_H, as it is those in other parts of the project. [Emil Velikov: Split out from a larger commit, rework commit message] Signed-off-by: Emil Velikov

[PATCH 3/4] Include config.h before any other headers.

The former has a series of defines which in some cases are crusial to be set before including any system headers. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/common_vgaarb.c | 8 src/freebsd_pci.c | 8 src/linux_sysfs.c | 8 src/netbsd_pci.c| 8

[PATCH 4/4] Check for __linux__ instead of linux during compilation

...@intel.com [Emil Velikov: Remove irrelevant Android details from commit msg.] Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/common_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/common_init.c b/src/common_init.c index a127a8b..b1c0c3e 100644 --- a/src

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

On 11/01/15 08:31, Mathias Fröhlich wrote: Hi, On Sunday, January 04, 2015 20:53:59 Emil Velikov wrote: Adding Mathias and Frank Binns to the Cc list. So taking into account the discussion so far, including Mathias's input that the official nvidia driver does the same

[PATCH libpciaccess 3/5] Include config.h before any other headers.

The former has a series of defines which in some cases are crusial to be set before including any system headers. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/common_vgaarb.c | 8 src/freebsd_pci.c | 8

Re: [PATCH libpciaccess 5/5] linux: Remove no longer needed _GNU_SOURCE define.

On 12/02/15 22:14, Alan Coopersmith wrote: On 02/10/15 06:55 AM, Emil Velikov wrote: With earlier commit we're including config.h before the system headers. As such we no longer require the extra define as it is handled/set via AC_USE_SYSTEM_EXTENSIONS. Note platforms which do not use

Re: [PATCH 4/4] Check for __linux__ instead of linux during compilation

Would anyone have some input - apart from the missing libpciaccess prefix of course ? Fwiw src/common_interface.c already checks for __linux__, so this patch makes things more consistent as an added bonus :-P Cheers, Emil On 6 February 2015 at 17:29, Emil Velikov emil.l.veli...@gmail.com wrote

Re: [PATCH libpciaccess 5/5] linux: Remove no longer needed _GNU_SOURCE define.

On 10 February 2015 at 14:55, Emil Velikov emil.l.veli...@gmail.com wrote: With earlier commit we're including config.h before the system headers. As such we no longer require the extra define as it is handled/set via AC_USE_SYSTEM_EXTENSIONS. Note platforms which do not use autotools

[PATCH libpciaccess 4/5] Check for __linux__ instead of linux during compilation

...@intel.com v2: Drop double negative from commit msg. Spotted by Mateusz Jończyk. [Emil Velikov: Remove irrelevant Android details from commit msg.] Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net --- src/common_init.c | 4 +++- 1 file changed, 3

[PATCH libpciaccess 2/5] Add missing guards around config.h inclusion

From: Chih-Wei Huang cwhu...@linux.org.tw In some cases the header may not exist, leading to compilation issues. Add the ifdef HAVE_CONFIG_H, as it is those in other parts of the project. [Emil Velikov: Split out from a larger commit, rework commit message] Signed-off-by: Emil Velikov

[PATCH libpciaccess 5/5] linux: Remove no longer needed _GNU_SOURCE define.

-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/linux_sysfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/linux_sysfs.c b/src/linux_sysfs.c index 50d94cf..a194e8b 100644 --- a/src/linux_sysfs.c +++ b/src/linux_sysfs.c @@ -32,8

[PATCH libpciaccess 1/5] Include the POSIX fcntl.h instead of sys/fcntl.h

The former is part of the POSIX standard, and (unlike the latter) is more widely available. v2: Drop gracious d in header name. Spotted by Alan. Cc: Adam Jackson a...@redhat.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

On 17/12/14 05:20, Mario Kleiner wrote: On 12/17/2014 05:49 AM, Keith Packard wrote: Mario Kleiner mario.kleiner...@gmail.com writes: It's just that i need access to both, the old behaviour i described, and the new drop frame behaviour, and i need a way to select what i want at runtime via

[PATCH 3/5] randr: use local variables where possible

This will allow us to make the code more readable, and the lines will fit within 80 columns. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- randr/rrcrtc.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/randr/rrcrtc.c b/randr

[PATCH 2/5] randr: use randr: prefix in ErrorF()

To provide some information about the origin of the message. Cc: Dave Airlie airl...@redhat.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- randr/rrcrtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index 6d297aa..dca0691

[PATCH 0/5] Trivial randr cleanups

, 3...) or similar. While there, my editor pointed out a few long lines so I've decided to address those as well :-) Any and all input will be appreciated. Cheers Emil Emil Velikov (5): randr: remove chatty error messages randr: use randr: prefix in ErrorF() randr: use local

[PATCH 5/5] randr: coding style fixes

In most of xserver code-base we define new functions at column 0, with their return type provided on the previous line. Two functions did not follow this rule so update them, and get them wrapped up to 80 as an added bonus. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- randr/rrcrtc.c

[PATCH 4/5] randr: wrap long line

Also make use of total_name_len variable for consistency. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- randr/rrscreen.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/randr/rrscreen.c b/randr/rrscreen.c index c2a7798..d0ca91e 100644 --- a/randr/rrscreen.c

[PATCH 1/5] randr: remove chatty error messages

All of these seem like left over from developments stage. Remove them as they can cause excessive flood in the logs. Cc: Dave Airlie airl...@redhat.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- randr/rrcrtc.c | 4 randr/rrscreen.c | 2 -- 2 files changed, 6 deletions

Re: [PATCH] configure.ac: remove remaining TLS references

Humble ping. On 8 March 2015 at 20:51, Emil Velikov emil.l.veli...@gmail.com wrote: No longer used with the removal of the GL dispatch (glapi) from libglx a few releases ago. Cc: Adam Jackson a...@redhat.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac

[PATCH libpciaccess v2] autogen.sh: pass --force to autoreconf, quote string variables

By passing --force autoreconf will update all the aux files, which would otherwise be ignored if one updates autoconf/automake. Quote the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when it contains space. v2: Also handle $srcdir and $0. Signed-off-by: Emil Velikov emil.l.veli

[PATCH] autogen.sh: use quoted string variables

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- autogen.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/autogen.sh b/autogen.sh index dd0731a..aee4beb

[PATCH libpciaccess] autogen.sh: pass --force to autoreconf, quote ORIGDIR

By passing --force autoreconf will update all the aux files, which would otherwise be ignored if one updates autoconf/automake. Quote the ORIGDIR variable to prevent fall-outs, when it's name contains space. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- autogen.sh | 4 ++-- 1 file

Re: [PATCH] Byte-swapping and size-checking generator all-in-one

Hi Asalle, Note that I'm not a core xserver developer like the rest of the folks here, so... take this with a pinch of salt :-P On 11/03/15 18:46, asalle@gmail.com wrote: ... diff --git a/configure.ac b/configure.ac index 96524c5..5b89705 100644 --- a/configure.ac +++ b/configure.ac @@

Re: [PATCH libpciaccess 1/2] vgaarb: add a the trailing NULL character on read(vgaarb_fd)

Another humble ping. Can we get any comments on these two patches ? Thanks Emil On 27 February 2015 at 16:16, Emil Velikov emil.l.veli...@gmail.com wrote: Humble ping ? On 23 February 2015 at 21:31, Emil Velikov emil.l.veli...@gmail.com wrote: From: arsharma ankitprasad.r.sha...@intel.com

[PATCH] configure.ac: remove remaining TLS references

No longer used with the removal of the GL dispatch (glapi) from libglx a few releases ago. Cc: Adam Jackson a...@redhat.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac| 16 +- include/dix-config.h.in | 3 --- m4/xorg-tls.m4 | 55

Re: [PATCH] autogen.sh: use quoted string variables

Hi Peter, On 10 March 2015 at 05:34, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Mar 09, 2015 at 12:00:52PM +, Emil Velikov wrote: Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov emil.l.veli

Re: [PULL] randr cleanups et al

Humble ping. On 24/03/15 17:52, Emil Velikov wrote: Hi Keith, Various patches from me. Please consider pulling into master. The following changes since commit 0a78b599b34cc8b5fe6fe82f90e90234e8ab7a56: int10: Fix error check for pci_device_map_legacy (2015-03-13 12:31:21 +1000

Re: [PATCH 1/2] xserver: add xorg.conf support for gpu devices.

Hi Dave, On 31/03/15 07:12, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This allows gpu devices to be specified in xorg.conf Screen sections. Section Device Driver intel Identifier intel0 Option AccelMethod uxa EndSection Section Device

Re: [PATCH libpciaccess 1/2] vgaarb: add a the trailing NULL character on read(vgaarb_fd)

Humble ping ? On 23 February 2015 at 21:31, Emil Velikov emil.l.veli...@gmail.com wrote: From: arsharma ankitprasad.r.sha...@intel.com Issue was spotted by Klocwork, and fixed by arsharma as part of Android-ia. Not 100% sure if the data read from /dev/vga_arbiter is not already null

[PATCH libpciaccess 1/2] vgaarb: add a the trailing NULL character on read(vgaarb_fd)

From: arsharma ankitprasad.r.sha...@intel.com Issue was spotted by Klocwork, and fixed by arsharma as part of Android-ia. Not 100% sure if the data read from /dev/vga_arbiter is not already null terminated, but making sure won't hurt either. [Emil Velikov: Split from larger patch, write commit

Re: close-on-exec

On 25/02/15 22:27, Alan Coopersmith wrote: On 02/25/15 01:24 PM, Thomas Klausner wrote: I don't know what the proper way to do this portably, but this is the diff we currently have in NetBSD's xsrc for xsm to close file descriptors on exec. I see that glibc added fopen's e flag for 2.7 (in

Re: close-on-exec

On 27 February 2015 at 01:02, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 02/26/15 08:04 AM, Emil Velikov wrote: On 25/02/15 22:27, Alan Coopersmith wrote: I'm not sure what more we can do. I have no idea how to write a configure check to test for fopen(..., e) support either

[PULL] randr cleanups et al

/evelikov/xserver.git for you to fetch changes up to 23702dd2689e2e1e65be5767ac0303a985bb04a0: randr: coding style fixes (2015-03-24 17:21:26 +) Emil Velikov (6): configure.ac: remove remaining TLS references randr

Re: [PULL] randr cleanups et al

Humble ping ? On 9 April 2015 at 15:49, Emil Velikov emil.l.veli...@gmail.com wrote: Silly me forgot to add Keith to the Cc list. Keith can you consider the pull request below. Thanks Emil On 24 March 2015 at 17:52, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Keith, Various

Re: [PULL] randr cleanups et al

Silly me forgot to add Keith to the Cc list. Keith can you consider the pull request below. Thanks Emil On 24 March 2015 at 17:52, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Keith, Various patches from me. Please consider pulling into master. The following changes since commit

Re: [PATCH 1/2] glamor: add support for allocating linear buffers

On 23 June 2015 at 02:46, Michel Dänzer mic...@daenzer.net wrote: On 23.06.2015 04:28, Emil Velikov wrote: On 22 June 2015 at 07:56, Michel Dänzer mic...@daenzer.net wrote: On 20.06.2015 07:32, Dave Airlie wrote: at which point you'd want to continue the versioning from the mesa point

Re: [PATCH 1/2] glamor: add support for allocating linear buffers

On 15 June 2015 at 05:08, Michel Dänzer mic...@daenzer.net wrote: On 12.06.2015 08:48, Dave Airlie wrote: We need this for doing USB offload scenarios using glamor and modesetting driver. unfortunately only gbm in mesa 10.6 has support for the linear API. Signed-off-by: Dave Airlie

Re: [PATCH 1/2] glamor: add support for allocating linear buffers

On 19 June 2015 at 02:12, Dave Airlie airl...@gmail.com wrote: On 19 June 2015 at 02:02, Emil Velikov emil.l.veli...@gmail.com wrote: On 15 June 2015 at 05:08, Michel Dänzer mic...@daenzer.net wrote: On 12.06.2015 08:48, Dave Airlie wrote: We need this for doing USB offload scenarios using

Re: [PATCH 1/2] glamor: add support for allocating linear buffers

On 22 June 2015 at 07:56, Michel Dänzer mic...@daenzer.net wrote: On 20.06.2015 07:32, Dave Airlie wrote: at which point you'd want to continue the versioning from the mesa point to avoid epochs. So I don't take your argument, the API version is what we ship in the gbm.pc file, compatible

Re: [PATCH v2 2/4] Free the data returned by XGetWindowProperty()

On 21 May 2015 at 17:21, Jasper St. Pierre jstpie...@mecheye.net wrote: XFree crashes when passed NULL. I've never tried it personally, but it seems that XFree() is a simple wrapper around free(), which should work just fine. [1] [2] On the other hand $ man 3 XFree clearly states that NULL

Re: [PATCH:xf86-video-geode] Properly hide config.h inclusion inside HAVE_CONFIG_H.

On 21 July 2015 at 22:12, Thomas Klausner w...@netbsd.org wrote: On Mon, Jul 20, 2015 at 05:03:13PM +0100, Emil Velikov wrote: Hi Thomas, On 20 July 2015 at 09:37, Thomas Klausner w...@netbsd.org wrote: From: Matthew Green m...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

On 21 July 2015 at 22:18, Thomas Klausner w...@netbsd.org wrote: Hi Emil! On Mon, Jul 20, 2015 at 05:00:43PM +0100, Emil Velikov wrote: On 19 July 2015 at 08:56, Thomas Klausner w...@netbsd.org wrote: From: Matthew Green m...@netbsd.org Move X11/Xpoll.h include earlier than sys/select.h

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

Hello gents, On 15 July 2015 at 09:51, Marek Chalupa mchqwe...@gmail.com wrote: Reviewed-by: Marek Chalupa mchqwe...@gmail.com (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html) On 05/16/2015 07:38 AM, Dima Ryazanov wrote: snprintf does not allocate memory, so we

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

On 15 July 2015 at 19:11, Bryce Harrington br...@osg.samsung.com wrote: On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote: Hello gents, On 15 July 2015 at 09:51, Marek Chalupa mchqwe...@gmail.com wrote: Reviewed-by: Marek Chalupa mchqwe...@gmail.com (http

Re: [PATCH:xfs 1/2] FD_SETSIZE fixes.

Hi Thomas, On 19 July 2015 at 08:56, Thomas Klausner w...@netbsd.org wrote: From: Matthew Green m...@netbsd.org Move X11/Xpoll.h include earlier than sys/select.h to avoid missing out on setting FD_SETSIZE early enough. Shouldn't there be a comment to prevent the next person from

Re: [PATCH:xf86-video-geode] Properly hide config.h inclusion inside HAVE_CONFIG_H.

Hi Thomas, On 20 July 2015 at 09:37, Thomas Klausner w...@netbsd.org wrote: From: Matthew Green m...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/geode.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/geode.h b/src/geode.h index ac69368..244cadf 100644

Re: [PATCH v2] Handle failures in setting a CRTC to a DRM mode properly

On 26 October 2015 at 10:55, Daniel Martin wrote: > On 26 October 2015 at 10:39, Michel Dänzer wrote: >>> diff --git a/src/drmmode_display.c b/src/drmmode_display.c >>> index 64e79d4..f0f121e 100644 >>> --- a/src/drmmode_display.c >>> +++

Re: [PATCH v2] Handle failures in setting a CRTC to a DRM mode properly

On 27 October 2015 at 02:07, Michel Dänzer <mic...@daenzer.net> wrote: > On 26.10.2015 20:01, Emil Velikov wrote: >> On 26 October 2015 at 10:55, Daniel Martin <consume.no...@gmail.com> wrote: >>> On 26 October 2015 at 10:39, Michel Dänzer <mic...@daenzer.n

Re: [PATCH] vidmode: Drop the unused event code

and certainly > has never been enabled since Xorg 7.0. > > Also, K > > Signed-off-by: Adam Jackson <a...@redhat.com> I second your git archaeological discovery - upstream has ever set XF86VIDMODE_EVENTS. While here one can also nuke the if 0 guarded XF86VidModeReqCode hun

Re: [PATCH xserver] xwayland: Add Xfree86-VidModeExtension to Xwayland

On 29 October 2015 at 14:10, Adam Jackson <a...@nwnk.net> wrote: > On Thu, 2015-10-29 at 09:50 +0000, Emil Velikov wrote: >> On 29 October 2015 at 09:37, Olivier Fourdan <ofour...@redhat.com> wrote: >> > Hi Krzysztof, >> > >> > Quick questio

Re: [PATCH] vidmode: Drop the unused event code

and certainly > has never been enabled since Xorg 7.0. > > Also, K > > Signed-off-by: Adam Jackson <a...@redhat.com> I second your git archaeological discovery - upstream has ever set XF86VIDMODE_EVENTS. While here one can also nuke the if 0 guarded XF86VidModeReqCode hun

Re: [PATCH] build: Remove stale miext/cw include paths

NT = $(XORG_MALLOC_DEBUG_ENV) > > AM_CFLAGS = $(DIX_CFLAGS) @XORG_CFLAGS@ > -AM_CPPFLAGS = $(XORG_INCS) -I$(top_srcdir)/miext/cw > +AM_CPPFLAGS = $(XORG_INCS) > if XORG > AM_CPPFLAGS += -I$(top_srcdir)/hw/xfree86/parser \ > -I$(top_srcdir)/hw/xfree86/ddc \ Nicely spotted. miext

Re: [PATCH xserver] xwayland: Add Xfree86-VidModeExtension to Xwayland

On 29 October 2015 at 09:37, Olivier Fourdan wrote: > Hi Krzysztof, > > Quick question, as I haven't heard back from you, do you plan to follow up > on these patches or should I fix them? > While there, can someone confirm if the two extra files aren't just a copy/pasta from

Re: [PATCH] configure.ac: Use libsystemd in REQUIRED_LIBS check

Hi Jussi, I'm not as experienced as other devs here so take all of the following with a pinch of salt. On 16 November 2015 at 14:46, Jussi Kukkonen wrote: > REQUIRED_LIBS needs to be set to the correct systemd library, > otherwise the later check will either fail or

Re: [PATCH] configure.ac: Use libsystemd in REQUIRED_LIBS check

On 16 November 2015 at 16:20, Jussi Kukkonen <jussi.kukko...@intel.com> wrote: > On 16 November 2015 at 17:26, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >> Hi Jussi, >> >> I'm not as experienced as other devs here so take all of the following >&g

Re: List display device names

On 12 November 2015 at 07:37, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 11 Nov 2015 22:06:12 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> Hi Tom, >> >> On 11 November 2015 at 13:31, Tom Deseyn <tom.des...@gmail.com> wrote:

Re: List display device names

Hi Tom, On 11 November 2015 at 13:31, Tom Deseyn wrote: > Hi all, > > To configure X I need to know the display device names (e.g. DFP-0). I get > these by looking at the Xorg.log. Is there a way to list these display > device names which is more suitable for automation? I

Re: [PATCH] modesetting: and entity setup to generic probe path.

On 17 November 2015 at 00:23, Dave Airlie wrote: > From: Dave Airlie > > Totally untested, cross fingers hope it works. > > Signed-off-by: Dave Airlie > --- > hw/xfree86/drivers/modesetting/driver.c | 25 + > 1

Re: [PATCH xserver 3/4] modesetting: Remove XF86_CRTC_VERSION checks

.h:#define XF86_CRTC_VERSION 6 > > Signed-off-by: Daniel Martin <consume.no...@gmail.com> The first three are Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> There are a couple more trivial defines in case you're interested - MODESETTING_OUTPUT_SLAVE_SUPPORT and XF8

Re: [PATCH] Xdmx: add a missing dependency to librandr introduced by 90db5ed

Hi Martin, Adam was slightly ahead of you on this one. http://lists.x.org/archives/xorg-devel/2015-July/046893.html Cheers Emil ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH] modesetting: create entities for pci and old probe. (v2)

y, NULL, NULL, NULL, > NULL); > +entity_num = xf86ClaimFbSlot(drv, 0, devSections[i], TRUE); > +scrn = xf86ConfigFbEntity(scrn, 0, entity_num, NULL, NULL, NULL, > NULL); > } > > if (scrn) { > @@ -448,6 +450,7 @@ Probe(DriverPtr

Re: [PATCH v2] configure.ac: Use libsystemd in REQUIRED_LIBS check

On 17 November 2015 at 08:39, Jussi Kukkonen wrote: > REQUIRED_LIBS needs to be set to the correct systemd library, > otherwise the later check will either fail or use the wrong > pc file. > > Signed-off-by: Jussi Kukkonen > --- > > > Changes

Re: [PATCH 1/2] modesetting: drop platform_dev pointer.

keup_registered; /* server generation for which fd > has been registered for wakeup handling */ > int fd_wakeup_ref; > unsigned int assigned_crtcs; > -#ifdef XSERVER_PLATFORM_BUS > -struct xf86_platform_device *platform_dev; > -#endif > } modesettingEntRec, *modesettingEntPtr; >

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name

Hi Keith, On 2 September 2015 at 08:15, Keith Packard wrote: > This eliminates the weak symbol adventures and makes all of the calls > back to the X server or Font server go through a table of functions > instead, clarifying the required API. > > As this is a rather major

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

On 10 September 2015 at 02:41, Keith Packard <kei...@keithp.com> wrote: > Emil Velikov <emil.l.veli...@gmail.com> writes: > >> From a very quick look, only fontstruct.h seems to be used. If truly >> so, one can rework it (rename or fold into libxfont2.h, rename the &

[PATCH] glamor: explicitly check for GL_OES_EGL_image

Otherwise we'll fail miserably later on as we try to use glEGLImageTargetTexture2DOES. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- glamor/glamor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/glamor/glamor.c b/glamor/glamor.c index d4a0236..8178785 100644 --- a/

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

hich defines the X > server and Font server interfaces. > > This moves util/atom.c to stubs/atom.c and reformats that file, hence > the diff being larger than it would otherwise be. > > v2: Rename to libXfont2 instead of libXfont_2 as suggested by Emil Velikov > Fix whitespace i

[PATCH xserver] glamor: move GL_OES_EGL_image check next to EGL_EXT_image_dma_buf_import

: Eric Anholt <e...@anholt.net> Suggested-by: Eric Anholt <e...@anholt.net> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- glamor/glamor.c | 5 - glamor/glamor_egl.c | 3 ++- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/glamor/glamor.c b/gla

Re: [PATCH] glamor: explicitly check for GL_OES_EGL_image

Hi Eric, On 17 September 2015 at 15:52, Eric Anholt <e...@anholt.net> wrote: > Emil Velikov <emil.l.veli...@gmail.com> writes: > >> Otherwise we'll fail miserably later on as we try to use >> glEGLImageTargetTexture2DOES. > > I thought this had been implied by

[PATCH xserver] glamor: move 'dri3_capable' extension checks after eglMakeCurrent

gmail.com> Reported-by: Nick Sarnie <commendsar...@gmail.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- Sorry about this guys - had a bit of a brain-freeze. I opted to move the whole hunk, as 1) the egl extension checks above are required, whist these are opt

Re: [PATCH] xserver: Fix configure.ac check for libsystemd/-daemon

Hi guys, We had a similar patch from an intel dev not too long ago, although it never got polished afaics. On 3 December 2015 at 11:39, Pekka Paalanen wrote: > On Fri, 27 Nov 2015 15:57:21 + > Bob Ham wrote: > >> The configure script looks for

Re: [PATCH 0/5] Remove DRI1

On 8 December 2015 at 22:58, Connor Behan wrote: > On 08/12/15 05:41 PM, Adam Jackson wrote: >> DRI1 hasn't really been a supported option for a while now, Mesa hasn't >> supplied any drivers for it in years, and the design really isn't >> compatible with KMS-like drivers.

Re: [PATCH 5/5] dix: Remove the remains of DRI1

On 8 December 2015 at 22:41, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- a/test/Makefile.am > +++ b/test/Makefile.am > @@ -64,10 +64,6 @@ CLEANFILES = sdksyms.c > sdksyms.c: $(top_builddir)/hw/xfree86/sdksyms.c > $(AM_V_GEN)$(LN_S)

Re: [PATCH xserver v2.1] os: Treat ssh as a non-local client (v2)

On 11 December 2015 at 10:20, Martin Peres wrote: > On 11/12/15 11:30, Michel Dänzer wrote: >> >> On 11.12.2015 18:17, Martin Peres wrote: >>> >>> On 11/12/15 04:34, Michel Dänzer wrote: From: Adam Jackson By the time we get to

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

On 9 December 2015 at 23:12, Keith Packard wrote: > --- a/dix/main.c > +++ b/dix/main.c > @@ -121,12 +121,9 @@ Equipment Corporation. > extern void Dispatch(void); > > #ifdef XQUARTZ > -#include > - > -BOOL serverRunning = FALSE; > +Bool serverRunning; Deliberate change ?

Cygwin and upstream (Was: Re: [PATCH xserver v2.1] os: Treat ssh as a non-local client (v2))

On 11 December 2015 at 15:47, Jon Turney <jon.tur...@dronecode.org.uk> wrote: > On 11/12/2015 10:31, Emil Velikov wrote: >> There's no (intentional) MSVC or mingw support in xserver that I know >> of - only Cygwin. There is also the GNU version of the function >> (#de

Re: Direct hardware bashing modules (int10 et al) and recent hardware

On 19 November 2015 at 15:06, Adam Jackson <a...@nwnk.net> wrote: > On Thu, 2015-11-19 at 12:07 +0000, Emil Velikov wrote: > >> It seems that most of the use-cases are related to the int10 module. >> To make things even more interesting - when using the Sun/Oracle >

Direct hardware bashing modules (int10 et al) and recent hardware

Hi all, Inspired by a comment about using inline assembly in xserver, I did a quick through the codebase. It seems that most of the use-cases are related to the int10 module. To make things even more interesting - when using the Sun/Oracle compiler many additional functions will end up exported

Re: [PATCHv3] build: Fix systemd-daemon compile/linker flags

On 22 November 2015 at 23:37, Peter Hutterer wrote: > On Thu, Nov 19, 2015 at 04:04:30PM +0200, Jussi Kukkonen wrote: >> * Dont add systemd to REQUIRED_LIBS (this lead to build failure when >> libsystemd is available but libsystemd-daemon is not) >> * Only use systemd

  1   2   3   4   5   6   >