(haven't touched that part of the code for multiple months), you
can also have a ...
Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
Acked-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
... from me. I was suffering the same problems and was just about to
spend my weekend on hunting
-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076
On Apr 27, 2011, at 5:12 PM, Ian Pilcher wrote:
On 04/27/2011 10:00 AM, Mario Kleiner wrote:
Original thread was this, between Michel and Keith:
http://lists.x.org/archives/xorg-devel/2011-March/020716.html
The refined patch of Keith that needs testing:
http://www.mail-archive.com/xorg
On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote:
On Thu, 28 Apr 2011 13:27:18 -0700
Jesse Barnes jbar...@virtuousgeek.org wrote:
I obviously failed to count the swap event structure size after
adding
and removing fields a few times, and didn't even account for
padding. The
end result is
On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote:
On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote:
On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote:
I came to the conclusion that the xserver DRI2 invalidate patches
that
have been discussed aren't really fixing the problem.
On May 5, 2011, at 6:06 PM, Ville Syrjälä wrote:
On Thu, May 05, 2011 at 05:09:56PM +0200, Mario Kleiner wrote:
On May 5, 2011, at 4:23 PM, Ville Syrjälä wrote:
On Thu, May 05, 2011 at 11:46:45AM +0200, Michel Dänzer wrote:
On Mit, 2011-05-04 at 23:51 +0300, Ville Syrjala wrote:
I came
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
e-mail: mario.klei
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
*
Mario Kleiner
Max Planck Institute for Biological
On Oct 7, 2010, at 10:06 AM, Pauli Nieminen wrote:
On 07/10/10 00:42 +0200, ext Mario Kleiner wrote:
On Oct 6, 2010, at 1:05 PM, Pauli Nieminen wrote:
DDX driver may implement schedule swap without GetMSC. In that
case we
can't call GetMSC in DRI2SwapBuffers.
I don't think this check
You can add a...
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
to your patch if you like. As far as i can see, such a driver would
be limited to simple glXSwapBuffers() calls though if it doesn't
know its own
Oops, of course i meant a
Reviewed-by: Mario Kleiner
, not the windowed case.
thanks,
-mario
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
e-mail: mario.klei...@tuebingen.mpg.de
office: +49 (0)7071/601-1623
fax:+49 (0)7071/601-616
On Oct 25, 2010, at 6:52 PM, Jesse Barnes wrote:
On Mon, 25 Oct 2010 17:13:58 +0300
Pauli Nieminen ext-pauli.niemi...@nokia.com wrote:
There isn't API that allows application atomically query for msc
changes
and schedule swaps. If msc changes dramatically between query and
scheduling
be
unblocked and which are valid calls again?
Ideas?
Thanks again for all your work on this. These are good improvements.
Indeed!
-mario
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
On Oct 28, 2010, at 6:10 PM, Pauli Nieminen wrote:
I think we should have some way for the drivers to back out of this
gracefully or at least cover their tails. E.g., allow the ddx to set
a hard upper limit for the swap_limit, in a new field max_swap_limit.
Your patch could make sure that
On Oct 28, 2010, at 6:02 PM, Jesse Barnes wrote:
On Thu, 28 Oct 2010 18:47:09 +0300
Pauli Nieminen ext-pauli.niemi...@nokia.com wrote:
Most of what you have in (b) is pretty straightfoward; even the
shared
drawable case shouldn't be too bad, since each X connection could
have
bits
The whole patch series looks now good to me. For all of them:
Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
thanks,
-mario
On Nov 1, 2010, at 3:22 PM, Pauli Nieminen wrote:
DDX can now implement validation for swap_limit changes to prevent
configurations that are not support
On 11/19/2010 07:52 PM, Adam Jackson wrote:
Never implemented in any open source driver. The implementation
assumed explicit DDX driver knowledge of how the client-side driver
worked, since at the time the server's GL renderer was not a DRI driver.
But now, it is, so any implementation of these
On 12/08/2010 05:15 PM, Pauli Nieminen wrote:
On 08/12/10 16:55 +0100, ext Alex Deucher wrote:
One other thing that might be worth adding to DRI2 is a way for the
driver to access the swap interval. If we could, then the driver
could dynamically disable things like vline waits for buffer
On Dec 13, 2010, at 11:21 AM, Michel Dänzer wrote:
On Mon, 2010-12-13 at 11:35 +0200, Pauli Nieminen wrote:
On 12/12/10 19:49 -0500, ext Jerome Glisse wrote:
On Fri, Dec 10, 2010 at 9:40 AM, Mario Kleiner
mario.klei...@tuebingen.mpg.de wrote:
On 12/08/2010 05:15 PM, Pauli Nieminen wrote
On Dec 10, 2010, at 8:00 PM, Jesse Barnes wrote:
On Fri, 10 Dec 2010 15:40:38 +0100
Mario Kleiner mario.klei...@tuebingen.mpg.de wrote:
It schedules an immediate copy-swap via blitting. Unfortunately
the ddx
doesn't know about the swap_interval, so it still synchronizes the
execution
scheduling a wait due to sbc = target_sbc.
Now if function doesn't schedule a wait, but returns immediately,
it returns the (ust,msc,sbc) of the most recently completed swap,
i.e., the UST and MSC corresponding to the time when the returned
current SBC was reached.
Signed-off-by: Mario Kleiner mario.klei
The following series of 3 patches contains some bug fixes and adds some
missing functionality to the new DRI2 2.2 protocol requests for
implementation of the SGI_swap_interval and OML_sync_control GLX
extensions.
Jesse Barnes already had a positive look at these patches, but i couldn't test
any
at the patches. Due to lack
of suitable hardware i wasn't able to test any of these, not even if
they compile.
Could somebody please test these and apply them if appropriate?
Thanks,
mario
*
Mario Kleiner
Max Planck Institute
This series of 2 patches fixes issues in the Intel DDX implementation
of I830DRI2ScheduleWaitMSC() and I830DRI2ScheduleSwap().
The previous implementation should mostly work in the simple
glXSwapBuffers() case, although it may reduce the maximum
swaprate to half the video refresh interval, e.g.,
manual adjustments to the returned vbl.reply.sequence number.
This patch adds the needed adjustments.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/i830_dri.c | 110 +++
1 files changed, 70 insertions(+), 40 deletions(-)
diff
Previous code only handled divisor == 0 case correctly. This should
honor a given target_msc for the divisor 0 case and handle the
(msc % divisor) == remainder constraint correctly.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/i830_dri.c | 19 +++
1
://cgit.freedesktop.org/~jbarnes/xf86-video-intel/commit/?
id=dd1930673565e70ec247f7f96ca0bdc575eecfb0
Ideas to fix? I'm a git newbie.
thanks,
-mario
On Mar 4, 2010, at 1:28 AM, Eric Anholt wrote:
On Sun, 21 Feb 2010 18:45:46 +0100, Mario Kleiner
mario.klei...@tuebingen.mpg.de wrote:
This series of 2 patches
.
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
everything to
master. The tree to generate fixes against is
git://git.freedesktop.org/git/xorg/driver/xf86-video-intel.
Jesse
On Thu, 4 Mar 2010 05:24:38 +0100
Mario Kleiner mario.klei...@tuebingen.mpg.de wrote:
They are against Jesse Barnes xf86-video-intel tree:
http://cgit.freedesktop.org
will probably fail to merge and looking at it it seems
that the amount of breakage/merge conflicts to fix will be much
smaller if my patch is applied first, then yours on top of it instead
of the other way round.
-mario
Thanks,
Jesse
On Thu, 4 Mar 2010 19:03:15 +0100
Mario Kleiner mario.klei
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
e-mail: mario.klei...@tuebingen.mpg.de
office: +49 (0)7071/601-1623
fax:+49 (0)7071/601-616
www:http://www.kyb.tuebingen.mpg.de/~kleinerm
;
... accidentally got copied twice into the if () clause, which is not
harmful, but a bit redundant :-)
best,
-mario
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
e
is finished and out there.
-mario
On Mar 7, 2010, at 6:10 PM, Jesse Barnes wrote:
On Sun, 7 Mar 2010 08:44:51 +0100
Mario Kleiner mario.klei...@tuebingen.mpg.de wrote:
On Mar 5, 2010, at 6:50 PM, Jesse Barnes wrote:
Ok pushed fixes for these issues to the repo above. I know
you've put
On Mar 7, 2010, at 6:18 PM, Jesse Barnes wrote:
Arg, I did botch that patch. And of course I only tested the swap
buffers behavior and not OML's WaitMSC so I didn't catch it. I'll
improve the test and push the fix.
No problem. Just fyi: I noticed you added a test in
in bad MSC
values is a good goal though too; I'd definitely be interested in
making that aspect more robust.
--
Jesse Barnes, Intel Open Source Technology Center
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
On Mar 8, 2010, at 6:07 PM, Jesse Barnes wrote:
On Sun, 7 Mar 2010 21:16:21 +0100
Florian Mickler flor...@mickler.org wrote:
On Sun, 7 Mar 2010 09:10:51 -0800
Jesse Barnes jbar...@virtuousgeek.org wrote:
On Sun, 7 Mar 2010 08:44:51 +0100
Mario Kleiner mario.klei...@tuebingen.mpg.de wrote
On Mar 8, 2010, at 8:34 PM, Jesse Barnes wrote:
Ok just pushed these fixes; omlsync seems to do the right thing now
with both waits and swaps.
Sorry to torture you further, almost there ;-) -- the devil is in the
details.
In I830DRI2ScheduleWaitMSC():
At the end, in this if statement...
On Mar 22, 2010, at 11:03 PM, Jesse Barnes wrote:
This is a collection of fixes from my personal server tree
targeting the
1.8 release. They're mostly small fixes, but they fix a few important
(i.e. common) cases with the new protocol code.
Please review; I'll make any necessary changes,
Hi,
here a set of patches against the nouveau-ddx. This is an extended and
revised set, based on Francisco Jerez feedback from autumn last year.
[1/9] Makes pageflipping work again on X-Server 1.12rc. It apparently stopped
working somewhere around Xorg 1.11+.
[2/9] Implements handling of
can_exchange() fails on at least Xorg 1.12+. This fixes
it in the same way it was fixed in the ati intel ddx.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/nouveau_dri2.c b/src
of the crtc whose vblank event initially
triggered the swap is used, but handler waits for flip
completion on all involved crtc's before completing the
swap and releasing the old framebuffer.
This code is almost identical to the code used in the
ati/radeon ddx and intel ddx.
Signed-off-by: Mario
-buffering on XOrg 1.12+,
1 for double-buffering on older servers, as we can't
change the swap limit there.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
man/nouveau.man| 11 +++
src/nouveau_dri2.c | 29 +++--
src/nv_const.h |2
for the ati/radeon ddx to fix the
same bug there.
See thread at:
http://lists.x.org/archives/xorg-devel/2011-May/021908.html
Fixes FDO bug #35452.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c | 45 ++---
1 files changed, 42
/nouveau/2011-September/009143.html
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c | 23 +--
1 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c
index 8608678..719b3bb 100644
--- a/src
(),
glXGetSyncValuesOML(), glXWaitVideoSyncSGI, ...
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c
index 719b3bb..6a0800c 100644
--- a/src/nouveau_dri2.c
+++ b/src
vblank, at least
if sync to vblank for the compositor is on.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c | 32 +---
1 files changed, 29 insertions(+), 3 deletions(-)
diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c
index
-servers.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
man/nouveau.man|6 +-
src/nouveau_dri2.c | 32 +---
src/nv_driver.c| 11 ++-
3 files changed, 40 insertions(+), 9 deletions(-)
diff --git a/man/nouveau.man b/man/nouveau.man
this throttling is not needed
or done.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c
index f0c7fec..7878a5a 100644
--- a/src
On 02/16/2012 11:04 AM, Michel Dänzer wrote:
On Don, 2012-02-16 at 00:45 +0100, Mario Kleiner wrote:
can_exchange() fails on at least Xorg 1.12+. This fixes
it in the same way it was fixed in the ati intel ddx.
Signed-off-by: Mario Kleinermario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2
On 02/16/2012 10:46 AM, Michel Dänzer wrote:
On Don, 2012-02-16 at 00:45 +0100, Mario Kleiner wrote:
If a swaplimit 1 is set on a server which
supports the swaplimit api (XOrg 1.12.0+),
the following can happen:
1. Client calls glXSwapBuffersMscOML() with a
swap target 1 vblank
to benchmark how fast the whole
rendering loop could go in the best case, so i want it to tear. Same
for benchmarks.
Other than that
Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
thanks,
-mario
*
Mario Kleiner
Max Planck
On 02/20/2012 11:27 AM, Michel Dänzer wrote:
On Mon, 2012-02-20 at 05:59 +0100, Mario Kleiner wrote:
On 02/16/2012 11:04 AM, Michel Dänzer wrote:
On Don, 2012-02-16 at 00:45 +0100, Mario Kleiner wrote:
can_exchange() fails on at least Xorg 1.12+. This fixes
it in the same way it was fixed
.
Tested for screen DefaultDepth 24 and also 30 bits
(for RGB10 framebuffers) on NV-50.
The problem was fixed in the same way in the ati intel ddx.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
, so not useful in
practice.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
src/nouveau_dri2.c | 57 +++-
1 files changed, 34 insertions(+), 23 deletions(-)
diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c
index 7878a5a..eb008c9
On 02/29/2012 08:17 AM, Ben Skeggs wrote:
On Thu, 2012-02-16 at 00:45 +0100, Mario Kleiner wrote:
Hi,
Hey Mario,
What's your plan with this patchset? Do you intend on taking Michel's
comments into account?
CC'ing Francisco as he had some comments on IRC. I'd like to get this
all sorted
On Mar 1, 2012, at 9:37 PM, Daniel Stone wrote:
Hi,
On 1 March 2012 18:11, Mario Kleiner
mario.klei...@tuebingen.mpg.de wrote:
can_exchange() returns false and thereby prevents page
flipping on some drawables where page flipping would
work fine. This due to non-matching drawable depths
.
This patch fixes the problem by implementing DRI2WaitSBC similar
to the clean and proven DRI2WaitMSC implementation.
Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de
---
hw/xfree86/dri2/dri2.c| 10 --
hw/xfree86/dri2/dri2.h|3 +--
hw/xfree86/dri2/dri2ext.c | 16
Hi
This patch fixes a hang in glXSwapBuffers if a user moves
a drawable from a fast running crtc, e.g., 60 Hz to a slower
running crtc, e.g., 50 Hz, when using the new DRI2 sync swap bits.
It should fix Bugzilla bug #28383.
https://bugs.freedesktop.org/show_bug.cgi?id=28383
I've tested this
the baseline for scheduling the next swap.
If a movement between crtc's is not taken into account, the swap may
schedule for a vblank count on the new crtc far in the future, resulting
in a apparent hang of the drawable for a long time.
Fixes Bugzilla bug #28383.
Signed-off-by: Mario Kleiner mario.klei
of different refresh rate.
It would be good to apply it to 1.9 and 1.8.2 if possible, for a more
enjoyable multi-display OpenGL experience.
thanks,
-mario
On Jun 14, 2010, at 6:13 PM, Jesse Barnes wrote:
On Sun, 13 Jun 2010 18:05:26 +0200
Mario Kleiner mario.klei...@tuebingen.mpg.de wrote
could ignore
IgnoreClient and solve the multi-threading / multiple drawable issues
i believe exist.
-mario
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
e-mail
On Jun 29, 2010, at 2:24 AM, Keith Packard wrote:
On Tue, 29 Jun 2010 02:18:31 +0200, Mario Kleiner
mario.klei...@tuebingen.mpg.de wrote:
What i assume but didn't check is that xlib doesn't have a problem
with getting replies out of sequence
The X protocol is purely sequential -- you
On Jul 2, 2010, at 11:43 PM, Jesse Barnes wrote:
On Tue, 29 Jun 2010 04:07:48 +0200
Mario Kleiner mario.klei...@tuebingen.mpg.de wrote:
...
Then i think the idea of multiple wait queues doesn't allow to get
rid of IgnoreClient(), but we will still need those wait queues in
addition
displays. If such a virtualized
counter wouldn't be very accurate or if the associated ust timestamps
wouldn't be very accurate, i'd be in trouble and the OML_sync_control
extension would lose most of its value to me.
*
Mario
On Jul 9, 2010, at 3:20 PM, Pauli Nieminen wrote:
But actual patch has two problems. First, GetMSC is not NULL checked
before calling it. This causes crash with driver that is using
flipping without OML_sync_control. Second, same freeze would happen
I avoided a ds-GetMSC() NULL check because
On Jul 9, 2010, at 6:15 PM, Michel Dänzer wrote:
[...]
For the old intel DRI1 swap scheduling hack, I solved this by
making the
MSC not correspond to any specific CRTC counter directly but making
it a
'virtual' counter which increases at the same rate as the CRTC the
window is currently being
/lib/octave-3.2.3/liboctinterp.so
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany
e-mail: mario.klei...@tuebingen.mpg.de
office: +49 (0)7071/601-1623
fax:+49 (0)7071/601
Hello everybody
My name is Mario Kleiner and i'm new to this list, so i apologize
beforehand should i violate some rules of netiquette, state the
totally obvious, or if this post is somehow considered off-topic or
way too long. Please tell me if so, and how to do better next time.
First
for UST being the time of
start of scanout of the first scanline of a new video frame, instead
of start of vblank.
Let me know what you think about this,
-mario
*
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Hi,
i finally figured out why dri3/present failed so miserably with my
neuro-science application, which relies on OML_sync_control and
INTEL_swap_events extensively and worked nicely under dri2 for years.
I found so far two bugs in the x-server and 3 bugs in mesas
dri/present backend. I'll send
quite a bit more
easy.
Please also cherry-pick this for a 1.16.x stable update.
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
present/present.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/present/present.c b/present/present.c
index cf283f4..d84bdef
fixes the problem, as tested on top of XOrg 1.16.2
on nouveau and intel.
Please also apply to XOrg 1.16 stable.
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
present/present.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/present/present.c b/present
On 03.07.2012, at 16:22, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This adds the initial prime support for dri2 offload. The main thing is
when we get a connection from a prime client, we stored the information
and mark all drawables from that client as prime. We then create
On 03.07.2012, at 20:47, Dave Airlie wrote:
On Tue, Jul 3, 2012 at 7:39 PM, Mario Kleiner
mario.klei...@tuebingen.mpg.de wrote:
On 03.07.2012, at 16:22, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This adds the initial prime support for dri2 offload. The main thing is
when
On 02/20/2013 09:27 PM, Keith Packard wrote:
Chris Wilson ch...@chris-wilson.co.uk writes:
What I don't see here is how the client instructs the server to
handle a missed swap.
Right, this first pass was just trying to replicate the DRI2 semantics;
figuring out how to improve those seems like
Restores proper immediate tearing swap behaviour for
OpenGL bufferswap under DRI3/Present.
Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
src/glx/dri3_glx.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src
on this not regressing under DRI3/Present,
e.g., Neuro-Science software like Psychtoolbox-3.
This patch fixes the problem.
Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
src/glx/dri3_glx.c | 11 +++
src/glx/dri3_priv.h | 5 -
2 files
one. I'll send it out after giving it some testing.
thanks,
-mario
On 25/11/2014 04:00, Mario Kleiner wrote :
Restores proper immediate tearing swap behaviour for
OpenGL bufferswap under DRI3/Present.
Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org
Signed-off-by: Mario Kleiner mario.kleiner
...
thanks,
-mario
On 25/11/14 03:00, Mario Kleiner wrote:
Restores proper immediate tearing swap behaviour for
OpenGL bufferswap under DRI3/Present.
Cc: 10.3 10.4 mesa-sta...@lists.freedesktop.org
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
src/glx/dri3_glx.c | 6 +-
1 file
and XOrg 1.16.2 stable.
Applying on top of XOrg 1.16.2 may require cherry-picking
commit 2051514652481a83bd7cf22e57cb0fcd40333f33
which trivially fixes lack of support for protocol option
PresentOptionCopy - get two bug fixes for the price of one!
Signed-off-by: Mario Kleiner mario.kleiner
quite a bit more
easy.
Please also cherry-pick this for a 1.16.x stable update.
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
present/present.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/present/present.c b/present/present.c
index ac9047e..e5d3fd5
Hi,
an updated set of patches to fix the bugs i found in the
xserver dri3/present implementation and one bug in intel-ddx
uxa/dri3/present implementation. Axel Davys comments made me
rethink my original xserver patch and the new solution is
simple and better and afaics how this was actually
Make sure we reject async flips if we don't support
async flips.
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
src/uxa/intel_present.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/uxa/intel_present.c b/src/uxa/intel_present.c
index d20043f..d2aa9ee 100644
--- a/src
this is the minimal fix to cover all cases.
Thoughts? Keith, maybe an opinion if my story here is correct?
thanks,
-mario
Axel Davy
On 02/12/2014 20:08, Mario Kleiner wrote :
Pageflips for Pixmap presents were not synchronized to vblank on
drivers with support for PresentCapabilityAsync, due to some
On 12/05/2014 12:56 AM, Eric Anholt wrote:
Mario Kleiner mario.kleiner...@gmail.com writes:
Pageflips for Pixmap presents were not synchronized to vblank on
drivers with support for PresentCapabilityAsync, due to some
missing init for vblank-sync_flips. The PresentOptionAsync
flag
quite a bit more
easy.
Please also cherry-pick this for a 1.16.x stable update.
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
Reviewed-by: Eric Anholt e...@anholt.net
---
present/present.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/present/present.c b
Ok, the final patchset. I made the changes Eric Anholt proposed,
retested, and got them reviewed by him. With those on top of
XServer 1.16.2, DRI3/Present works for me on all drivers and
backends (intel sna, uxa and nouveau exa, glamor), single and
dual-display fullscreen and windowed,
() function.
Fixes fdo bug #84744 on older kernels.
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
---
src/sna/sna_display.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c
index 163..a7ad6cc 100644
--- a/src
On 12/15/2014 06:46 AM, Keith Packard wrote:
Mario Kleiner mario.kleiner...@gmail.com writes:
Restores proper immediate tearing swap behaviour for
OpenGL bufferswap under DRI3/Present.
Hrm. I'd love for this to be controlled by the GLX_EXT_swap_control_tear
extension, but that one uses
On 12/16/2014 09:23 AM, Keith Packard wrote:
Mario Kleiner mario.kleiner...@gmail.com writes:
The 0 case is good for benchmarking.
Sure, but the current code does benchmarking just fine. In fact, because
it doesn't copy queued frames that aren't the most recent before the
vblank, benchmarks
On 12/17/2014 04:17 AM, Keith Packard wrote:
Mario Kleiner mario.kleiner...@gmail.com writes:
Hmm. For benchmarking i think i'd consider that a mild form of cheating.
You get higher fps because you skip processing like the whole gpu blit
overhead and host processing overhead for queuing
On 12/17/2014 05:49 AM, Keith Packard wrote:
Mario Kleiner mario.kleiner...@gmail.com writes:
It's just that i need access to both, the old behaviour i described, and
the new drop frame behaviour, and i need a way to select what i want
at runtime via api without the need for easily overwhelmed
flip, so the FB
would be in use? Not sure though...
Feel free to add a
Reviewed-and-Tested-by: Mario Kleiner mario.kleiner...@gmail.com
for the bits i tested and reviewed if that helps. The other patches in
the series seem to be fine,
thanks,
-mario
+for (i = 0; i config-num_crtc; i
Hi Keith and Owen,
it's a bit too late for XOrg 1.17, but i reviewed and tested
Keith's patchset, after rebasing the 3rd patch on top of 1.17-rc2.
The series has my
Reviewed-and-Tested-by: Mario Kleiner mario.kleiner...@gmail.com
My patch 1/3 is Keith's patch 3/3, just rebased and with my
?)
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
Tested-by: Mario Kleiner mario.kleiner...@gmail.com
---
present/present.c | 90 +--
1 file changed, 68 insertions(+), 22 deletions(-)
diff --git a/present/present.c b/present/present.c
Packard kei...@keithp.com
Reviewed-by: Mario Kleiner mario.kleiner...@gmail.com
v2 (mario): Trivial rebase on top of 1.17.0-rc2
Signed-off-by: Mario Kleiner mario.kleiner...@gmail.com
Tested-by: Mario Kleiner mario.kleiner...@gmail.com
---
present/present.c | 19 ++-
1 file changed
On 04/28/2015 06:31 AM, Kenneth Graunke wrote:
On Tuesday, April 21, 2015 05:58:44 PM Kenneth Graunke wrote:
Based on code by Keith Packard, Eric Anholt, and Jason Ekstrand.
v2:
- Fix double free and flip_count underrun (caught by Mario Kleiner).
- Don't leak flip_vblank_event on the error_out
,
NULL,
NULL, NULL,
- PresentOptionAsync,
+ divisor == 0 ? PresentOptionAsync : 0,
target_msc, divisor, remainder, NULL, 0);
}
Reviewed-by: Mario Kleiner mario.kleiner
-and-tested-by: Mario Kleiner mario.kleiner...@gmail.com
-mario
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
good to me, also no problems during testing on top of
current master, so
Reviewed-and-tested-by: Mario Kleiner mario.kleiner...@gmail.com
-mario
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
1 - 100 of 184 matches
Mail list logo
