Re: [PATCH] remove dead code in dummy driver

2016-10-01 Thread Bob Terek
On 09/27/2016 12:22 AM, Antoine Martin wrote: It think it probably makes sense to apply the cleanup patches first, to remove code before adding some more? I had planned to send them all at once, but you're right, it is a good idea to get the cleanups in separately. My problem has been

Re: [PATCH] remove dead code in dummy driver

2016-09-27 Thread Antoine Martin
On 24/09/16 00:20, Aaron Plattner wrote: > On 09/22/2016 04:30 PM, Bob Terek wrote: >> On 09/21/2016 10:22 AM, Aaron Plattner wrote: >>> On 09/20/2016 02:07 AM, Eric Engestrom wrote: On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: > Signed-off-by: Antoine Martin

Re: [PATCH] remove dead code in dummy driver

2016-09-27 Thread Antoine Martin
On 25/09/16 18:52, Bob Terek wrote: > > On 09/23/2016 07:20 AM, Aaron Plattner wrote: > >> On 09/22/2016 04:30 PM, Bob Terek wrote: > >>> Shouldn't the first 5 of Aaron's patches be applied, since they are all >>> cleanup items? >>> >>>

Re: [PATCH] remove dead code in dummy driver

2016-09-25 Thread Bob Terek
On 09/23/2016 07:20 AM, Aaron Plattner wrote: On 09/22/2016 04:30 PM, Bob Terek wrote: Shouldn't the first 5 of Aaron's patches be applied, since they are all cleanup items? https://lists.x.org/archives/xorg-devel/2015-January/045395.html I never pushed them because they were never

Re: [PATCH] remove dead code in dummy driver

2016-09-23 Thread Aaron Plattner
On 09/22/2016 04:30 PM, Bob Terek wrote: > On 09/21/2016 10:22 AM, Aaron Plattner wrote: >> On 09/20/2016 02:07 AM, Eric Engestrom wrote: >>> On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: Signed-off-by: Antoine Martin >>> >>> Reviewed-by: Eric

Re: [PATCH] remove dead code in dummy driver

2016-09-22 Thread Bob Terek
On 09/21/2016 10:22 AM, Aaron Plattner wrote: On 09/20/2016 02:07 AM, Eric Engestrom wrote: On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: Signed-off-by: Antoine Martin Reviewed-by: Eric Engestrom Looks good to me too

Re: [PATCH] remove dead code in dummy driver

2016-09-22 Thread Antoine Martin
On 22/09/16 03:22, Aaron Plattner wrote: > On 09/20/2016 02:07 AM, Eric Engestrom wrote: >> On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: >>> Signed-off-by: Antoine Martin >> >> Reviewed-by: Eric Engestrom > > Looks good to me

Re: [PATCH] remove dead code in dummy driver

2016-09-21 Thread Aaron Plattner
On 09/20/2016 02:07 AM, Eric Engestrom wrote: > On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: >> Signed-off-by: Antoine Martin > > Reviewed-by: Eric Engestrom Looks good to me too (although I'm cheating since this chunk is

Re: [PATCH] remove dead code in dummy driver

2016-09-20 Thread Eric Engestrom
On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: > Signed-off-by: Antoine Martin Reviewed-by: Eric Engestrom > --- > src/dummy_driver.c | 19 --- > 1 file changed, 19 deletions(-) > > diff --git

[PATCH] remove dead code in dummy driver

2016-09-20 Thread Antoine Martin
Signed-off-by: Antoine Martin --- src/dummy_driver.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/dummy_driver.c b/src/dummy_driver.c index c84000f..ec1acf3 100644 --- a/src/dummy_driver.c +++ b/src/dummy_driver.c @@ -700,25 +700,6 @@