Re: [DISCUSS] Developing features in branches

2015-05-08 Thread Steve Loughran
On 6 May 2015, at 17:50, Vinod Kumar Vavilapalli vino...@hortonworks.com wrote: +1 for the idea in general. We definitely need design discussion and consensus upfront, lest branches turn into dumping grounds and people complaining about why their branches (instead of patches) do not

Re: [DISCUSS] Developing features in branches

2015-05-06 Thread Vinod Kumar Vavilapalli
is beneficial. That's the way I would think about it. -Original Message- From: Chris Nauroth [mailto:cnaur...@hortonworks.com] Sent: Thursday, April 30, 2015 3:46 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches In HDFS, our recent feature

Re: [DISCUSS] Developing features in branches

2015-05-01 Thread Chris Nauroth
think about it. -Original Message- From: Chris Nauroth [mailto:cnaur...@hortonworks.com] Sent: Thursday, April 30, 2015 3:46 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches In HDFS, our recent feature branches tried to keep large portions

Re: [DISCUSS] Developing features in branches

2015-05-01 Thread Steve Loughran
think about it. -Original Message- From: Chris Nauroth [mailto:cnaur...@hortonworks.com] Sent: Thursday, April 30, 2015 3:46 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches In HDFS, our recent feature branches tried to keep large portions

Re: [DISCUSS] Developing features in branches

2015-04-30 Thread Karthik Kambatla
-preserving restart could have been merged first. Thanks, Zhijie From: Subramaniam V K subru...@gmail.com Sent: Wednesday, April 29, 2015 7:16 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches Karthik, thanks

RE: [DISCUSS] Developing features in branches

2015-04-30 Thread Bikas Saha
Subject: Re: [DISCUSS] Developing features in branches My 2 cents: Branch maintenance cost should be fine if we have few features to be developed in branches. However, if there're too many, each other branch may be blind to most of latest code change from others, and trunk/branch-2 becomes stale

Re: [DISCUSS] Developing features in branches

2015-04-30 Thread Karthik Kambatla
consumption, would could merge in milestones. Bikas -Original Message- From: Zhijie Shen [mailto:zs...@hortonworks.com] Sent: Wednesday, April 29, 2015 9:43 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches My 2 cents: Branch maintenance cost

Re: [DISCUSS] Developing features in branches

2015-04-30 Thread Ray Chiang
not be a good idea to hold a feature in the branch too long before merging it back. Thanks, Zhijie From: Subramaniam V K subru...@gmail.com Sent: Wednesday, April 29, 2015 7:16 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features

RE: [DISCUSS] Developing features in branches

2015-04-30 Thread Bikas Saha
, April 30, 2015 10:35 AM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches Following up on Zhijie's comments, there's nothing to prevent periodically pulling updates from the main branch (e.g. branch-2 or trunk) into the feature branch, is there? Or cherry

RE: [DISCUSS] Developing features in branches

2015-04-30 Thread Bikas Saha
...@hortonworks.com] Sent: Thursday, April 30, 2015 3:46 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches In HDFS, our recent feature branches tried to keep large portions of their new code in new classes (i.e

Re: [DISCUSS] Developing features in branches

2015-04-30 Thread Karthik Kambatla
- not just in code but also in semantics. Bikas -Original Message- From: Ray Chiang [mailto:rchi...@cloudera.com] Sent: Thursday, April 30, 2015 10:35 AM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches Following up on Zhijie's comments

Re: [DISCUSS] Developing features in branches

2015-04-30 Thread Chris Nauroth
Saha bi...@hortonworks.com Sent: Thursday, April 30, 2015 12:52 PM To: yarn-dev@hadoop.apache.org Subject: RE: [DISCUSS] Developing features in branches I think what Zhijie is talking about is a little different. Work happening in parallel across 2 branches have no clue about each other since

Re: [DISCUSS] Developing features in branches

2015-04-30 Thread Zhijie Shen
] Sent: Thursday, April 30, 2015 10:35 AM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches Following up on Zhijie's comments, there's nothing to prevent periodically pulling updates from the main branch (e.g. branch-2 or trunk) into the feature branch

Re: [DISCUSS] Developing features in branches

2015-04-29 Thread Subramaniam V K
Karthik, thanks for starting the thread. Here's my $0.02 based on the experience of working on a feature branch while adding reservations (YARN-1051). Overall a +1 for the approach. The couple of pain points we faced were: 1) Merge cost with trunk 2) Lack of CI in the feature branch The

Re: [DISCUSS] Developing features in branches

2015-04-29 Thread Zhijie Shen
From: Subramaniam V K subru...@gmail.com Sent: Wednesday, April 29, 2015 7:16 PM To: yarn-dev@hadoop.apache.org Subject: Re: [DISCUSS] Developing features in branches Karthik, thanks for starting the thread. Here's my $0.02 based on the experience of working on a feature

Re: [DISCUSS] Developing features in branches

2015-04-28 Thread Sangjin Lee
Ah, I missed that part (obviously). Fantastic! On Tue, Apr 28, 2015 at 5:31 PM, Sean Busbey bus...@cloudera.com wrote: On Apr 28, 2015 5:59 PM, Sangjin Lee sjl...@gmail.com wrote: That said, in a way we're deferring the cost of cleaning things up towards the end of the branch. For

[DISCUSS] Developing features in branches

2015-04-28 Thread Karthik Kambatla
Hi Yarn devs, I wanted to hear your thoughts on moving to a model where we develop ALL features in branches. I see the following pros/cons of this approach: Pros: 1. A feature gets included in a release only after it is in a usable state - security etc. included. e.g. SharedCache has been