[
https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323865#comment-15323865
]
Li Lu commented on YARN-5170:
-
Thanks [~jrottinghuis]! Last patch LGTM. +1 pending Jenkins. Please feel free
[
https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323633#comment-15323633
]
Li Lu commented on YARN-5170:
-
Ah that's fine. Let's not expose it in the milestone then. Let's open another
[
https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323601#comment-15323601
]
Li Lu commented on YARN-5170:
-
Thanks for the work [~jrottinghuis]! This is a big one and generally LGTM. I
[
https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323496#comment-15323496
]
Li Lu commented on YARN-5170:
-
Thanks [~jrottinghuis] and [~varun_saxena] for the work! I'll take a look at it
[
https://issues.apache.org/jira/browse/YARN-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322995#comment-15322995
]
Li Lu commented on YARN-5052:
-
Per ATS weekly discussion, let's review this one and make it land before other
[
https://issues.apache.org/jira/browse/YARN-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322955#comment-15322955
]
Li Lu commented on YARN-5174:
-
bq. some documentation on the entity model
Right now I do have some writeups
[
https://issues.apache.org/jira/browse/YARN-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321744#comment-15321744
]
Li Lu commented on YARN-5210:
-
Hmm, just realized we're closing the branch for now. I'll make sure this commit
[
https://issues.apache.org/jira/browse/YARN-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321314#comment-15321314
]
Li Lu commented on YARN-5210:
-
Thanks [~varun_saxena]! Patch LGTM, will commit later today if no other
[
https://issues.apache.org/jira/browse/YARN-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319277#comment-15319277
]
Li Lu commented on YARN-5210:
-
LGTM. Did we miss this in TestDistributedShell all the time?
> NPE in
[
https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315096#comment-15315096
]
Li Lu commented on YARN-5189:
-
Will commit the latest patch shortly.
> Make HBaseTimeline[Reader|Writer]Impl
[
https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314480#comment-15314480
]
Li Lu commented on YARN-5189:
-
Thanks [~sjlee0]! I'll commit later today if no other concerns raised.
> Make
[
https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314438#comment-15314438
]
Li Lu commented on YARN-5189:
-
bq. The necessary config parameters that need to be set are slightly different
[
https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313351#comment-15313351
]
Li Lu commented on YARN-5189:
-
Thanks for the work [~jrottinghuis] and [~sjlee0]! I took a look at the most
[
https://issues.apache.org/jira/browse/YARN-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311025#comment-15311025
]
Li Lu commented on YARN-5156:
-
I checked the code and seems like the same code is also in trunk. However, for
[
https://issues.apache.org/jira/browse/YARN-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304942#comment-15304942
]
Li Lu commented on YARN-5111:
-
Thanks [~Naganarasimha]! I tried the patch and I can see from the posted
[
https://issues.apache.org/jira/browse/YARN-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304844#comment-15304844
]
Li Lu commented on YARN-5169:
-
Thanks [~sjlee0]!
bq. Are event timestamps for consumption by the timeline
[
https://issues.apache.org/jira/browse/YARN-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304555#comment-15304555
]
Li Lu edited comment on YARN-5169 at 5/27/16 6:51 PM:
--
Thanks [~sjlee0] for raising
[
https://issues.apache.org/jira/browse/YARN-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304555#comment-15304555
]
Li Lu commented on YARN-5169:
-
Thanks [~sjlee0] for raising this issue! I noticed that in RM's
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302788#comment-15302788
]
Li Lu commented on YARN-5138:
-
I tried mvn findbugs:findbugs locally and it looks fine. Can someone else try
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu resolved YARN-5138.
-
Resolution: Fixed
> fix "no findbugs output file" error for
> hadoop-yarn-server-timelineservice-hbase-tests
>
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu reopened YARN-5138:
-
Not sure why it shows cannot reproduce.
> fix "no findbugs output file" error for
>
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302617#comment-15302617
]
Li Lu commented on YARN-5138:
-
OK, now fixed it.
> fix "no findbugs output file" error for
>
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302603#comment-15302603
]
Li Lu commented on YARN-5138:
-
+1 will commit shortly.
> fix "no findbugs output file" error for
>
[
https://issues.apache.org/jira/browse/YARN-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301393#comment-15301393
]
Li Lu commented on YARN-5111:
-
I think I forgot this part in the original patch... My bad.
{code}
/**
*
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5094:
Attachment: YARN-5094-YARN-2928.001.patch
First draft to resolve the problem. Note that I still decide to put
Li Lu created YARN-5156:
---
Summary: YARN_CONTAINER_FINISHED of YARN_CONTAINERs will always
have running state
Key: YARN-5156
URL: https://issues.apache.org/jira/browse/YARN-5156
Project: Hadoop YARN
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300873#comment-15300873
]
Li Lu commented on YARN-5138:
-
Let me kick Jenkins for you...
> fix "no findbugs output file" error for
>
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Attachment: YARN-4987-trunk.004.patch
Sorry I uploaded a wrong patch... This is the right one...
> Read cache
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Attachment: (was: YARN-4987-trunk.004.patch)
> Read cache concurrency issue between read and evict in
[
https://issues.apache.org/jira/browse/YARN-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299020#comment-15299020
]
Li Lu commented on YARN-5138:
-
LGTM. +1 pending Jenkins.
BTW, there are a lot of warnings and we may want to
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Attachment: YARN-4987-trunk.004.patch
Thanks [~djp]! The factor to enforce cache item release is more of an
[
https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298895#comment-15298895
]
Li Lu commented on YARN-5097:
-
bq. But do we want to enable findbugs for tests ?
I think it's much easier to
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298625#comment-15298625
]
Li Lu commented on YARN-5018:
-
Yes. I believe they're unrelated.
> Online aggregation logic should not run
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298605#comment-15298605
]
Li Lu commented on YARN-5018:
-
Right. Potentially this might be a problem since we may "lose control" to some
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298585#comment-15298585
]
Li Lu commented on YARN-5018:
-
YARN-4478 appears to be an umbrella, and I think at least YARN-4318 is
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298548#comment-15298548
]
Li Lu commented on YARN-5018:
-
Seems like we didn't apply the fixes to those UT failures happen in trunk?
>
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5018:
Attachment: YARN-5018-YARN-2928.005.patch
New patch to address [~sjlee0]'s comments.
> Online aggregation logic
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297449#comment-15297449
]
Li Lu commented on YARN-5018:
-
Thanks [~sjlee0]! That looks fine. I can hide the logic of collector.postPut
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297397#comment-15297397
]
Li Lu commented on YARN-5018:
-
The current situation is a little bit nasty... In the original version we
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296707#comment-15296707
]
Li Lu commented on YARN-5094:
-
bq. We can either populate the timestamp in
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294486#comment-15294486
]
Li Lu commented on YARN-5094:
-
OK, seems like we missed something here: We use the incoming container event's
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5018:
Attachment: YARN-5018-YARN-2928.004.patch
Fix the findbugs warnings. Sorry that was a real bug...
> Online
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5018:
Attachment: YARN-5018-YARN-2928.003.patch
New patch to add checks in
[
https://issues.apache.org/jira/browse/YARN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294173#comment-15294173
]
Li Lu commented on YARN-5097:
-
Seems like we're not generating findbugs files for the newly added module?
>
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293864#comment-15293864
]
Li Lu commented on YARN-5018:
-
Yes I was thinking about the same thing. Let me add some checks (in a
[
https://issues.apache.org/jira/browse/YARN-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292478#comment-15292478
]
Li Lu commented on YARN-5111:
-
Thanks for the info [~sjlee0]! Probably some wire-up issues in the collector
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5018:
Attachment: YARN-5018-YARN-2928.002.patch
New patch applies to the latest YARN-2928 branch.
> Online aggregation
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5018:
Attachment: YARN-5018-YARN-2928.001.patch
OK let me do a first-aid style fix to this problem. The problem occurs
[
https://issues.apache.org/jira/browse/YARN-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292421#comment-15292421
]
Li Lu commented on YARN-5050:
-
Sorry I mean, a +1 from Jenkins... I'm not trying to +1 my own patch...
> Code
[
https://issues.apache.org/jira/browse/YARN-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292416#comment-15292416
]
Li Lu commented on YARN-5111:
-
Here I think I forgot one thing which could be the cause. I forgot to send the
[
https://issues.apache.org/jira/browse/YARN-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292410#comment-15292410
]
Li Lu commented on YARN-5050:
-
+1, finally!
> Code cleanup for TestDistributedShell
>
[
https://issues.apache.org/jira/browse/YARN-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5050:
Attachment: YARN-5050-YARN-2928.002.patch
002 patch to fix the intermittent UT failure. I changed the async
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Attachment: YARN-4987-trunk.003.patch
003 patch addresses checkstyle issues.
> Read cache concurrency issue
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Attachment: YARN-4987-trunk.002.patch
Thanks [~djp] for the review! I addressed your comments in the latest patch.
[
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287551#comment-15287551
]
Li Lu commented on YARN-5018:
-
Agree that we should mark this as a merge blocker. For the missing CPU and
[
https://issues.apache.org/jira/browse/YARN-5102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287374#comment-15287374
]
Li Lu commented on YARN-5102:
-
+1. LGTM. Thanks for the fix!
> timeline service build fails with java 8
>
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286092#comment-15286092
]
Li Lu commented on YARN-5094:
-
Found same issue when working on the UI stuff. Let me take a look at it.
>
[
https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu reassigned YARN-5094:
---
Assignee: Li Lu
> some YARN container events have timestamp of -1 in REST output
>
[
https://issues.apache.org/jira/browse/YARN-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285748#comment-15285748
]
Li Lu commented on YARN-5095:
-
Oh sorry for the confusion, I meant to reply to your specific NPE message on
[
https://issues.apache.org/jira/browse/YARN-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285740#comment-15285740
]
Li Lu commented on YARN-5075:
-
Sure. Once the problem is fixed and Jenkins turns green, I'm fine with
[
https://issues.apache.org/jira/browse/YARN-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285672#comment-15285672
]
Li Lu commented on YARN-5095:
-
Yes I saw the same info in RM log. YARN-5018 will fix this issue.
> flow
[
https://issues.apache.org/jira/browse/YARN-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285628#comment-15285628
]
Li Lu commented on YARN-4412:
-
bq. The checkstyle issues, most of which was caused by indentation errors have
[
https://issues.apache.org/jira/browse/YARN-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285572#comment-15285572
]
Li Lu commented on YARN-4412:
-
Actually there are more things than findbugs that makes jenkins returns -1.
[
https://issues.apache.org/jira/browse/YARN-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4097:
Attachment: YARN-4097-bugfix.patch
OK here's the current patch (applies to branch YARN-3368 which sets up the new
[
https://issues.apache.org/jira/browse/YARN-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284868#comment-15284868
]
Li Lu commented on YARN-4097:
-
Thanks [~Sreenath] for the help! Right now the code is not yet checked in, but
[
https://issues.apache.org/jira/browse/YARN-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283307#comment-15283307
]
Li Lu commented on YARN-4097:
-
I've rebased the POC patch to the latest YARN-3368 branch. While rebasing and
[
https://issues.apache.org/jira/browse/YARN-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4977:
Priority: Critical (was: Major)
> Fix javadocs warnings in yarn-api for jdk 1.8
>
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Attachment: YARN-4987-trunk.001.patch
Upload a patch to add reference counting mechanism to fix the concurrency
[
https://issues.apache.org/jira/browse/YARN-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278638#comment-15278638
]
Li Lu commented on YARN-5070:
-
Let me check with some of the HBase/Phoenix folks for their suggestions.
>
[
https://issues.apache.org/jira/browse/YARN-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278517#comment-15278517
]
Li Lu commented on YARN-5070:
-
Thanks [~sjlee0]. I'm fine with upgrading our HBase version. Just a reminder
[
https://issues.apache.org/jira/browse/YARN-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274693#comment-15274693
]
Li Lu commented on YARN-5045:
-
Awesome, thanks! +1 for the latest patch.
> hbase unit tests fail due to
[
https://issues.apache.org/jira/browse/YARN-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274670#comment-15274670
]
Li Lu commented on YARN-5045:
-
Thanks [~sjlee0] for fixing this problem! I checked locally and it works. One
[
https://issues.apache.org/jira/browse/YARN-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273647#comment-15273647
]
Li Lu commented on YARN-5050:
-
Cannot reproduce the test failure locally. The test is only for ATS v1.0 and
[
https://issues.apache.org/jira/browse/YARN-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-5050:
Attachment: YARN-5050-YARN-2928.001.patch
Patch 001 to clean up the code and make sure all UTs pass.
> Code
Li Lu created YARN-5050:
---
Summary: Code cleanup for TestDistributedShell
Key: YARN-5050
URL: https://issues.apache.org/jira/browse/YARN-5050
Project: Hadoop YARN
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/YARN-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4978:
Assignee: Gergely Novák
> The number of javadocs warnings is limited to 100
>
[
https://issues.apache.org/jira/browse/YARN-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269720#comment-15269720
]
Li Lu commented on YARN-4978:
-
Thanks for the work [~GergelyNovak]! I tried the patch locally and we're
[
https://issues.apache.org/jira/browse/YARN-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4851:
Attachment: YARN-4851-trunk.004.patch
Version 004 patch to address [~djp]'s comments. One thing to notice is that I
[
https://issues.apache.org/jira/browse/YARN-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265512#comment-15265512
]
Li Lu commented on YARN-3150:
-
No other concerns raised. Will commit shortly.
> [Documentation] Documenting
Li Lu created YARN-5018:
---
Summary: Online aggregation logic should not run immediately after
collectors got started
Key: YARN-5018
URL: https://issues.apache.org/jira/browse/YARN-5018
Project: Hadoop YARN
[
https://issues.apache.org/jira/browse/YARN-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264531#comment-15264531
]
Li Lu commented on YARN-3150:
-
Thanks [~sjlee0] and [~vrushalic]! Latest patch LGTM. I'll wait about a day to
[
https://issues.apache.org/jira/browse/YARN-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263337#comment-15263337
]
Li Lu commented on YARN-3959:
-
bq. If there is no generic way of doing this, I think we might want to re-word
[
https://issues.apache.org/jira/browse/YARN-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263082#comment-15263082
]
Li Lu commented on YARN-3959:
-
Hi [~varun_saxena], thanks for the prompt work! Some of my comments:
- Are we
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Description: To handle concurrency issues, key value based timeline storage
may return null on reads that are
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Summary: Read cache concurrency issue between read and evict in
EntityGroupFS timeline store (was: EntityGroupFS
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261240#comment-15261240
]
Li Lu commented on YARN-4987:
-
I just notice there is a caching/concurrency bug hidden behind this issue. The
[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4987:
Priority: Critical (was: Minor)
> EntityGroupFS timeline store needs to handle null storage gracefully
>
[
https://issues.apache.org/jira/browse/YARN-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260585#comment-15260585
]
Li Lu commented on YARN-4956:
-
No concerns raised. I'll commit shortly.
> findbug issue on
[
https://issues.apache.org/jira/browse/YARN-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259389#comment-15259389
]
Li Lu commented on YARN-4956:
-
[~aplusplus] yes actually Jenkins turned green after the fix (1 fixed). +1 for
[
https://issues.apache.org/jira/browse/YARN-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259186#comment-15259186
]
Li Lu commented on YARN-4956:
-
Please feel free to assign to yourself if you'd like to work on it. Thanks!
>
[
https://issues.apache.org/jira/browse/YARN-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu reassigned YARN-4956:
---
Assignee: Li Lu
> findbug issue on LevelDBCacheTimelineStore
> --
>
>
[
https://issues.apache.org/jira/browse/YARN-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4851:
Attachment: YARN-4851-trunk.003.patch
Thanks [~hitesh]! I addressed most of the comments except the following items:
[
https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4983:
Attachment: YARN-4983-trunk.003.patch
New patch, removed the wrong exception tag in javadoc. Kicking Jenkins for
[
https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258960#comment-15258960
]
Li Lu commented on YARN-4983:
-
bq. One pedantic little comment: lest we work against YARN-4977, can we please
[
https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258938#comment-15258938
]
Li Lu commented on YARN-4983:
-
I thought [~templedf] uploaded a patch to another JIRA to this one and then
[
https://issues.apache.org/jira/browse/YARN-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257368#comment-15257368
]
Li Lu commented on YARN-3150:
-
Thanks [~sjlee0] for the prompt update! By saying update YARN-2928, I was
[
https://issues.apache.org/jira/browse/YARN-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257177#comment-15257177
]
Li Lu commented on YARN-3150:
-
Thanks [~sjlee0] for the update! Quite close, some comments on the newly added
[
https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257168#comment-15257168
]
Li Lu commented on YARN-4983:
-
Could not reproduce the UT failures locally. At least two UT failures
[
https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256754#comment-15256754
]
Li Lu commented on YARN-4983:
-
Thanks for the review [~djp]! I totally agree that we need to refactor the code
[
https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Li Lu updated YARN-4983:
Attachment: YARN-4983-trunk.002.patch
Added an unit test for the standby metrics. The UT failures in the previous
301 - 400 of 1306 matches
Mail list logo
