[
https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797267#comment-16797267
]
Peter Bacsko commented on YARN-9398:
I'll try to fix this quickly including the warnings.
> Javadoc
[
https://issues.apache.org/jira/browse/YARN-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797175#comment-16797175
]
Peter Bacsko commented on YARN-9356:
+1 (non-binding)
> Add more tests to ratio method in
[
https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797190#comment-16797190
]
Peter Bacsko commented on YARN-9398:
Shall we fix warnings in a separate JIRA?
> Javadoc error on
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797023#comment-16797023
]
Peter Bacsko edited comment on YARN-9267 at 3/20/19 10:32 AM:
--
[~devaraj.k]
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797023#comment-16797023
]
Peter Bacsko commented on YARN-9267:
[~devaraj.k] the reason I introduced the method reference is
[
https://issues.apache.org/jira/browse/YARN-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796143#comment-16796143
]
Peter Bacsko commented on YARN-9358:
Just minor things:
* "fair share for queue" --> I think "fair
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796011#comment-16796011
]
Peter Bacsko commented on YARN-9267:
[~devaraj.k] I think now you can submit the patch.
> General
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795944#comment-16795944
]
Peter Bacsko commented on YARN-9268:
Just as I thought, it fails to apply. It should be good after
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Attachment: YARN-9268-004.patch
> General improvements in FpgaDevice
>
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Attachment: YARN-9267-007.patch
> General improvements in FpgaResourceHandlerImpl
>
[
https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795928#comment-16795928
]
Peter Bacsko commented on YARN-9398:
Thanks [~eyang] for reporting. Will fix these soon.
> Javadoc
[
https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko reassigned YARN-9398:
--
Assignee: Peter Bacsko
> Javadoc error on FPGA related java files
>
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795918#comment-16795918
]
Peter Bacsko commented on YARN-9268:
[~devaraj.k] this patch depends on the previous ones (the same
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795916#comment-16795916
]
Peter Bacsko commented on YARN-9267:
[~devaraj.k] yes there was a commit in the meantime which caused
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Attachment: YARN-9267-006.patch
> General improvements in FpgaResourceHandlerImpl
>
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795068#comment-16795068
]
Peter Bacsko edited comment on YARN-9267 at 3/18/19 2:39 PM:
-
[~devaraj.k]
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795068#comment-16795068
]
Peter Bacsko commented on YARN-9267:
[~devaraj.k] please check patch v6 which should be free of
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Attachment: YARN-9267-005.patch
> General improvements in FpgaResourceHandlerImpl
>
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794947#comment-16794947
]
Peter Bacsko commented on YARN-9267:
[~devaraj.k] thanks for the tip, will check this out.
> General
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Attachment: YARN-9267-004.patch
> General improvements in FpgaResourceHandlerImpl
>
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Summary: General improvements in FpgaDevice (was: Various fixes are needed
in FpgaDevice)
> General
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Summary: General improvements in FpgaResourceHandlerImpl (was: Various
fixes are needed in
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789441#comment-16789441
]
Peter Bacsko commented on YARN-9267:
Thanks [~tangzhankun] - this patch needs a rebase, so don't
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-008.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-009.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787300#comment-16787300
]
Peter Bacsko commented on YARN-9265:
Patch v9: addressed failing unit test, ASF license problem and
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-008.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774338#comment-16774338
]
Peter Bacsko commented on YARN-9322:
+1 lgtm (non-binding)
> Store metrics for custom resource types
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773193#comment-16773193
]
Peter Bacsko commented on YARN-9265:
I made a slight modification in {{FpgaDiscoverer.discover()}},
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773193#comment-16773193
]
Peter Bacsko edited comment on YARN-9265 at 2/20/19 4:56 PM:
-
I made a slight
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-007.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771997#comment-16771997
]
Peter Bacsko commented on YARN-9264:
[~sunilg] [~tangzhankun] please review the first three patch:
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771960#comment-16771960
]
Peter Bacsko commented on YARN-9267:
[~snemeth] you can check it again.
> Various fixes are needed in
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-006.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Attachment: YARN-9267-003.patch
> Various fixes are needed in FpgaResourceHandlerImpl
>
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771240#comment-16771240
]
Peter Bacsko commented on YARN-9267:
Thanks for the comment [~snemeth].
"FpgaDevice.hash should
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-005.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771097#comment-16771097
]
Peter Bacsko commented on YARN-9265:
Fixed chekstyle + findbugs issues.
Regarding Findbugs, I removed
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-004.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-003.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771005#comment-16771005
]
Peter Bacsko commented on YARN-9265:
Thanks [~zsiegl] it's a reasonable improvement. Will update the
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-007.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-006.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769392#comment-16769392
]
Peter Bacsko commented on YARN-9266:
Test failure is unrelated, see
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-005.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768648#comment-16768648
]
Peter Bacsko commented on YARN-9266:
"Some of the refactors that you performed are not included in the
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768590#comment-16768590
]
Peter Bacsko commented on YARN-9098:
After some discussion with Szilard, now I can +1 this
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768437#comment-16768437
]
Peter Bacsko commented on YARN-9266:
Thanks [~adam.antal] I'll go through your suggestions one-by-one
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Description:
Problems identified in this class:
* {{InnerShellExecutor}} ignores the timeout
[
https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768360#comment-16768360
]
Peter Bacsko commented on YARN-9135:
{quote}Using the immutable type in the definition of the methods
[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768340#comment-16768340
]
Peter Bacsko commented on YARN-9138:
+1 non-binding
> Test error handling of nvidia-smi binary
[
https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768333#comment-16768333
]
Peter Bacsko commented on YARN-9139:
+1 non-binding
> Simplify initializer code of GpuDiscoverer
>
[
https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768331#comment-16768331
]
Peter Bacsko commented on YARN-9235:
[~bsteinbach] can you add a simple unit test for this scenario?
[
https://issues.apache.org/jira/browse/YARN-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768158#comment-16768158
]
Peter Bacsko commented on YARN-9264:
Suggested order of committing the patches: YARN-9265 and
[
https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9270:
---
Attachment: YARN-9270-003.patch
> Minor cleanup in TestFpgaDiscoverer
>
[
https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768139#comment-16768139
]
Peter Bacsko commented on YARN-9270:
Patch v3 - handled checkstyle issues.
> Minor cleanup in
[
https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9269:
---
Attachment: YARN-9269-003.patch
> Minor cleanup in FpgaResourceAllocator
>
[
https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767351#comment-16767351
]
Peter Bacsko commented on YARN-9118:
"If I put those method names into a newline, it looks really
[
https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767351#comment-16767351
]
Peter Bacsko edited comment on YARN-9118 at 2/13/19 4:03 PM:
-
"If I put those
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767298#comment-16767298
]
Peter Bacsko commented on YARN-9098:
Maybe it's just nitpicking, but...
{noformat}
public
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767291#comment-16767291
]
Peter Bacsko commented on YARN-9123:
" testGetNMResourceInfoFailBecauseOfUnknownPlugin is a bit
[
https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767287#comment-16767287
]
Peter Bacsko commented on YARN-9135:
Thanks for updating the patch [~snemeth].
Please make sure that
[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767279#comment-16767279
]
Peter Bacsko commented on YARN-9133:
+1 (non-binding)
> Make tests more easy to comprehend in
[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263
]
Peter Bacsko commented on YARN-9138:
[~snemeth] now you can remove this unnecessary code-paths:
[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263
]
Peter Bacsko edited comment on YARN-9138 at 2/13/19 2:47 PM:
-
[~snemeth]
1.
[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263
]
Peter Bacsko edited comment on YARN-9138 at 2/13/19 2:38 PM:
-
[~snemeth] now
[
https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767257#comment-16767257
]
Peter Bacsko commented on YARN-9139:
[~snemeth]
1. Please fix the remaining checkstyle issues
2. Why
[
https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767226#comment-16767226
]
Peter Bacsko commented on YARN-9118:
Minor:
{{Configuration conf = new Configuration(false);}} - this
[
https://issues.apache.org/jira/browse/YARN-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767203#comment-16767203
]
Peter Bacsko commented on YARN-9217:
Minor comments:
1. Do we need a separate variable here?
[
https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767153#comment-16767153
]
Peter Bacsko commented on YARN-9270:
Uploaded v2. Changes:
* FpgaDiscoverer is no longer singleton
*
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Description:
Need to fix the following in the class {{FpgaDevice}}:
* It implements {{Comparable}},
[
https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9270:
---
Attachment: YARN-9270-002.patch
> Minor cleanup in TestFpgaDiscoverer
>
[
https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767085#comment-16767085
]
Peter Bacsko commented on YARN-9270:
" could we remove the wildcard import import java.util.*."
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Attachment: YARN-9268-003.patch
> Various fixes are needed in FpgaDevice
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-004.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-002.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9267:
---
Attachment: YARN-9267-002.patch
> Various fixes are needed in FpgaResourceHandlerImpl
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-003.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9265:
---
Attachment: YARN-9265-001.patch
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764841#comment-16764841
]
Peter Bacsko commented on YARN-9265:
I started to work on this.
I decided to handle the script output
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763083#comment-16763083
]
Peter Bacsko edited comment on YARN-9265 at 2/7/19 9:16 PM:
[~snemeth] yes
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763083#comment-16763083
]
Peter Bacsko commented on YARN-9265:
[~snemeth] yes that is a possibility. A property value has to be
[
https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9270:
---
Attachment: YARN-9270-001.patch
> Minor cleanup in TestFpgaDiscoverer
>
[
https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762946#comment-16762946
]
Peter Bacsko commented on YARN-9269:
Thanks [~adam.antal] for the comments.
1. {{allowedFpgas}} is
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762595#comment-16762595
]
Peter Bacsko edited comment on YARN-9266 at 2/7/19 11:54 AM:
-
Patch v2 -
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Attachment: YARN-9266-002.patch
> Various fixes are needed in IntelFpgaOpenclPlugin
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762595#comment-16762595
]
Peter Bacsko commented on YARN-9266:
Patvh v2 - removed {{aliasMap}}, fixed a lot of checkstyle
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761821#comment-16761821
]
Peter Bacsko edited comment on YARN-9265 at 2/6/19 3:08 PM:
Today we had a
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko reassigned YARN-9265:
--
Assignee: Peter Bacsko
> FPGA plugin fails to recognize Intel Processing Accelerator Card
>
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761821#comment-16761821
]
Peter Bacsko commented on YARN-9265:
Today we had a meeting with [~snemeth], [~shuzirra], [~zsiegl],
[
https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9269:
---
Attachment: YARN-9269-002.patch
> Minor cleanup in FpgaResourceAllocator
>
[
https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9269:
---
Attachment: YARN-9269-001.patch
> Minor cleanup in FpgaResourceAllocator
>
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Attachment: YARN-9268-002.patch
> Various fixes are needed in FpgaDevice
>
[
https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9269:
---
Description:
Some stuff that we observed:
* {{addFpga()}} - we check for duplicate devices, but we
[
https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9269:
---
Description:
Some stuff that we observed:
* {{addFpga()}} - we check for duplicate devices, but we
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760766#comment-16760766
]
Peter Bacsko commented on YARN-9268:
Patch has dependency (at least) on YARN-9266 so it has to be
[
https://issues.apache.org/jira/browse/YARN-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9264:
---
Affects Version/s: (was: 3.1.1)
3.1.0
> [Umbrella] Follow-up on
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Attachment: YARN-9268-001.patch
> Various fixes are needed in FpgaDevice
>
[
https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9266:
---
Description:
Problems identified in this class:
* {{InnerShellExecutor}} ignores the timeout
[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
---
Description:
Need to fix the following the class {{FpgaDevice}}:
* It implements {{Comparable}}, but
1501 - 1600 of 1682 matches
Mail list logo
