[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226714#comment-14226714
]
Hadoop QA commented on YARN-2165:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226749#comment-14226749
]
Zhijie Shen commented on YARN-2165:
---
+1 for the last patch. Will commit it.
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225832#comment-14225832
]
Zhijie Shen commented on YARN-2165:
---
[~vasanthkumar], the patch looks good to me overall.
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219417#comment-14219417
]
Hadoop QA commented on YARN-2165:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216289#comment-14216289
]
Hadoop QA commented on YARN-2165:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216407#comment-14216407
]
Chen He commented on YARN-2165:
---
Hi [~vasanthkumar], thank you for the patch. A small nit in
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216413#comment-14216413
]
Chen He commented on YARN-2165:
---
Agree with [~zhijie shen] to combine parameter checking
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216765#comment-14216765
]
Hadoop QA commented on YARN-2165:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216914#comment-14216914
]
Zhijie Shen commented on YARN-2165:
---
[~vasanthkumar], thanks for your contribution! Some
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212595#comment-14212595
]
Zhijie Shen commented on YARN-2165:
---
bq. should the check be (= 0) instead of ( 0) ?
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208475#comment-14208475
]
Chen He commented on YARN-2165:
---
Hi [~zjshen], should the check be (= 0) instead of ( 0) ?
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208535#comment-14208535
]
Hadoop QA commented on YARN-2165:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075594#comment-14075594
]
Hadoop QA commented on YARN-2165:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033377#comment-14033377
]
Zhijie Shen commented on YARN-2165:
---
[~karams], how about gathering the similar
14 matches
Mail list logo