[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641284#comment-15641284
]
Varun Saxena commented on YARN-3359:
Thanks [~gtCarrera9] for the patch.
Will commit it before starting
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15640692#comment-15640692
]
Hadoop QA commented on YARN-3359:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15640583#comment-15640583
]
Li Lu commented on YARN-3359:
-
BTW, TestWorkPreservingRMRestart appears to be flaky. I cannot reproduce this
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15640568#comment-15640568
]
Hadoop QA commented on YARN-3359:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15640527#comment-15640527
]
Hadoop QA commented on YARN-3359:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15640396#comment-15640396
]
Varun Saxena commented on YARN-3359:
[~gtCarrera9], wouldn't it be better to have code like below ?
If
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639671#comment-15639671
]
Varun Saxena commented on YARN-3359:
[~gtCarrera9], kindly address the comments above so that I can
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638492#comment-15638492
]
Varun Saxena commented on YARN-3359:
Raised YARN-5841.
> Recover collector list in RM failed over
>
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638449#comment-15638449
]
Varun Saxena commented on YARN-3359:
bq. For now, shall we move forward with this fix without the
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638015#comment-15638015
]
Sangjin Lee commented on YARN-3359:
---
I think Varun covered pretty much what I was thinking of. I have
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637799#comment-15637799
]
Li Lu commented on YARN-3359:
-
bq. Also, we are sending all collectors known to this NM and not only the NMs'
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634344#comment-15634344
]
Varun Saxena commented on YARN-3359:
Thanks [~gtCarrera9] for the patch. Code largely seems fine and
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633666#comment-15633666
]
Li Lu commented on YARN-3359:
-
I cannot reproduce those two test failures and they appears to be unrelated.
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613713#comment-15613713
]
Hadoop QA commented on YARN-3359:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613036#comment-15613036
]
Li Lu commented on YARN-3359:
-
Thanks [~vrushalic]! I'll clean those checkstyle warnings. The failure in
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612971#comment-15612971
]
Vrushali C commented on YARN-3359:
--
Filed YARN-5790 for the NM side collector lifecycle considerations
>
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612938#comment-15612938
]
Vrushali C commented on YARN-3359:
--
[~gtCarrera9] , overall patch looks fine. Do you have a jira for the
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586732#comment-15586732
]
Hadoop QA commented on YARN-3359:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586718#comment-15586718
]
Hadoop QA commented on YARN-3359:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506221#comment-15506221
]
Rohith Sharma K S commented on YARN-3359:
-
The overall patch looks good. I think right place for
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489375#comment-15489375
]
Junping Du commented on YARN-3359:
--
More specifically, I think there are several works need to be done for
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489295#comment-15489295
]
Junping Du commented on YARN-3359:
--
Thanks [~gtCarrera9] for reply.
bq. The only challenge is when two or
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485847#comment-15485847
]
Li Lu commented on YARN-3359:
-
Thanks [~jdu]! Actually keeping the copies in the NMs will do the work. The
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485786#comment-15485786
]
Junping Du commented on YARN-3359:
--
btw, app's attempt id shouldn't be used here as collector is designed
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485770#comment-15485770
]
Junping Du commented on YARN-3359:
--
Thanks for bringing up many options here. Rather than RM state store,
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485264#comment-15485264
]
Li Lu commented on YARN-3359:
-
Thanks [~vinodkv]! Creating YARN-5638 to trace the collector ID related changes
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485242#comment-15485242
]
Vinod Kumar Vavilapalli commented on YARN-3359:
---
bq. Right now each collector is mapped with
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485225#comment-15485225
]
Li Lu commented on YARN-3359:
-
I've got some offline discussion with [~vinodkv] about this issue. We cannot
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485188#comment-15485188
]
Li Lu commented on YARN-3359:
-
Thanks [~djp], I'm taking it over. Thanks for letting me know YARN-4758 which
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483620#comment-15483620
]
Junping Du commented on YARN-3359:
--
Hi [~gtCarrera9], please feel free to take this over as I don't have
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477871#comment-15477871
]
Li Lu commented on YARN-3359:
-
Hi [~djp], are you still working on this? If not can I take it over? Thanks!
>
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524405#comment-14524405
]
Junping Du commented on YARN-3359:
--
Hi [~sidharta-s], Yes. We need this in phase 3 of new
[
https://issues.apache.org/jira/browse/YARN-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524341#comment-14524341
]
Sidharta Seethana commented on YARN-3359:
-
[~djp] , are you planning to work on
33 matches
Mail list logo
