[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450701#comment-16450701
]
Hudson commented on YARN-5301:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1405
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003452#comment-16003452
]
Hudson commented on YARN-5301:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1170
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003224#comment-16003224
]
Daniel Templeton commented on YARN-5301:
Interesting.
http://stackoverflow.com/que
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003194#comment-16003194
]
Miklos Szegedi commented on YARN-5301:
--
Thank you for the review [~templedf]. I think,
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003151#comment-16003151
]
Daniel Templeton commented on YARN-5301:
OK, did one last pass. Not a biggie, but
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993662#comment-15993662
]
Daniel Templeton commented on YARN-5301:
Latest patch LGTM.
> NM mount cpu cgroups
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987177#comment-15987177
]
Hadoop QA commented on YARN-5301:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986227#comment-15986227
]
Hadoop QA commented on YARN-5301:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985964#comment-15985964
]
Hadoop QA commented on YARN-5301:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985792#comment-15985792
]
Hadoop QA commented on YARN-5301:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985324#comment-15985324
]
Daniel Templeton commented on YARN-5301:
My concern was that swallowing the excepti
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975742#comment-15975742
]
Miklos Szegedi commented on YARN-5301:
--
Yes, it is safe in this code. cgroups is avail
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975612#comment-15975612
]
Daniel Templeton commented on YARN-5301:
Thanks for fixing that test, [~miklos.szeg
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975601#comment-15975601
]
Hadoop QA commented on YARN-5301:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975412#comment-15975412
]
Hadoop QA commented on YARN-5301:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975310#comment-15975310
]
Daniel Templeton commented on YARN-5301:
Darn. Looks like we need a rebase. :(
>
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966552#comment-15966552
]
Hadoop QA commented on YARN-5301:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966486#comment-15966486
]
Daniel Templeton commented on YARN-5301:
Thanks. LGTM +1
> NM mount cpu cgroups f
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966482#comment-15966482
]
Miklos Szegedi commented on YARN-5301:
--
I opened YARN-6474 for the remaining checkstyl
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966315#comment-15966315
]
Daniel Templeton commented on YARN-5301:
Looking at the changes in the latest patch
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966296#comment-15966296
]
Daniel Templeton commented on YARN-5301:
Maybe file a JIRA to address the throws in
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963792#comment-15963792
]
Hadoop QA commented on YARN-5301:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963632#comment-15963632
]
Daniel Templeton commented on YARN-5301:
{quote}I checked and we only iterate throu
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951734#comment-15951734
]
Hadoop QA commented on YARN-5301:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951701#comment-15951701
]
Miklos Szegedi commented on YARN-5301:
--
Thank you, [~templedf] for the review. Most of
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949819#comment-15949819
]
Daniel Templeton commented on YARN-5301:
Thanks, [~miklos.szeg...@cloudera.com]. A
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947957#comment-15947957
]
Miklos Szegedi commented on YARN-5301:
--
[~bibinchundatt], do you have time to take a l
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947891#comment-15947891
]
Hadoop QA commented on YARN-5301:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947816#comment-15947816
]
Hadoop QA commented on YARN-5301:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
29 matches
Mail list logo