[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514760#comment-15514760
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514704#comment-15514704
]
Carlo Curino commented on YARN-5324:
[~subru] thanks for reviewing. I addressed the nits.
> Stateless
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514674#comment-15514674
]
Subru Krishnan commented on YARN-5324:
--
+1 on the latest patch, thanks [~curino] for addressing all my
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511558#comment-15511558
]
Hadoop QA commented on YARN-5324:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511434#comment-15511434
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511406#comment-15511406
]
Carlo Curino commented on YARN-5324:
[~subru] thanks for the follow up.
I think I have address all
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504769#comment-15504769
]
Subru Krishnan commented on YARN-5324:
--
Thanks [~curino] for addressing my comments.
The patch looks
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504647#comment-15504647
]
Hadoop QA commented on YARN-5324:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504555#comment-15504555
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504494#comment-15504494
]
Carlo Curino commented on YARN-5324:
Last few checkstyles (one should be suppressed but it depends on
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504215#comment-15504215
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497420#comment-15497420
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497151#comment-15497151
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497124#comment-15497124
]
Carlo Curino commented on YARN-5324:
[~subru], thanks for the good review. I think I have addressed
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485752#comment-15485752
]
Subru Krishnan commented on YARN-5324:
--
Thanks [~curino] for the patch. I looked at it and have a few
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485329#comment-15485329
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485287#comment-15485287
]
Carlo Curino commented on YARN-5324:
More cleanups. The remaining checkstyle (>7 params) I think is ok
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485097#comment-15485097
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485039#comment-15485039
]
Carlo Curino commented on YARN-5324:
Standard pass on fixing checkstyle/javadoc/findbugs/asflicense
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478764#comment-15478764
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478744#comment-15478744
]
Carlo Curino commented on YARN-5324:
Rebased the patch based on YARN-5323.
The patch does a minor
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416397#comment-15416397
]
Carlo Curino commented on YARN-5324:
Much of the errors are because this depends on YARN-5323
>
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416367#comment-15416367
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416353#comment-15416353
]
Hadoop QA commented on YARN-5324:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390197#comment-15390197
]
Carlo Curino commented on YARN-5324:
[~yochen] thanks for reviewing this.
# The
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388615#comment-15388615
]
Young Chen commented on YARN-5324:
--
Thanks [~curino],
Just a couple things I noticed when going through
[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380912#comment-15380912
]
Carlo Curino commented on YARN-5324:
This patch provides 3 simple implementation of
27 matches
Mail list logo