[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819442#comment-15819442 ] Hudson commented on YARN-5554: -- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11108 (See

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816669#comment-15816669 ] Daniel Templeton commented on YARN-5554: Looks like we'll need a branch-2 patch. Can you take care

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813260#comment-15813260 ] Daniel Templeton commented on YARN-5554: Sorry. Looks like I started repeating myself. TMJ! (Too

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803665#comment-15803665 ] Wilfred Spiegelenburg commented on YARN-5554: - bq. In testMoveApplicationSubmitTargetQueue()

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801637#comment-15801637 ] Daniel Templeton commented on YARN-5554: In doing a last pass, I have two questions on the test

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799926#comment-15799926 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799765#comment-15799765 ] Daniel Templeton commented on YARN-5554: One more detail: in the new comment on the old

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799480#comment-15799480 ] Daniel Templeton commented on YARN-5554: Thanks, [~wilfreds]. Can you move that {{checkAccess()}}

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783908#comment-15783908 ] Daniel Templeton commented on YARN-5554: Let's get this thing closed out. A few more comments: *

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783850#comment-15783850 ] Daniel Templeton commented on YARN-5554: Yep, I noticed that as well. The {{remoteAddress}} and

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730829#comment-15730829 ] Wilfred Spiegelenburg commented on YARN-5554: - I am all for it but I think we should do that

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730275#comment-15730275 ] Wilfred Spiegelenburg commented on YARN-5554: - Correct the {{checkAccess()}} methods does not

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729432#comment-15729432 ] Daniel Templeton commented on YARN-5554: Since this patch is having to replicate that code again,

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729427#comment-15729427 ] Daniel Templeton commented on YARN-5554: What you're saying then, is that the

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727669#comment-15727669 ] Wilfred Spiegelenburg commented on YARN-5554: - The main point is that the {{ClientRMService}}

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727172#comment-15727172 ] Jian He commented on YARN-5554: --- oh, I think it was because the CapacityScheduler#checkAccess is actually not

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727066#comment-15727066 ] Daniel Templeton commented on YARN-5554: My question is why the {{QueueACLsManager.checkAccess()}}

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726994#comment-15726994 ] Jian He commented on YARN-5554: --- In YARN-4571, do you mean the QueueACLsManager#checkAccess method ? it has

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726946#comment-15726946 ] Daniel Templeton commented on YARN-5554: bq. The change to not use the checkAccess() of the

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724046#comment-15724046 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715767#comment-15715767 ] Hadoop QA commented on YARN-5554: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715560#comment-15715560 ] Wilfred Spiegelenburg commented on YARN-5554: - bq." doesn't have permissions submit to target

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706689#comment-15706689 ] Daniel Templeton commented on YARN-5554: Thanks for all the patch updates, [~wilfreds]. My turn.

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547911#comment-15547911 ] Hadoop QA commented on YARN-5554: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547699#comment-15547699 ] Bibin A Chundatt commented on YARN-5554: Thank you [~wilfreds] for patch. In Audit logger and

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547586#comment-15547586 ] Hadoop QA commented on YARN-5554: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547136#comment-15547136 ] Karthik Kambatla commented on YARN-5554: Thanks for reporting and working on this, [~wilfreds].

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528729#comment-15528729 ] Yufei Gu commented on YARN-5554: The latest patch looks good to me. +1(non-binding). >

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526160#comment-15526160 ] Hadoop QA commented on YARN-5554: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525970#comment-15525970 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525405#comment-15525405 ] Yufei Gu commented on YARN-5554: Thanks [~wilfreds]'s new patch. It makes sense to not introduce more

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523246#comment-15523246 ] Wilfred Spiegelenburg commented on YARN-5554: - The test failure is logged as YARN-5043 and i

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523217#comment-15523217 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522861#comment-15522861 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454389#comment-15454389 ] Jian He commented on YARN-5554: --- For the permission part: should we check (submit_acl_on_target_queue ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453039#comment-15453039 ] Yufei Gu commented on YARN-5554: Thanks [~wilfreds] for working on this. The patch looks good to me

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438130#comment-15438130 ] Haibo Chen commented on YARN-5554: -- Sorry for messing up the history. I will keep it in mind. >

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436779#comment-15436779 ] Hadoop QA commented on YARN-5554: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436467#comment-15436467 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436270#comment-15436270 ] Rohith Sharma K S commented on YARN-5554: - Please do not delete once attached patches. It is

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435596#comment-15435596 ] Haibo Chen commented on YARN-5554: -- Thanks [~rohithsharma] for the review! Yes, the patch does not fix the

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435546#comment-15435546 ] Rohith Sharma K S commented on YARN-5554: - +1 for the issue. And also I think there are uncovered

[jira] [Commented] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

[ https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434140#comment-15434140 ] Hadoop QA commented on YARN-5554: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||