[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935534#comment-15935534
]
Yufei Gu commented on YARN-6326:
Looks like we don't need to put this on branch-2 since it based on
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935490#comment-15935490
]
Hudson commented on YARN-6326:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11439 (See
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935452#comment-15935452
]
Robert Kanter commented on YARN-6326:
-
I've pushed it to trunk, but this doesn't apply cleanly to
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935440#comment-15935440
]
Robert Kanter commented on YARN-6326:
-
+1
> Shouldn't use AppAttemptIds to fetch applications while AM
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931102#comment-15931102
]
Hadoop QA commented on YARN-6326:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931095#comment-15931095
]
Yufei Gu commented on YARN-6326:
Thanks [~rkanter] for the review. Uploaded patch v5 for your comments.
#
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930777#comment-15930777
]
Robert Kanter commented on YARN-6326:
-
Two things:
# I like the way you made the metrics enums, but
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928954#comment-15928954
]
Hadoop QA commented on YARN-6326:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926805#comment-15926805
]
Hadoop QA commented on YARN-6326:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925002#comment-15925002
]
Hadoop QA commented on YARN-6326:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924798#comment-15924798
]
Hadoop QA commented on YARN-6326:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923604#comment-15923604
]
Hadoop QA commented on YARN-6326:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923495#comment-15923495
]
Yufei Gu commented on YARN-6326:
Thanks [~rkanter] for the review. Uploaded a new patch for your comments.
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922860#comment-15922860
]
Robert Kanter commented on YARN-6326:
-
Seems fine overall; some minor things:
# whitespace as reported
[
https://issues.apache.org/jira/browse/YARN-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906021#comment-15906021
]
Hadoop QA commented on YARN-6326:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
15 matches
Mail list logo