[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266361#comment-17266361
]
Szilard Nemeth commented on YARN-7200:
--
Thanks [~akshink] for the new patch and the explanation.
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264853#comment-17264853
]
Agshin Kazimli commented on YARN-7200:
--
[~snemeth] Thanks for your thoughts.
I've changed the error
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264154#comment-17264154
]
Hadoop QA commented on YARN-7200:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263356#comment-17263356
]
Szilard Nemeth commented on YARN-7200:
--
Hi [~akshink],
Thanks for the explanation, makes sense.
I
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260573#comment-17260573
]
Hadoop QA commented on YARN-7200:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260469#comment-17260469
]
Hadoop QA commented on YARN-7200:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260416#comment-17260416
]
Agshin Kazimli commented on YARN-7200:
--
Hi [~snemeth],
Thanks for the review.
I've investigated the
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252048#comment-17252048
]
Szilard Nemeth commented on YARN-7200:
--
Hi [~akshink]
Thanks for working on this.
Some comments:
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243816#comment-17243816
]
Andras Gyori commented on YARN-7200:
Thank you [~akshink] it seems good to me +1 non-bindig.
> SLS
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243113#comment-17243113
]
Hadoop QA commented on YARN-7200:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242946#comment-17242946
]
Andras Gyori commented on YARN-7200:
[~akshink] I get this logic now. However, you are making an
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241375#comment-17241375
]
Agshin Kazimli commented on YARN-7200:
--
[~gandras] Thank you for the review. In an ideal setup, the
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238196#comment-17238196
]
Andras Gyori commented on YARN-7200:
Thank you [~akshink] for the patch. Good job! I have one
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233846#comment-17233846
]
Hadoop QA commented on YARN-7200:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233777#comment-17233777
]
Agshin Kazimli commented on YARN-7200:
--
Keeping the old exit logic as it is and not changing any
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232862#comment-17232862
]
Gergely Pollak commented on YARN-7200:
--
[~akshink] It does matter.
1) You break backwards
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232833#comment-17232833
]
Agshin Kazimli commented on YARN-7200:
--
[~snemeth] [~shuzirra] Thanks for the reviews.
As there are
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232770#comment-17232770
]
Gergely Pollak commented on YARN-7200:
--
[~akshink] Thank you for the patch.
I'm not entirely aware
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232625#comment-17232625
]
Agshin Kazimli commented on YARN-7200:
--
The normal cli behaviour and test behaviour differs in SLS.
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231658#comment-17231658
]
Szilard Nemeth commented on YARN-7200:
--
Hi [~akshink],
Checked the call hierarchy of
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231602#comment-17231602
]
Hadoop QA commented on YARN-7200:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231550#comment-17231550
]
Szilard Nemeth commented on YARN-7200:
--
Hi [~akshink],
Checking your patch soon.
As a general rule
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216025#comment-17216025
]
Agshin Kazimli commented on YARN-7200:
--
I've added a patch involving two changes in
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213278#comment-17213278
]
Rudolf Reti commented on YARN-7200:
---
Thanks [~akshink]. Good first step. Let's jump on the thorough test
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213169#comment-17213169
]
Agshin Kazimli commented on YARN-7200:
--
I have debugged the 'TestAMSimulator.java', the output file -
[
https://issues.apache.org/jira/browse/YARN-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450188#comment-16450188
]
Dedunu Dhananjaya commented on YARN-7200:
-
Can you please explain this further?
> SLS generates a
26 matches
Mail list logo