[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246500#comment-16246500
]
Konstantinos Karanasos commented on YARN-7437:
--
Yeah, was checking it now, committing.
> Give
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246485#comment-16246485
]
Wangda Tan commented on YARN-7437:
--
The failed unit test is not related to the patch.
> Give
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246483#comment-16246483
]
Hadoop QA commented on YARN-7437:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245147#comment-16245147
]
Hadoop QA commented on YARN-7437:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245000#comment-16245000
]
Konstantinos Karanasos commented on YARN-7437:
--
Thanks, [~leftnoteasy]! Looks good, will
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243162#comment-16243162
]
Wangda Tan commented on YARN-7437:
--
Thanks [~kkaranasos] for these comments,
bq. AppPlacementAllocator:
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243285#comment-16243285
]
Hadoop QA commented on YARN-7437:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243047#comment-16243047
]
Konstantinos Karanasos commented on YARN-7437:
--
Thanks for the patch, [~leftnoteasy]. Looks
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242878#comment-16242878
]
Hadoop QA commented on YARN-7437:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242656#comment-16242656
]
Wangda Tan commented on YARN-7437:
--
Hold on, I need to make few edits. Please give me a few mins.
> Give
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242625#comment-16242625
]
Arun Suresh commented on YARN-7437:
---
Thanks for raising this [~wangda], I like AppPlacementAllocator.
>
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242612#comment-16242612
]
Wangda Tan commented on YARN-7437:
--
[~kkaranasos], I'm fine with both of AppPlacement or
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241641#comment-16241641
]
Hadoop QA commented on YARN-7437:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241566#comment-16241566
]
Konstantinos Karanasos commented on YARN-7437:
--
Thanks [~leftnoteasy].
I had an offline chat
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240623#comment-16240623
]
Wangda Tan commented on YARN-7437:
--
Thanks [~kkaranasos] for your comments, all make sense to me. I will
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240596#comment-16240596
]
Konstantinos Karanasos commented on YARN-7437:
--
bq. I'm fine with CandidateNodeSet/NodeSet, I
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238505#comment-16238505
]
Wangda Tan commented on YARN-7437:
--
Thanks [~kkaranasos] for suggestions.
For your renaming suggestions:
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238461#comment-16238461
]
Konstantinos Karanasos commented on YARN-7437:
--
Thanks for starting this, [~leftnoteasy].
[
https://issues.apache.org/jira/browse/YARN-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237896#comment-16237896
]
Wangda Tan commented on YARN-7437:
--
[~asuresh]/[~kkaranasos]/[~subru].
How about rename it to
19 matches
Mail list logo