[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410869#comment-16410869 ] Rohith Sharma K S commented on YARN-7581: - committing branch-2 patch shortly > HBase filters are

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410835#comment-16410835 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409772#comment-16409772 ] Rohith Sharma K S commented on YARN-7581: - bq. The compilation fails even with JDK8 I agree,

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409706#comment-16409706 ] Jason Lowe commented on YARN-7581: -- bq. I did compilation for branch-2 and committed. Looks my workspace

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408973#comment-16408973 ] Haibo Chen commented on YARN-7581: -- Uploading a patch for branch-2 > HBase filters are not constructed

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408969#comment-16408969 ] Rohith Sharma K S commented on YARN-7581: - Thanks [~jlowe] for reporting and I apologies for

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408719#comment-16408719 ] Vrushali C commented on YARN-7581: -- Oh, apologies, thanks Jason. Haibo, Rohith, looks like we need to be

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407483#comment-16407483 ] Hudson commented on YARN-7581: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13862 (See

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407388#comment-16407388 ] Rohith Sharma K S commented on YARN-7581: - committed to branch-2 as well. thanks to [~haibochen]

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407384#comment-16407384 ] Haibo Chen commented on YARN-7581: -- Although branch-2 technically does not need the patch to work

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405793#comment-16405793 ] Rohith Sharma K S commented on YARN-7581: - [~vrushalic] Go ahead and commit it. thanks. > HBase

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405226#comment-16405226 ] Vrushali C commented on YARN-7581: -- Also, Rohith was +1 on this patch, so perhaps I can commit it later

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405225#comment-16405225 ] Vrushali C commented on YARN-7581: -- Yes, thanks, +1 on patch 05. The adding of info CF is pre-existing,

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405218#comment-16405218 ] Haibo Chen commented on YARN-7581: -- [~vrushalic] Are you okay with the latest patch? > HBase filters are

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403532#comment-16403532 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403482#comment-16403482 ] Haibo Chen commented on YARN-7581: -- {quote}someone wanted to see their megabytemillis counter value, do we

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402510#comment-16402510 ] Vrushali C commented on YARN-7581: -- Thanks for the patch [~haibochen] ! I have some questions. I am

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402073#comment-16402073 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401761#comment-16401761 ] Rohith Sharma K S commented on YARN-7581: - +1 for latest patch. > HBase filters are not

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400958#comment-16400958 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400857#comment-16400857 ] Haibo Chen commented on YARN-7581: -- 04 patch to address the checkstyle issue. > HBase filters are not

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400832#comment-16400832 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400745#comment-16400745 ] Haibo Chen commented on YARN-7581: -- Updated the patch to address Rohith's comments. > HBase filters are

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399916#comment-16399916 ] Haibo Chen commented on YARN-7581: -- {quote}Does it because of assumption that info field will be retrieved

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398132#comment-16398132 ] Rohith Sharma K S commented on YARN-7581: - Overall patch approach looks good. Some comments

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398109#comment-16398109 ] Rohith Sharma K S commented on YARN-7581: - Looking into patch, I get one doubt that how does filter

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397342#comment-16397342 ] Rohith Sharma K S commented on YARN-7581: - I ran failing tests against hbase-2 profile with this

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395511#comment-16395511 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395444#comment-16395444 ] Haibo Chen commented on YARN-7581: -- 02 patch to address the checkstyle issue as well. > HBase filters are

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395432#comment-16395432 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395380#comment-16395380 ] Haibo Chen commented on YARN-7581: -- Patch updated to enforce byte[] to String encoding with UTF-8 > HBase

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394967#comment-16394967 ] Rohith Sharma K S commented on YARN-7581: - [~haibochen] would you update the patch fixing findbugs?

[jira] [Commented] (YARN-7581) HBase filters are not constructed correctly in ATSv2

[ https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388498#comment-16388498 ] genericqa commented on YARN-7581: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||