[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819481#comment-16819481
]
Szilard Nemeth commented on YARN-9123:
--
Oh I see. I didn't know this failure is coming up usually.
>
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819470#comment-16819470
]
Wei-Chiu Chuang commented on YARN-9123:
---
It's unrelated to this patch and Hudson always fails.
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819423#comment-16819423
]
Szilard Nemeth commented on YARN-9123:
--
Thanks a lot [~jojochuang]!
Do you know what caused the
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819360#comment-16819360
]
Hudson commented on YARN-9123:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16421 (See
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819349#comment-16819349
]
Wei-Chiu Chuang commented on YARN-9123:
---
+1
> Clean up and split testcases in TestNMWebServices for
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819085#comment-16819085
]
Hadoop QA commented on YARN-9123:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819015#comment-16819015
]
Szilard Nemeth commented on YARN-9123:
--
Hi [~jojochuang]!
Please see the latest patch, this should
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818964#comment-16818964
]
Wei-Chiu Chuang commented on YARN-9123:
---
Please update the patch to address the checkstyle warning.
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811769#comment-16811769
]
Szilard Nemeth commented on YARN-9123:
--
Hi [~jojochuang]!
The only one in the checkstyle logs is
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808125#comment-16808125
]
Hadoop QA commented on YARN-9123:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808093#comment-16808093
]
Szilard Nemeth commented on YARN-9123:
--
Thanks [~jojochuang] for taking a look at this!
If it turns
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808056#comment-16808056
]
Wei-Chiu Chuang commented on YARN-9123:
---
Looks good to me. I retriggered the precommit check to
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768506#comment-16768506
]
Adam Antal commented on YARN-9123:
--
I missed the TestNMWebServices failure by jenkins, but by int-casting
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768459#comment-16768459
]
Hadoop QA commented on YARN-9123:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768176#comment-16768176
]
Hadoop QA commented on YARN-9123:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768160#comment-16768160
]
Szilard Nemeth commented on YARN-9123:
--
Thanks [~adam.antal]
> Clean up and split testcases in
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768127#comment-16768127
]
Adam Antal commented on YARN-9123:
--
+1 (non-binding).
I filed YARN-9304 for my concerns.
> Clean up and
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768114#comment-16768114
]
Szilard Nemeth commented on YARN-9123:
--
Hi [~adam.antal] and [~pbacsko]!
Thanks for your review
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767291#comment-16767291
]
Peter Bacsko commented on YARN-9123:
" testGetNMResourceInfoFailBecauseOfUnknownPlugin is a bit
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765911#comment-16765911
]
Adam Antal commented on YARN-9123:
--
Hi [~snemeth]. Thanks for the patch! The cleaning looks good, I have
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759548#comment-16759548
]
Szilard Nemeth commented on YARN-9123:
--
UT failure seems unrelated.
> Clean up and split testcases
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757532#comment-16757532
]
Hadoop QA commented on YARN-9123:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757393#comment-16757393
]
Szilard Nemeth commented on YARN-9123:
--
Hi [~pbacsko]!
Thanks for the review!
I fixed all of the
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750084#comment-16750084
]
Peter Bacsko commented on YARN-9123:
Two things:
1. Please use the {{assert}} methods a bit more
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723879#comment-16723879
]
Szilard Nemeth commented on YARN-9123:
--
[~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg],
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722941#comment-16722941
]
Hadoop QA commented on YARN-9123:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722886#comment-16722886
]
Szilard Nemeth commented on YARN-9123:
--
Patch002 is fixing the checkstyle issue.
> Clean up and
[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721334#comment-16721334
]
Hadoop QA commented on YARN-9123:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
28 matches
Mail list logo