[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785485#comment-16785485 ] Sunil Govindan commented on YARN-9138: -- +1 on latest patch. > Test error handling of nvidia-smi

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783658#comment-16783658 ] Szilard Nemeth commented on YARN-9138: -- This seems to be ready to commit now, I guess. > Test error

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783594#comment-16783594 ] Hadoop QA commented on YARN-9138: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783449#comment-16783449 ] Szilard Nemeth commented on YARN-9138: -- Hi [~sunilg]! I see, I removed the final keyword from msg. No

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782989#comment-16782989 ] Sunil Govindan commented on YARN-9138: -- Thanks [~snemeth]. For messages, if its reused, you can

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782374#comment-16782374 ] Hadoop QA commented on YARN-9138: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781767#comment-16781767 ] Szilard Nemeth commented on YARN-9138: -- Hi [~sunilg]! Thanks for the comments! 1. Fixed. 2. msg is

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781705#comment-16781705 ] Sunil Govindan commented on YARN-9138: -- Hi [~snemeth] Few comments: # Could GPU_SCRIPT_REFERENCE

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780688#comment-16780688 ] Sunil Govindan commented on YARN-9138: -- Thanks [~snemeth]. i ll check on same now > Test error

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780684#comment-16780684 ] Szilard Nemeth commented on YARN-9138: -- [~sunilg]: Tried to apply trunk patch to branch-3.2 /

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777939#comment-16777939 ] Hadoop QA commented on YARN-9138: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777872#comment-16777872 ] Adam Antal commented on YARN-9138: -- Thanks [~snemeth], Yeah, I didn't see that the GpuDiscoverer passes

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777869#comment-16777869 ] Szilard Nemeth commented on YARN-9138: -- Hi [~adam.antal]! Thanks for another round of the review! As

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1698#comment-1698 ] Adam Antal commented on YARN-9138: -- Thanks for your responses [~snemeth], the patch is pretty good now.

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775642#comment-16775642 ] Hadoop QA commented on YARN-9138: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775585#comment-16775585 ] Szilard Nemeth commented on YARN-9138: -- Hi [~adam.antal]! Thanks for your comments, they are very

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774399#comment-16774399 ] Adam Antal commented on YARN-9138: -- Hi [~snemeth], thanks for the patch! I have some minor comment

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768340#comment-16768340 ] Peter Bacsko commented on YARN-9138: +1 non-binding > Test error handling of nvidia-smi binary

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768153#comment-16768153 ] Hadoop QA commented on YARN-9138: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768106#comment-16768106 ] Szilard Nemeth commented on YARN-9138: -- Hi [~pbacsko]! Thanks for the review! 1. True, I removed

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767263#comment-16767263 ] Peter Bacsko commented on YARN-9138: [~snemeth] now you can remove this unnecessary code-paths:

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759547#comment-16759547 ] Szilard Nemeth commented on YARN-9138: -- UT failure seems unrelated. > Test error handling of

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757453#comment-16757453 ] Hadoop QA commented on YARN-9138: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757351#comment-16757351 ] Szilard Nemeth commented on YARN-9138: -- Hi [~pbacsko]! Thanks for the review! # Description added

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749963#comment-16749963 ] Peter Bacsko commented on YARN-9138: [~snemeth] two things: 1. Add a short description to the JIRA

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723871#comment-16723871 ] Szilard Nemeth commented on YARN-9138: -- [~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg],

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722502#comment-16722502 ] Hadoop QA commented on YARN-9138: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||