[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956347#comment-16956347 ] Eric Badger commented on YARN-9884: --- Thanks for the commit, [~eyang]! Thanks for the reviews

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955010#comment-16955010 ] Hudson commented on YARN-9884: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17550 (See

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955003#comment-16955003 ] Eric Yang commented on YARN-9884: - +1 for patch 004. Committing shortly. > Make container-executor mount

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954993#comment-16954993 ] Eric Badger commented on YARN-9884: --- I have added this as a blocker for YARN-9561, as the most recent

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953870#comment-16953870 ] Jim Brennan commented on YARN-9884: --- Thanks for the update [~ebadger]! I am +1 on patch 004

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953177#comment-16953177 ] Hadoop QA commented on YARN-9884: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953124#comment-16953124 ] Eric Badger commented on YARN-9884: --- Thanks for the review, [~Jim_Brennan]! I've attached patch 004 to

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951032#comment-16951032 ] Jim Brennan commented on YARN-9884: --- Thanks for the updates [~ebadger]! I am +1 (non-binding) on patch

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949822#comment-16949822 ] Hadoop QA commented on YARN-9884: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949790#comment-16949790 ] Eric Badger commented on YARN-9884: --- Thanks for the prompt reviews, everyone! Patch 003 combines the

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949703#comment-16949703 ] Craig Condit commented on YARN-9884: [~ebadger], this looks pretty good for the most part. However,

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949691#comment-16949691 ] Jim Brennan commented on YARN-9884: --- [~ebadger] good job on the re-factoring.  This looks pretty good to

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949497#comment-16949497 ] Eric Badger commented on YARN-9884: --- bq. I am wondering if we need to combine the list to prevent future

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949080#comment-16949080 ] Hadoop QA commented on YARN-9884: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949038#comment-16949038 ] Eric Yang commented on YARN-9884: - [~ebadger] Sorry, I just committed YARN-9860 which breaks this patch.

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949034#comment-16949034 ] Eric Badger commented on YARN-9884: --- Looks like a conflict came up just before I put up the patch, so it

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949020#comment-16949020 ] Hadoop QA commented on YARN-9884: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9884) Make container-executor mount logic modular

[ https://issues.apache.org/jira/browse/YARN-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948968#comment-16948968 ] Eric Badger commented on YARN-9884: --- [~eyang], [~Jim_Brennan], [~ccondit], could you review this when